Re: Add -lssp_nonshared to LINK_SSP_SPEC

2012-02-07 Thread Jakub Jelinek
On Mon, Jan 23, 2012 at 12:03:27PM +0100, Richard Guenther wrote: On Mon, Jan 23, 2012 at 12:23 AM, Gerald Pfeifer ger...@pfeifer.com wrote: On Sat, 21 Jan 2012, Tijl Coosemans wrote: I've been using this patch now. It's similar to the above url, but conditional on TARGET_LIBC_PROVIDES_SSP

Re: Add -lssp_nonshared to LINK_SSP_SPEC

2012-02-07 Thread Richard Guenther
On Tue, Feb 7, 2012 at 9:54 AM, Jakub Jelinek ja...@redhat.com wrote: On Mon, Jan 23, 2012 at 12:03:27PM +0100, Richard Guenther wrote: On Mon, Jan 23, 2012 at 12:23 AM, Gerald Pfeifer ger...@pfeifer.com wrote: On Sat, 21 Jan 2012, Tijl Coosemans wrote: I've been using this patch now. It's

Re: Add -lssp_nonshared to LINK_SSP_SPEC

2012-02-07 Thread Tijl Coosemans
On Tuesday 07 February 2012 09:54:43 Jakub Jelinek wrote: On Mon, Jan 23, 2012 at 12:03:27PM +0100, Richard Guenther wrote: On Mon, Jan 23, 2012 at 12:23 AM, Gerald Pfeifer ger...@pfeifer.com wrote: On Sat, 21 Jan 2012, Tijl Coosemans wrote: I've been using this patch now. It's similar to the

Re: Add -lssp_nonshared to LINK_SSP_SPEC

2012-02-07 Thread Jakub Jelinek
On Tue, Feb 07, 2012 at 12:17:59PM +0100, Tijl Coosemans wrote: Everything still works on FreeBSD. After discussion about this on IRC Richard expressed his preference for the following variant instead: 2012-02-07 Jakub Jelinek ja...@redhat.com * config/freebsd-spec.h: Add comment

Re: Add -lssp_nonshared to LINK_SSP_SPEC

2012-02-07 Thread Richard Guenther
On Tue, Feb 7, 2012 at 12:53 PM, Jakub Jelinek ja...@redhat.com wrote: On Tue, Feb 07, 2012 at 12:17:59PM +0100, Tijl Coosemans wrote: Everything still works on FreeBSD. After discussion about this on IRC Richard expressed his preference for the following variant instead: Ok. Thanks,

Re: Add -lssp_nonshared to LINK_SSP_SPEC

2012-02-07 Thread Joseph S. Myers
On Tue, 7 Feb 2012, Jakub Jelinek wrote: So, if this mess is really needed (does anybody actually use -mcall-freebsd on non-freebsd targets?), IMHO freebsd-spec.h must avoid defining non-FBSD_ I've argued for a long time that the -mcall-* support should be removed and targets using

Re: Add -lssp_nonshared to LINK_SSP_SPEC

2012-02-07 Thread Jakub Jelinek
On Tue, Feb 07, 2012 at 01:13:35PM +, Joseph S. Myers wrote: On Tue, 7 Feb 2012, Jakub Jelinek wrote: So, if this mess is really needed (does anybody actually use -mcall-freebsd on non-freebsd targets?), IMHO freebsd-spec.h must avoid defining non-FBSD_ I've argued for a long time

Re: Add -lssp_nonshared to LINK_SSP_SPEC

2012-02-07 Thread Tijl Coosemans
On Tuesday 07 February 2012 12:53:24 Jakub Jelinek wrote: On Tue, Feb 07, 2012 at 12:17:59PM +0100, Tijl Coosemans wrote: Everything still works on FreeBSD. After discussion about this on IRC Richard expressed his preference for the following variant instead: Works too.

Re: Add -lssp_nonshared to LINK_SSP_SPEC

2012-01-23 Thread Richard Guenther
On Mon, Jan 23, 2012 at 12:23 AM, Gerald Pfeifer ger...@pfeifer.com wrote: On Sat, 21 Jan 2012, Tijl Coosemans wrote: I've been using this patch now. It's similar to the above url, but conditional on TARGET_LIBC_PROVIDES_SSP to support older FreeBSD versions. Gerald volunteered to commit.

Re: Add -lssp_nonshared to LINK_SSP_SPEC

2012-01-22 Thread Gerald Pfeifer
On Sat, 21 Jan 2012, Tijl Coosemans wrote: I've been using this patch now. It's similar to the above url, but conditional on TARGET_LIBC_PROVIDES_SSP to support older FreeBSD versions. Gerald volunteered to commit. Gerald, just trunk for now or older branches too? If Richi agries, I'd

Re: Add -lssp_nonshared to LINK_SSP_SPEC

2012-01-20 Thread Tijl Coosemans
On Wednesday 11 January 2012 10:06:42 Richard Guenther wrote: On Tue, Jan 10, 2012 at 8:50 PM, Tijl Coosemans t...@freebsd.org wrote: On Tuesday 10 January 2012 15:40:15 Richard Guenther wrote: On Tue, Jan 10, 2012 at 3:38 PM, Richard Guenther richard.guent...@gmail.com wrote: On Tue, Jan 10,

Re: Add -lssp_nonshared to LINK_SSP_SPEC

2012-01-11 Thread Richard Guenther
On Tue, Jan 10, 2012 at 8:50 PM, Tijl Coosemans t...@freebsd.org wrote: On Tuesday 10 January 2012 15:40:15 Richard Guenther wrote: On Tue, Jan 10, 2012 at 3:38 PM, Richard Guenther richard.guent...@gmail.com wrote: On Tue, Jan 10, 2012 at 3:14 PM, Tijl Coosemans t...@coosemans.org wrote: On

Add -lssp_nonshared to LINK_SSP_SPEC

2012-01-10 Thread Tijl Coosemans
[TARGET_LIBC_PROVIDES_SSP] (LINK_SSP_SPEC): Add -lssp_nonshared. --- gcc/gcc.c.orig +++ gcc/gcc.c @@ -602,7 +602,7 @@ proper position among the other output f #ifndef LINK_SSP_SPEC #ifdef TARGET_LIBC_PROVIDES_SSP -#define LINK_SSP_SPEC %{fstack-protector:} +#define LINK_SSP_SPEC %{fstack-protector|fstack-protector

Re: Add -lssp_nonshared to LINK_SSP_SPEC

2012-01-10 Thread Richard Guenther
approved. Works fine for me on i?86-linux without -lssp_nonshared (which I do not have, so linking would fail). Richard. 2011-01-10  Tijl Coosemans  t...@coosemans.org        * gcc.c [TARGET_LIBC_PROVIDES_SSP] (LINK_SSP_SPEC): Add -lssp_nonshared. --- gcc/gcc.c.orig +++ gcc/gcc.c

Re: Add -lssp_nonshared to LINK_SSP_SPEC

2012-01-10 Thread Tijl Coosemans
shipped with FreeBSD has been patched like this: http://svnweb.freebsd.org/base/head/contrib/gcc/config/freebsd-spec.h?r1=195697r2=195696 2011-01-10 Tijl Coosemans t...@coosemans.org * gcc.c [TARGET_LIBC_PROVIDES_SSP] (LINK_SSP_SPEC): Add -lssp_nonshared. --- gcc/gcc.c.orig +++ gcc