Re: Backtrace library [3/3]

2017-10-02 Thread Thomas Schwinge
Hi! On Fri, 22 Sep 2017 09:26:19 +0200 (CEST), Richard Biener wrote: > On Thu, 21 Sep 2017, Matthias Klose wrote: > > On 21.09.2017 17:50, Ian Lance Taylor via gcc-patches wrote: > > > On Thu, Sep 21, 2017 at 4:52 AM, Thomas Schwinge > > > wrote: > >

Re: Backtrace library [3/3]

2017-09-22 Thread Richard Biener
On Thu, 21 Sep 2017, Matthias Klose wrote: > On 21.09.2017 17:50, Ian Lance Taylor via gcc-patches wrote: > > On Thu, Sep 21, 2017 at 4:52 AM, Thomas Schwinge > > wrote: > >> > >> On Fri, 14 Sep 2012 14:20:08 -0700, Ian Lance Taylor > >> wrote: >

Re: Backtrace library [3/3]

2017-09-21 Thread Matthias Klose
On 21.09.2017 17:50, Ian Lance Taylor via gcc-patches wrote: > On Thu, Sep 21, 2017 at 4:52 AM, Thomas Schwinge > wrote: >> >> On Fri, 14 Sep 2012 14:20:08 -0700, Ian Lance Taylor wrote: [libbacktrace] >> >>> I won't commit for a day or two in case

Re: Backtrace library [3/3]

2017-09-21 Thread Ian Lance Taylor via gcc-patches
On Thu, Sep 21, 2017 at 4:52 AM, Thomas Schwinge wrote: > > On Fri, 14 Sep 2012 14:20:08 -0700, Ian Lance Taylor wrote: >>> [libbacktrace] > >> I won't commit for a day or two in case anybody sees a >> problem in the implementation. > > Eventually got

Re: Backtrace library [3/3]

2017-09-21 Thread Thomas Schwinge
Hi! On Fri, 14 Sep 2012 14:20:08 -0700, Ian Lance Taylor wrote: >> [libbacktrace] > I won't commit for a day or two in case anybody sees a > problem in the implementation. Eventually got committed, trunk r191397. I just happened to notice that contrib/gcc_update never got

Re: Backtrace library [3/3]

2012-09-14 Thread Jakub Jelinek
On Fri, Sep 14, 2012 at 11:50:31AM +0300, Janne Blomqvist wrote: A few quick comments, 1) Although mmap is not guaranteed to be async-signal-safe, in practice it should be as you mentioned previously. However I see that when using mmap, the implementation uses pthread mutexes. These are not

Re: Backtrace library [3/3]

2012-09-13 Thread Diego Novillo
On 2012-09-12 10:48 , Ian Lance Taylor wrote: On Tue, Sep 11, 2012 at 3:55 PM, Ian Lance Taylor i...@google.com wrote: This patch is the actual implementation of libbacktrace. This is the updated version of this patch with a state parameter. This is OK. Thank you so much for doing this!

Re: Backtrace library [3/3]

2012-09-12 Thread Florian Weimer
On 09/12/2012 12:55 AM, Ian Lance Taylor wrote: I have finished the initial implementation of the backtrace library I proposed at http://gcc.gnu.org/ml/gcc/2012-08/msg00317.html . I've separated the work into three patches. These patches only implement the backtrace library itself; actual use

Re: Backtrace library [3/3]

2012-09-12 Thread Ian Lance Taylor
On Tue, Sep 11, 2012 at 10:16 PM, Jakub Jelinek ja...@redhat.com wrote: On Tue, Sep 11, 2012 at 03:55:04PM -0700, Ian Lance Taylor wrote: +/* The DWARF abbreviations for a compilation unit. This structure + only exists while reading the compilation unit. Most DWARF readers + seem to a

Re: Backtrace library [3/3]

2012-09-12 Thread Ian Lance Taylor
On Wed, Sep 12, 2012 at 2:01 AM, Florian Weimer fwei...@redhat.com wrote: +backtrace_open (const char *filename, backtrace_error_callback error_callback, + void *data) +{ + int descriptor; + + descriptor = open (filename, O_RDONLY | O_CLOEXEC); + if (descriptor 0) +

Re: Backtrace library [3/3]

2012-09-11 Thread Jakub Jelinek
On Tue, Sep 11, 2012 at 03:55:04PM -0700, Ian Lance Taylor wrote: +/* The DWARF abbreviations for a compilation unit. This structure + only exists while reading the compilation unit. Most DWARF readers + seem to a hash table to map abbrev ID's to abbrev entries. + However, we primarily