Re: RFA: fix PR 51649

2012-01-30 Thread Tom Tromey
Tom == Tom Tromey tro...@redhat.com writes: Tom Unless you have other tests to suggest, I am going to say that it has Tom been sufficiently tested and check it in on Friday. Jakub said on irc that he thought I had done sufficient testing. So, I am checking this patch in now. thanks, Tom

Re: RFA: fix PR 51649

2012-01-25 Thread Tom Tromey
Jakub == Jakub Jelinek ja...@redhat.com writes: Jakub Well, even bad debugging experience problems would be very undesirable Jakub if we generated wrong debug info and everybody compiled it into their Jakub sources. But pretty-printers stay on the side, it is just a matter of Jakub updating the

Re: RFA: fix PR 51649

2012-01-24 Thread Richard Guenther
On Mon, Jan 23, 2012 at 8:36 PM, Tom Tromey tro...@redhat.com wrote: This patch fixes some pretty-printer bugs pointed out in PR 51649. The bug in the PR is that the pretty-printers don't work if you build with --enable-symvers=gnu-versioned-namespace. This patch adds test cases for all the

Re: RFA: fix PR 51649

2012-01-24 Thread Jakub Jelinek
On Tue, Jan 24, 2012 at 11:29:12AM +0100, Richard Guenther wrote: We're technically in regression-fixes-only mode. We give target/language maintainers some extra freedom though - while C++/libstdc++ are considered release critical and thus should not regress at this point I'm less sure about

RFA: fix PR 51649

2012-01-23 Thread Tom Tromey
This patch fixes some pretty-printer bugs pointed out in PR 51649. The bug in the PR is that the pretty-printers don't work if you build with --enable-symvers=gnu-versioned-namespace. This patch adds test cases for all the changes I made. I derived most of the information here from reading