Re: [patch, fortran] PR93461 - Bogus "symbol is already defined" with long subroutine names in submodule

2020-01-28 Thread Tobias Burnus
Hi Andrew, On 1/27/20 9:57 PM, Andrew Benson wrote: The problem occurs because GFC_MAX_MANGLED_SYMBOL_LEN is set to GFC_MAX_SYMBOL_LEN*2+4, which is sufficient for a module name plus function name (plus the additional "_"'s that get prepended), but insufficient if a submodule name is included.

Re: [PATCH] forwprop: Tweak choice of VEC_PERM_EXPR filler [PR92822]

2020-01-28 Thread Richard Biener
On Mon, 27 Jan 2020, Richard Sandiford wrote: > For the 2s failures in the PR, we have a V4SF VEC_PERM_EXPR in > which the first two elements are duplicates of one element and > the other two are don't-care: > > v4sf_b = VEC_PERM_EXPR ; > > The heuristic was to extend this with a blend: >

Re: [PATCH] predcom: Fix invalid store-store commoning [PR93434]

2020-01-28 Thread Richard Sandiford
Richard Sandiford writes: > predcom has the following code to stop one rogue load from > interfering with other store-load opportunities: > > /* If A is read and B write or vice versa and there is unsuitable >dependence, instead of merging both components into a component >

Re: [PATCH] doc: clarify the situation with pointer arithmetic

2020-01-28 Thread Richard Biener
On Tue, Jan 28, 2020 at 8:20 AM Alexander Monakov wrote: > > On Tue, 28 Jan 2020, Uecker, Martin wrote: > > > > (*) this also shows the level of "obfuscation" needed to fool compilers > > > to lose provenance knowledge is hard to predict. > > > > Well, this is exactly the problem we want to

[Patch][Fortran] gfortran.texi - minor style cleanup

2020-01-28 Thread Tobias Burnus
Most items in the @menu do not end with a period; all of them do not end with one when used as @section. Hence, it make sense to unify the style to w/o tailing '.'. Committed. Tobias commit 4593f60558474983c79cbbdedc31b4c19e63b671 Author: Tobias Burnus Date: Tue Jan 28 10:58:00 2020 +0100

Re: [PATCH 3/3] Check array contiguity for OpenACC/Fortran

2020-01-28 Thread Tobias Burnus
(CC: fortran@ as it relates to Fortran.) Hi all, On 1/7/20 12:16 PM, Tobias Burnus wrote: in terms of the check, it looks fine to me – but I am not sure about the spec. * [OpenACC] Actually, I simply missed the bit (here: OpenACC 3; OpenACC 2.6 is same): “Any array or subarray in a data

[PATCH] Fix 2 typos in documentation of libstdc++.

2020-01-28 Thread Martin Liška
Hi. It's a simple documentation fix. I'm going to install the patch. Martin libstdc++-v3/ChangeLog: 2020-01-28 Martin Liska PR libstdc++/93478 * include/std/atomic: Fix typo. * include/std/optional: Likewise. --- libstdc++-v3/include/std/atomic | 2 +-

Re: [PATCH] predcom: Fix invalid store-store commoning [PR93434]

2020-01-28 Thread Richard Biener
On Tue, Jan 28, 2020 at 10:49 AM Richard Sandiford wrote: > > Richard Sandiford writes: > > predcom has the following code to stop one rogue load from > > interfering with other store-load opportunities: > > > > /* If A is read and B write or vice versa and there is unsuitable > >

Re: [Ping][GCC][IRA] Revert 11b8091fb to fix Bug 93221

2020-01-28 Thread Eric Botcazou
> Ping! Eric, do you have any objections to reverting? See my comment posted in the audit trail of the TN on 01/20... -- Eric Botcazou

Re: [committed] Add diagnostic_metadata and CWE support

2020-01-28 Thread Jakub Jelinek
On Wed, Dec 18, 2019 at 07:08:25PM -0500, David Malcolm wrote: > This patch adds support for associating a diagnostic message with an > optional diagnostic_metadata object, so that plugins can add extra data > to their diagnostics (e.g. mapping a diagnostic to a taxonomy or coding > standard such

[PATCH] predcom: Fix invalid store-store commoning [PR93434]

2020-01-28 Thread Richard Sandiford
predcom has the following code to stop one rogue load from interfering with other store-load opportunities: /* If A is read and B write or vice versa and there is unsuitable dependence, instead of merging both components into a component that will certainly not pass

Re: [Ping][GCC][IRA] Revert 11b8091fb to fix Bug 93221

2020-01-28 Thread Joel Hutton
On 28/01/2020 09:07, Eric Botcazou wrote: >> Ping! Eric, do you have any objections to reverting? > > See my comment posted in the audit trail of the TN on 01/20... > Probably missing live range splitting or somesuch, as envisioned by > Vladimir in its approval message. Feel free to eventually

Re: [PATCH v2][ARM] Disable code hoisting with -O3 (PR80155)

2020-01-28 Thread Richard Biener
On Mon, Jan 27, 2020 at 10:47 PM Segher Boessenkool wrote: > > Hi! > > On Tue, Jan 21, 2020 at 02:10:21PM +, Wilco Dijkstra wrote: > > While code hoisting generally improves codesize, it can affect performance > > negatively. Benchmarking shows it doesn't help SPEC and negatively affects > >

Re: [PATCH] analyzer: fix build with gcc 4.4 (PR 93276)

2020-01-28 Thread Jakub Jelinek
On Fri, Jan 24, 2020 at 07:53:28PM -0500, David Malcolm wrote: > This patch fixes various build failures seen with gcc 4.4 > > gcc prior to 4.6 complains about: > > error: #pragma GCC diagnostic not allowed inside functions > > for various uses of PUSH_IGNORE_WFORMAT and POP_IGNORE_WFORMAT. >

Re: [patch, fortran] PR93473 - ICE on valid with long module + submodule names

2020-01-28 Thread Tobias Burnus
On 1/28/20 12:41 AM, Andrew Benson wrote: The problem occurs in set_syms_host_assoc() where the "parent1" and "parent2" variables have a maximum length of GFC_MAX_SYMBOL_LEN+1. This is insufficient when the parent names are a module+submodule name concatenated with a ".". The patch above fixes

* PING * Re: [OpenACC] bump version for 2.6 plus libgomp.texi update — document acc_attach/acc_detach, acc_*_async, acc_*_finalize(_async) functions

2020-01-28 Thread Tobias Burnus
*PING* Those two patches bump the OpenACC version number from 2.0 (alias 201306) to OpenACC 2.6 (alias 201711). I believe except for bugs and known omissions (e.g. PR93225+93226), the OpenACC 2.6 support is complete. Additionally, it updates the documentation accordingly, no longer marks

[COMMITTED] c++: Fix return deduction of lambda in discarded stmt.

2020-01-28 Thread Jason Merrill
A return statement in a discarded statement is not used for return type deduction, but we still want to do deduction for a return statement in a lambda in a discarded statement. Tested x86_64-pc-linux-gnu, applying to trunk. PR c++/93442 * parser.c (cp_parser_lambda_expression):

[COMMITTED] c++: Fix guard variable and attribute weak.

2020-01-28 Thread Jason Merrill
My patch for PR 91476 worked for decls that are implicitly comdat/weak due to C++ linkage rules, but broke variables explicitly marked weak. Tested x86_64-pc-linux-gnu, applying to trunk. PR c++/93477 PR c++/91476 * decl2.c (copy_linkage): Do copy DECL_ONE_ONLY and

Re: [PATCH 3/3] Implementation of -Wclobbered on tree-ssa

2020-01-28 Thread Jeff Law
On Tue, 2019-10-08 at 18:04 +0300, Alexander Monakov wrote: > On Thu, 3 Oct 2019, Jeff Law wrote: > > > You may want to review the 2018 discussion: > > > > https://www.mail-archive.com/gcc-patches@gcc.gnu.org/msg185287.html > > > > THe 2018 discussion was primarily concerned with fixing the CFG

Re: [PATCH] testsuite: XFAIL gcc.dg/torture/pr93133.c for powerpc*-*-* [PR93393]

2020-01-28 Thread Segher Boessenkool
On Tue, Jan 28, 2020 at 10:43:24AM +, Richard Sandiford wrote: > Tested on aarch64-linux-gnu, x86_64-linux-gnu and powerpc64le-linux-gnu. > OK to install? Yes, thank you. Segher > 2020-01-28 Richard Sandiford > > gcc/testsuite/ > PR testsuite/93393 > *

[committed] add test for PR 93437

2020-01-28 Thread Martin Sebor
Done in r10-6309-g4dd27b527c503aa50909fe1eb7d308266b1e103a. Martin

Re: [PATCH 3/3] Implementation of -Wclobbered on tree-ssa

2020-01-28 Thread Jeff Law
On Thu, 2019-10-17 at 16:14 +0300, Alexander Monakov wrote: > On Tue, 8 Oct 2019, Alexander Monakov wrote: > > [massive snip] > > > So in my opinion our CFG is good enough, the real issues with -Wclobbered > > false > > positives are not due to phi nodes but other effects. > > > > If you

Re: [PATCH] i386: Disable TARGET_SSE_TYPELESS_STORES for TARGET_AVX

2020-01-28 Thread H.J. Lu
On Mon, Jan 27, 2020 at 11:04 PM Uros Bizjak wrote: > > On Mon, Jan 27, 2020 at 11:17 PM H.J. Lu wrote: > > > > On Mon, Jan 27, 2020 at 12:26 PM Uros Bizjak wrote: > > > > > > On Mon, Jan 27, 2020 at 7:23 PM H.J. Lu wrote: > > > > > > > > movaps/movups is one byte shorter than movdaq/movdqu.

[PATCH] Add OpenACC acc_get_property support for AMD GCN

2020-01-28 Thread Harwath, Frederik
Hi, this patch adds full support for the OpenACC 2.6 acc_get_property and acc_get_property_string functions to the libgomp GCN plugin. This replaces the existing stub in libgomp/plugin-gcn.c. Andrew: The value returned for acc_property_memory ("size of device memory in bytes" according to the

Re: [Ping][GCC][IRA] Revert 11b8091fb to fix Bug 93221

2020-01-28 Thread Vladimir Makarov
On 1/28/20 4:30 AM, Joel Hutton wrote: On 28/01/2020 09:07, Eric Botcazou wrote: Ping! Eric, do you have any objections to reverting? See my comment posted in the audit trail of the TN on 01/20... Probably missing live range splitting or somesuch, as envisioned by Vladimir in its approval

[PATCH] diagnostic_metadata: unbreak xgettext

2020-01-28 Thread David Malcolm
On Tue, 2020-01-28 at 11:16 +0100, Jakub Jelinek wrote: > On Wed, Dec 18, 2019 at 07:08:25PM -0500, David Malcolm wrote: > > This patch adds support for associating a diagnostic message with > > an > > optional diagnostic_metadata object, so that plugins can add extra > > data > > to their

Re: [PATCH] diagnostic_metadata: unbreak xgettext

2020-01-28 Thread Jakub Jelinek
On Tue, Jan 28, 2020 at 09:30:17AM -0500, David Malcolm wrote: > * diagnostic-core.h (warning_at): Rename overload to... > (warning_with_metadata_at): ...this. I think this is just too long, especially for a function used at least in the analyzer pretty often, leading to lots of ugly

Re: [PATCH] i386: Disable TARGET_SSE_TYPELESS_STORES for TARGET_AVX

2020-01-28 Thread Uros Bizjak
On Tue, Jan 28, 2020 at 3:32 PM H.J. Lu wrote: > > On Mon, Jan 27, 2020 at 11:04 PM Uros Bizjak wrote: > > > > On Mon, Jan 27, 2020 at 11:17 PM H.J. Lu wrote: > > > > > > On Mon, Jan 27, 2020 at 12:26 PM Uros Bizjak wrote: > > > > > > > > On Mon, Jan 27, 2020 at 7:23 PM H.J. Lu wrote: > > > >

[PATCH] diagnostic_metadata: unbreak xgettext (v2)

2020-01-28 Thread David Malcolm
On Tue, 2020-01-28 at 15:36 +0100, Jakub Jelinek wrote: > On Tue, Jan 28, 2020 at 09:30:17AM -0500, David Malcolm wrote: > > * diagnostic-core.h (warning_at): Rename overload to... > > (warning_with_metadata_at): ...this. > > I think this is just too long, especially for a function used

Re: [PATCH] analyzer: fix build with gcc 4.4 (PR 93276)

2020-01-28 Thread David Malcolm
On Tue, 2020-01-28 at 11:13 +0100, Jakub Jelinek wrote: > On Fri, Jan 24, 2020 at 07:53:28PM -0500, David Malcolm wrote: > > This patch fixes various build failures seen with gcc 4.4 > > > > gcc prior to 4.6 complains about: > > > > error: #pragma GCC diagnostic not allowed inside functions >

[PR 93542] Make __has_include a builtin macro

2020-01-28 Thread Nathan Sidwell
The clever hack of '#define __has_include __has_include' breaks -dD and -fdirectives-only, because that emits definitions. This turns __has_include into a proper builtin macro. Thus it's never emitted via -dD, and because use outside of directive processing is undefined, we can just expand it

[PATCH] coroutines: Fix ICE on invalid (PR93458).

2020-01-28 Thread Iain Sandoe
Hi, Since coroutine-ness is discovered lazily, we encounter the diagnostics during each keyword parse. We were not handling the case where a user code failed to include fundamental information (e.g. the traits) in a graceful manner (nor tolerating that level of fail for subsequent diagnostics).

[COMMITTED] testsuite: Add -Wpsabi to gcc.dg/torture/pr93170.c [PR93460]

2020-01-28 Thread Richard Sandiford
Tested on aarch64-linux-gnu, x86_64-linux-gnu and powerpc64le-linux-gnu. Pushed as obvious. Richard 2020-01-28 Richard Sandiford gcc/testsuite/ PR testsuite/93460 * gcc.dg/torture/pr93170.c: Add -Wpsabi. --- gcc/testsuite/gcc.dg/torture/pr93170.c | 1 + 1 file changed, 1

Re: [PATCH v2][ARM] Disable code hoisting with -O3 (PR80155)

2020-01-28 Thread Ramana Radhakrishnan
On Tue, Nov 26, 2019 at 3:18 PM Wilco Dijkstra wrote: > > Hi, > > While code hoisting generally improves codesize, it can affect performance > negatively. Benchmarking shows it doesn't help SPEC and negatively affects > embedded benchmarks. Since the impact is relatively small with -O2 and mainly

Re: [PATCH][AArch64] Fix shrinkwrapping interactions with atomics (PR92692)

2020-01-28 Thread Segher Boessenkool
Hi! On Mon, Jan 27, 2020 at 04:28:29PM +, Wilco Dijkstra wrote: > > On Thu, Jan 16, 2020 at 12:50:14PM +, Wilco Dijkstra wrote: > >> The separate shrinkwrapping pass may insert stores in the middle > >> of atomics loops which can cause issues on some implementations. > >> Avoid this by

[PATCH] c++: Function declared with typedef with eh-specification.

2020-01-28 Thread Jason Merrill
We just need to handle the exception specification like other properties of a function typedef. Tested x86_64-pc-linux-gnu, applying to trunk/9. PR c++/90731 * decl.c (grokdeclarator): Propagate eh spec from typedef. --- gcc/cp/decl.c| 1 +

Re: [PATCH] i386: Disable TARGET_SSE_TYPELESS_STORES for TARGET_AVX

2020-01-28 Thread H.J. Lu
On Tue, Jan 28, 2020 at 6:45 AM Uros Bizjak wrote: > > On Tue, Jan 28, 2020 at 3:32 PM H.J. Lu wrote: > > > > On Mon, Jan 27, 2020 at 11:04 PM Uros Bizjak wrote: > > > > > > On Mon, Jan 27, 2020 at 11:17 PM H.J. Lu wrote: > > > > > > > > On Mon, Jan 27, 2020 at 12:26 PM Uros Bizjak wrote: > >

Re: [PATCH] diagnostic_metadata: unbreak xgettext (v2)

2020-01-28 Thread Jakub Jelinek
On Tue, Jan 28, 2020 at 10:30:58AM -0500, David Malcolm wrote: > gcc/analyzer/ChangeLog: > * region-model.cc (poisoned_value_diagnostic::emit): Update for > renaming of warning_at overload to warning_meta. > * sm-file.cc (file_leak::emit): Likewise. > * sm-malloc.cc

Re: [PATCH] gcc: Add new configure options to allow static libraries to be selected

2020-01-28 Thread Jonathan Wakely
On 22/01/20 15:39 +, Andrew Burgess wrote: The motivation behind this change is to make it easier for a user to link against static libraries on a target where dynamic libraries are the default library type (for example GNU/Linux). Further, my motivation is really for linking libraries into

Re: [PATCH] Add OpenACC acc_get_property support for AMD GCN

2020-01-28 Thread Andrew Stubbs
On 28/01/2020 14:55, Harwath, Frederik wrote: Hi, this patch adds full support for the OpenACC 2.6 acc_get_property and acc_get_property_string functions to the libgomp GCN plugin. This replaces the existing stub in libgomp/plugin-gcn.c. Andrew: The value returned for acc_property_memory ("size

Re: [PATCH] Fix component mappings with derived types for OpenACC

2020-01-28 Thread Julian Brown
On Fri, 24 Jan 2020 10:58:49 +0100 Tobias Burnus wrote: > Hi Julian, > > the gfortran part is rather obvious and it and the test case look > fine to me → OK. > The oacc-mem.c also looks okay, but I assume Thomas needs to > rubber-stamp it. I understand that Thomas is unavailable for the time

Re: [PING][PATCH][GCC][ARM] Arm generates out of range conditional branches in Thumb2 (PR91816)

2020-01-28 Thread Kyrill Tkachov
Hi Stam, On 1/8/20 3:18 PM, Stam Markianos-Wright wrote: On 12/10/19 5:03 PM, Kyrill Tkachov wrote: Hi Stam, On 11/15/19 5:26 PM, Stam Markianos-Wright wrote: Pinging with more correct maintainers this time :) Also would need to backport to gcc7,8,9, but need to get this approved first!

[Patch, committed][Fortran] avoid ICE in gfc_omp_check_optional_argument (PR93464)

2020-01-28 Thread Tobias Burnus
(This was a GCC 10 regression, affecting both OpenMP and OpenACC.) In gfc_omp_check_optional_argument: DECL_LANG_SPECIFIC is always available (check at the top). However, if decl is not a PARM_DECL, it can have two reasons: Either it is no parameter (C sense; Fortran: dummy argument) at all

[PATCH] tree-optimization/93439 move clique bookkeeping to OMP expansion

2020-01-28 Thread Richard Biener
Autopar was doing clique bookkeeping too early when creating destination functions but then later introducing new cliques via versioning loops. The following moves the bookkeeping to the actual outlining process. Bootstrapped & tested on x86_64-unknown-linux-gnu, pushed. Richard. 2020-01-28

Re: [PATCH] simplify-rtx: Extend (truncate (*extract ...)) fold [PR87763]

2020-01-28 Thread Richard Sandiford
Jeff Law writes: > On Mon, 2020-01-27 at 16:41 +, Richard Sandiford wrote: >> In the gcc.target/aarch64/lsl_asr_sbfiz.c part of this PR, we have: >> >> Failed to match this instruction: >> (set (reg:SI 95) >> (ashift:SI (subreg:SI (sign_extract:DI (subreg:DI (reg:SI 97) 0) >>

Re: [RFC] [c-family] PR92867 - Add returns_arg attribute

2020-01-28 Thread Jakub Jelinek
On Tue, Jan 28, 2020 at 05:09:36PM +0530, Prathamesh Kulkarni wrote: > On Tue, 28 Jan 2020 at 17:00, Jakub Jelinek wrote: > > > > On Tue, Jan 28, 2020 at 04:56:59PM +0530, Prathamesh Kulkarni wrote: > > > Thanks for the suggestions. In the attached patch I bumped up value of > > >

Re: [PATCH] doc: clarify the situation with pointer arithmetic

2020-01-28 Thread Uecker, Martin
Am Dienstag, den 28.01.2020, 11:01 +0100 schrieb Richard Biener: > On Tue, Jan 28, 2020 at 8:20 AM Alexander Monakov wrote: > > > > On Tue, 28 Jan 2020, Uecker, Martin wrote: > > > > > > (*) this also shows the level of "obfuscation" needed to fool compilers > > > > to lose provenance knowledge

[COMMITTED] libstdc++: Avoid using sizeof with function types (PR 93470)

2020-01-28 Thread Jonathan Wakely
PR libstdc++/93470 * include/bits/refwrap.h (reference_wrapper::operator()): Restrict static assertion to object types. Tested powerpc64le-linux and verified with Clang. Committed to master. Backport to gcc-9-branch needed too. commit

Re: [PR47785] COLLECT_AS_OPTIONS

2020-01-28 Thread Richard Biener
On Fri, Jan 24, 2020 at 7:04 AM Prathamesh Kulkarni wrote: > > On Mon, 20 Jan 2020 at 15:44, Richard Biener > wrote: > > > > On Wed, Jan 8, 2020 at 11:20 AM Prathamesh Kulkarni > > wrote: > > > > > > On Tue, 5 Nov 2019 at 17:38, Richard Biener > > > wrote: > > > > > > > > On Tue, Nov 5, 2019

Re: [PATCH] doc: clarify the situation with pointer arithmetic

2020-01-28 Thread Uecker, Martin
Am Dienstag, den 28.01.2020, 10:20 +0300 schrieb Alexander Monakov: > On Tue, 28 Jan 2020, Uecker, Martin wrote: > > > > (*) this also shows the level of "obfuscation" needed to fool compilers > > > to lose provenance knowledge is hard to predict. > > > > Well, this is exactly the problem we

[PATCH] libstdc++: Replace glibc-specific check for clock_gettime (PR 93325)

2020-01-28 Thread Jonathan Wakely
It's wrong to assume that clock_gettime is unavailable on any *-*-linux* target that doesn't have glibc 2.17 or later. Use a generic test instead of using __GLIBC_PREREQ. Only do that test when is_hosted=yes so that we don't get an error for cross targets without a working linker. This ensures

Re: [PATCH] gcc: Add new configure options to allow static libraries to be selected

2020-01-28 Thread Iain Sandoe
Hi Andrew, Andrew Burgess wrote: * Jeff Law [2020-01-22 13:52:27 -0700]: On Wed, 2020-01-22 at 15:39 +, Andrew Burgess wrote: The motivation behind this change is to make it easier for a user to link against static libraries on a target where dynamic libraries are the default library

[PATCH] testsuite: XFAIL gcc.dg/torture/pr93133.c for powerpc*-*-* [PR93393]

2020-01-28 Thread Richard Sandiford
Tested on aarch64-linux-gnu, x86_64-linux-gnu and powerpc64le-linux-gnu. OK to install? Richard 2020-01-28 Richard Sandiford gcc/testsuite/ PR testsuite/93393 * gcc.dg/torture/pr93133.c: XFAIL for powerpc*-*-*. --- gcc/testsuite/gcc.dg/torture/pr93133.c | 2 +- 1 file

Re: [RFC] [c-family] PR92867 - Add returns_arg attribute

2020-01-28 Thread Prathamesh Kulkarni
On Mon, 27 Jan 2020 at 17:36, Richard Biener wrote: > > On Fri, Jan 24, 2020 at 11:53 PM Joseph Myers wrote: > > > > On Fri, 24 Jan 2020, Prathamesh Kulkarni wrote: > > > > > The middle-end representation issue of ERF_RETURNS_ARG still remains, > > > which restricts the attribute till first four

Re: [RFC] [c-family] PR92867 - Add returns_arg attribute

2020-01-28 Thread Jakub Jelinek
On Tue, Jan 28, 2020 at 04:56:59PM +0530, Prathamesh Kulkarni wrote: > Thanks for the suggestions. In the attached patch I bumped up value of > ERF_RETURNS_ARG_MASK > to UINT_MAX >> 2, and use highest two bits for ERF_NOALIAS and > ERF_RETURNS_ARG. > And use fn spec "Z" to store the argument

Re: [RFC] [c-family] PR92867 - Add returns_arg attribute

2020-01-28 Thread Prathamesh Kulkarni
On Tue, 28 Jan 2020 at 17:00, Jakub Jelinek wrote: > > On Tue, Jan 28, 2020 at 04:56:59PM +0530, Prathamesh Kulkarni wrote: > > Thanks for the suggestions. In the attached patch I bumped up value of > > ERF_RETURNS_ARG_MASK > > to UINT_MAX >> 2, and use highest two bits for ERF_NOALIAS and > >

Re: [PATCH v2][ARM] Disable code hoisting with -O3 (PR80155)

2020-01-28 Thread Segher Boessenkool
On Tue, Jan 28, 2020 at 10:42:16AM +0100, Richard Biener wrote: > On Mon, Jan 27, 2020 at 10:47 PM Segher Boessenkool > wrote: > > On Tue, Jan 21, 2020 at 02:10:21PM +, Wilco Dijkstra wrote: > > > While code hoisting generally improves codesize, it can affect performance > > > negatively.

Re: [GCC][PATCH][AArch32] ACLE intrinsics bfloat16 vmmla and vfma for AArch32 AdvSIMD

2020-01-28 Thread Delia Burduv
Ping. From: Delia Burduv Sent: 22 January 2020 17:26 To: gcc-patches@gcc.gnu.org Cc: ni...@redhat.com ; Richard Earnshaw ; Ramana Radhakrishnan ; Kyrylo Tkachov Subject: Re: [GCC][PATCH][AArch32] ACLE intrinsics bfloat16 vmmla and vfma for AArch32 AdvSIMD

Re: [PATCH] i386: Disable TARGET_SSE_TYPELESS_STORES for TARGET_AVX

2020-01-28 Thread Uros Bizjak
On Tue, Jan 28, 2020 at 4:34 PM H.J. Lu wrote: > > You could move > > > > (match_test "TARGET_AVX") > > (const_string "TI") > > > > up to bypass the cases below. > > > > I don't think we can do that. There are 2 cases where we prefer > movaps/movups: > > /* Use packed single precision

Re: [PATCH] i386: Prefer TARGET_AVX over TARGET_SSE_TYPELESS_STORES

2020-01-28 Thread Uros Bizjak
On Tue, Jan 28, 2020 at 6:51 PM H.J. Lu wrote: > > On Tue, Jan 28, 2020 at 9:12 AM Uros Bizjak wrote: > > > > On Tue, Jan 28, 2020 at 4:34 PM H.J. Lu wrote: > > > > > > You could move > > > > > > > > (match_test "TARGET_AVX") > > > > (const_string "TI") > > > > > > > > up to bypass the cases

Re: [committed, amdgcn] Fix ICE on unsupported FP comparison

2020-01-28 Thread Andrew Stubbs
On 24/01/2020 14:58, Andrew Stubbs wrote: I've committed this patch to fix an ICE building the gcc.dg/vect/fast-math-pr55281.c testcase. Oops, I got that crossed. This was the fix for gcc.dg/pr50310-2.c. The fast-math-pr55281.c fix will be posted shortly. The problem was that the combine

Re: [patch, fortran] PR93461 - Bogus "symbol is already defined" with long subroutine names in submodule

2020-01-28 Thread Andrew Benson
Hi Tobias, Thanks - committed as https://gcc.gnu.org/git/gitweb.cgi? p=gcc.git;a=commit;h=ad690d79cfbb905c5546c9333c5fd089d906505b I'll send a separate email about changes to the release notes. -Andrew On Tuesday, January 28, 2020 6:49:54 PM PST Tobias Burnus wrote: > Hi Andrew, > > On

Re: [patch, fortran] PR93461 - Bogus "symbol is already defined" with long subroutine names in submodule

2020-01-28 Thread Andrew Benson
Hi Tobias, > > The problem occurs because GFC_MAX_MANGLED_SYMBOL_LEN is set to > > GFC_MAX_SYMBOL_LEN*2+4, which is sufficient for a module name plus > > function name (plus the additional "_"'s that get prepended), but > > insufficient if a submodule name is included. The name then gets > >

Re: [patch, fortran] PR93473 - ICE on valid with long module + submodule names

2020-01-28 Thread Andrew Benson
On Tuesday, January 28, 2020 9:27:58 AM PST Tobias Burnus wrote: > On 1/28/20 12:41 AM, Andrew Benson wrote: > > The problem occurs in set_syms_host_assoc() where the "parent1" and > > "parent2" variables have a maximum length of GFC_MAX_SYMBOL_LEN+1. This > > is insufficient when the parent names

Re: ACLE intrinsics: BFloat16 store (vst{q}_bf16) intrinsics for AArch32

2020-01-28 Thread Delia Burduv
Ping. From: Delia Burduv Sent: 22 January 2020 17:29 To: gcc-patches@gcc.gnu.org Cc: ni...@redhat.com ; Richard Earnshaw ; Kyrylo Tkachov ; Ramana Radhakrishnan Subject: Re: ACLE intrinsics: BFloat16 store (vst{q}_bf16) intrinsics for AArch32 Ping. I will

Re: ACLE intrinsics: BFloat16 load intrinsics for AArch32

2020-01-28 Thread Delia Burduv
Ping. From: Delia Burduv Sent: 22 January 2020 17:31 To: gcc-patches@gcc.gnu.org Cc: ni...@redhat.com ; Richard Earnshaw ; Kyrylo Tkachov ; Ramana Radhakrishnan Subject: Re: ACLE intrinsics: BFloat16 load intrinsics for AArch32 Ping. I will change the tests

Re: Return slot optimization for stack protector strong

2020-01-28 Thread Stefan Schulze Frielinghaus
On Mon, Jan 27, 2020 at 06:53:51PM +0100, Jakub Jelinek wrote: > On Mon, Jan 27, 2020 at 06:49:23PM +0100, Stefan Schulze Frielinghaus wrote: > > some function calls trigger the stack-protector-strong although such > > calls are later on implemented via calls to internal functions. > > Consider

Re: [PATCH] doc: clarify the situation with pointer arithmetic

2020-01-28 Thread Alexander Monakov
On Tue, 28 Jan 2020, Uecker, Martin wrote: > Unfortunately, this is not as simple. It is not trivial to > define the set of objects whose "address could have participated > in the computation" > [...] I am not satisfied with the response, but I'm not sure I should continue arguing here.

[PATCH] i386: Prefer TARGET_AVX over TARGET_SSE_TYPELESS_STORES

2020-01-28 Thread H.J. Lu
On Tue, Jan 28, 2020 at 9:12 AM Uros Bizjak wrote: > > On Tue, Jan 28, 2020 at 4:34 PM H.J. Lu wrote: > > > > You could move > > > > > > (match_test "TARGET_AVX") > > > (const_string "TI") > > > > > > up to bypass the cases below. > > > > > > > I don't think we can do that. There are 2 cases

Re: [patch, fortran] PR93473 - ICE on valid with long module + submodule names

2020-01-28 Thread Andrew Benson
Thanks - committed as a83b5cc5828ee34471de415e8893242dd3b0a91b https://gcc.gnu.org/git/gitweb.cgi? p=gcc.git;a=commit;h=a83b5cc5828ee34471de415e8893242dd3b0a91b I'll close the PR. Thanks, Andrew On Tuesday, January 28, 2020 6:32:21 PM PST Tobias Burnus wrote: > LGTM now. > > Thanks, > >

[PATCH, ivopts] Fix fast-math-pr55281.c ICE

2020-01-28 Thread Andrew Stubbs
This patch fixes an ICE compiling fast-math-pr55281.c for amdgcn. The problem is that an "iv" is created in which both base and step are pointer types, but the base is converted to sizetype without also converting the step to a non-pointer type. Later in the compilation this results in a

Re: [patch, fortran] PR93473 - ICE on valid with long module + submodule names

2020-01-28 Thread Tobias Burnus
LGTM now. Thanks, Tobias On 1/28/20 5:41 PM, Andrew Benson wrote: On Tuesday, January 28, 2020 9:27:58 AM PST Tobias Burnus wrote: On 1/28/20 12:41 AM, Andrew Benson wrote: The problem occurs in set_syms_host_assoc() where the "parent1" and "parent2" variables have a maximum length of

Re: [patch, fortran] PR93461 - Bogus "symbol is already defined" with long subroutine names in submodule

2020-01-28 Thread Tobias Burnus
Hi Andrew, On 1/28/20 5:41 PM, Andrew Benson wrote: Can you also update the comment before the #define? It currently has: Thanks for the suggestion. An updated patch is attached. Thanks. LGTM now. PS: I wonder whether there are relevant systems which will fail because they do not handle that

Re: [PATCH] i386: Prefer TARGET_AVX over TARGET_SSE_TYPELESS_STORES

2020-01-28 Thread H.J. Lu
On Tue, Jan 28, 2020 at 10:04 AM Uros Bizjak wrote: > > On Tue, Jan 28, 2020 at 6:51 PM H.J. Lu wrote: > > > > On Tue, Jan 28, 2020 at 9:12 AM Uros Bizjak wrote: > > > > > > On Tue, Jan 28, 2020 at 4:34 PM H.J. Lu wrote: > > > > > > > > You could move > > > > > > > > > > (match_test

[patch, fortran] PR93486 - ICE on valid with nested submodules and long submodule names

2020-01-28 Thread Andrew Benson
algorithms: zlib gcc version 10.0.1 20200128 (experimental) (GCC) $ gfortran -c test.F90 -o test.o f951: internal compiler error: Segmentation fault 0xe1bc9f crash_signal ../../gcc-git/gcc/toplev.c:328 0x7f98119c71ef ??? /data001/abenson/Galacticus/Tools/glibc-2.12.1/signal

Re: [patch, fortran, wwwdocs] PR93461 - Bogus "symbol is already defined" with long subroutine names in submodule

2020-01-28 Thread Andrew Benson
Hi Tobias, On Tuesday, January 28, 2020 6:49:54 PM PST Tobias Burnus wrote: > Thus, I do not think it is a real problem in practice. We could be nice, > however, and add a note to the release notes (i.e. > https://gcc.gnu.org/gcc-10/changes.html); I not completely sure whether > it is worthwhile

[RFA/RFC] Improve DSE/aliasing around __builtin_object_size (PR89689, P2 regression)

2020-01-28 Thread Jeff Law
Here's two approaches to fix the regression in 89689. Note this only fixes the regression in the originally reported testcase. THe deeper issue Martin raises in C#1 is not addressed. Thus if we go forward with either patch ISTM that we would drop the regression markers, but keep the BZ open.

[PATCH] c++: Fix class NTTP with template arguments [PR92948]

2020-01-28 Thread Marek Polacek
This PR points out an ICE with an alias template and class NTTP, but I found that there are more issues. Trouble arise when we use a (non-type) template parameter as an argument to the template arg list of a template that accepts a class NTTP and a conversion to a class is involved, e.g.

Re: [cris-decc0 8/9] cris: Move trivially from cc0 to reg:CC model, removing most optimizations.

2020-01-28 Thread Hans-Peter Nilsson
> From: Segher Boessenkool > Date: Mon, 27 Jan 2020 23:52:21 +0100 > Hi! > > On Wed, Jan 22, 2020 at 07:11:27AM +0100, Hans-Peter Nilsson wrote: > > I intend to put back as many as I find use for, of those > > anonymous patterns in a controlled manner, with self-contained > > test-cases proving

Re: GCC fixincludes bug

2020-01-28 Thread Bruce Korb
On 1/23/20 8:07 AM, Pétur Orri Ragnarsson wrote: > Hi. > > I ran into a problem with fixincludes when building GCC. Your email is > in the README file. > > > When building a crosscompiling GCC 8.3.0 for powerpc the following "fix" > is applied: > >     $ diff

Re: [committed] Add include hack to fix missing SCNuMAX defines in inttypes.h on hpux11.[01]*

2020-01-28 Thread Bruce Korb
On 1/25/20 9:34 AM, John David Anglin wrote: > +/* > + * Fix missing SCNuMAX defines in inttypes.h > + */ > +fix = { > +hackname = hpux_c99_inttypes4; > +mach = "hppa*-hp-hpux11.[01]*"; > +files = inttypes.h; > +sed = "/^[ \t]*#[ \t]*define[ \t]*SCNxMAX[

profile: fix profile count dumping

2020-01-28 Thread Jan Hubicka
Hi, this patch fixes dump of quality. Comitted as obvious. * profile-count.h (profile_quality_display_names): Fix ordering. diff --git a/gcc/profile-count.c b/gcc/profile-count.c index 0c792297826..c89914ff8a0 100644 --- a/gcc/profile-count.c +++ b/gcc/profile-count.c @@ -78,9 +78,9 @@

[COMMITTED] c++: Allow template rvalue-ref conv to bind to lvalue ref.

2020-01-28 Thread Jason Merrill
When I implemented the [over.match.ref] rule that a reference conversion function needs to match l/rvalue of the target reference type it changed our handling of this testcase. It seems to me that our current behavior is what the standard says, but it doesn't seem desirable, and all the other

diagnostics: make error message lowercase.

2020-01-28 Thread Jan Hubicka
Hi, I comitted this ias obvious. I also wonder if the next error should be info or should be part of the first error message. * coverage.c (read_counts_file): Make error message lowercase. diff --git a/gcc/coverage.c b/gcc/coverage.c index 5e961b26f66..f29ff640c43 100644 ---

Patch to fix PR93272

2020-01-28 Thread Vladimir Makarov
The following patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93272 The patch was successfully tested and bootstrapped on x86_64. Unfortunately it is hard to create a test case for the patch.  So there is no test for this PR. commit 5c8a1211b9873a1b69ef7b2fddae181535bc3b0a (HEAD

[committed] analyzer: fix ICE when longjmp isn't marked 'noreturn' (PR 93316)

2020-01-28 Thread David Malcolm
Comments 11-16 within PR analyzer/93316 discuss an ICE in some setjmp tests seen on AIX and powerpc-darwin9. The issue turned out to be an implicit assumption that longjmp is marked "noreturn". There are two places in engine.cc where the code attempted to locate the longjmp GIMPLE_CALL by

ipa: fix handling of multiple speculations (PR93318)

2020-01-28 Thread Jan Hubicka
Hi, This patch started as work to resole Richard's comment on quadratic lookups in resolve_speculation. While doing it I however noticed multiple problems in the new speuclative call code which made the patch quite big. In particular: 1) Before applying speculation we consider only targets with

[PATCH] coroutines: Prevent repeated error messages for missing promise.

2020-01-28 Thread Iain Sandoe
While looking at Pr93458, I spotted the following non-fatal, but unhelpful diagnostic output. If the user's coroutine return type omits the mandatory promise type then we will currently restate that error each time we see a coroutine keyword, which doesn't provide any new information. This

Re: [PATCH] diagnostic_metadata: unbreak xgettext (v2)

2020-01-28 Thread David Malcolm
On Tue, 2020-01-28 at 16:34 +0100, Jakub Jelinek wrote: > On Tue, Jan 28, 2020 at 10:30:58AM -0500, David Malcolm wrote: > > gcc/analyzer/ChangeLog: > > * region-model.cc (poisoned_value_diagnostic::emit): Update for > > renaming of warning_at overload to warning_meta. > > * sm-file.cc

Re: [PATCH] i386: Prefer TARGET_AVX over TARGET_SSE_TYPELESS_STORES

2020-01-28 Thread Jakub Jelinek
On Tue, Jan 28, 2020 at 10:20:36AM -0800, H.J. Lu wrote: > From 66c534dedc7a9a632aa38c32e3f7c251b8f2c778 Mon Sep 17 00:00:00 2001 > From: "H.J. Lu" > Date: Mon, 27 Jan 2020 09:35:11 -0800 > Subject: [PATCH] i386: Prefer TARGET_AVX over TARGET_SSE_TYPELESS_STORES > > movaps/movups is one byte

Re: [PATCH] i386: Prefer TARGET_AVX over TARGET_SSE_TYPELESS_STORES

2020-01-28 Thread H.J. Lu
On Tue, Jan 28, 2020 at 10:58 AM Jakub Jelinek wrote: > > On Tue, Jan 28, 2020 at 10:20:36AM -0800, H.J. Lu wrote: > > From 66c534dedc7a9a632aa38c32e3f7c251b8f2c778 Mon Sep 17 00:00:00 2001 > > From: "H.J. Lu" > > Date: Mon, 27 Jan 2020 09:35:11 -0800 > > Subject: [PATCH] i386: Prefer TARGET_AVX

Verify sanity of indirect call/topn profiles

2020-01-28 Thread Jan Hubicka
Hi, I will try to reming this next stage1 since it is not regression fix. I found it useful to have bit of sanity checking of the topn profiles to work out the bugs in merging and updating that was there. Honza gcc/ChangeLog: 2020-01-28 Jan Hubicka * profile.c