[PR debug/57232] don't record non-fixed reg as CFA base value

2014-02-26 Thread Alexandre Oliva
(GET_MODE (stack_pointer_rtx), stack_pointer_rtx, -ofst); cselib_add_permanent_equiv (val, expr, get_insns ()); -- Alexandre Oliva, freedom fighterhttp://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi Be Free! -- http://FSFLA.org

[PR debug/59992 #1/2] avoid quadratic behavior for the removal of useless values

2014-02-26 Thread Alexandre Oliva
)) -remove_useless_values (); + remove_useless_values (); } /* Initialize cselib for one pass. The caller must also call -- Alexandre Oliva, freedom fighterhttp://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi Be Free! -- http://FSFLA.org/ FSF Latin

[PR debug/59992 #2/2] preserve permanent values in a separate table

2014-02-26 Thread Alexandre Oliva
preserved hash table:\n); + cselib_preserved_hash_table.traverse FILE *, dump_cselib_val (out); if (first_containing_mem != dummy_val) { fputs (first mem , out); -- Alexandre Oliva, freedom fighterhttp://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world

Re: [PR debug/59992 #1/2] avoid quadratic behavior for the removal of useless values

2014-03-05 Thread Alexandre Oliva
On Feb 27, 2014, Alexandre Oliva aol...@redhat.com wrote: I wasn't entirely sure this wouldn't invalidate assumptions made in callers of cselib_preserve_only_values (the function called at the end of each extended basic block), but some analysis, plus comparing before and after assembly

[PR58479] introduce a param to limit debug stmts count

2014-03-14 Thread Alexandre Oliva
testing, but I haven't investigated any further. Regstrapped incrementally (first patch alone, first and second, and all 3) on i686- and x86_64-linux-gnu. Ok to install? Introduce --param max-vartrack-debug-stmts From: Alexandre Oliva aol...@redhat.com for gcc/ChangeLog PR debug/58479

Re: [PR58479] introduce a param to limit debug stmts count

2014-03-18 Thread Alexandre Oliva
limit is exceeded From: Alexandre Oliva aol...@redhat.com for gcc/ChangeLog PR debug/58479 * ipa-prop.c (ipa_modify_call_arguments): Don't build new debug stmts if BUILD_DEBUG_STMTS_P doesn't hold any more. * ipa-split.c (split_function): Likewise. * tree-cfg.c (gimple_merge_blocks

[PR libmudflap/53952] don't check access to non-mem decls

2012-12-05 Thread Alexandre Oliva
on access to SRAed variables. From: Alexandre Oliva aol...@redhat.com for gcc/ChangeLog PR libmudflap/53952 * expr.c (mem_ref_refers_to_non_mem_p): Factor out implementation into... (addr_expr_of_non_mem_decl_p_1): ... this new function. (addr_expr_of_non_mem_decl_p): New. * tree.h

[mudflap] fix infinite recursion in verbose trace

2012-12-05 Thread Alexandre Oliva
on verbose mudflap From: Alexandre Oliva aol...@redhat.com for libmudflap/ChangeLog * mf-hooks1.c (free): Return on NULL before any logging. --- libmudflap/mf-hooks1.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libmudflap/mf-hooks1.c b/libmudflap/mf-hooks1.c

Re: Minimize downward code motion during reassociation

2012-12-07 Thread Alexandre Oliva
.?? ... x_? = expr -- Alexandre Oliva, freedom fighterhttp://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi Be Free! -- http://FSFLA.org/ FSF Latin America board member Free Software Evangelist Red Hat Brazil Compiler Engineer

fix libquadmath build regression

2012-12-20 Thread Alexandre Oliva
From: Alexandre Oliva aol...@redhat.com for libquadmath/ChangeLog * configure.ac: Check that calling feraiseexcept compiles when fenv.h is included. Define QUADMATH_FERAISEEXCEPT cpp macro and LIBQUAD_FERAISEEXCEPT conditional otherwise. * Makefile.am (libquadmath_la_SOURCES): Add math

[PR libmudflap/53359] don't register symbols not emitted

2012-12-20 Thread Alexandre Oliva
symbols that won't be emitted From: Alexandre Oliva aol...@redhat.com for gcc/ChangeLog PR libmudflap/53359 * tree-mudflap.c (mudflap_finish_file): Skip deferred decls not found in the symtab. --- gcc/tree-mudflap.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git

Re: fix libquadmath build regression

2012-12-29 Thread Alexandre Oliva
On Dec 24, 2012, Paolo Bonzini bonz...@gnu.org wrote: Il 21/12/2012 06:17, Alexandre Oliva ha scritto: The problem is that glibc has an extern inline definition of fraiseexcept that is introduced by including fenv.h (it's in bits/fenv.h), and this definition requires SSE support regardless

Re: fix libquadmath build regression

2012-12-29 Thread Alexandre Oliva
the latest version of the patch for libquadmath just in case the library maintainers wish to have an internal fix for this particular bug. What do you say, should I put it in? Deal with SSE-requiring extern inline in bits/fenv.h From: Alexandre Oliva aol...@redhat.com for libquadmath/ChangeLog

Re: [PR libmudflap/53359] don't register symbols not emitted

2012-12-29 Thread Alexandre Oliva
On Dec 21, 2012, Richard Biener richard.guent...@gmail.com wrote: On Fri, Dec 21, 2012 at 6:33 AM, Alexandre Oliva aol...@redhat.com wrote: libmudflap emits a global initializer that registers memory ranges for global data symbols. However, even if IPA decides not to emit a symbol because

Re: [PR libmudflap/53359] don't register symbols not emitted

2013-01-06 Thread Alexandre Oliva
On Jan 2, 2013, Richard Biener richard.guent...@gmail.com wrote: On Sun, Dec 30, 2012 at 1:22 AM, Alexandre Oliva aol...@redhat.com wrote: On Dec 21, 2012, Richard Biener richard.guent...@gmail.com wrote: On Fri, Dec 21, 2012 at 6:33 AM, Alexandre Oliva aol...@redhat.com wrote: libmudflap

Re: fixincludes for libquadmath build regression

2013-01-06 Thread Alexandre Oliva
out the generated text from the review message. Done. Ok? Fix mandatory SSE in 2.1[56]ish glibc's feraiseexcept From: Alexandre Oliva aol...@redhat.com for fixincludes/ChangeLog * inclhack.def (feraiseexcept_nosse_invalid): New. (feraiseexcept_nosse_divbyzero): Likewise. * fixincl.x

Re: [PR libmudflap/53359] don't register symbols not emitted

2013-01-16 Thread Alexandre Oliva
On Jan 7, 2013, Richard Biener richard.guent...@gmail.com wrote: On Sun, Jan 6, 2013 at 8:47 PM, Alexandre Oliva aol...@redhat.com wrote: On Jan 2, 2013, Richard Biener richard.guent...@gmail.com wrote: On Sun, Dec 30, 2012 at 1:22 AM, Alexandre Oliva aol...@redhat.com wrote: On Dec 21

fix for PR49888 var-tracking compile-time regression

2013-01-16 Thread Alexandre Oliva
target libraries for C, C++ and Java. Regstrapped on x86_64-linux-gnu and i686-linux-gnu. Ok to install? Cache canonical addresses within VTA From: Alexandre Oliva aol...@redhat.com for gcc/ChangeLog PR debug/54114 PR debug/54402 PR debug/49888 * var-tracking.c (negative_power_of_two_p): New

Re: [PR libmudflap/53359] don't register symbols not emitted

2013-01-16 Thread Alexandre Oliva
is the correct test. TREE_ASM_WRITTEN doesn't carry the same information as far as external objects are concerned, so we ended up failing to register them when I tried it, and that caused regressions in the testsuite, with tests that were designed to catch precisely this sort of error. -- Alexandre

Re: fix for PR49888 var-tracking compile-time regression

2013-01-16 Thread Alexandre Oliva
On Jan 16, 2013, Jakub Jelinek ja...@redhat.com wrote: On Wed, Jan 16, 2013 at 08:28:59AM -0200, Alexandre Oliva wrote: PR49888 introduced clobber_overlapping_mems to detach VALUEs (and variables bound to them) from MEMs as the MEMs are modified. This turned out to be quite expensive

Re: [PR55547] fix alias regression on alpha on misaligned symbols

2013-01-16 Thread Alexandre Oliva
. -- Alexandre Oliva, freedom fighterhttp://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi Be Free! -- http://FSFLA.org/ FSF Latin America board member Free Software Evangelist Red Hat Brazil Compiler Engineer

Re: [PR55547] fix alias regression on alpha on misaligned symbols

2013-01-16 Thread Alexandre Oliva
elsewhere From: Alexandre Oliva aol...@redhat.com for gcc/ChangeLog PR rtl-optimization/55547 PR rtl-optimization/53827 PR debug/53671 PR debug/49888 * alias.c (memrefs_conflict_p): Use abs of sizes all over, retaining the conservative special case for symbolic constants. --- gcc

Re: fix for PR49888 var-tracking compile-time regression

2013-01-17 Thread Alexandre Oliva
results with those based on the earlier tree, so I'm now running a baseline test just to be sure that the regressions are not caused by this patch. Ok to install if they aren't? Cache canonical addresses within VTA From: Alexandre Oliva aol...@redhat.com for gcc/ChangeLog PR debug/54114 PR debug

Re: [PR55547] fix alias regression on alpha on misaligned symbols

2013-01-18 Thread Alexandre Oliva
/msg01706.html Thanks, the (cosmetically) revised patch is now in. -- Alexandre Oliva, freedom fighterhttp://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi Be Free! -- http://FSFLA.org/ FSF Latin America board member Free Software Evangelist Red Hat Brazil

[PR 48333] avoid -fcompare-debug errors from builtins in MEM attrs

2011-04-02 Thread Alexandre Oliva
might be doable, but I find that highly undesirable; another option would be to always dump functions as their builtins; there are probably other options too. This regstrapped on x86_64-linux-gnu. Ok to install? for gcc/ChangeLog from Alexandre Oliva aol...@redhat.com PR debug/48333 * calls.c

Re: [PATCH] Fix VTA updating in the combiner (PR debug/48343)

2011-04-05 Thread Alexandre Oliva
is needed. It seems to me that extending the range might even cause us to modify e.g. unrelated uses of the same pseudo, no? Isn't the problem perhaps that we are failing to adjust some debug insns at an earlier call? -- Alexandre Oliva, freedom fighterhttp://FSFLA.org/~lxoliva/ You must

Re: Scheduler cleanups, 1/N

2011-04-05 Thread Alexandre Oliva
to the latest nondebug scheduled insn, so we wouldn't have to skip over debug insns at that point. Regstrapped on x86_64- and i686-linux-gnu. Ok to install? for gcc/ChangeLog from Alexandre Oliva aol...@redhat.com * haifa-sched.c (last_nondebug_scheduled_insn): New. (rank_for_schedule): Use

Re: Scheduler cleanups, 1/N

2011-04-05 Thread Alexandre Oliva
On Apr 5, 2011, Bernd Schmidt ber...@codesourcery.com wrote: On 04/05/2011 11:05 PM, Alexandre Oliva wrote: While debugging the -fcompare-debug regression that turned out to be independently reported as 48403, I got slightly annoyed that rank_for_schedule would walk a sequence of debug insns

Re: [VTA, PR49310] O(n+m)-ish emit_notes

2011-09-27 Thread Alexandre Oliva
checking_assert, and using that. How's that? -- Alexandre Oliva, freedom fighterhttp://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi Be Free! -- http://FSFLA.org/ FSF Latin America board member Free Software Evangelist Red Hat Brazil Compiler Engineer

Re: [patch] dwarf2out crash: missing GTY? (PR 50806)

2011-10-26 Thread Alexandre Oliva
of incoming args referenced in the exprs of other debug temps. (more details in the bug report) Ok to install? for gcc/ChangeLog from Alexandre Oliva aol...@redhat.com PR debug/50826 * var-tracking.c (rtx_debug_expr_p): New. (use_type): Don't use debug exprs to track non-VTA variables

fwprop: fix REG_DEAD notes rendered incorrect

2011-10-27 Thread Alexandre Oliva
and i686-linux-gnu. Ok to install? for gcc/ChangeLog from Alexandre Oliva aol...@redhat.com * fwprop.c (all_uses_available_at): Skip debug insns. (try_fwprop_subst): Drop outdated REG_DEAD notes. Index: gcc/fwprop.c === --- gcc

fix incorrect debug temp added by df-problems

2011-10-27 Thread Alexandre Oliva
. Regstrapped on x86_64-linux-gnu and i686-linux-gnu. Ok to install? for gcc/ChangeLog from Alexandre Oliva aol...@redhat.com * df-problems.c (df_note_bb_compute): Do not add take note of debug uses for whose REGs we won't emit DEAD or UNUSED notes. Index: gcc/df-problems.c

Re: fwprop: fix REG_DEAD notes rendered incorrect

2011-10-27 Thread Alexandre Oliva
). Instead passes consuming these notes have to invoke df_note_add_problem on entry. It looked confusing, and it wasn't hard to fix, but, ok, patch withdrawn. -- Alexandre Oliva, freedom fighterhttp://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi Be Free

[PR51570] minimize ENTRY_VALUEs in debug location lists

2012-04-08 Thread Alexandre Oliva
-linux-gnu. It restored pr45003-[23].c to XPASS, without any regressions. pr45003-1.c is unchanged by this patch by itself, but in combination with another patch I'm posting soon that caused it to regress, this patch also avoids the regression. Ok to install? for gcc/ChangeLog from Alexandre Oliva

Re: [trunk-vta] Re: [vtab] Permit coalescing of user variables

2012-04-08 Thread Alexandre Oliva
Ping? (Updated with improved docs; should the options be renamed to -ftree-copyrename-* to match the option that covers the entire pass?) On Jun 4, 2011, Alexandre Oliva aol...@redhat.com wrote: On Oct 13, 2009, Alexandre Oliva aol...@redhat.com wrote: On Jun 1, 2009, Alexandre Oliva aol

Re: [PR48866] three alternative fixes

2012-04-09 Thread Alexandre Oliva
On Jun 2, 2011, Alexandre Oliva aol...@redhat.com wrote: On May 30, 2011, Alexandre Oliva aol...@redhat.com wrote: On May 30, 2011, Alexandre Oliva aol...@redhat.com wrote: I have 3 different, mutually exclusive patches that fix PR 48866. The problem is exponential time while dealing

Re: fix left-over debug insns in DCE

2012-04-09 Thread Alexandre Oliva
On Jun 6, 2011, Alexandre Oliva aol...@redhat.com wrote: On Jun 6, 2011, Eric Botcazou ebotca...@adacore.com wrote: It might be too late for DF to do anything sensible to preserve the debug info rather than just throw it away, as your partial approval suggests. OK, let me think about

[PR 50826] [DF] no debug temps for artificial uses

2012-04-09 Thread Alexandre Oliva
to install? for gcc/ChangeLog from Alexandre Oliva aol...@redhat.com PR debug/50826 * df-problems.c (df_note_bb_compute): Do not take note of debug uses for whose REGs we won't emit DEAD or UNUSED notes. Index: gcc/df-problems.c

Re: [PATCH] Fix ICE in expand_cse_reciprocals (PR tree-optimization/42078)

2012-04-09 Thread Alexandre Oliva
On Jun 3, 2011, Alexandre Oliva aol...@redhat.com wrote: According to http://gcc.gnu.org/ml/gcc-patches/2009-11/msg01082.html on Nov 20, 2009, Alexandre Oliva aol...@redhat.com wrote: On Nov 19, 2009, Richard Guenther richard.guent...@gmail.com wrote: In fact this exchanging of the LHS

Re: fix incorrect debug temp added by df-problems

2012-04-09 Thread Alexandre Oliva
On Oct 27, 2011, Alexandre Oliva aol...@redhat.com wrote: pr43165.c -Os -g exercises a bug in df-problems WRT the introduction of debug temps. After pro_and_epilogue, the function was optimized to this: push bp mov bp,sp # debug insn referencing bp pop bp I don't know why we bother

Re: don't force debug insns after their PREV_INSNs

2012-04-09 Thread Alexandre Oliva
On Jun 3, 2011, Bernd Schmidt ber...@codesourcery.com wrote: On 06/03/2011 04:47 PM, Alexandre Oliva wrote: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=677681 can be “fixed” by disabling the artificial dependency of a debug insn on its previous insn. Debug insns will often depend

Re: debug insns in SMS

2012-04-09 Thread Alexandre Oliva
on x86_64-linux-gnu and i686-pc-linux-gnu) for gcc/ChangeLog from Alexandre Oliva aol...@redhat.com * ddg.c (build_intra_loop_deps): Discard deps of nondebug on debug. Index: gcc/ddg.c === --- gcc/ddg.c.orig 2012-01-04 21:06

Re: fix left-over debug insns in DCE

2012-04-13 Thread Alexandre Oliva
a comment explaining what this is doing. How's this? I've just installed the patch, but if you find the need for any further improvement, let me know and I'll do it right away. Thanks, for gcc/ChangeLog from Alexandre Oliva aol...@redhat.com PR debug/48866 * df.h (enum debug_temp_where): New

Re: fix incorrect debug temp added by df-problems

2012-04-13 Thread Alexandre Oliva
On Apr 9, 2012, Jakub Jelinek ja...@redhat.com wrote, in response to my posting to the wrong thread (now fixed): On Mon, Apr 09, 2012 at 03:29:05AM -0300, Alexandre Oliva wrote: + (!df_ignore_stack_reg (uregno))) Please remove the extra () around this line

Re: [PR debug/47624] improve value tracking in non-VTA locations

2012-04-22 Thread Alexandre Oliva
On Jun 4, 2011, Alexandre Oliva aol...@redhat.com wrote: On Feb 15, 2011, Alexandre Oliva aol...@redhat.com wrote: VTA only tracks locations of gimple regs, while addressable variables still use the old var tracking strategy. This means addressable variables, during var-tracking, got

[C++ Patch] fix semi-random template specialization ICE

2012-05-03 Thread Alexandre Oliva
, regstrapped on the latter. Ok to install? for gcc/cp/ChangeLog from Alexandre Oliva aol...@redhat.com * pt.c (tsubst_decl): Bail out if argvec is error_mark_node. Index: gcc/cp/pt.c === --- gcc/cp/pt.c.orig 2012-04-30 15:34:44.018432544

[PR52983] eliminate autoinc from debug_insn locs (was: Re: fix left-over debug insns in DCE)

2012-05-03 Thread Alexandre Oliva
a reasonable idea, so this patch moves all this value-tracking stuff to valtrack.[ch]. Regstrapped on x86_64-linux-gnu and i686-linux-gnu; verified to fix the reported ppc problem with a cross compiler. Ok to install? for gcc/ChangeLog from Alexandre Oliva aol...@redhat.com PR debug/52983

Re: Restore bootstrap (PR53197)

2012-05-03 Thread Alexandre Oliva
test, and hence I wasn't seeing the problem anywhere). Any chance you could adjust the script to strip out the .comment section you mentioned elsewhere, so that you get faster bootstrap with bootstrap-debug testing too? I checked that this patch restores bootstrap Thanks! -- Alexandre Oliva

Re: [PR52983, PR48866] eliminate autoinc from debug_insn locs

2012-05-03 Thread Alexandre Oliva
On May 3, 2012, Alexandre Oliva aol...@redhat.com wrote: My recent patch for PR48866 ... had some inconsistency in behavior between dce and word_dce, as you pointed out. I couldn't find any reason for that, so I made them the same. Regstrapped on x86_64-linux-gnu and i686-linux-gnu

Re: [C++ Patch] fix semi-random template specialization ICE

2012-05-13 Thread Alexandre Oliva
On May 10, 2012, Jason Merrill ja...@redhat.com wrote: OK. Thanks, installed a few days ago. Is it ok for the 4.7 branch too? I didn't realize the bug could occur there as well, but PR c++/53209 suggests it does. Regstrapping now. -- Alexandre Oliva, freedom fighterhttp://FSFLA.org

[PR49888, VTA] don't keep VALUEs bound to modified MEMs

2012-05-23 Thread Alexandre Oliva
had observed with the proposed patch for PR47624, that this patch depends on. This patch was regstrapped along with the patch for PR47624 (ping http://gcc.gnu.org/ml/gcc-patches/2012-04/msg01320.html) on x86_64-linux-gnu and i686-linux-gnu. Ok to install? for gcc/ChangeLog from Alexandre Oliva

Re: [PR52983] eliminate autoinc from debug_insn locs

2012-07-21 Thread Alexandre Oliva
On Jul 17, 2012, Richard Henderson r...@redhat.com wrote: On 07/17/2012 02:36 PM, Alexandre Oliva wrote: http://gcc.gnu.org/ml/gcc-patches/2012-05/msg00300.html ... except that post has patch 1 repeated as patch 3. The actual patch 3 is missing. That said, the first two patches are ok

Re: [PR52983] eliminate autoinc from debug_insn locs

2012-07-24 Thread Alexandre Oliva
On Jul 24, 2012, Richard Henderson r...@redhat.com wrote: On 07/21/2012 03:25 AM, Alexandre Oliva wrote: PR debug/52983 * valtrack.c (dead_debug_insert_temp): Use cleanup_auto_inc_dec. Ok. Thanks. I'm about to go on a trip for the rest of the week and I won't be online much, so I won't

Re: [PR52983] eliminate autoinc from debug_insn locs

2012-08-01 Thread Alexandre Oliva
On Jul 24, 2012, Alexandre Oliva aol...@redhat.com wrote: Thanks. I'm about to go on a trip for the rest of the week and I won't be online much, so I won't check them in now. I will when I get back home, so that I'll have a better chance of dealing with any fallout. I've just installed

Re: [middle-end] Add machine_mode to address_cost target hook

2012-08-31 Thread Alexandre Oliva
On Aug 29, 2012, Oleg Endo oleg.e...@t-online.de wrote: * config/mn10300/mn10300.c (mn10300_address_cost): Add machine_mode argument. Use GET_MODE (x) in recursive invocation. * config/sh/sh.c (sh_address_cost): Likewise. These are ok, thanks. -- Alexandre Oliva

Re: [middle-end] Add machine_mode to address_cost target hook

2012-09-04 Thread Alexandre Oliva
, this should be MEM_ADDR_SPACE (x), no? -- Alexandre Oliva, freedom fighterhttp://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi Be Free! -- http://FSFLA.org/ FSF Latin America board member Free Software Evangelist Red Hat Brazil Compiler Engineer

Re: [PATCH][RFC] Add -Og

2012-09-05 Thread Alexandre Oliva
excellent results, rather than just -gO0d ones ;-) Any comments on the implementation details btw? Not really, sorry. -- Alexandre Oliva, freedom fighterhttp://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi Be Free! -- http://FSFLA.org/ FSF Latin

Re: [PATCH] Fix valtrack ICE (PR debug/53923)

2012-09-05 Thread Alexandre Oliva
or don't recall the details (sorry it took me so long to get back to you), I'll be glad to have a look myself. 2012-08-20 Jakub Jelinek ja...@redhat.com PR debug/53923 * valtrack.c (dead_debug_insert_temp): Drop non-reg uses from the chain. -- Alexandre Oliva, freedom

Re: [PATCH] Improve debug info if tree DCE removes stores (PR debug/50317, fallout)

2012-09-05 Thread Alexandre Oliva
treatment, growing memory use and compile time. -- Alexandre Oliva, freedom fighterhttp://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi Be Free! -- http://FSFLA.org/ FSF Latin America board member Free Software Evangelist Red Hat Brazil Compiler

Re: [PR49888, VTA] don't keep VALUEs bound to modified MEMs

2012-06-05 Thread Alexandre Oliva
On May 23, 2012, Jakub Jelinek ja...@redhat.com wrote: On Wed, May 23, 2012 at 06:27:21AM -0300, Alexandre Oliva wrote: + for (loc = var-var_part[0].loc_chain; loc; loc = loc-next) +if (GET_CODE (loc-loc) == MEM + !nonoverlapping_memrefs_p (loc-loc, mloc, false

Re: [PR52983] eliminate autoinc from debug_insn locs

2012-06-13 Thread Alexandre Oliva
On May 3, 2012, Alexandre Oliva aol...@redhat.com wrote: Here are the 3 patches that, together, are equivalent to the one posted before, except for the visibility of cleanup_auto_inc_dec. Ping? http://gcc.gnu.org/ml/gcc-patches/2012-05/msg00300.html -- Alexandre Oliva, freedom fighter

Re: [PR debug/47624] improve value tracking in non-VTA locations

2012-06-13 Thread Alexandre Oliva
On Apr 22, 2012, Alexandre Oliva aol...@redhat.com wrote: for gcc/ChangeLog from Alexandre Oliva aol...@redhat.com PR debug/47624 * var-tracking.c (loc_exp_dep_pool): New. (vt_emit_notes): Create and release the pool. (compute_bb_dataflow): Use value-based

Re: debug insns in SMS

2012-06-13 Thread Alexandre Oliva
On Apr 9, 2012, Alexandre Oliva aol...@redhat.com wrote: I think this will restore proper functioning to SMS in the presence of debug insns. A while ago, we'd never generate deps of non-debug insns on debug insns. I introduced them to enable sched to adjust (reset) debug insns when non

Re: don't force debug insns after their PREV_INSNs

2012-06-13 Thread Alexandre Oliva
On Apr 9, 2012, Alexandre Oliva aol...@redhat.com wrote: The problem here is that a nondebug insn may be moved ahead of a useful debug insn and clobber one of its inputs, rendering it useless, when there's no good reason for the debug insn to be kept in place, other than an accidental

Re: [PR48866] three alternative fixes

2012-06-13 Thread Alexandre Oliva
On Apr 9, 2012, Alexandre Oliva aol...@redhat.com wrote: On Jun 2, 2011, Alexandre Oliva aol...@redhat.com wrote: On May 30, 2011, Alexandre Oliva aol...@redhat.com wrote: On May 30, 2011, Alexandre Oliva aol...@redhat.com wrote: I have 3 different, mutually exclusive patches that fix PR

Re: [trunk-vta] Re: [vtab] Permit coalescing of user variables

2012-06-13 Thread Alexandre Oliva
On Apr 9, 2012, Alexandre Oliva aol...@redhat.com wrote: On Jun 4, 2011, Alexandre Oliva aol...@redhat.com wrote: On Oct 13, 2009, Alexandre Oliva aol...@redhat.com wrote: On Jun 1, 2009, Alexandre Oliva aol...@redhat.com wrote: A long time ago, when variable tracking at assignments

Re: [PR52983, PR48866] eliminate autoinc from debug_insn locs

2012-06-13 Thread Alexandre Oliva
On May 3, 2012, Alexandre Oliva aol...@redhat.com wrote: On May 3, 2012, Alexandre Oliva aol...@redhat.com wrote: My recent patch for PR48866 ... had some inconsistency in behavior between dce and word_dce, as you pointed out. I couldn't find any reason for that, so I made them the same

Re: [PATCH] Fix ICE in expand_cse_reciprocals (PR tree-optimization/42078)

2012-06-13 Thread Alexandre Oliva
to be computed and stored in a temporary, an artificial variable or a user-defined variable. -- Alexandre Oliva, freedom fighterhttp://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi Be Free! -- http://FSFLA.org/ FSF Latin America board member Free Software

Re: debug insns in SMS

2012-06-13 Thread Alexandre Oliva
Apologies for the duplicate ping, this one is now properly addressed to the pass maintainer. On Apr 9, 2012, Alexandre Oliva aol...@redhat.com wrote: On May 4, 2011, Revital1 Eres e...@il.ibm.com wrote: Hello Alexandre I think this will restore proper functioning to SMS in the presence

Re: [PATCH] Fix ICE in expand_cse_reciprocals (PR tree-optimization/42078)

2012-06-14 Thread Alexandre Oliva
this. */ gcc_checking_assert (gimple_replace_lhs_wants_value () == save_value); if (save_value) { -- Alexandre Oliva, freedom fighterhttp://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi Be Free! -- http://FSFLA.org/ FSF Latin America board member

Re: [PR49888, VTA] don't keep VALUEs bound to modified MEMs

2012-06-15 Thread Alexandre Oliva
On Jun 14, 2012, H.J. Lu hjl.to...@gmail.com wrote: On Tue, Jun 12, 2012 at 1:42 PM, Richard Henderson r...@redhat.com wrote: On 2012-06-05 12:33, Alexandre Oliva wrote: for  gcc/ChangeLog from  Alexandre Oliva  aol...@redhat.com       PR debug/49888       * var-tracking.c: Include

[PR debug/53682] avoid crash in cselib promote_debug_loc

2012-06-19 Thread Alexandre Oliva
to deal with this case. Ok to install? for gcc/ChangeLog from Alexandre Oliva aol...@redhat.com PR debug/53682 * cselib.c (promote_debug_loc): Don't crash on NULL argument. Index: gcc/cselib.c === --- gcc/cselib.c.orig 2012-06-17

Re: [PR49888, VTA] don't keep VALUEs bound to modified MEMs

2012-06-19 Thread Alexandre Oliva
only with a patchset that fixes all debug info regressions? for gcc/ChangeLog from Alexandre Oliva aol...@redhat.com PR debug/53671 PR debug/49888 * alias.c (memrefs_conflict_p): Improve handling of AND for alignment. Index: gcc/alias.c

Re: [PR debug/53682] avoid crash in cselib promote_debug_loc

2012-06-20 Thread Alexandre Oliva
On Jun 20, 2012, Jakub Jelinek ja...@redhat.com wrote: On Wed, Jun 20, 2012 at 12:39:29AM -0300, Alexandre Oliva wrote: When promote_debug_loc was first introduced, it would never be called with a NULL loc list. However, because of the strategy of temporarily resetting loc lists before

Re: debug insns in SMS

2012-06-21 Thread Alexandre Oliva
a comment next to the code stating why it's important not to create such deps. Done You may also want to store the result of DEP_PRO (dep) in src_something and use it twice, for clarity. Done Here's what I'm about to check in. Thanks, for gcc/ChangeLog from Alexandre Oliva aol...@redhat.com

Re: [PR49888, VTA] don't keep VALUEs bound to modified MEMs

2012-06-21 Thread Alexandre Oliva
); } } as the sole supported case. Ack. Regstrapped successfully, checking this in. for gcc/ChangeLog from Alexandre Oliva aol...@redhat.com PR debug/53671 PR debug/49888 * alias.c (memrefs_conflict_p): Improve handling of AND for alignment. Index: gcc/alias.c

Re: RFA: dead_debug_* ICE

2012-06-24 Thread Alexandre Oliva
://gcc.gnu.org/bugzilla/show_bug.cgi?id=53740 The patch looks reasonable to me, but I don't think I'm entitled to approve it. -- Alexandre Oliva, freedom fighterhttp://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi Be Free! -- http://FSFLA.org/ FSF Latin

Re: [PR debug/53682] avoid crash in cselib promote_debug_loc

2012-06-25 Thread Alexandre Oliva
On Jun 20, 2012, Alexandre Oliva aol...@redhat.com wrote: When promote_debug_loc was first introduced, it would never be called with a NULL loc list. However, because of the strategy of temporarily resetting loc lists before recursion introduced a few months ago in alias.c, the earlier

Re: [wwwdocs] Update coding conventions for C++

2012-06-25 Thread Alexandre Oliva
On Jun 25, 2012, Lawrence Crowl cr...@google.com wrote: +These conventions will change over time, +but changing them requires that a convincing rationale. s/that// +Complex heirarchies are to be avoided. s/heir/hier/ -- Alexandre Oliva, freedom fighterhttp://FSFLA.org/~lxoliva/ You

Re: [PATCH][configure] Make sure CFLAGS_FOR_TARGET And CXXFLAGS_FOR_TARGET contain -O2

2012-06-26 Thread Alexandre Oliva
of ensuring -O2 makes to C*FLAGS_FOR_TARGET, when all it appears to do is to prepend -g. Can you please clarify? Thanks, -- Alexandre Oliva, freedom fighterhttp://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi Be Free! -- http://FSFLA.org/ FSF Latin America

Re: RFA: dead_debug_* ICE

2012-06-26 Thread Alexandre Oliva
On Jun 25, 2012, Richard Sandiford rdsandif...@googlemail.com wrote: I'll leave the proper fix to Alex. ACK. Thanks for the patch, it should help me get started. -- Alexandre Oliva, freedom fighterhttp://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi

Re: [PR49888, VTA] don't keep VALUEs bound to modified MEMs

2012-06-26 Thread Alexandre Oliva
patches were regstrapped on x86_64-linux-gnu and i686-linux-gnu. Ok? for gcc/ChangeLog from Alexandre Oliva aol...@redhat.com PR debug/53671 PR debug/49888 * var-tracking.c (attrs_list_by_loc_eq): New. (track_stack_pointer): New. (dataflow_set_merge): Use it. (vt_initialize): Record

[testsuite] don't use lto plugin if it doesn't work

2012-06-26 Thread Alexandre Oliva
looked around for some such way, I figured it would be useful to have information that the linker plugin was not used in a particular test run, so I went for this patch instead. Ok to install? for gcc/testsuite/ChangeLog from Alexandre Oliva aol...@redhat.com * lib/c-torture.exp

Re: [testsuite] don't use lto plugin if it doesn't work

2012-06-27 Thread Alexandre Oliva
[Adding gcc@] On Jun 26, 2012, H.J. Lu hjl.to...@gmail.com wrote: On Tue, Jun 26, 2012 at 3:39 PM, Mike Stump mikest...@comcast.net wrote: On Jun 26, 2012, at 2:04 PM, Alexandre Oliva wrote: I test i686-linux-gnu in a presumably unusual setting I like the setup and testing

Re: [PATCH] Fix accesses to freed up memory in var-tracking (PR debug/53706)

2012-06-27 Thread Alexandre Oliva
remained uninitialized, and free_alloc_pool doesn't like to release NULL pools ;-) The resulting patch was regstrapped on i686- and x86_64-linux-gnu. I'm going to check it in as obvious after getting some sleep. for gcc/ChangeLog from Alexandre Oliva aol...@redhat.com, Uros Bizjak ubiz

Re: RFA: dead_debug_* ICE

2012-06-27 Thread Alexandre Oliva
On Jun 25, 2012, Alexandre Oliva aol...@redhat.com wrote: On Jun 24, 2012, Richard Sandiford rdsandif...@googlemail.com wrote: gcc.c-torture/compile/vector-2.c fails on mips64-elf with RTL checking enabled because dead_debug_insert_temp tries to read the REGNO of something that it has already

Re: [PR49888, VTA] don't keep VALUEs bound to modified MEMs

2012-06-28 Thread Alexandre Oliva
On Jun 27, 2012, Richard Henderson r...@redhat.com wrote: On 06/26/2012 01:54 PM, Alexandre Oliva wrote: + track_stack_pointer (dst, src1, src2); Why does this function return a value then? During testing, I used an assert on the return value to catch cases that couldn't be handled

Re: [testsuite] don't use lto plugin if it doesn't work

2012-06-28 Thread Alexandre Oliva
On Jun 27, 2012, Mike Stump mikest...@comcast.net wrote: On Jun 27, 2012, at 2:07 AM, Alexandre Oliva wrote: Why? We don't demand a working plugin. Indeed, we disable the use of the plugin if we find a linker that doesn't support it. We just don't account for the possibility of finding

Re: [PATCH][configure] Make sure CFLAGS_FOR_TARGET And CXXFLAGS_FOR_TARGET contain -O2

2012-06-28 Thread Alexandre Oliva
if it was pre-pended just above. I see, thanks for clarifying. I suggest changing both occurrences of $CFLAGS within the case statements, then; the more uniform logic is more appealing to me. Patch approved with these changes. Thanks, -- Alexandre Oliva, freedom fighterhttp://FSFLA.org

Re: [testsuite] don't use lto plugin if it doesn't work

2012-06-28 Thread Alexandre Oliva
On Jun 28, 2012, Jakub Jelinek ja...@redhat.com wrote: On Thu, Jun 28, 2012 at 04:16:55AM -0300, Alexandre Oliva wrote: I'd very be surprised if I asked for an i686 native build to package and install elsewhere, and didn't get a plugin just because the build-time linker wouldn't have been

Re: [PATCH][configure] Make sure CFLAGS_FOR_TARGET And CXXFLAGS_FOR_TARGET contain -O2

2012-06-28 Thread Alexandre Oliva
they contain -O2. * configure: Regenerate. -- Alexandre Oliva, freedom fighterhttp://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi Be Free! -- http://FSFLA.org/ FSF Latin America board member Free Software Evangelist Red Hat Brazil Compiler

Re: [testsuite] don't use lto plugin if it doesn't work

2012-06-28 Thread Alexandre Oliva
On Jun 28, 2012, Mike Stump mikest...@comcast.net wrote: On Jun 28, 2012, at 4:39 AM, Alexandre Oliva aol...@redhat.com wrote: That still doesn't sound right to me: why should the compiler refrain from using a perfectly functional linker plugin on the machine where it's installed (not where

Re: [testsuite] don't use lto plugin if it doesn't work

2012-07-02 Thread Alexandre Oliva
that would ensue. Another thing we may want to do documentat how to test GCC in such fake-native settings, so that people can refer to it and save duplicate effort and avoid inconsistent results. -- Alexandre Oliva, freedom fighterhttp://FSFLA.org/~lxoliva/ You must be the change you wish to see

Re: [PR52983] eliminate autoinc from debug_insn locs

2012-07-02 Thread Alexandre Oliva
On Jun 13, 2012, Alexandre Oliva aol...@redhat.com wrote: On May 3, 2012, Alexandre Oliva aol...@redhat.com wrote: Here are the 3 patches that, together, are equivalent to the one posted before, except for the visibility of cleanup_auto_inc_dec. Ping? http://gcc.gnu.org/ml/gcc-patches

Re: Allow use of ranges in copyright notices

2012-07-02 Thread Alexandre Oliva
On Jun 30, 2012, David Edelsohn dje@gmail.com wrote: IBM's policy specifies a comma: first year, last year and not a dash range. But this notation already means something else in our source tree. -- Alexandre Oliva, freedom fighterhttp://FSFLA.org/~lxoliva/ You must be the change

Re: [PR49888, VTA] don't keep VALUEs bound to modified MEMs

2012-07-06 Thread Alexandre Oliva
On Jun 21, 2012, Alexandre Oliva aol...@redhat.com wrote: Here's one more patch that addresses a problem I found out while investigating the PR53671 regressions: rather than recording incoming stack args as MEMs with non-VALUE expressions, it's more consistent (and less surprising) if we emit

[PR50869] don't attempt to expand CFA within cselib

2011-10-28 Thread Alexandre Oliva
possible for the expression depth to remain uninitialized, and added an initialization and an assertion check to make sure it only remains zero when no location is found. Regstrapped on x86_64-linux-gnu and i686-linux-gnu. Ok to install? for gcc/ChangeLog from Alexandre Oliva aol...@redhat.com PR

Re: [trans-mem][build] Hack around top-level Makefile libstdc++ breakage

2011-11-04 Thread Alexandre Oliva
at configure time in the multi-do: fragment it adds to the Makefile. I'm not quite sure how to introduce that yet, but that's what I'm trying to figure out now. -- Alexandre Oliva, freedom fighterhttp://FSFLA.org/~lxoliva/ You must be the change you wish to see in the world. -- Gandhi

Keep static VTA locs in cselib tables only

2011-11-23 Thread Alexandre Oliva
expressions, an increase of 0.1% in the total number of variables with location lists and less than 0.5% decrease in variables with full coverage. Here's the patch. Ok to install? for gcc/ChangeLog from Alexandre Oliva aol...@redhat.com * cselib.h (cselib_add_permanent_equiv): Declare

[PR 48093] document -mtls-dialect opt (and GCC_COMPARE_DEBUG env)

2011-04-28 Thread Alexandre Oliva
Ok to install? for gcc/ChangeLog from Alexandre Oliva aol...@redhat.com PR other/48093 * doc/invoke.texi: Document -mtls-dialect and GCC_COMPARE_DEBUG. Index: gcc/doc/invoke.texi === --- gcc/doc/invoke.texi.orig 2011-04-27 15

  1   2   3   4   5   6   7   8   9   10   >