[patch] fix std::chrono::duration literals

2014-06-23 Thread Jonathan Wakely
This fixes errors when using 0s or 1'000s to create durations. Tested x86_64-linux, committed to trunk. commit c57e645222ac9bf476ef5b6414773b5f4e2b86fc Author: Jonathan Wakely jwak...@redhat.com Date: Sun Jun 22 18:06:42 2014 +0100 * include/bits/parse_numbers.h (_Number_help): Fix

Re: [patch] Update libstdc++ FAQ and ensure stable anchors in HTML docs

2014-06-23 Thread Jonathan Wakely
On 22/06/14 22:40 +0200, Gerald Pfeifer wrote: On Mon, 9 Jun 2014, Jonathan Wakely wrote: This fairly tedious patch refreshes the FAQ, including adding some notes saying This answer is old and probably no longer relevant to several answers referring to problems in the GCC 3.x era. I'm

[patch] libstdc++/61532 fix make_signed failures

2014-06-23 Thread Jonathan Wakely
43db1e59326da5af1f75a86e37e51f015989b738 Author: Jonathan Wakely jwak...@redhat.com Date: Mon Jun 23 18:30:08 2014 +0100 PR libstdc++/61532 * testsuite/20_util/make_signed/requirements/typedefs-1.cc: Do not apply the signed specifier to wchar_t. * testsuite/20_util/make_signed/requirements/typedefs-2.cc

Re: [patch] libstdc++/61532 fix make_signed failures

2014-06-23 Thread Jonathan Wakely
On 23/06/14 19:18 +0100, Jonathan Wakely wrote: This fixes some more fallout from my make_signedwchar_t changes and improves the make_unsigned tests which were already fixed last month. Tested x86_64-linux and powerpc64-linux, committed to trunk. I'll be making the same changes on the 4.9

[patch] fix namespaces for std::experimental types

2014-06-23 Thread Jonathan Wakely
The current Fundamentals TS says any, optional and string_view should be in an inline namespace called fundamentals_v1. Tested x86_64-linux, committed to trunk. commit 3b316b60d21ea224c56bb23a8e1afb06e2277cf8 Author: Jonathan Wakely jwak...@redhat.com Date: Mon Jun 23 21:34:29 2014 +0100

[patch] Fix some pedantic warnings

2014-06-24 Thread Jonathan Wakely
This fixes some warnings when building the library with -Wpedantic (some only show up when also building with -Wsystem-headers). Tested x86_64-linux, committed to trunk. commit bf385e3ea2d8d10bdaa8e41c7638d32eb26b9bfd Author: Jonathan Wakely jwak...@redhat.com Date: Tue Jun 24 14:16:28 2014

[patch] Simplify allocator use

2014-06-25 Thread Jonathan Wakely
to trunk. commit 3309b9fc32a266f5bf296aec8e8fcbbe6f41d81b Author: Jonathan Wakely jwak...@redhat.com Date: Wed Jun 25 20:16:16 2014 +0100 * include/bits/alloc_traits.h (__alloc_rebind): Define alias template. * include/bits/forward_list.h (_Fwd_list_base): Use __alloc_rebind. * include

Re: [patch] Simplify allocator use

2014-06-25 Thread Jonathan Wakely
This simplifies some of the test changes in my last patch, I was misusing the CustomPointerAlloc due to confusion with some uncommitted changes. Tested x86_64-linux, committed to trunk. commit d1a05535e99bfecb427829d3e03ef82e0977e60c Author: Jonathan Wakely jwak...@redhat.com Date: Wed Jun

Re: testsuite allocators patch

2014-06-26 Thread Jonathan Wakely
On 25/06/14 21:47 +0200, François Dumont wrote: I would like to finally propose this patch before the one on _Rb_tree, as a separate one. I have adopted the same evolution on the tracker_allocator with even a perfect forwarding constructor to allow its usage on top of the

Re: [patch] Simplify allocator use

2014-06-26 Thread Jonathan Wakely
On 25/06/14 21:56 +0100, Jonathan Wakely wrote: The other adds an RAII type to help manage pointers obtained from allocators. The new type means I can remove several ugly try-catch blocks that are all very similar in structure and have been bothering me for some time. The new type also makes

Re: [patch] Simplify allocator use

2014-06-26 Thread Jonathan Wakely
On 26/06/14 12:31 +0100, Jonathan Wakely wrote: @@ -137,20 +139,12 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION __node_type* __node = _M_nodes; _M_nodes = _M_nodes-_M_next(); __node-_M_nxt = nullptr; - __value_alloc_type __a(_M_h._M_node_allocator

Re: [patch] Simplify allocator use

2014-06-26 Thread Jonathan Wakely
On 26/06/14 00:06 +0100, Jonathan Wakely wrote: This simplifies some of the test changes in my last patch, I was misusing the CustomPointerAlloc due to confusion with some uncommitted changes. And this fixes the -fno-rtti version of make_shared, I shouldn't have changed the deleter's parameter

[patch] c++/58051 Implement Core 1579

2014-06-26 Thread Jonathan Wakely
? commit 45e8a7ceb267cafde4d4411563a3e84bbd49ad8c Author: Jonathan Wakely jwak...@redhat.com Date: Thu Jun 26 11:00:54 2014 +0100 gcc/cp: DR 1579 PR c++/58051 * typeck.c (check_return_expr): Lookup as an rvalue even when the types aren't the same. gcc/testsuite

Re: testsuite allocators patch

2014-06-26 Thread Jonathan Wakely
On 26/06/14 23:21 +0200, Paolo Carlini wrote: Hi, I'm afraid something went badly wrong with this commit, I'm seeing tens of fails. See eg: https://gcc.gnu.org/ml/gcc-testresults/2014-06/msg02439.html It seems that uneq_allocator is no longer copy constructible.

Re: testsuite allocators patch

2014-06-27 Thread Jonathan Wakely
I didn't see an obvious fix (I'm not sure if the templated constructor can deduce its argument since the change) but have been out all day and not had a chance to look into it. On 27 June 2014 08:27, Paolo Carlini paolo.carl...@oracle.com wrote: Hi, On 06/27/2014 12:38 AM, Jonathan Wakely

Re: [PR 61424] std::regex matches right to left, not leftmost longest

2014-06-28 Thread Jonathan Wakely
On 28/06/14 00:18 -0700, Tim Shen wrote: diff --git a/libstdc++-v3/include/bits/regex_executor.h b/libstdc++-v3/include/bits/regex_executor.h index 1991c00..e02fa65 100644 --- a/libstdc++-v3/include/bits/regex_executor.h +++ b/libstdc++-v3/include/bits/regex_executor.h @@ -173,6 +173,8 @@

Re: [Patch, PR 61061] Add state limit for regex NFA

2014-06-28 Thread Jonathan Wakely
On 27/06/14 09:53 -0700, Tim Shen wrote: On Fri, Jun 27, 2014 at 12:37 AM, Paolo Carlini paolo.carl...@oracle.com wrote: The actual patch is missing.. ;) Sigh...every time. Sorry. PS: sorry for being distracted by other issues: what happened to the other regex issue? I think we are simply

Re: [Patch] Patch set for regex instantiation

2014-06-29 Thread Jonathan Wakely
). commit 82f3e9fa7d16a677bb9ebc6bc3da12c1209c2df5 Author: Jonathan Wakely jwak...@redhat.com Date: Sun Jun 29 17:58:59 2014 +0100 * include/bits/regex_scanner.h (_ScannerBase): Replace member data with static member functions. * include/bits/regex_scanner.tcc (_ScannerBase

Re: [PR 61424] std::regex matches right to left, not leftmost longest

2014-07-01 Thread Jonathan Wakely
On 30/06/14 19:17 -0700, Tim Shen wrote: On Sat, Jun 28, 2014 at 2:45 AM, Jonathan Wakely jwak...@redhat.com wrote: On 28/06/14 00:18 -0700, Tim Shen wrote: Please put a space above this new function, otherwise it looks like the Dummy implementations comment applies to this function

Re: [patch] c++/58051 Implement Core 1579

2014-07-01 Thread Jonathan Wakely
On 01/07/14 16:10 +0200, Marc Glisse wrote: On Tue, 1 Jul 2014, Markus Trippelsdorf wrote: This patch cause yet another LLVM build error: [...] Reduced: markus@x4 llvm_build % cat CompilerInvocation.ii template typename T class A { T Obj; public: T element_type; A (T *); template class X A

Re: [patch] c++/58051 Implement Core 1579

2014-07-01 Thread Jonathan Wakely
On 01/07/14 15:06 +0200, Markus Trippelsdorf wrote: On 2014.06.26 at 14:06 +0100, Jonathan Wakely wrote: DR1579 relaxes [class.copy]/32 so that expressions in return statements can be looked up as rvalues even when they aren't the same type as the function return type. Implementing that seems

Re: [PATCH] Memory leak in parallel/unique_copy

2014-07-03 Thread Jonathan Wakely
On 02/07/14 22:42 +0100, Goncalo Carvalho wrote: Hi, In parallel/unique_copy.h __counter is never deleted. I'm also trying to follow from other posts how to submit a patch but is well possible I missed some of the conventions. Many apologies if that's the case. Thanks for this, it looks

Re: [PATCH] Memory leak in parallel/unique_copy

2014-07-03 Thread Jonathan Wakely
On 03/07/14 13:40 +0100, Goncalo Carvalho wrote: Hi, Many thanks! I'll try add a test to the suite (unsure how foolproof will be in terms of detecting memory usage). Yes, it might not be worth adding to the testsuite, but I want to be able to verify the patch changes something :-) The 11000

[patch] Some small libstdc++ fixes

2014-07-08 Thread Jonathan Wakely
A fix and some minor tweaks. Tested x86_64-linux, committed to trunk. commit 7f2475d59cc4ca4729341021e8b418ca77f7ccb2 Author: Jonathan Wakely jwak...@redhat.com Date: Tue Jul 8 13:33:02 2014 +0100 * include/bits/allocated_ptr.h (__allocated_ptr::operator=): Add missing return

Re: [Patch, PR 61720] Clear regex BFS match queue after every iteration

2014-07-09 Thread Jonathan Wakely
On 08/07/14 18:53 -0700, Tim Shen wrote: +// libstdc++/61720 +void +PR61720() +{ + bool test __attribute__((unused)) = true; + + string test = R(test\); Does this compile? You've redeclared 'test'

Re: [Patch, PR 61720] Clear regex BFS match queue after every iteration

2014-07-09 Thread Jonathan Wakely
On 09/07/14 09:48 +0200, Paolo Carlini wrote: Hi, On 07/09/2014 03:53 AM, Tim Shen wrote: +// This file is for general testcases in regex. +// We use a single file for multiple testcases because it takes too long to +// compile regex for each testcase in a single file. +// Normal testcases in

Re: [Patch, PR 61720] Clear regex BFS match queue after every iteration

2014-07-09 Thread Jonathan Wakely
On 09/07/14 10:10 +0200, Paolo Carlini wrote: Hi, On 07/09/2014 10:08 AM, Jonathan Wakely wrote: All the 28_regex tests run as part of the same target: normal7) \ dirs=`cd $$srcdir; echo 26_*/* 28_*/[c-z]*`;; \ I've tried moving the 26_numeric tests to a different target

Re: [Patch, PR 61720] Clear regex BFS match queue after every iteration

2014-07-09 Thread Jonathan Wakely
On 9 July 2014 18:33, Mike Stump wrote: The other limit is how big the resulting program is. Too large, and it won’t test on a small memory system. Under a meg, and most people don’t care. As it climbs above that it starts mattering more. If the test is driven by a data file containing

[patch] Fix bug in experimental::any

2014-07-10 Thread Jonathan Wakely
Real Soon Now. Tested x86_64-linux, committed to trunk. commit a5b7242e6eed8f4bbac02ddfb9c798d55481e264 Author: Jonathan Wakely jwak...@redhat.com Date: Thu Jul 10 15:22:35 2014 +0100 * include/experimental/any (any::_Manager_alloc::_Data): Reorder tuple members to simplify pretty

Re: [PATCH v3 3/3] Port libstdc++ pretty-printers to Python 2 + Python 3

2014-07-11 Thread Jonathan Wakely
On 10/07/14 22:48 -0400, Samuel Bronson wrote: PR libstdc++/58962 * python/libstdcxx/v6/printers.py: Port to Python 2+3 (imap): New compat function. (izip): Likewise. (Iterator): New mixin to allow writing iterators in Python 3 style

Re: [PATCH v2 1/3] Make libstdc++ testsuite work with pre-color GCC versions again

2014-07-11 Thread Jonathan Wakely
On 10/07/14 22:48 -0400, Samuel Bronson wrote: When I try to build test just libstdc++, or to run the testsuite from trunk against my installed libstdc++, the testsuite tries to pass -fdiagnostics-color=never to the system GCC, which is too old to know what that is. Since I really just want

Re: [PATCH v2 2/3] libstdc++ testsuite: Turn off GDB's auto-load, list loaded libs

2014-07-11 Thread Jonathan Wakely
On 10/07/14 22:48 -0400, Samuel Bronson wrote: We load our pretty-printers explicitly, and we shouldn't need any other random -gdb.gdb or -gdb.py files from anywhere, so in this patch we turn that off by running set auto-load no. Also, run info share so that the list of loaded libraries ends

[patch] Add libstdc++ type printers for class templates

2014-07-14 Thread Jonathan Wakely
before committing, in case my use of the GDB API or Python can be improved by anyone. commit 538e6eddc52681d9b3ca8fb5d97f194492ee68da Author: Jonathan Wakely jwak...@redhat.com Date: Thu Jul 10 20:31:11 2014 +0100 * python/libstdcxx/v6/printers.py (TemplateTypePrinter): Add type printer

Re: [patch] Add libstdc++ type printers for class templates

2014-07-14 Thread Jonathan Wakely
On 14/07/14 15:21 +0100, Jonathan Wakely wrote: This defines a new style of Python type printer that recognizes templates and can be used to omit default template arguments from the typename GDB prints, e.g. showing std::vectorT, std::allocatorT as simply std::vectorT. Additionally, T will get

[patch] Add libstdc++ pretty printers for Library Fundamentals TS types

2014-07-14 Thread Jonathan Wakely
) printer = RxPrinter(name, function) self.subprinters.append(printer) commit 6a3842ae658fe9693a0989a9aa5ea7b42d01fe28 Author: Jonathan Wakely jwak...@redhat.com Date: Mon Jul 14 15:41:22 2014 +0100 * python/libstdcxx/v6/printers.py (SingleObjContainerPrinter): New base class

Re: [patch] Add libstdc++ type printers for class templates

2014-07-14 Thread Jonathan Wakely
On 14/07/14 14:08 -0600, Tom Tromey wrote: Jonathan This passes the python testsuite but I'll wait for comments before Jonathan committing, in case my use of the GDB API or Python can be improved by Jonathan anyone. It looked fine to me. Thanks for checking it. One thing I should have

Re: [patch] Add libstdc++ type printers for class templates

2014-07-14 Thread Jonathan Wakely
On 14/07/14 14:11 -0600, Tom Tromey wrote: Jonathan I forgot to say that with these type recognizers we might want to Jonathan revisit the output of the existing printers for the containers, so Jonathan that instead of: Jonathan std::map with 3 elements = { ... } Jonathan GDB could print the

Re: [patch] Add libstdc++ type printers for class templates

2014-07-15 Thread Jonathan Wakely
On 15/07/14 00:50 +0100, Jonathan Wakely wrote: One part of the patch I wasn't sure about was this, where 'mgr' is a function pointer: func = gdb.block_for_pc(int(mgr.cast(gdb.lookup_type('intptr_t' Is there a better way to get a pc from the function pointer? I tried simply int(mgr

Re: [patch] Add libstdc++ pretty printers for Library Fundamentals TS types

2014-07-15 Thread Jonathan Wakely
On 14/07/14 20:31 +0100, Jonathan Wakely wrote: This adds printers for the types in the std::experimental namespace. I've committed this slightly improved patch, which removes the duplicate _contained method from StdExpOptionalPrinter (it was meant to be using the base class version) and fixes

Re: [patch] Update catch(...) handlers to deal with __forced_unwind

2014-07-16 Thread Jonathan Wakely
Aha! Thanks for the update, I can cross that one off my TODO list :)

[patch] Fix typo in extend.texi

2014-07-17 Thread Jonathan Wakely
Committed as obvious. commit 713d72fb657827ced70636147fd1c7217891f4f7 Author: Jonathan Wakely jwak...@redhat.com Date: Thu Jul 17 11:43:21 2014 +0100 * doc/extend.texi (Template Instantiation): Remove stray parenthesis. diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi index

[patch] libstdc++/61835 fix invalid character escape in docstring

2014-07-18 Thread Jonathan Wakely
Committed to trunk. commit dacf2aec1b84828e92a06431d725a6e80413b21d Author: redi redi@138bc75d-0d04-0410-961f-82ee72b054a4 Date: Fri Jul 18 15:56:00 2014 + PR libstdc++/61835 * python/libstdcxx/v6/printers.py (TemplateTypePrinter): Use raw string.

[patch] fix libstdc++ configure output

2014-07-19 Thread Jonathan Wakely
Fix a minor issue in the configure output. Tested x86_64-linux, committed to trunk. commit 199a8ec797d04b96f36d64ed0fb064209ff07c04 Author: Jonathan Wakely jwak...@redhat.com Date: Sat Jul 19 18:23:12 2014 +0100 * acinclude.m4 (GLIBCXX_CHECK_SDT_H): Replace AC_MSG_RESULT

Re: [PATCH] libstdc++: add uniform on sphere distribution

2014-07-23 Thread Jonathan Wakely
On 23/07/14 11:58 +0200, Marc Glisse wrote: * can't we end up dividing by 0 if all values of the normal distribution happen to be 0? As an aside, we already have divide-by-zero bugs in ext/random, it would be nice if someone could look at that.

Re: [patch] Add libstdc++ pretty printers for Library Fundamentals TS types

2014-07-23 Thread Jonathan Wakely
On 15/07/14 13:03 +0100, Jonathan Wakely wrote: On 14/07/14 20:31 +0100, Jonathan Wakely wrote: This adds printers for the types in the std::experimental namespace. This should fix the test failures that Paolo and HJ are seeing, older versions of GDB didn't have the gdb.Type.name attribute

Re: testsuite allocators patch

2014-07-24 Thread Jonathan Wakely
On 23/07/14 22:33 +0200, François Dumont wrote: I have a small question regarding some code next to the one I am modifying in this patch. I can see lines like: propagating_allocator() noexcept = default; When using a default implementation shouldn't we let the compiler decide if

Re: [PATCH] libstdc++: add uniform on sphere distribution

2014-07-24 Thread Jonathan Wakely
On 24 July 2014 22:15, Ulrich Drepper wrote: On Wed, Jul 23, 2014 at 6:29 AM, Jonathan Wakely jwak...@redhat.com wrote: As an aside, we already have divide-by-zero bugs in ext/random, it would be nice if someone could look at that. I'll take a look at this soon. That would be great, thanks!

Re: testsuite allocators patch

2014-07-24 Thread Jonathan Wakely
On 24 July 2014 21:11, François Dumont wrote: Yes I have tested with no other changes in my tree and got only those pretty printers errors which are unrelated I think: Python Exception class 'TypeError' iter() returned non-iterator of type '_contained': $2 = std::experimental::optionalint

Re: Make the string_view literal operators constexpr like the ctors they call.

2014-07-25 Thread Jonathan Wakely
On 25 July 2014 04:50, Ed Smith-Rowland 3dw...@verizon.net wrote: On 03/08/2014 01:33 PM, Jonathan Wakely wrote: On 8 March 2014 16:29, Ed Smith-Rowland wrote: On 03/08/2014 11:27 AM, Ed Smith-Rowland wrote: The title says it all. This was just an oversight in the original patch

Re: [PATCH ] PR libstdc++/60037 - SIGFPE in std::generate_canonicalunsigned int...

2014-07-29 Thread Jonathan Wakely
On 29/07/14 04:11 -0400, Ed Smith-Rowland wrote: As discussed in the audit trail both _Adaptor and generate_canonical are both meant to use floating point values. Both are here given static_asserts to that effect. This would have prevented this error and might help future users. The main

[patch] libstdc++/61946 Fix old regression in ext/rope

2014-07-29 Thread Jonathan Wakely
This has been broken since 4.3.0 Tested x86_64-linux, committed to trunk. commit 35ba1889a1652eece0b4a3ab07290fcd8dc8f120 Author: Jonathan Wakely jwak...@redhat.com Date: Tue Jul 29 10:06:39 2014 +0100 PR libstdc++/61946 * include/ext/rope (rope::rope(char_producer_CharT*, size_t

[patch] libstdc++/61947 fix constructor ambiguity in std::tuple

2014-07-29 Thread Jonathan Wakely
to fix this on the release branches too at some point. commit 007f346ea8b17e323fedba0c425f80ee3f8fddee Author: Jonathan Wakely jwak...@redhat.com Date: Tue Jul 29 16:35:10 2014 +0100 PR libstdc++/61947 * include/std/tuple (_Head_base): Use allocator_arg_t parameters to disambiguate

Re: testsuite allocators patch

2014-07-29 Thread Jonathan Wakely
On 23/07/14 22:33 +0200, François Dumont wrote: On 27/06/2014 21:48, Paolo Carlini wrote: Hi, On 06/27/2014 07:33 PM, Jonathan Wakely wrote: I didn't see an obvious fix (I'm not sure if the templated constructor can deduce its argument since the change) but have been out all day and not had

Re: testsuite allocators patch

2014-07-29 Thread Jonathan Wakely
On 25/07/14 00:19 +0100, Jonathan Wakely wrote: On 24 July 2014 21:11, François Dumont wrote: Yes I have tested with no other changes in my tree and got only those pretty printers errors which are unrelated I think: Python Exception class 'TypeError' iter() returned non-iterator of type

Re: testsuite allocators patch

2014-07-29 Thread Jonathan Wakely
On 29/07/14 22:33 +0100, Jonathan Wakely wrote: Tested x86_64-linux (thanks to Samual Bronson for testing with Python3) and committed to trunk. Oops, Samuel not Samual ... no idea why my fingers typed that wrong!

Re: [Bug libstdc++/61107] stl_algo.h: std::__inplace_stable_partition() doesn't process the whole data range

2014-11-10 Thread Jonathan Wakely
On 10/11/14 21:50 +0100, François Dumont wrote: Any news about this one ? Here is another version with additional random tests on algos just to challenge other combinations of tests. PR libstdc++/61107 * include/bits/stl_algo.h (__inplace_stable_partition): Delete.

Re: [PATCH] libstdc++ - Add xmethods for associative containers (ordered and unordered)

2014-11-10 Thread Jonathan Wakely
On 09/11/14 16:00 -0800, Siva Chandra wrote: Hello, Attached is a patch which adds xmethods for the associative containers (set, map, multiset and multimap) and their unordered versions. I think the GDB Python API is not rich enough to implement xmethods for the more interesting methods like

Re: [Bug libstdc++/61107] stl_algo.h: std::__inplace_stable_partition() doesn't process the whole data range

2014-11-10 Thread Jonathan Wakely
On 10/11/14 23:14 +0100, François Dumont wrote: I introduced the random tests after Christopher Jefferson request to have more intensive tests on those algos. Is it the whole stuff of tests using random numbers that you don't like or just the usage of mt19937 ? The use of random number in

Re: [Bug libstdc++/61107] stl_algo.h: std::__inplace_stable_partition() doesn't process the whole data range

2014-11-10 Thread Jonathan Wakely
On 10/11/14 23:39 +0100, François Dumont wrote: No the random tests didn't show any problem. I had demonstrated the problems with the modifications on the existing tests simulating constraint memory context. So unless specified otherwise I will commit tomorrow without the tests using random

Re: libstdc++ new deque failures

2014-11-10 Thread Jonathan Wakely
On 05/11/14 17:49 +, Jonathan Wakely wrote: On 5 November 2014 14:14, David Edelsohn wrote: Jonathan, I still am seeing new failures in the libstdc++ deque testsuite as of last night. I don't know if you still are working through the fallout from the earlier patches, but I wanted to make

Re: libstdc++ new deque failures

2014-11-11 Thread Jonathan Wakely
, committed to trunk. commit 3a81c243672bd721f15bc6320fc7a82e850fc3d8 Author: Jonathan Wakely jwak...@redhat.com Date: Tue Nov 11 10:11:09 2014 + PR libstdc++/63811 * include/bits/stl_deque.h (_Deque_base::_M_move_impl()): Avoid using badname. diff --git a/libstdc++-v3/include/bits

Re: [PATCH] libstdc++ - Add xmethods for associative containers (ordered and unordered)

2014-11-11 Thread Jonathan Wakely
On 10/11/14 21:49 +, Jonathan Wakely wrote: On 09/11/14 16:00 -0800, Siva Chandra wrote: Hello, Attached is a patch which adds xmethods for the associative containers (set, map, multiset and multimap) and their unordered versions. I think the GDB Python API is not rich enough to implement

Re: [PATCH] libstdc++ - Add xmethods for associative containers (ordered and unordered)

2014-11-11 Thread Jonathan Wakely
On 11/11/14 11:38 +, Jonathan Wakely wrote: On 10/11/14 21:49 +, Jonathan Wakely wrote: On 09/11/14 16:00 -0800, Siva Chandra wrote: Hello, Attached is a patch which adds xmethods for the associative containers (set, map, multiset and multimap) and their unordered versions. I think

[patch] add varargs support to std::mem_fn

2014-11-11 Thread Jonathan Wakely
x86_64-linux, committed to trunk. commit 07591983a7880e2370fbc10020e0d9cdfaa86678 Author: Jonathan Wakely jwak...@redhat.com Date: Tue Nov 11 13:44:45 2014 + Make std::mem_fn work with varargs functions. * include/std/functional (_Mem_fn_traits): Add partial specializations

[patch] LWG 2408. SFINAE-friendly common_type/iterator_traits is missing in C++14

2014-11-11 Thread Jonathan Wakely
changed a couple of places to use void_t directly instead of using the _GLIBCXX_HAS_NESTED_TYPE macro at all. Tested x86_64-linux, committed to trunk. commit 57477dc54a9b74a3aaa8d50949d8aa7b23488a4c Author: Jonathan Wakely jwak...@redhat.com Date: Tue Nov 11 18:55:33 2014 + Define __void_t

[patch] Detect non-member operator() overloads in std::experimental::optional

2014-11-11 Thread Jonathan Wakely
The _Has_addressof trait only detected an overloaded operator() as a member function, this also checks for a non-member. Tested x86_64-linux, committed to trunk. commit 32b294e3eddf7789c25f3b751ae6b2a2c5c43275 Author: Jonathan Wakely jwak...@redhat.com Date: Mon Nov 10 19:02:02 2014 +

Re: [patch] Detect non-member operator() overloads in std::experimental::optional

2014-11-11 Thread Jonathan Wakely
On 12/11/14 00:16 +, Jonathan Wakely wrote: The _Has_addressof trait only detected an overloaded operator() as a member function, this also checks for a non-member. Also clean up the tests by removing some unused headers. Tested x86_64-linux, committed to trunk. commit

Re: [patch] LWG 2408. SFINAE-friendly common_type/iterator_traits is missing in C++14

2014-11-12 Thread Jonathan Wakely
On 12/11/14 07:13 +0100, Marc Glisse wrote: On Tue, 11 Nov 2014, Jonathan Wakely wrote: + templatetypename _Iterator, typename = __void_t Is there a particular reason not to write void directly? I like this form as a hint that the specialization is expected to use void_t

[patch] c++/33911 add -Wno-deprecated to libstdc++ tests

2014-11-12 Thread Jonathan Wakely
Once the front end patch goes in these tests will need -Wno-deprecated. Tested x86_64-linux, committed to trunk. commit 11b6e8991a772a5795e52e01b4598bcd947cac41 Author: Jonathan Wakely jwak...@redhat.com Date: Wed Nov 12 03:12:22 2014 + Add -Wno-deprecated to dg-options. PR

[patch] LWG DR 2315. weak_ptr should be movable

2014-11-12 Thread Jonathan Wakely
http://cplusplus.github.io/LWG/lwg-defects.html#2315 Tested x86_64-linux and ppc64-linux, committed to trunk. commit d362afb7d30cbf9b138c162050376f1491a5c6f5 Author: Jonathan Wakely jwak...@redhat.com Date: Mon Feb 10 18:15:08 2014 -0800 LWG DR 2315. weak_ptr should be movable

Re: [Bug libstdc++/61107] stl_algo.h: std::__inplace_stable_partition() doesn't process the whole data range

2014-11-12 Thread Jonathan Wakely
On 12/11/14 14:56 +, Christopher Jefferson wrote: I did suggest this change, so I feel I should defend it! Our testing of many algorithms is woefully slim, that is how (for example) the segfaulting bug in std::nth_element got through into a release -- the tests for that algorithm were

[patch] Apply LWG 2399, 2400 and 2401 to std::shared_ptr and std::function

2014-11-12 Thread Jonathan Wakely
5930336c20503e26ed22f8ab5fe81146b31a60e5 Author: Jonathan Wakely jwak...@redhat.com Date: Wed Nov 12 14:21:41 2014 + Implement resolutions of LWG 2399, 2400 and 2401. * include/bits/shared_ptr.h (shared_ptr, weak_ptr): Define _Convertible alias template to simplify constraints

Re: [patch] libstdc++/57250 shared_ptr atomic operations

2014-11-12 Thread Jonathan Wakely
On 17/10/14 19:27 +0100, Jonathan Wakely wrote: I'm not very proud of this solution, but unless anyone has a better ideas this is how I plan to add the atomic operations for shared_ptr. I used __gnu_cxx::__mutex instead of std::mutex because it has fewer dependencies, so the atomic operations

Re: [gimple-classes, committed 4/6] tree-ssa-tail-merge.c: Use gassign

2014-11-13 Thread Jonathan Wakely
On 13 November 2014 10:45, Richard Biener wrote: Hmm. struct assign; struct base { operator assign *() const { return (assign *)this; } }; struct assign : base { }; void foo (assign *); void bar (base *b) { foo (b); } doesn't work, but void bar (base b) { foo (b); }

[patch] Fix mangling of ABI-tagged std::wstring

2014-11-14 Thread Jonathan Wakely
Jason approved this yesterday on IRC. Tested powerpc64-linux, committed to trunk. commit 9a8efcc0e2068abb51aaf513b4a7ed262454cd1e Author: Jonathan Wakely jwak...@redhat.com Date: Fri Nov 14 11:00:24 2014 + gcc/cp: * mangle.c (find_substitution): Look for abi_tag on class

[patch] Define new std::ios_base::failure with abi_tag(cxx11)

2014-11-14 Thread Jonathan Wakely
-linux and x86_64-linux commit 8f8279579e72423450eb3ff744d9102f7b891d8d Author: Jonathan Wakely jwak...@redhat.com Date: Thu Nov 13 19:30:15 2014 + Define C++11 version of std::ios_base::failure. * config/abi/pre/gnu.ver: Add new exports. * include/bits/ios_base.h (ios_base

[patch] New std::string implementation

2014-11-14 Thread Jonathan Wakely
This is the long-awaited ABI break for std::string, replacing our venerable Copy-On-Write implementation with a C++11-conforming Small-String-Optimization implementation (based on Paolo's vstring). The gist of it is adding a second complete std::string implementation that is tagged with

Re: [PATCH] c++98/mt_allcoator.cc: Fix assumption sizeof(void *) == sizeof(size_t)

2014-11-14 Thread Jonathan Wakely
On 14/11/14 10:10 -0600, Joel Sherrill wrote: Attached is an updated version of the patch which includes some commentary above the include of stdint.h. Is this OK to apply? OK, thanks.

Re: [patch] New std::string implementation

2014-11-14 Thread Jonathan Wakely
On 14/11/14 16:32 +, Christopher Jefferson wrote: Some (very small) questions / cleanups 1) Do you plan on supporting CXX11 ABI on C++03? There is some #if __cplusplus 201103L inside the new basic_string. Yes, the intention is that you get the same std::string implementation independent

Re: [patch] New std::string implementation

2014-11-14 Thread Jonathan Wakely
On 14/11/14 16:42 +, Jonathan Wakely wrote: On 14/11/14 16:32 +, Christopher Jefferson wrote: I tried bootstrapping on Mac OS X 10.10, and got lots of linking issues, the relevant part is:: I might be missing some of the new instantiations, I'll look into that. I am missing some

Re: [patch] New std::string implementation

2014-11-14 Thread Jonathan Wakely
On 14/11/14 16:51 +, Jonathan Wakely wrote: On 14/11/14 16:42 +, Jonathan Wakely wrote: On 14/11/14 16:32 +, Christopher Jefferson wrote: I tried bootstrapping on Mac OS X 10.10, and got lots of linking issues, the relevant part is:: I might be missing some of the new

Re: [patch] [WIP] Optimize synchronization in std::future if futexes are available.

2014-11-16 Thread Jonathan Wakely
Oing libstdc++@, as required for all libstdc++ patches. Original patch at https://gcc.gnu.org/ml/gcc-patches/2014-11/msg02004.html This WORK-IN-PROGRESS patch uses an atomic unsigned and futex operations to optimize the synchronization code in std::future. The current code uses a

Re: [patch] New std::string implementation

2014-11-17 Thread Jonathan Wakely
On 14/11/14 15:43 +, Jonathan Wakely wrote: This is the long-awaited ABI break for std::string, replacing our venerable Copy-On-Write implementation with a C++11-conforming Small-String-Optimization implementation (based on Paolo's vstring). This patch fixes move construction

Re: [patch] New std::string implementation

2014-11-17 Thread Jonathan Wakely
On 17/11/14 13:06 +0100, Markus Trippelsdorf wrote: On 2014.11.14 at 15:43 +, Jonathan Wakely wrote: Tested on x86_64-linux and powerpc64-linux, also with --disable-libstdcxx11-abi to verify all the incompatible changes can be disabled if needed. On ppc64 I get: FAIL: libstdc++-abi

Re: [patch] New std::string implementation

2014-11-18 Thread Jonathan Wakely
On 18/11/14 10:45 +0100, Richard Biener wrote: Looking at all these issues that just pop up inside libstdc++ I wonder if this whole business will not blow up in our face once out in the wild... I'm trying to ensure that most of the the pain is dealt with inside libstdc++ and so users won't

Re: PR 13631 Problems in messages

2014-11-23 Thread Jonathan Wakely
On 24/11/14 00:13 +0100, François Dumont wrote: Hello As we are at doing some evolution in the ABI I would like to take the opportunity to merge branch libstdcxx_so_7-2. The first fix was I don't think we want to merge everything, but it's certainly worth looking to see if there are some

Re: [Patch, libstdc++/63920] Fix regex_constants::match_not_null behavior

2014-11-24 Thread Jonathan Wakely
On 18/11/14 11:12 -0800, Tim Shen wrote: Bootstrapped and tested. Thanks! -- Regards, Tim Shen commit f17155183b9ae1283d04f3bbdb61d05d9279ebe4 Author: timshen tims...@google.com Date: Tue Nov 18 00:07:28 2014 -0800 PR libstdc++/63920 * include/bits/regex_executor.h: Make

Re: [patch] Define new std::ios_base::failure with abi_tag(cxx11)

2014-11-24 Thread Jonathan Wakely
On 24/11/14 17:48 +0100, Tom de Vries wrote: On 14-11-14 13:18, Jonathan Wakely wrote: This adds system_error support to iostreams, including the required base class changes to std::ios_base::failure. The abi_tag is used to make it a distinct type. This changes the type of I/O exceptions

Re: [Patch, libstdc++/63497] Avoid dereferencing invalid iterator in regex_executor

2014-11-25 Thread Jonathan Wakely
On 25/11/14 00:41 -0800, Tim Shen wrote: On Wed, Oct 22, 2014 at 8:19 PM, Tim Shen tims...@google.com wrote: Committed. Thank you too! I'm backporting this patch to gcc-4_9-branch. Do we usually boot test it and then commit directly, or it should be reviewed again? I approved it for the

Re: [Patch, ARM, ping1] Fix PR target/56846

2014-11-26 Thread Jonathan Wakely
On 26/11/14 17:23 -, Thomas Preud'homme wrote: Ping? I'm OK with backporting it if a release manager approves it. -Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- ow...@gcc.gnu.org] On Behalf Of Thomas Preud'homme Sent: Wednesday, November 19, 2014

Re: PR 13631 Problems in messages

2014-11-28 Thread Jonathan Wakely
On 27/11/14 23:19 +0100, François Dumont wrote: Hi Here is a revisited version. I finally go without compiling in C++11 as I prefer to use __builtin_alloca instead of using std::unique_ptr and heap memory. I also realized that I could use codecvt::max_length to know the max number of

Re: PR 13631 Problems in messages

2014-11-28 Thread Jonathan Wakely
On 28/11/14 10:49 +, Jonathan Wakely wrote: I think it's fine to say you can't have more than 2^31 open message catalogs, but we should for numeric_limitscatalog::max() before ... but we should *check* for ... doing anything and return -1 to say it couldn't be opened.

Re: [Bug libstdc++/62313] Data race in debug iterators

2014-09-26 Thread Jonathan Wakely
On 26/09/14 00:00 +0200, François Dumont wrote: Apart from those minor adjustments I think this looks good, but I'd like to know that it has been tested with -fsanitize=thread, even if only lightly tested. Hi Dmitry, who reported the bug, confirmed the fix. Can I go ahead and commit ?

Re: [PATCH] Add libstdc++ baseline_symbols for aarch64

2014-09-29 Thread Jonathan Wakely
On 26/09/14 23:42 +0200, Andreas Schwab wrote: Generated by make new-abi-baseline on aarch64-suse-linux. Andreas. * config/abi/post/aarch64-linux-gnu/baseline_symbols.txt: New file. OK, thanks.

Re: [PATCH] Fix finding default baseline symbols directory

2014-09-29 Thread Jonathan Wakely
On 26/09/14 23:42 +0200, Andreas Schwab wrote: Tested on aarch64-suse-linux, where try_cpu=generic. Andreas. * configure.host: Use host_cpu, not try_cpu, to define default abi_baseline_pair. --- libstdc++-v3/configure.host | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [libstdc++] Refactor python/hook.in

2014-09-29 Thread Jonathan Wakely
On 29/09/14 06:02 -0700, Siva Chandra wrote: The attached patch refactors python/hook.in so that there are no individual function calls to load pretty printers and xmethods. This was suggested by Tom here: https://gcc.gnu.org/ml/gcc-patches/2014-08/msg02589.html. He indicates that it is better

[patch] Update libstdc++ status table.

2014-09-29 Thread Jonathan Wakely
Update the docs again. Committed to trunk. commit ef8c7f18cdfc087d54b0bbe2a1cd171409eb1f18 Author: Jonathan Wakely jwak...@redhat.com Date: Mon Sep 29 15:13:33 2014 +0100 * doc/xml/manual/status_cxx2011.xml: Update. * doc/html/manual/status.html: Regenerate. diff --git a/libstdc

Re: __intN patch 3/5: main __int128 - __intN conversion.

2014-09-29 Thread Jonathan Wakely
On 29/09/14 14:06 -0400, DJ Delorie wrote: Just one question about the include/std/limits changes below. It seems that __glibcxx_signed_b isn't strictly necessary as it doesn't use the B argument, so is it just there for consistency? Yup. OK, thanks for confirming.

Re: [PATCH] Fix finding default baseline symbols directory

2014-09-29 Thread Jonathan Wakely
On 29/09/14 19:24 +0200, Andreas Schwab wrote: Jonathan Wakely jwak...@redhat.com writes: Would a safer change be to just add a new pattern for aarch64? --- a/libstdc++-v3/configure.host +++ b/libstdc++-v3/configure.host @@ -345,6 +345,9 @@ case ${host} in x86_64

Re: [Bug libstdc++/62313] Data race in debug iterators

2014-09-30 Thread Jonathan Wakely
On 26/09/14 11:05 +0100, Jonathan Wakely wrote: On 26/09/14 00:00 +0200, François Dumont wrote: Apart from those minor adjustments I think this looks good, but I'd like to know that it has been tested with -fsanitize=thread, even if only lightly tested. Hi Dmitry, who reported the bug

  1   2   3   4   5   6   7   8   9   10   >