Re: [PATCH] Trust TREE_ADDRESSABLE

2014-06-23 Thread Richard Biener
) + fprintf (dump_file, %s (non-addressable non-aliased), vnode-name ()); varpool_for_node_and_aliases (vnode, clear_addressable_bit, NULL, true); } if (!address_taken !written -- Richard Biener rguent...@suse.de SUSE / SUSE Labs SUSE LINUX Products GmbH

Re: [PATCH] Fix PR61375: cancel bswap optimization when value doesn't fit in a HOST_WIDE_INT

2014-06-23 Thread Richard Biener
On Fri, Jun 20, 2014 at 12:41 PM, Thomas Preud'homme thomas.preudho...@arm.com wrote: From: Richard Biener [mailto:richard.guent...@gmail.com] Sent: Tuesday, June 10, 2014 5:05 PM Backports are welcome - please post a patch. Sorry for the delay. Here you are: diff --git a/gcc/testsuite

Re: [PATCH] Remove bogus include path with in-tree cloog

2014-06-23 Thread Richard Biener
On Fri, Jun 20, 2014 at 6:52 PM, Bernd Edlinger bernd.edlin...@hotmail.de wrote: Hi, I have noticed there is a minor flaw with the include path when cloog is installed in-tree. That is, the cloog-include directory is added twice, first with absolute path, and then again with relative

Re: [PATCH] Fix forwporp pattern (T)(P + A) - (T)P - (T)A

2014-06-23 Thread Richard Biener
On Sun, Jun 22, 2014 at 9:14 AM, Bernd Edlinger bernd.edlin...@hotmail.de wrote: Hi, I noticed that several testcases in the GMP-4.3.2 test suite are failing now which did not happen with GCC 4.9.0. I debugged the first one, mpz/convert, and found the file mpn/generic/get_str.c was

Re: [PATCH, PR61554] ICE during CCP

2014-06-23 Thread Richard Biener
On Mon, Jun 23, 2014 at 7:32 AM, Chung-Lin Tang clt...@codesourcery.com wrote: Hi Richard, In this change: https://gcc.gnu.org/ml/gcc-patches/2014-06/msg01278.html where substitute_and_fold() was changed to use a dom walker, the calls to purge dead EH edges during the walk can alter the

Re: [PATCH] Change default for --param allow-...-data-races to off

2014-06-23 Thread Richard Biener
On Mon, Jun 23, 2014 at 10:02 AM, Bernd Edlinger bernd.edlin...@hotmail.de wrote: Hi, On Fri, 20 Jun 2014 13:44:18, Martin Jambor wrote: Hi, On Thu, Jun 19, 2014 at 06:18:47PM +0200, Bernd Edlinger wrote: Hi, from a recent discussion on g...@gcc.gnu.org I have learned that the default

Re: [GSoC] [match-and-simplify] check for capture index

2014-06-23 Thread Richard Biener
On Wed, Jun 18, 2014 at 3:07 PM, Prathamesh Kulkarni bilbotheelffri...@gmail.com wrote: Put a check for capture index. * genmatch.c (parse_capture): Add condition to check capture index. (capture_max): New constant. (stdlib.h): Include. I'd rather

[PATCH][match-and-simplify] Remove now dead code

2014-06-23 Thread Richard Biener
This removes the non-DT matching code. Committed. Richard. 2014-06-23 Richard Biener rguent...@suse.de * genmatch.c (operand::gen_gimple_match): Remove. (predicate::gen_gimple_match): Likewise. (expr::gen_gimple_match): Likewise. (c_expr::gen_gimple_match

Re: [GSoC][match-and-simplify] mark some more operators as commutative

2014-06-23 Thread Richard Biener
On Mon, Jun 23, 2014 at 3:32 PM, Prathamesh Kulkarni bilbotheelffri...@gmail.com wrote: * match.pd: Mark operators in some bitwise and plus-minus patterns to be commutative. /* A - (A +- B) - -+ B */ (match_and_simplify - (minus @0 (plus @0 @1)) + (minus @0 (plus:c @0 @1)) (negate @0))

Re: [patch i386]: Combine memory and indirect jump

2014-06-23 Thread Richard Biener
On Mon, Jun 23, 2014 at 4:13 PM, Richard Henderson r...@redhat.com wrote: On 06/20/2014 02:59 PM, Kai Tietz wrote: So I suggest following change of passes.def: Index: passes.def === --- passes.def (Revision 211850) +++

Re: [GSoC][match-and-simplify] Remove gen_gimple_match_fail

2014-06-23 Thread Richard Biener
On Mon, Jun 23, 2014 at 3:43 PM, Prathamesh Kulkarni bilbotheelffri...@gmail.com wrote: * genmatch.c (gen_gimple_match_fail): Remove. (expr::gen_gimple_transform): Remove call to gen_gimple_match_fail. Change fprintf (f, if (!res)) to fprintf (f, if (!res) return false;\n) Thanks,

Re: [GSoC][match-and-simplify] mark some more operators as commutative

2014-06-23 Thread Richard Biener
On Mon, Jun 23, 2014 at 4:23 PM, Marc Glisse marc.gli...@inria.fr wrote: On Mon, 23 Jun 2014, Richard Biener wrote: On Mon, Jun 23, 2014 at 3:32 PM, Prathamesh Kulkarni bilbotheelffri...@gmail.com wrote: * match.pd: Mark operators in some bitwise and plus-minus patterns to be commutative

Re: [PATCH] Fix arrays in rtx.u + add minor rtx verification

2014-06-23 Thread Richard Biener
On Mon, Jun 23, 2014 at 4:25 PM, Richard Henderson r...@redhat.com wrote: On 06/20/2014 01:42 PM, Marek Polacek wrote: 2014-06-20 Marek Polacek pola...@redhat.com * genpreds.c (verify_rtx_codes): New function. (main): Call it. * rtl.h (RTX_FLD_WIDTH, RTX_HWINT_WIDTH):

Re: calloc = malloc + memset

2014-06-23 Thread Richard Biener
On June 23, 2014 5:51:30 PM CEST, Marc Glisse marc.gli...@inria.fr wrote: On Mon, 23 Jun 2014, Jakub Jelinek wrote: Ok for trunk, sorry for the delay. Thanks. Richard has moved the passes a bit since then, but I still have exactly one spot where the testsuite is ok :-) I need strlen to be

Re: [PATCH] Trust TREE_ADDRESSABLE

2014-06-23 Thread Richard Biener
On June 23, 2014 6:15:10 PM CEST, Jan Hubicka hubi...@ucw.cz wrote: I don't like this very much. It's fragile and it will be very hard to detect bugs caused by it. Please don't spread uses of the DECL_NONALIASED hack. If we are only concerned about LTO I'd rather have a in_lto_p check in

Re: [Patch] Not very subtle fix for pr61510

2014-06-23 Thread Richard Biener
? Richard. Thanks, James --- 2014-06-19 James Greenhalgh james.greenha...@arm.com PR regression/61510 * cgraphunit.c (analyze_functions): Check we have an origin node before dereferencing it. -- Richard Biener rguent...@suse.de SUSE / SUSE Labs SUSE LINUX

Re: [GSoC][match-and-simplify] mark some more operators as commutative

2014-06-23 Thread Richard Biener
On Mon, Jun 23, 2014 at 4:38 PM, Richard Biener richard.guent...@gmail.com wrote: On Mon, Jun 23, 2014 at 4:23 PM, Marc Glisse marc.gli...@inria.fr wrote: On Mon, 23 Jun 2014, Richard Biener wrote: On Mon, Jun 23, 2014 at 3:32 PM, Prathamesh Kulkarni bilbotheelffri...@gmail.com wrote

Re: calloc = malloc + memset

2014-06-23 Thread Richard Biener
On Mon, Jun 23, 2014 at 6:19 PM, Marc Glisse marc.gli...@inria.fr wrote: On Mon, 23 Jun 2014, Richard Biener wrote: On June 23, 2014 5:51:30 PM CEST, Marc Glisse marc.gli...@inria.fr wrote: On Mon, 23 Jun 2014, Jakub Jelinek wrote: Ok for trunk, sorry for the delay. Thanks. Richard has

Re: [PATCH][RFC] Gate loop passes group on number-of-loops 1, add no-loops group

2014-06-23 Thread Richard Biener
On Wed, 18 Jun 2014, Jeff Law wrote: On 06/18/14 04:42, Richard Biener wrote: The following aims at reducing the number of pointless passes we run on functions containing no loops. Those are at least two copyprop and one dce pass (two dce passes when vectorization is enabled, three

Re: [PATCH 3/3] add hash_map class

2014-06-23 Thread Richard Biener
On Fri, Jun 20, 2014 at 12:52 PM, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, This patch adds a hash_map class so we can consolidate the boiler plate around using hash_table as a map, it also allows us to get rid of pointer_map which I do in this patch by

Re: [PATCH 2/N] allow storing values directly in hash tables

2014-06-23 Thread Richard Biener
On Fri, Jun 20, 2014 at 12:52 PM, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, this patch allows you to define the type the hash table stores as elements instead of the type elements point at by having your hash descriptor define the type

Re: [PATCH] Fix forwporp pattern (T)(P + A) - (T)P - (T)A

2014-06-23 Thread Richard Biener
On Mon, Jun 23, 2014 at 4:28 PM, Bernd Edlinger bernd.edlin...@hotmail.de wrote: Hi, On Mon, 23 Jun 2014 10:40:53, Richard Biener wrote: On Sun, Jun 22, 2014 at 9:14 AM, Bernd Edlinger bernd.edlin...@hotmail.de wrote: Hi, I noticed that several testcases in the GMP-4.3.2 test suite

Re: [RFC] Making fold-const sane WRT symbol visibilities

2014-06-24 Thread Richard Biener
; + return q != 0; +} +/* { dg-final { scan-tree-dump return 1 ccp1} } */ +/* { dg-final { cleanup-tree-dump ccp1 } } */ -- Richard Biener rguent...@suse.de SUSE / SUSE Labs SUSE LINUX Products GmbH - Nuernberg - AG Nuernberg - HRB 16746 GF: Jeff Hawn, Jennifer Guild, Felix Imendorffer

Re: [PATCH] Introducing SAD (Sum of Absolute Differences) operation to GCC vectorizer.

2014-06-24 Thread Richard Biener
provides instructions for it. Thank you for your comment again! thanks, Cong Thanks, James -- Richard Biener rguent...@suse.de SUSE / SUSE Labs SUSE LINUX Products GmbH - Nuernberg - AG Nuernberg - HRB 16746 GF: Jeff Hawn, Jennifer Guild, Felix Imendorffer

Re: [PATCH] Fix forwporp pattern (T)(P + A) - (T)P - (T)A

2014-06-24 Thread Richard Biener
On Mon, Jun 23, 2014 at 8:02 PM, Bernd Edlinger bernd.edlin...@hotmail.de wrote: Hi, On Mon, 23 Jun 2014 19:12:47, Richard Biener wrote: On Mon, Jun 23, 2014 at 4:28 PM, Bernd Edlinger bernd.edlin...@hotmail.de wrote: Hi, On Mon, 23 Jun 2014 10:40:53, Richard Biener wrote: On Sun, Jun

[PATCH] Fix PR61572

2014-06-24 Thread Richard Biener
set (which really tells that all SSA names of the underlying decl must be able to coalesce to the same register). Richard. 2014-06-24 Richard Biener rguent...@suse.de PR tree-optimization/61572 * tree-ssa-sink.c (statement_sink_location): Do not sink loads from hard

Re: [GSoC] remove unnecessary temporaries

2014-06-24 Thread Richard Biener
On Tue, Jun 24, 2014 at 10:53 AM, Prathamesh Kulkarni bilbotheelffri...@gmail.com wrote: Hi, This patch attempts to generate temporaries only when required. I have changed generation of operand names. All children of an expr-node are assigned at expr-node itself. Names are generated as

Re: [RFC] optimize x - y cmp 0 with undefined overflow

2014-06-24 Thread Richard Biener
On Fri, Jun 20, 2014 at 11:33 AM, Eric Botcazou ebotca...@adacore.com wrote: [I'm at last back to this...] With [1, -x + INF] as the resulting range? But it can be bogus if x is itself equal to +INF (unlike the input range [x + 1, +INF] which is always correct) Hmm, indeed. so this

Re: [PATCH] Detect a pack-unpack pattern in GCC vectorizer and optimize it.

2014-06-24 Thread Richard Biener
On Sat, May 3, 2014 at 2:39 AM, Cong Hou co...@google.com wrote: On Mon, Apr 28, 2014 at 4:04 AM, Richard Biener rguent...@suse.de wrote: On Thu, 24 Apr 2014, Cong Hou wrote: Given the following loop: int a[N]; short b[N*2]; for (int i = 0; i N; ++i) a[i] = b[i*2]; After being

Re: [PATCH] Introducing SAD (Sum of Absolute Differences) operation to GCC vectorizer.

2014-06-24 Thread Richard Biener
On Tue, Dec 3, 2013 at 2:06 AM, Cong Hou co...@google.com wrote: Hi Richard Could you please take a look at this patch and see if it is ready for the trunk? The patch is pasted as a text file here again. (found it) The patch is ok for trunk. (please consider re-testing before you commit)

Re: [PATCH]Enable elimination of IV use with unsigned type candidate

2014-06-24 Thread Richard Biener
On Mon, Jun 23, 2014 at 11:49 AM, Bin Cheng bin.ch...@arm.com wrote: Hi, For below simplified case: #define LEN (32000) __attribute__((aligned(16))) float a[LEN],b[LEN]; int foo (int M) { for (int i = 0; i M; i++) a[i+M] = a[i] + b[i]; } Compiling it with command like: $

Re: [GSoC][match-and-simplify] factor expr check in gimple-match-head.c

2014-06-24 Thread Richard Biener
On Tue, Jun 24, 2014 at 1:29 PM, Prathamesh Kulkarni bilbotheelffri...@gmail.com wrote: This patch factors out checking expression-code in gimple-match-head.c * gimple-match-head.c (check_gimple_assign): New function. (check_gimple_assign_convert): Likewise.

[PATCH][match-and-simplify] GENERIC boilerplate

2014-06-24 Thread Richard Biener
This adds infrastructure to create generic-match.c (empty for now). Richard. 2014-06-24 Richard Biener rguent...@suse.de * Makefile.in (OBJS): Add generic-match.o. (.PRECIOUS): Likewise. (MOSTLYCLEANFILES): Add generic-match.c. (generic-match.c): New rule

[PATCH][match-and-simplify] Get rid of gimple_match_and_simplify wrappers

2014-06-24 Thread Richard Biener
This re-orders operands so we can default-initialize them to zero now that we only have a single autogenerated function. Richard. 2014-06-24 Richard Biener rguent...@suse.de * genmatch.c (write_fn_prototype): Remove and inline... (decision_tree::gen_gimple): ...here

Re: [patch] Do not generate useless integral conversions

2014-06-24 Thread Richard Biener
On Tue, Jun 24, 2014 at 12:54 PM, Eric Botcazou ebotca...@adacore.com wrote: Hi, https://gcc.gnu.org/ml/gcc-patches/2012-03/msg00491.html changed the old signed_type_for/unsigned_type_for functions and made them always return an integer type, whereas they would previously leave integral types

[PATCH][match-and-simplify] GENERIC code-gen

2014-06-24 Thread Richard Biener
). At the moment it just creates dead code. I'll see if it works to wire it in tomorrow. Committed. Richard. 2014-06-24 Richard Biener rguent...@suse.de * genmatch.c (operand::gen_gimple_transform): Rename to... (operand::gen_transform): ... this and add a flag argument

Re: [PATCH 3/3] add hash_map class

2014-06-24 Thread Richard Biener
On June 24, 2014 9:16:34 PM CEST, Trevor Saunders tsaund...@mozilla.com wrote: On Tue, Jun 24, 2014 at 08:23:49PM +0200, Jan Hubicka wrote: On 06/20/2014 12:52 PM, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, This patch adds a hash_map class so we

Re: [PATCH][match-and-simplify] GENERIC code-gen

2014-06-25 Thread Richard Biener
On Tue, 24 Jun 2014, Prathamesh Kulkarni wrote: On Tue, Jun 24, 2014 at 9:00 PM, Richard Biener rguent...@suse.de wrote: This massages things so GENERIC code-gen works (well, is emitted and compiles). The GENERIC interface matches that of fold_{unary,binary,ternary} with also supporting

Re: [RFC] Making fold-const sane WRT symbol visibilities

2014-06-25 Thread Richard Biener
} } */ -- Richard Biener rguent...@suse.de SUSE / SUSE Labs SUSE LINUX Products GmbH - Nuernberg - AG Nuernberg - HRB 16746 GF: Jeff Hawn, Jennifer Guild, Felix Imendorffer -- Richard Biener rguent...@suse.de SUSE / SUSE Labs SUSE LINUX Products GmbH - Nuernberg - AG Nuernberg - HRB 16746 GF

Re: [PATCH] Change default for --param allow-...-data-races to off

2014-06-25 Thread Richard Biener
On Tue, Jun 24, 2014 at 10:19 PM, Martin Jambor mjam...@suse.cz wrote: On Mon, Jun 23, 2014 at 03:35:01PM +0200, Bernd Edlinger wrote: Hi Martin, Well actually, I am not sure if we ever wanted to have a race condition here. Have you seen any impact of --param allow-store-data-races on

Re: [patch] Do not generate useless integral conversions

2014-06-25 Thread Richard Biener
On Tue, Jun 24, 2014 at 11:16 PM, Eric Botcazou ebotca...@adacore.com wrote: I think that was on purpose to avoid arithmetics in enum types. As those conversions are useless and thus stripped later is it really important to retain enum and boolean kind here? The problem is that convert.c is

[PATCH] Fix PR61560

2014-06-25 Thread Richard Biener
Committed. Richard. 2014-06-25 Richard Biener rguent...@suse.de PR testsuite/61560 * gcc.dg/tree-ssa/ssa-fre-32.c: Change to avoid differences for targets that return _Complex float in memory. Index: gcc/testsuite/gcc.dg/tree-ssa/ssa-fre-32.c

Re: [PATCH] Change default for --param allow-...-data-races to off

2014-06-25 Thread Richard Biener
On Wed, Jun 25, 2014 at 10:54 AM, Jakub Jelinek ja...@redhat.com wrote: On Wed, Jun 25, 2014 at 10:14:17AM +0200, Richard Biener wrote: Perhaps not unsurprisingly, the patch is very similar. Bootstrapped and tested on x86_64-linux. OK for trunk? Ok - please give the C++/atomics folks

[PATCH][match-and-simplify] Put GENERIC match-and-simplify to work

2014-06-25 Thread Richard Biener
the compiler optimizing those) because then we can create the final API for the GENERIC part directly. Installed. Richard. 2014-06-25 Richard Biener rguent...@suse.de * genmatch.c (decision_tree::gen_gimple): Create three gimple_match_and_simplify overloads again

Re: [PATCH] Fix forwprop pattern (T)(P + A) - (T)P - (T)A, Part 1

2014-06-25 Thread Richard Biener
On Tue, Jun 24, 2014 at 2:30 PM, Bernd Edlinger bernd.edlin...@hotmail.de wrote: Hi Richard, I have here part 1 of this patch, which does not use undefined behaviour. Currently I start to think that also TYPE_SATURATING just cannot happen here, because only some targets have saturating

Re: [PATCH] Fix forwprop pattern (T)(P + A) - (T)P - (T)A, Part 2

2014-06-25 Thread Richard Biener
On Wed, Jun 25, 2014 at 11:12 AM, Bernd Edlinger bernd.edlin...@hotmail.de wrote: Hi, this is part 2 of my patch, which uses the undefined behaviour, and emits a strict overflow warning. This fixes gnat.dg/opt37.adb again. The diff is relative to part 1:

Re: [patch passes.def]: Fix regression on ARM PR/61608

2014-06-25 Thread Richard Biener
On Wed, Jun 25, 2014 at 3:35 PM, Kai Tietz ktiet...@googlemail.com wrote: Hello, so there seems to be a fallout caused by moving peephole2 pass. See PR/61608. So we need indeed 2 peephole2 passes. ChangeLog 2014-06-25 Kai Tietz kti...@redhat.com PR rtl-optimization/61608 *

[PATCH] Fix parts of PR61607

2014-06-25 Thread Richard Biener
in out-of-SSA phase by inserting copies appropriately. Bootstrapped on x86_64-unknown-linux-gnu, ok? Thanks, Richard. 2014-06-25 Richard Biener rguent...@suse.de PR tree-optimization/61607 * tree-ssa-dom.c (cprop_operand): Remove restriction on propagating volatile

[PATCH] Fix parts of PR61607

2014-06-25 Thread Richard Biener
This removes prematurely killing loops during jump threading and moves it to a spot where we know we didn't cancel the jump thread. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Ok? Thanks, Richard. 2014-06-25 Richard Biener rguent...@suse.de PR tree-optimization

Re: [PATCH] Change default for --param allow-...-data-races to off

2014-06-26 Thread Richard Biener
On June 26, 2014 12:03:21 AM CEST, Martin Jambor mjam...@suse.cz wrote: Hi, On Wed, Jun 25, 2014 at 03:14:31PM -0600, Jeff Law wrote: On 06/24/14 14:19, Martin Jambor wrote: On Mon, Jun 23, 2014 at 03:35:01PM +0200, Bernd Edlinger wrote: Hi Martin, Well actually, I am not sure if we ever

Re: [PATCH] Add missing -fdump-* options

2014-06-26 Thread Richard Biener
On Wed, Jun 25, 2014 at 4:21 PM, Teresa Johnson tejohn...@google.com wrote: On Tue, May 13, 2014 at 8:19 AM, Xinliang David Li davi...@google.com wrote: On Tue, May 13, 2014 at 1:39 AM, Richard Biener richard.guent...@gmail.com wrote: On Fri, May 9, 2014 at 5:54 PM, Teresa Johnson tejohn

Re: [PATCH] Fix parts of PR61607

2014-06-26 Thread Richard Biener
On Wed, 25 Jun 2014, Jeff Law wrote: On 06/25/14 08:05, Richard Biener wrote: This removes restrictions in DOM cprop_operand that inhibit some optimizations. The volatile pointer thing is really realy old and no longer necessary while the loop-depth consideration is only valid

Re: [PATCH] Fix parts of PR61607

2014-06-26 Thread Richard Biener
On Thu, 26 Jun 2014, Richard Biener wrote: On Wed, 25 Jun 2014, Jeff Law wrote: On 06/25/14 08:05, Richard Biener wrote: This removes restrictions in DOM cprop_operand that inhibit some optimizations. The volatile pointer thing is really realy old and no longer necessary while

Re: [PATCH] Fix parts of PR61607

2014-06-26 Thread Richard Biener
On Thu, 26 Jun 2014, Richard Biener wrote: On Thu, 26 Jun 2014, Richard Biener wrote: On Wed, 25 Jun 2014, Jeff Law wrote: On 06/25/14 08:05, Richard Biener wrote: This removes restrictions in DOM cprop_operand that inhibit some optimizations. The volatile pointer thing

[PATCH][match-and-simplify] Improve GENERIC code-gen

2014-06-26 Thread Richard Biener
This re-structues GENERIC code to the suggested switch-stmt use which ideally should behave sanely wrt backtracking now (fingers crossing - we don't have any testcases yet excercising the GENERIC code-path). Installed. Richard. 2014-06-26 Richard Biener rguent...@suse.de

Re: [GSoC][match-and-simplify] factor gimple expressions and builtin functions

2014-06-26 Thread Richard Biener
On Thu, Jun 26, 2014 at 11:43 AM, Richard Biener richard.guent...@gmail.com wrote: On Thu, Jun 26, 2014 at 10:11 AM, Prathamesh Kulkarni bilbotheelffri...@gmail.com wrote: This patch factors expression checking for GIMPLE. Generates code as: if (TREE_CODE (opname) == SSA_NAME) { gimple

Re: [PATCH] Fix vector rotate regression (PR tree-optimization/57233)

2014-06-26 Thread Richard Biener
int *) a, (unsigned int *) g, 4, 0, 5); + check ((unsigned int *) c, (unsigned int *) h, 8, 0, 5); + check ((unsigned int *) e, (unsigned int *) j, 16, 0, 5); + return 0; +} Jakub -- Richard Biener rguent...@suse.de SUSE / SUSE Labs SUSE LINUX Products GmbH - Nuernberg - AG

[PATCH][match-and-simplify] Restore bootstrap

2014-06-26 Thread Richard Biener
We've accumulated some warnings - fixed below. Richard. 2014-06-26 Richard Biener rguent...@suse.de * genmatch.c (c_expr::gen_transform): Fix unused parameter. (dt_simplify::gen_gimple): Mark captures as possibly unused. (dt_simplify::gen_generic): Likewise

Re: [PATCH] Devirtualization dump functions fix

2014-06-26 Thread Richard Biener
On Thu, Jun 26, 2014 at 3:01 PM, Martin Liška mli...@suse.cz wrote: Hello, I encountered similar issue to PR ipa/61462 where location_t locus = gimple_location (e-call_stmt) is called for e-call_stmt == NULL (Firefox with -flto -fdump-ipa-devirt). So that, I decided to introduce new

Re: [PATCH] Devirtualization dump functions fix

2014-06-26 Thread Richard Biener
On Thu, Jun 26, 2014 at 3:43 PM, Martin Liška mli...@suse.cz wrote: On 06/26/2014 03:20 PM, Richard Biener wrote: On Thu, Jun 26, 2014 at 3:01 PM, Martin Liška mli...@suse.cz wrote: Hello, I encountered similar issue to PR ipa/61462 where location_t locus = gimple_location (e-call_stmt

Re: [RFC PATCH] -fsanitize=nonnull and -fsanitize=returns-nonnull support

2014-06-27 Thread Richard Biener
ArgNo) + +struct NonNullRetData { + SourceLocation Loc; +}; + +/// \brief Handle returning null from function with returns_nonnull attribute. +RECOVERABLE(nonnull_return, NonNullRetData *Data) + } #endif // UBSAN_HANDLERS_H Jakub -- Richard Biener rguent...@suse.de

Re: [PATCH] Devirtualization dump functions fix

2014-06-27 Thread Richard Biener
On Thu, Jun 26, 2014 at 5:58 PM, Martin Liška mli...@suse.cz wrote: On 06/26/2014 04:29 PM, Jakub Jelinek wrote: On Thu, Jun 26, 2014 at 04:27:49PM +0200, Martin Liška wrote: Well yes - it is of course similar broken in spirit but at least a lot simpler ;) I'd put a comment there why we do

Re: [PATCH] Fix PR61306: improve handling of sign and cast in bswap

2014-06-27 Thread Richard Biener
On Fri, Jun 27, 2014 at 4:29 AM, Thomas Preud'homme thomas.preudho...@arm.com wrote: From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- ow...@gcc.gnu.org] On Behalf Of Thomas Preud'homme Sent: Thursday, June 19, 2014 1:36 PM Richard, given this issue, I think we should wait a few more

Re: Optimize type streaming

2014-06-27 Thread Richard Biener
On Fri, 27 Jun 2014, Jan Hubicka wrote: Hi, the most common types of tree nodes streamed are declarations (5.4M for Firefox) and types (4.2M for Firefox). This patch makes representation of types smaller by avoiding saving redundent info about type and its variants. About 50% of types are

Re: [PATCH] Fix undefined behavior in ira-build.c

2014-06-27 Thread Richard Biener
On Fri, Jun 27, 2014 at 9:16 AM, Jakub Jelinek ja...@redhat.com wrote: Hi! This fixes the most common source of the new runtime diagnostics during bootstrap-ubsan, if num is 0, ira_object_id_map is often 0 as well. Ok for trunk/4.9? If it's also sometimes 1 then why not if (num 1) - just

Re: Don't use create_tmp_var for static vars

2014-06-27 Thread Richard Biener
On Fri, Jun 27, 2014 at 10:55 AM, Tobias Burnus tobias.bur...@physik.fu-berlin.de wrote: Bernd Schmidt wrote: I discovered that create_tmp_var is used in the gfortran frontend to create static variables. IMO the function is not intended to do this, and it causes problems for a modification I

[PATCH] Remove bswap STRICT_ALING target limitation

2014-06-27 Thread Richard Biener
. 2014-06-27 Richard Biener rguent...@suse.de * tree-ssa-math-opts.c (bswap_replace): Fix SLOW_UNALIGNED_ACCESS test to only apply to unaligned object. Index: gcc/tree-ssa-math-opts.c === --- gcc/tree-ssa-math-opts.c

Re: [PATCH][RFC] Fix PR61473, inline small memcpy/memmove during tree opts

2014-06-27 Thread Richard Biener
On Thu, 12 Jun 2014, Jeff Law wrote: On 06/12/14 04:12, Richard Biener wrote: This implements the requested inlining of memmove for possibly overlapping arguments by doing first all loads and then all stores. The easiest place is to do this in memory op folding where we already

Re: [PATCH][RFC] Fix PR61473, inline small memcpy/memmove during tree opts

2014-06-27 Thread Richard Biener
On Fri, 27 Jun 2014, Jakub Jelinek wrote: On Fri, Jun 27, 2014 at 01:49:38PM +0200, Richard Biener wrote: I'm going to go for a single load/store and MOVE_MAX for now - I have quite some fallout to deal with anyway (analyzed strlenopt-1.c FAIL only, the other strlenopt cases are probably

Re: [PATCH] Remove bswap STRICT_ALING target limitation

2014-06-27 Thread Richard Biener
On June 27, 2014 2:50:33 PM CEST, Rainer Orth r...@cebitec.uni-bielefeld.de wrote: Richard Biener rguent...@suse.de writes: The following patch enables bswap-from-load for STRICT_ALIGNMENT targets when the load is aligned instead of unconditionally (which probably was not intended). (note

Re: Optimize type streaming

2014-06-30 Thread Richard Biener
On June 29, 2014 9:53:03 PM CEST, Jan Hubicka hubi...@ucw.cz wrote: In addition of pr61644 and pr61646, this commit breaks a lot of fortran tests with -flto -O0. Hello, the problem here is that we have POINTER_TYPE that points to array of variable length (not sure why it happens only with -O0).

Re: [PATCH] Don't run guality.exp tests with LTO_TORTURE_OPTIONS.

2014-07-03 Thread Richard Biener
On July 3, 2014 1:06:30 AM CEST, Jason Merrill ja...@redhat.com wrote: I think that makes sense; I'm not aware of anyone working on improving LTO debugging. I've done that in the past. So it would be nice to verify we don't regress existing tests. Richard. Jason

Re: [PATCH] Don't run guality.exp tests with LTO_TORTURE_OPTIONS.

2014-07-03 Thread Richard Biener
On July 3, 2014 7:37:13 AM CEST, Jakub Jelinek ja...@redhat.com wrote: On Wed, Jul 02, 2014 at 04:06:30PM -0700, Jason Merrill wrote: I think that makes sense; I'm not aware of anyone working on improving LTO debugging. I think at this point all we care about is that with -flto we don't ICE on

Re: [PATCH] Don't run guality.exp tests with LTO_TORTURE_OPTIONS.

2014-07-03 Thread Richard Biener
On July 3, 2014 9:55:36 AM CEST, Jakub Jelinek ja...@redhat.com wrote: On Thu, Jul 03, 2014 at 09:41:15AM +0200, Richard Biener wrote: On July 3, 2014 7:37:13 AM CEST, Jakub Jelinek ja...@redhat.com wrote: On Wed, Jul 02, 2014 at 04:06:30PM -0700, Jason Merrill wrote: I think that makes sense

Re: [PATCH] Don't run guality.exp tests with LTO_TORTURE_OPTIONS.

2014-07-03 Thread Richard Biener
On July 3, 2014 8:38:14 PM CEST, Jakub Jelinek ja...@redhat.com wrote: On Thu, Jul 03, 2014 at 08:37:07PM +0200, Richard Biener wrote: Well, simply removing the regression testing for LTO is a maintainance nightmare as well. The guality testsuite is very noisy anyway with all the xfail

Re: [PATCH] Don't run guality.exp tests with LTO_TORTURE_OPTIONS.

2014-07-04 Thread Richard Biener
On July 3, 2014 10:47:52 PM CEST, Mark Wielaard m...@redhat.com wrote: On Thu, 2014-07-03 at 22:14 +0200, Jakub Jelinek wrote: On Thu, Jul 03, 2014 at 10:04:35PM +0200, Mark Wielaard wrote: On Thu, 2014-07-03 at 21:52 +0200, Richard Biener wrote: On July 3, 2014 8:38:14 PM CEST, Jakub

Re: [PATCH] Fix ICE with thunks (PR middle-end/61654)

2014-07-04 Thread Richard Biener
On July 3, 2014 8:47:36 PM CEST, Jakub Jelinek ja...@redhat.com wrote: Hi! update_ssa that expand_thunk calls, if it needs to change anything, computes CDI_DOMINATORS, but we assert that dominators are not computed when we release e.g. an unused thunk. Fixed thusly, bootstrapped/regtested on

Re: [PATCH] Fix recognize_single_bit_test (PR tree-optimization/61684)

2014-07-04 Thread Richard Biener
On July 3, 2014 8:44:28 PM CEST, Jakub Jelinek ja...@redhat.com wrote: Hi! The rhs1 of CONVERT_EXPR_CODE_P doesn't have to be a SSA_NAME, can be e.g. invariant like ADDR_EXPR of a var, but ifcombine didn't think about that possibility. Fixed thusly, bootstrapped/regtested on x86_64-linux and

Re: [PATCH] Fix arrays in rtx.u + add minor rtx verification

2014-07-05 Thread Richard Biener
On July 4, 2014 10:50:01 PM CEST, Jakub Jelinek ja...@redhat.com wrote: On Mon, Jun 23, 2014 at 04:40:43PM +0200, Richard Biener wrote: Can we instead refactor expmed.c to avoid allocating rtx_def directly? Like by using rtx in init_expmed_rtl and allocating from an obstack (or not care and GC

Re: [PATCH] Fix gennews

2014-07-07 Thread Richard Biener
On Sun, 29 Jun 2014, Gerald Pfeifer wrote: On Thu, 12 Jun 2014, Richard Biener wrote: It seems the https transition broke refering to permanently moved URL gcc-3.0/gcc-3.0.html (I get a certificate error or some such), breaking gennews and thus gcc_release. Fixed like below which makes

Re: Optimize type streaming

2014-07-07 Thread Richard Biener
, len, scc_entry_len, scc_hash)) continue; /* Do remaining fixup tasks for prevailing nodes. */ bool seen_type = false; for (unsigned i = 0; i len; ++i) { -- Richard Biener rguent...@suse.de SUSE / SUSE Labs SUSE LINUX Products GmbH

Re: Optimize type streaming

2014-07-07 Thread Richard Biener
On Mon, 30 Jun 2014, Jan Hubicka wrote: Please revert the original patch instead which was not tested properly. I'll get back to this after I return from vacation. OK, I will bootstrap and revert tomorrow morning. Note that testusite passes with the patch; the problem appears only

Re: Optimize type streaming

2014-07-07 Thread Richard Biener
On Mon, 30 Jun 2014, Dominique Dhumieres wrote: Note that testusite passes with the patch; ... Confirmed. There is a typo s/fileds/fields/ I have seen the failures because I now run the gfortran testsuite with the addition of '-g -flto'. Is it worth pushing in this direction? Yes. It

Re: [PATCH] Don't run guality.exp tests with LTO_TORTURE_OPTIONS.

2014-07-07 Thread Richard Biener
On Thu, 3 Jul 2014, Jakub Jelinek wrote: On Thu, Jul 03, 2014 at 09:41:15AM +0200, Richard Biener wrote: On July 3, 2014 7:37:13 AM CEST, Jakub Jelinek ja...@redhat.com wrote: On Wed, Jul 02, 2014 at 04:06:30PM -0700, Jason Merrill wrote: I think that makes sense; I'm not aware of anyone

Re: Fix representation of gcov_info_type

2014-07-07 Thread Richard Biener
On Sat, Jun 28, 2014 at 8:22 PM, Jan Hubicka hubi...@ucw.cz wrote: Hi, This is first bug noticed by the type consistency checks I added. gcov_info_type is a structure that contains function pointer to itself. While building it we first build a structure w/o size and fields, then we build a

Re: Fix ipa-devirt WRT type variants

2014-07-07 Thread Richard Biener
On Sat, Jun 28, 2014 at 8:26 PM, Jan Hubicka hubi...@ucw.cz wrote: Hi, this is another bug noticed. Here ipa-devirt attempts to merge binfos of two representations of the same ODR type, but forgets about variants. I also noticed that using variant instead of the type may end up in

Re: [wwwdocs] Migrate http://gcc.gnu.org/bugzilla/buglist.cgi to https

2014-07-07 Thread Richard Biener
On Sat, Jun 28, 2014 at 10:38 PM, Gerald Pfeifer ger...@pfeifer.com wrote: Applied. Richi, Jakub, I noticed that you seem to have stopped including those with GCC 4.7 and later. Any particular reason? It appears useful to me. Are you sure? I can still see them in 4.7 changes.html and

Re: Fix duplication of TYPE_SIZE/TYPE_SIZE_UNIT of variadic array type variants

2014-07-07 Thread Richard Biener
On Sun, Jun 29, 2014 at 12:44 AM, Jan Hubicka hubi...@ucw.cz wrote: Hi, this patch fixes another problem where we manage to produce a variant of variadic array that has different TYPE_SIZE (but an equivalent expression). This happens because remap_type_1 blindly copies all expressions referred

Re: SRA: don't drop clobbers

2014-07-07 Thread Richard Biener
On Mon, Jun 30, 2014 at 1:38 AM, Marc Glisse marc.gli...@inria.fr wrote: Hello, with this patch on top of https://gcc.gnu.org/ml/gcc-patches/2014-06/msg02315.html we finally warn for the testcase of PR 60517. The new function is copied from init_subtree_with_zero right above. I guess it

Re: [tree-optimization/61607] Look through SSA_NAME_VALUE chains

2014-07-07 Thread Richard Biener
On Mon, Jun 30, 2014 at 8:56 AM, Jeff Law l...@redhat.com wrote: SSA_NAME_VALUE is, in effect, a chain of values. ie, it's possible for SSA_NAME_VALUE of any given SSA_NAME to refer to another SSA_NAME. Hmm, but it shouldn't as we walk in dominator order and should always do

Re: [PATCH, alpha]: Wrap {un,}aligned_store sequence with memory blockages.

2014-07-07 Thread Richard Biener
On Mon, Jun 30, 2014 at 5:54 PM, Richard Henderson r...@redhat.com wrote: On 06/29/2014 11:14 AM, Uros Bizjak wrote: if (MEM_READONLY_P (x)) +if (GET_CODE (mem_addr) == AND) + return 1; return 0; Certainly missing braces here. But with that fixed the patch looks plausible.

Re: [PATCH] remove useless unused attributes in i386 code

2014-07-07 Thread Richard Biener
On Thu, Jul 3, 2014 at 1:08 AM, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, So apparently its not entirely obvious to everyone that removing the names of unused arguments is the best way of dealing with warnings about unused arguments in places like hooks

Re: [PATCH] remove useless unused attributes in i386 code

2014-07-07 Thread Richard Biener
On Mon, Jul 7, 2014 at 11:45 AM, Richard Biene richard.guent...@gmail.com wrote: On Thu, Jul 3, 2014 at 1:08 AM, tsaund...@mozilla.com wrote: From: Trevor Saunders tsaund...@mozilla.com Hi, So apparently its not entirely obvious to everyone that removing the names of unused arguments is

Re: [PATCH PR61576]

2014-07-07 Thread Richard Biener
On Thu, Jul 3, 2014 at 2:39 PM, Yuri Rumyantsev ysrum...@gmail.com wrote: Ping! Ok. Thanks, Richard. 2014-06-24 13:37 GMT+04:00 Yuri Rumyantsev ysrum...@gmail.com: Hi All, Here is a fix for PR 61576 - additional test was added that block containing reduction statement is predecessor of

Re: [PATCH] Add guality [p]type test.

2014-07-07 Thread Richard Biener
On Thu, Jul 3, 2014 at 11:53 AM, Mark Wielaard m...@redhat.com wrote: Hi, I pulled out the guality.exp [p]type test extension from the actual dwarf2out.c changes (which I will repost soon with some tweaks). I think the test extension itself is useful on its own (and will use it to add tests

Re: update address taken: don't drop clobbers

2014-07-07 Thread Richard Biener
On Sun, Jul 6, 2014 at 4:23 PM, Marc Glisse marc.gli...@inria.fr wrote: On Mon, 30 Jun 2014, Jeff Law wrote: On 06/28/14 16:33, Marc Glisse wrote: In an earlier version of the patch, I was using get_or_create_ssa_default_def (cfun, sym); (I was reusing the same variable). This passed

[PATCH] Fix PR61681

2014-07-07 Thread Richard Biener
. 2014-07-07 Richard Biener rguent...@suse.de PR tree-optimization/61681 * tree-ssa-structalias.c (find_what_var_points_to): Expand NONLOCAL inside ESCAPED. * gcc.dg/torture/pr61681.c: New testcase. Index: gcc/tree-ssa-structalias.c

[PATCH] Fix PR61680

2014-07-07 Thread Richard Biener
The following fixes PR61680. Bootstrap and regtest running on x86_64-unknown-linux-gnu. Richard. 2014-07-07 Richard Biener rguent...@suse.de PR tree-optimization/61680 * tree-vect-data-refs.c (vect_analyze_data_ref_dependence): Handle properly all read-write

Re: [PATCH, alpha]: Wrap {un,}aligned_store sequence with memory blockages.

2014-07-07 Thread Richard Biener
On Mon, Jul 7, 2014 at 4:20 PM, Richard Henderson r...@redhat.com wrote: On 07/07/2014 02:10 AM, Richard Biener wrote: On Mon, Jun 30, 2014 at 5:54 PM, Richard Henderson r...@redhat.com wrote: On 06/29/2014 11:14 AM, Uros Bizjak wrote: if (MEM_READONLY_P (x)) +if (GET_CODE (mem_addr

Re: [PATCH, alpha]: Wrap {un,}aligned_store sequence with memory blockages.

2014-07-07 Thread Richard Biener
On Mon, Jul 7, 2014 at 4:34 PM, Richard Biener richard.guent...@gmail.com wrote: On Mon, Jul 7, 2014 at 4:20 PM, Richard Henderson r...@redhat.com wrote: On 07/07/2014 02:10 AM, Richard Biener wrote: On Mon, Jun 30, 2014 at 5:54 PM, Richard Henderson r...@redhat.com wrote: On 06/29/2014 11:14

  1   2   3   4   5   6   7   8   9   10   >