Re: [Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-10-01 Thread Liviu Andronic
On Thu, Sep 30, 2010 at 5:52 PM, Nick Treleaven nick.trelea...@btinternet.com wrote: I've now implemented this, but it was harder because you have to avoid recursion - opening a document closes an empty doc, but that triggered a new doc before the document was opened. Please test. r5271 seems

Re: [Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-09-30 Thread Nick Treleaven
On Fri, 24 Sep 2010 15:35:59 +0300 Liviu Andronic landronim...@gmail.com wrote: On Thu, Sep 23, 2010 at 7:37 PM, Nick Treleaven nick.trelea...@btinternet.com wrote: * new_document_after_close=true under [geany] in geany.conf. I'm really nitpicking now, but is there a reason that the

Re: [Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-09-24 Thread Nick Treleaven
On Thu, 23 Sep 2010 21:18:11 +0300 Liviu Andronic landronim...@gmail.com wrote: ..if a single _untitled_ tab is displayed. This is the way Opera handles it, and that the behaviour that I find ergonomic in this case; it allows to close the last titled document tab without the need to close

Re: [Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-09-24 Thread Liviu Andronic
On Thu, Sep 23, 2010 at 7:37 PM, Nick Treleaven nick.trelea...@btinternet.com wrote: * new_document_after_close=true under [geany] in geany.conf. I'm really nitpicking now, but is there a reason that the following two actions are visually different, when a last empty tab is present: - close last

Re: [Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-09-23 Thread Liviu Andronic
Hello Nick On Thu, Sep 23, 2010 at 7:37 PM, Nick Treleaven nick.trelea...@btinternet.com wrote: ..if a single _untitled_ tab is displayed. This is the way Opera handles it, and that the behaviour that I find ergonomic in this case; it allows to close the last titled document tab without the

Re: [Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-09-22 Thread Jiří Techet
On Wed, Sep 22, 2010 at 02:34, Colomban Wendling lists@herbesfolles.org wrote: Le 22/09/2010 02:20, Erik de Castro Lopo a écrit : Nick Treleaven wrote: So closing the last new document doesn't create a new document straight away? Correct. Are you sure you're running current SVN?

Re: [Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-09-22 Thread Erik de Castro Lopo
Liviu Andronic wrote: Personally I tend to prefer having the tabbar displayed at all times, in most tabbed apps. +1 ..if a single _untitled_ tab is displayed. This is the way Opera handles it, and that the behaviour that I find ergonomic in this case; it allows to close the last titled

Re: [Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-09-21 Thread Nick Treleaven
On Tue, 21 Sep 2010 08:51:30 +1000 Erik de Castro Lopo mle+to...@mega-nerd.com wrote: When opening a project file with project sessions enabled, the first tab is always a new document, which shouldn't be there. Now committed a change with the idle callback. Unfortunately, this does

Re: [Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-09-21 Thread Liviu Andronic
On Tue, Sep 21, 2010 at 7:54 PM, Nick Treleaven nick.trelea...@btinternet.com wrote: Gedit (2.20) does not do this. Do you have examples of a text editing app with this behaviour? At least jEdit always keeps an untitled document open. Liviu ___

Re: [Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-09-21 Thread Frank Lanitz
On Tue, 21 Sep 2010 17:54:36 +0100 Nick Treleaven nick.trelea...@btinternet.com wrote: On Tue, 21 Sep 2010 08:51:30 +1000 Erik de Castro Lopo mle+to...@mega-nerd.com wrote: With this patch applied geany also has the same look after the last tab is closed as when geany is run without any

Re: [Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-09-21 Thread Erik de Castro Lopo
Nick Treleaven wrote: So closing the last new document doesn't create a new document straight away? Correct. Are you sure you're running current SVN? Absolutely. I have checked. Twice. Anyway, Frank Lanitz has asked for a pref for this and personally I don't really like the behaviour.

Re: [Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-09-21 Thread Colomban Wendling
Le 22/09/2010 02:20, Erik de Castro Lopo a écrit : Nick Treleaven wrote: So closing the last new document doesn't create a new document straight away? Correct. Are you sure you're running current SVN? Absolutely. I have checked. Twice. For me it works perfectly well (SVN r5250). I

Re: [Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-09-20 Thread Nick Treleaven
On Sun, 19 Sep 2010 18:46:47 +1000 Erik de Castro Lopo mle+to...@mega-nerd.com wrote: Well, the responses are all positive. But I don't think that keybindings.c is the best place for this code. What about writing it as an idle callback from document_remove_page?

Re: [Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-09-20 Thread Erik de Castro Lopo
Nick Treleaven wrote: When opening a project file with project sessions enabled, the first tab is always a new document, which shouldn't be there. Now committed a change with the idle callback. Unfortunately, this does work. With this version, closing the last document does not create a new

Re: [Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-09-19 Thread Erik de Castro Lopo
Erik de Castro Lopo wrote: Nick Treleaven wrote: On Thu, 16 Sep 2010 08:32:05 +1000 Erik de Castro Lopo mle+to...@mega-nerd.com wrote: Well, the responses are all positive. But I don't think that keybindings.c is the best place for this code. What about writing it as an

Re: [Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-09-16 Thread Erik de Castro Lopo
Nick Treleaven wrote: On Thu, 16 Sep 2010 08:32:05 +1000 Erik de Castro Lopo mle+to...@mega-nerd.com wrote: Well, the responses are all positive. But I don't think that keybindings.c is the best place for this code. What about writing it as an idle callback from

Re: [Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-09-15 Thread Nick Treleaven
On Tue, 14 Sep 2010 18:03:52 +1000 Erik de Castro Lopo mle+to...@mega-nerd.com wrote: Currently, when closing the last tab, I get a geany window without any text area. The attached patch fixes that, by creating a new untitled document when the last tab is closed. I've been running with this

Re: [Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-09-15 Thread Erik de Castro Lopo
Nick Treleaven wrote: Well, the responses are all positive. But I don't think that keybindings.c is the best place for this code. What about writing it as an idle callback from document_remove_page? Actually, doesn't even need a callback. Attached patch moves the code I initially had in

Re: [Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-09-15 Thread Erik de Castro Lopo
Erik de Castro Lopo wrote: Nick Treleaven wrote: Well, the responses are all positive. But I don't think that keybindings.c is the best place for this code. What about writing it as an idle callback from document_remove_page? Actually, doesn't even need a callback. Attached patch

[Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-09-14 Thread Erik de Castro Lopo
Hi all, Currently, when closing the last tab, I get a geany window without any text area. The attached patch fixes that, by creating a new untitled document when the last tab is closed. I've been running with this patch for over a week. Cheers, Erik --

Re: [Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-09-14 Thread Liviu Andronic
On Tue, Sep 14, 2010 at 2:23 PM, Nick Treleaven nick.trelea...@btinternet.com wrote: The attached patch fixes that, by creating a new untitled document when the last tab is closed. I've been running with this patch for over a week. Personally I'm not sure about this, see what others think.

Re: [Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-09-14 Thread Nick Treleaven
On Tue, 14 Sep 2010 18:03:52 +1000 Erik de Castro Lopo mle+to...@mega-nerd.com wrote: Currently, when closing the last tab, I get a geany window without any text area. The attached patch fixes that, by creating a new untitled document when the last tab is closed. I've been running with this

Re: [Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-09-14 Thread Oliver Krystal
On 9/14/2010 6:23 AM, Nick Treleaven wrote: On Tue, 14 Sep 2010 18:03:52 +1000 Erik de Castro Lopomle+to...@mega-nerd.com wrote: Currently, when closing the last tab, I get a geany window without any text area. The attached patch fixes that, by creating a new untitled document when the

Re: [Geany-devel] [Patch] : On closing the last tab create new untitled document.

2010-09-14 Thread Erik de Castro Lopo
Nick Treleaven wrote: On Tue, 14 Sep 2010 18:03:52 +1000 Erik de Castro Lopo mle+to...@mega-nerd.com wrote: Currently, when closing the last tab, I get a geany window without any text area. The attached patch fixes that, by creating a new untitled document when the last tab is