Re: [Geany-devel] Empty project properties dialog

2012-02-22 Thread Dimitar Zhekov
On Tue, 21 Feb 2012 23:25:02 +0100 Jiří Techet tec...@gmail.com wrote: Hi Dimitar, have a look at the attached patch - I've added the signal but as I don't know exactly when you need to emit it, you'll probably need to modify it. Also I haven't documented the signal as I still don't

Re: [Geany-devel] Empty project properties dialog

2012-02-21 Thread Dimitar Zhekov
On Mon, 20 Feb 2012 22:40:50 +0100 Jiří Techet tec...@gmail.com wrote: On Mon, Feb 20, 2012 at 17:51, Dimitar Zhekov dimitar.zhe...@gmail.com wrote: Since you are changing the project signals anyway, can you do me a favor and add an unconditional project-before-save signal in

Re: [Geany-devel] Empty project properties dialog

2012-02-21 Thread Jiří Techet
On Tue, Feb 21, 2012 at 19:23, Dimitar Zhekov dimitar.zhe...@gmail.com wrote: On Mon, 20 Feb 2012 22:40:50 +0100 Jiří Techet tec...@gmail.com wrote: On Mon, Feb 20, 2012 at 17:51, Dimitar Zhekov dimitar.zhe...@gmail.com wrote: Since you are changing the project signals anyway, can you do

Re: [Geany-devel] Empty project properties dialog

2012-02-20 Thread Dimitar Zhekov
Hi, Jiří, On Mon, 20 Feb 2012 00:35:24 +0100 Jiří Techet tec...@gmail.com wrote: I've created new pull request with the changes here: https://github.com/geany/geany/pull/25 Since you are changing the project signals anyway, can you do me a favor and add an unconditional project-before-save

Re: [Geany-devel] Empty project properties dialog

2012-02-20 Thread Jiří Techet
On Mon, Feb 20, 2012 at 17:51, Dimitar Zhekov dimitar.zhe...@gmail.com wrote: Hi, Jiří, On Mon, 20 Feb 2012 00:35:24 +0100 Jiří Techet tec...@gmail.com wrote: I've created new pull request with the changes here: https://github.com/geany/geany/pull/25 Since you are changing the project

Re: [Geany-devel] Empty project properties dialog

2012-02-19 Thread Jiří Techet
On Sat, Jan 14, 2012 at 21:16, Jiří Techet tec...@gmail.com wrote: On Fri, Jan 13, 2012 at 22:57, Lex Trotman ele...@gmail.com wrote: On Sat, Jan 14, 2012 at 3:12 AM, Matthew Brush mbr...@codebrainz.ca wrote: On 01/13/2012 03:31 AM, Lex Trotman wrote: [...] What if we deprecate the old

Re: [Geany-devel] Empty project properties dialog

2012-02-19 Thread Jiří Techet
On Sun, Feb 19, 2012 at 17:57, Jiří Techet tec...@gmail.com wrote: On Sat, Jan 14, 2012 at 21:16, Jiří Techet tec...@gmail.com wrote: On Fri, Jan 13, 2012 at 22:57, Lex Trotman ele...@gmail.com wrote: On Sat, Jan 14, 2012 at 3:12 AM, Matthew Brush mbr...@codebrainz.ca wrote: On 01/13/2012

Re: [Geany-devel] Empty project properties dialog

2012-01-14 Thread Jiří Techet
On Fri, Jan 13, 2012 at 22:57, Lex Trotman ele...@gmail.com wrote: On Sat, Jan 14, 2012 at 3:12 AM, Matthew Brush mbr...@codebrainz.ca wrote: On 01/13/2012 03:31 AM, Lex Trotman wrote: [...] What if we deprecate the old project create/confirm API altogether, add the project preferences

Re: [Geany-devel] Empty project properties dialog

2012-01-13 Thread Lex Trotman
[...] What if we deprecate the old project create/confirm API altogether, add the project preferences dialog to GeanyMainWidgets structure, and just let plugins use the response, hide and show signals on it as a normal GtkDialog? Sounds fine to my limited understanding. This wasn't

Re: [Geany-devel] Empty project properties dialog

2012-01-13 Thread Matthew Brush
On 01/13/2012 03:31 AM, Lex Trotman wrote: [...] What if we deprecate the old project create/confirm API altogether, add the project preferences dialog to GeanyMainWidgets structure, and just let plugins use the response, hide and show signals on it as a normal GtkDialog? Sounds fine to my

Re: [Geany-devel] Empty project properties dialog

2012-01-12 Thread Lex Trotman
[...] There was no change in documented functions, signals or behaviour AFAIK. Ok, if the functionality used is not *documented* to be in the API then it is not protected, but, as the change in behaviour is going to require a change in the plugin interface an API bump will happen by default.

Re: [Geany-devel] Empty project properties dialog

2012-01-12 Thread Lex Trotman
[...] Nope, plugins can add their notebook page during the `project_dialog_create` signal and remove it during the `project_dialog_confirmed` signal, nothing changed here I don't think. So the project_dialog_create actually means dialog open, in which case we probably should change the

Re: [Geany-devel] Empty project properties dialog

2012-01-12 Thread Matthew Brush
On 01/12/2012 04:12 PM, Jiří Techet wrote: On Thu, Jan 12, 2012 at 16:51, Matthew Brushmbr...@codebrainz.ca wrote: On 01/12/2012 01:44 AM, Lex Trotman wrote: [...] There was no change in documented functions, signals or behaviour AFAIK. Ok, if the functionality used is not *documented*

Re: [Geany-devel] Empty project properties dialog

2012-01-11 Thread Jiří Techet
On Mon, Jan 9, 2012 at 01:05, Matthew Brush mbr...@codebrainz.ca wrote: On 12/26/2011 01:37 PM, Jiří Techet wrote: Hi, I'm experiencing a bug where the project properties dialog is empty when opened for the second time. Steps to reproduce: 1. Open project properties dialog. 2. Close it.

Re: [Geany-devel] Empty project properties dialog

2012-01-11 Thread Matthew Brush
On 01/11/2012 04:11 PM, Jiří Techet wrote: On Mon, Jan 9, 2012 at 01:05, Matthew Brushmbr...@codebrainz.ca wrote: On 12/26/2011 01:37 PM, Jiří Techet wrote: Hi, I'm experiencing a bug where the project properties dialog is empty when opened for the second time. Steps to reproduce: 1. Open

Re: [Geany-devel] Empty project properties dialog

2012-01-11 Thread Lex Trotman
On Thu, Jan 12, 2012 at 1:25 PM, Matthew Brush mbr...@codebrainz.ca wrote: On 01/11/2012 04:11 PM, Jiří Techet wrote: On Mon, Jan 9, 2012 at 01:05, Matthew Brushmbr...@codebrainz.ca  wrote: On 12/26/2011 01:37 PM, Jiří Techet wrote: Hi, I'm experiencing a bug where the project properties

Re: [Geany-devel] Empty project properties dialog

2012-01-11 Thread Matthew Brush
On 01/11/2012 11:10 PM, Lex Trotman wrote: On Thu, Jan 12, 2012 at 1:25 PM, Matthew Brushmbr...@codebrainz.ca wrote: On 01/11/2012 04:11 PM, Jiří Techet wrote: On Mon, Jan 9, 2012 at 01:05, Matthew Brushmbr...@codebrainz.cawrote: On 12/26/2011 01:37 PM, Jiří Techet wrote: Hi, I'm

Re: [Geany-devel] Empty project properties dialog

2012-01-08 Thread Matthew Brush
On 12/26/2011 01:37 PM, Jiří Techet wrote: Hi, I'm experiencing a bug where the project properties dialog is empty when opened for the second time. Steps to reproduce: 1. Open project properties dialog. 2. Close it. 3. Open it for the second time. Result: the project properties dialog is much

Re: [Geany-devel] Empty project properties dialog

2012-01-01 Thread Matthew Brush
On 12/26/2011 01:37 PM, Jiří Techet wrote: Hi, I'm experiencing a bug where the project properties dialog is empty when opened for the second time. Steps to reproduce: 1. Open project properties dialog. 2. Close it. 3. Open it for the second time. Result: the project properties dialog is much

Re: [Geany-devel] Empty project properties dialog

2011-12-26 Thread Matthew Brush
On 12/26/2011 01:37 PM, Jiří Techet wrote: Hi, I'm experiencing a bug where the project properties dialog is empty when opened for the second time. Steps to reproduce: 1. Open project properties dialog. 2. Close it. 3. Open it for the second time. Result: the project properties dialog is much