Re: [Geeqie-devel] Crashes with LCMS2 patch
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi Michael, Am Di den 17. Jun 2014 um 12:24 schrieb Michael Schwendt: This results in unprintable strings that can crash g_markup, because these profile IDs are based on MD5. Even with LCMS1 unpatched, Geeqie could not print such a Screen profile name and warned about it in terminal output (probably causing a crash in special cases, too). Thanks for your patch. I marked your mail for review but only came to it back after finding that problem in the new released debian version. I was never able to see the crash so I never got into checking it. Now the fix is included in geeqie and will be in the next release for debian too. Regards Klaus - -- Klaus Ethgen http://www.ethgen.ch/ pub 4096R/4E20AF1C 2011-05-16 Klaus Ethgen kl...@ethgen.de Fingerprint: 85D4 CA42 952C 949B 1753 62B3 79D0 B06F 4E20 AF1C -BEGIN PGP SIGNATURE- Version: GnuPG v1 iQGcBAEBCgAGBQJUJp83AAoJEKZ8CrGAGfasuDQL/173+V0lETCo19FgiscHIiR2 CyzYKyPdHMj9TsCpIt1tcjJy7BDp93zLwOWYZS+Y57rCXrwx03KJGosU/EpLss7O UfLjmqlKGmj4PbblpM1jaY7uSSMgoCNphqB3VNj9rkWFjshSdTM+BI/YSUG6WoxG gQE+EoS0xbS2UyKisz/BcjHCJH7wA97TWJi9xpq/gHW+S3dSZXrSLSLN9sQzHWRw O1x3RNclb5c2vsMqAV1u/oBvUPeis+I4uQ2wEiKb5asa+DOv0CYCMUrwDutvPXzT BZ1TsuII5/lMO0LY1hac2ECGDkQJduNt6Eu9wXQjvFDjzS5HEPLbWW31K59NLLkU ziXlrHywRO6HUzvVmqq1nrvyG1lQYAUgZjlrtX7tNaXvuQwnih9qfDPJUq19bdJ1 Ix5g50dX4vhx2XT/nFqKt30MzV8o0LjrH/txa7WwtVxPWcet/qhewUnsFMFdm1Gj L39xh/3/ydCAEQ1+3mZ0R9UXB1Hv6uxRgNGrzFSxGw== =aN/y -END PGP SIGNATURE- -- Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://pubads.g.doubleclick.net/gampad/clk?id=154622311iu=/4140/ostg.clktrk ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
[Geeqie-devel] Crashes with LCMS2 patch
Hello everyone! The patch for LCMS2 support that has been published on this list does the following to generate the tooltip texts for Image profile and Screen profile: cmsUInt8Number profileID[17]; profileID[16] = '\0'; cmsGetHeaderProfileID(profile, profileID); return g_strdup(profileID); This results in unprintable strings that can crash g_markup, because these profile IDs are based on MD5. Even with LCMS1 unpatched, Geeqie could not print such a Screen profile name and warned about it in terminal output (probably causing a crash in special cases, too). One safer way to retrieve printable image/screen profile names is this: cmsUInt32Number r; char buffer[20]; buffer[0] = '\0'; r = cmsGetProfileInfoASCII(profile, cmsInfoDescription, en, US, buffer, 20); return g_strdup(buffer); Find the full revised patch at: http://mschwendt.fedorapeople.org/geeqie-1.1-lcms2.patch -- HPCC Systems Open Source Big Data Platform from LexisNexis Risk Solutions Find What Matters Most in Your Big Data with HPCC Systems Open Source. Fast. Scalable. Simple. Ideal for Dirty Data. Leverages Graph Analysis for Fast Processing Easy Data Exploration http://p.sf.net/sfu/hpccsystems ___ Geeqie-devel mailing list Geeqie-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/geeqie-devel
