On Sun, 17 Apr 2016 17:09:49 +0100
Colin Clark wrote:
> Hi Jonathan
>
> It looks to me that the user doesn't get notified that part of the
> DnD has failed.
>
> Would it be better to perhaps include something like:
>
> warning_dialog(_("Drag and Drop failed"), "some text",
> GTK_STOCK_DIALOG
On Sun, 17 Apr 2016 17:09:49 +0100
Colin Clark wrote:
> Sorry, but I cannot test here this because I cannot replicate that
> fault on my system.
I'm using Fluxbox rather than a full Desktop Environment; maybe that
has something to do with it?
---
Dragged and dropped paths from xfe aren't escaped like paths from a gtk
app. A folder named 'test # one' for example causes g_filename_from_uri
to fail and return NULL, which then causes a SIGSEGV in path_to_utf8.
This patch fixes the crash by checking for failed conversions. If
conversion failed
Changes since v1: This version pops up a dialog to notify the user that
there was an error in the drag and drop operation.
Since warning_dialog() is non-modal, and there's no upper limit to the
number of problematic URIs, uri_pathlist_from_uris() will accumulate and
return a list of URIs that fail
On Mon, 18 Apr 2016 17:39:23 -0700
Jonathan Boeing wrote:
> diff --git a/src/ui_bookmark.c b/src/ui_bookmark.c
> index 842b947..18f7311 100644
> --- a/src/ui_bookmark.c
> +++ b/src/ui_bookmark.c
> @@ -707,13 +707,19 @@ static void bookmark_dnd_get_data(GtkWidget
> *widget, {
> BookMarkData
