On 11/24/2010 12:58 PM, Martin Nordholts wrote:
On 11/23/2010 05:00 AM, Patrick Horgan wrote:
On 11/16/2010 11:22 AM, Martin Nordholts wrote:
Hi
The patch doesn't apply cleanly for me (sorry for messy formating):
Sorry about that. I think I may know why, I was two checkins away from
trunk
On 11/16/2010 11:22 AM, Martin Nordholts wrote:
Hi
The patch doesn't apply cleanly for me (sorry for
messy formating):
Sorry about that. I think I may know why, I was two
checkins away from trunk and the patch only reflected
one. This one should apply, but if not please let me know.
On 11/09/2010 10:32 PM, Martin Nordholts wrote:
Thanks! A few comments:
On 11/10/2010 02:02 AM, Patrick Horgan wrote:
+ if(fread (header, 1, 8, infile)!=8)
No magic numbers please, use a define for at least 8
Ok, I use a const size_t now.
+ g_warning (%s is not a valid png file,
Just feeling my way in here, and it seemed an easy fix
to get rid of a warning that uncovered an error. fread
return value was being ignored when checking header of
a png file, and if the file was truncated it would have
caused other errors. Better to catch the error and
abort then instead
Thanks! A few comments:
On 11/10/2010 02:02 AM, Patrick Horgan wrote:
+ if(fread (header, 1, 8, infile)!=8)
No magic numbers please, use a define for at least 8
+ g_warning (%s is not a valid png file, path);
You should give a more detailed error message than just is not valid
+
5 matches
Mail list logo
