Re: [Gegl-developer] various blurs

2011-01-31 Thread Martin Nordholts
On 01/26/2011 09:08 PM, andy gill wrote: I've redone the patches for the box-blur and pixelise filters to include tests. the patches now total 300k however, what's the preferred method of submitting them? Put them in bugzilla please, that way it's easy to find them when one looks for them.

Re: [Gegl-developer] various blurs

2011-01-26 Thread andy gill
I've redone the patches for the box-blur and pixelise filters to include tests. the patches now total 300k however, what's the preferred method of submitting them? On 19 January 2011 10:39, Øyvind Kolås pip...@gimp.org wrote: On Wed, Jan 19, 2011 at 10:29 AM, andy gill andygg...@gmail.com

Re: [Gegl-developer] various blurs

2011-01-19 Thread andy gill
Could you explain how the tests work, it's not obvious to me what I need to add. Do the tests make sure that the results match a reference image in some way? As for the alternative gaussian implementation, it was not my intention that we should keep both, only that interested parties may wish to

Re: [Gegl-developer] various blurs

2011-01-19 Thread Øyvind Kolås
On Wed, Jan 19, 2011 at 10:29 AM, andy gill andygg...@gmail.com wrote: Could you explain how the tests work, it's not obvious to me what I need to add. Do the tests make sure that the results match a reference image in some way? XML files in gegl/tests/compositions are rendered and their

Re: [Gegl-developer] various blurs

2011-01-18 Thread Martin Nordholts
On 01/18/2011 11:43 PM, andy gill wrote: I've attached 3 more patches, they are: box-blur. it's now a good deal faster, and also properly supports fractional blur widths. fast gaussian blur. this is implemented as 3 box filters in series. it approximates a gaussian fairly closely, visually