Re: [Gegl-developer] babl portability patches, and a test failure

2009-03-09 Thread Gary V. Vaughan
Hi Sven, On Sun, Mar 08, 2009 at 08:56:59PM +0100, Sven Neumann wrote: On Tue, 2009-02-24 at 23:27 +0100, Sven Neumann wrote: attached is a patch for babl_log. I am not too happy with the outcome as it will result in less informative log output on platforms that don't support variadic

Re: [Gegl-developer] babl portability patches, and a test failure

2009-02-26 Thread Gary V. Vaughan
Hi Sven, Thanks for following up on this. On Tue, Feb 24, 2009 at 11:27:22PM +0100, Sven Neumann wrote: attached is a patch for babl_log. I am not too happy with the outcome as it will result in less informative log output on platforms that don't support variadic macros. But I guess that's

Re: [Gegl-developer] babl portability patches, and a test failure

2009-02-26 Thread Gary V. Vaughan
Hi Sven, On Tue, Feb 24, 2009 at 10:19:50PM +0100, Sven Neumann wrote: On Tue, 2009-02-24 at 03:22 +, Gary V. Vaughan wrote: * for gnulib and autoconf to work properly, every .c file needs to #include config.h before anything else! Yes, definitely! And I even kept

Re: [Gegl-developer] babl portability patches, and a test failure

2009-02-24 Thread Sven Neumann
Hi, On Tue, 2009-02-24 at 03:22 +, Gary V. Vaughan wrote: * for gnulib and autoconf to work properly, every .c file needs to #include config.h before anything else! Yes, definitely! And I even kept that in a separate patch! :) I have committed that part to trunk now.