Re: [VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc3
*bq. no need to add anything into NOTICE* Correction: here we need to analyze the Spark NOTICE file and the relevant portions bubbled up into the top-level NOTICE file [1], as already pointed out by Justin in previous reply [2]. Best Regards, Yu [1] https://infra.apache.org/licensing-howto.html#alv2-dep [2] https://lists.apache.org/thread/bopd2yql1nvjt1kmn9vcd86zqg924g21 On Tue, 31 Jan 2023 at 14:03, Yu Li wrote: > Thanks for the further clarification Justin, it helps a lot. And thanks > for correcting me. Now I understand that I should have referred to the > 3rd-party section [1] instead. > > Explicitly, I think the action-to-do is to add (append) the below lines > into the Celeborn LICENSE file [2] (similar to that of Spark [3]), meantime > keep the copyright text in the source file and no need to add anything into > NOTICE: > > > ** > > *This product bundles various third-party components under other open > source licenses.* > > *This section summarizes those components and their licenses. See > licenses/* > > *for text of these licenses.* > > > > *Apache Software Foundation License 2.0* > > *--* > > > > *common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java* > > > > == > PS. attaching the detailed license instructions below for easier reference: > >1. The term "third-party work" refers to a work not submitted directly >to the ASF by the copyright owner or owner's agent. This includes parts of >a work submitted directly to the ASF for which the submitter is not the >copyright owner or owner's agent. >2. Do not modify or remove any copyright notices or licenses within >third-party works. >3. Make sure that every third-party work includes its associated >license, even if that requires adding a copy of the license from the >third-party download site into the distribution. >4. Do not add the standard Apache License header to the top of >third-party source files. >5. Minor modifications/additions to third-party source files should >typically be licensed under the same terms as the rest of the third-party >source for convenience. >6. The project's PMC should deal with major modifications/additions to >third-party source files on a case-by-case basis. > > > Best Regards, > Yu > > [1] https://www.apache.org/legal/src-headers.html#3party > [2] https://github.com/apache/incubator-celeborn/blob/main/LICENSE > [3] https://github.com/apache/spark/blob/master/LICENSE#L204-L213 > > > On Tue, 31 Jan 2023 at 13:11, Justin Mclean > wrote: > >> Hi, >> >> > *bq. It belongs in LICENSE not NOTICE only copyright notices that have >> been >> > removed (by or with the permission of the owner) get listed in NOTICE* >> > Since Guava is also with ALv2, referring to [1], my understanding is >> that: >> > 1. There should be no copyright notice in the header (#2) >> > 2. We need to move the copyright to the NOTICE file associated with each >> > applicable project release (#1.b) >> > >> > And referring to [2], "Copyright notifications which have been >> relocated, >> > rather than removed, from source files must be preserved in NOTICE >> (unless >> > embedded in MIT/BSD license)". I'm not sure whether reserving the >> copyright >> > in Spark way means "relocate", but if it is, then it seems the copyright >> > should occur (be reserved) in NOTICE. >> >> Sorry that's not correct as: >> - Relocated in this context means that the owner has given the software >> to the ASF (usually via a software grant). >> - Guava is 3rd party software so it needs to be mentioned in LICENSE. >> - Guava is not an ASF project so its header would have a copyright line >> >> This will probably help [1] >> >> Kind Regards, >> Justin >> >> 1. https://infra.apache.org/licensing-howto.html#alv2-dep >> - >> To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org >> For additional commands, e-mail: general-h...@incubator.apache.org >> >>
Re: [VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc3
Thanks for the further clarification Justin, it helps a lot. And thanks for correcting me. Now I understand that I should have referred to the 3rd-party section [1] instead. Explicitly, I think the action-to-do is to add (append) the below lines into the Celeborn LICENSE file [2] (similar to that of Spark [3]), meantime keep the copyright text in the source file and no need to add anything into NOTICE: ** *This product bundles various third-party components under other open source licenses.* *This section summarizes those components and their licenses. See licenses/* *for text of these licenses.* *Apache Software Foundation License 2.0* *--* *common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java* == PS. attaching the detailed license instructions below for easier reference: 1. The term "third-party work" refers to a work not submitted directly to the ASF by the copyright owner or owner's agent. This includes parts of a work submitted directly to the ASF for which the submitter is not the copyright owner or owner's agent. 2. Do not modify or remove any copyright notices or licenses within third-party works. 3. Make sure that every third-party work includes its associated license, even if that requires adding a copy of the license from the third-party download site into the distribution. 4. Do not add the standard Apache License header to the top of third-party source files. 5. Minor modifications/additions to third-party source files should typically be licensed under the same terms as the rest of the third-party source for convenience. 6. The project's PMC should deal with major modifications/additions to third-party source files on a case-by-case basis. Best Regards, Yu [1] https://www.apache.org/legal/src-headers.html#3party [2] https://github.com/apache/incubator-celeborn/blob/main/LICENSE [3] https://github.com/apache/spark/blob/master/LICENSE#L204-L213 On Tue, 31 Jan 2023 at 13:11, Justin Mclean wrote: > Hi, > > > *bq. It belongs in LICENSE not NOTICE only copyright notices that have > been > > removed (by or with the permission of the owner) get listed in NOTICE* > > Since Guava is also with ALv2, referring to [1], my understanding is > that: > > 1. There should be no copyright notice in the header (#2) > > 2. We need to move the copyright to the NOTICE file associated with each > > applicable project release (#1.b) > > > > And referring to [2], "Copyright notifications which have been relocated, > > rather than removed, from source files must be preserved in NOTICE > (unless > > embedded in MIT/BSD license)". I'm not sure whether reserving the > copyright > > in Spark way means "relocate", but if it is, then it seems the copyright > > should occur (be reserved) in NOTICE. > > Sorry that's not correct as: > - Relocated in this context means that the owner has given the software to > the ASF (usually via a software grant). > - Guava is 3rd party software so it needs to be mentioned in LICENSE. > - Guava is not an ASF project so its header would have a copyright line > > This will probably help [1] > > Kind Regards, > Justin > > 1. https://infra.apache.org/licensing-howto.html#alv2-dep > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
Re: [VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc3
Hi, > *bq. It belongs in LICENSE not NOTICE only copyright notices that have been > removed (by or with the permission of the owner) get listed in NOTICE* > Since Guava is also with ALv2, referring to [1], my understanding is that: > 1. There should be no copyright notice in the header (#2) > 2. We need to move the copyright to the NOTICE file associated with each > applicable project release (#1.b) > > And referring to [2], "Copyright notifications which have been relocated, > rather than removed, from source files must be preserved in NOTICE (unless > embedded in MIT/BSD license)". I'm not sure whether reserving the copyright > in Spark way means "relocate", but if it is, then it seems the copyright > should occur (be reserved) in NOTICE. Sorry that's not correct as: - Relocated in this context means that the owner has given the software to the ASF (usually via a software grant). - Guava is 3rd party software so it needs to be mentioned in LICENSE. - Guava is not an ASF project so its header would have a copyright line This will probably help [1] Kind Regards, Justin 1. https://infra.apache.org/licensing-howto.html#alv2-dep - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc3
Hi Justin, Thanks for the quick reply. *bq. Not sure why you are discussing this on your private list* Since I'm not sure whether the team has already addressed the issue and prepared another RC, and I'm not sure whether my understanding is correct, so I reduce the discussion scope to internal to prevent bothering others. Now I'm adding back the @general list since the discussion might also help others. *bq. It belongs in LICENSE not NOTICE only copyright notices that have been removed (by or with the permission of the owner) get listed in NOTICE* Since Guava is also with ALv2, referring to [1], my understanding is that: 1. There should be no copyright notice in the header (#2) 2. We need to move the copyright to the NOTICE file associated with each applicable project release (#1.b) And referring to [2], "Copyright notifications which have been relocated, rather than removed, from source files must be preserved in NOTICE (unless embedded in MIT/BSD license)". I'm not sure whether reserving the copyright in Spark way means "relocate", but if it is, then it seems the copyright should occur (be reserved) in NOTICE. Please further correct me if I misunderstood anything. Thanks. Best Regards, Yu [1] https://www.apache.org/legal/src-headers.html#headers [2] https://infra.apache.org/licensing-howto.html#mod-notice On Tue, 31 Jan 2023 at 11:51, Justin Mclean wrote: > Hi, > > Not sure why you are discussing this on your private list. > > 3. The Spark project directly nests the Guava copyright in the source > file, which is incorrect according to [1] from my perspective. Instead, it > should include the Guava copyright in its NOTICE file. > > > It belongs in LICENSE not NOTICE only copyright notices that have been > removed (by or with the permission of the owner) get listed in NOTICE. > > > 4. For us, I believe the correct thing to do is to add the Guava copyright > into our NOTICE file, in a way like below (referring to [4]): > The codes of common/network/util/LimitedInputStream partially derives > from Guava > Copyright (C) 2007 The Guava Authors > > > No that is not correct. > > Kind Regards, > Justin > > On 31 Jan 2023, at 2:36 pm, Yu Li wrote: > > Hi Team, > > I'm wondering whether this issue is already addressed, if not, here are my > two cents: > 1. Overall we should follow the instructions here: [1]. > 2. From the originated Spark source file [2], it stems from the Google > Guava project [3]. > 3. The Spark project directly nests the Guava copyright in the source > file, which is incorrect according to [1] from my perspective. Instead, it > should include the Guava copyright in its NOTICE file. > 4. For us, I believe the correct thing to do is to add the Guava copyright > into our NOTICE file, in a way like below (referring to [4]): > The codes of common/network/util/LimitedInputStream partially derives > from Guava > Copyright (C) 2007 The Guava Authors > 5. The Spark modified part (if any, didn't check details) should already > be covered by the existing notice in NOTICE file > This product includes software developed at > The Apache Software Foundation (https://www.apache.org/). > > @Mentors: > Feel free to correct me if you have different ideas > > CC @Justin here for easier follow-up (and thanks for the careful review, > Justin!) > > Best Regards, > Yu > > [1] https://www.apache.org/legal/src-headers.html#headers > [2] > https://github.com/apache/spark/blob/master/common/network-common/src/main/java/org/apache/spark/network/util/LimitedInputStream.java > [3] > https://github.com/google/guava/blob/master/guava/src/com/google/common/io/ByteStreams.java#L706 > [4] https://infra.apache.org/licensing-howto.html#example-notice > > > -- Forwarded message - > From: Ethan Feng > Date: Sat, 28 Jan 2023 at 10:39 > Subject: Re: [VOTE] Release Apache Celeborn(Incubating) > 0.2.0-incubating-rc3 > To: > > > Hi Justin, >Thanks for your advice. We'll consult our mentors. > >This vote is closed. > > Thanks, > Ethan Feng > > Justin Mclean 于2023年1月26日周四 06:29写道： > > > > Hi, > > > > I suggest you ask you mentors for help on this. > > > > > Thanks for your advice. We’ve checked the spark distribution > > > package, and we figure out that there is no [3] related notice in > > > [1][2]. > > > > You still need to take the relevant parts from that NOTICE file and add > it to yours. Please see [1] and [2]. This IMO would include the "Apache > Spark Copyright 2014 and onwards The Apache Software Foundation.” part. > > > > > Do we need to add the following text block to notice file in our > > >
Re: [VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc3
Hi Justin, Thanks for your advice. We'll consult our mentors. This vote is closed. Thanks, Ethan Feng Justin Mclean 于2023年1月26日周四 06:29写道： > > Hi, > > I suggest you ask you mentors for help on this. > > > Thanks for your advice. We’ve checked the spark distribution > > package, and we figure out that there is no [3] related notice in > > [1][2]. > > You still need to take the relevant parts from that NOTICE file and add it to > yours. Please see [1] and [2]. This IMO would include the "Apache Spark > Copyright 2014 and onwards The Apache Software Foundation.” part. > > > Do we need to add the following text block to notice file in our > > source package according to [4]? > > > > “./common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java > > is based on LimitedInputStream.java from Google Guava > > Copyright (C) 2007 The Guava Authors” > > No license information goes in LICENSE not NOTICE, and the Google Guava file > doesn’t have a NOTICE file that I can see. > > Kind Regards, > Justin > > 1. https://infra.apache.org/licensing-howto.html#alv2-dep > 2. https://infra.apache.org/licensing-howto.html#mod-notice > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc3
Hi, I suggest you ask you mentors for help on this. > Thanks for your advice. We’ve checked the spark distribution > package, and we figure out that there is no [3] related notice in > [1][2]. You still need to take the relevant parts from that NOTICE file and add it to yours. Please see [1] and [2]. This IMO would include the "Apache Spark Copyright 2014 and onwards The Apache Software Foundation.” part. > Do we need to add the following text block to notice file in our > source package according to [4]? > > “./common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java > is based on LimitedInputStream.java from Google Guava > Copyright (C) 2007 The Guava Authors” No license information goes in LICENSE not NOTICE, and the Google Guava file doesn’t have a NOTICE file that I can see. Kind Regards, Justin 1. https://infra.apache.org/licensing-howto.html#alv2-dep 2. https://infra.apache.org/licensing-howto.html#mod-notice - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc3
Hi Justin, Thanks for your advice. We’ve checked the spark distribution package, and we figure out that there is no [3] related notice in [1][2]. Do we need to add the following text block to notice file in our source package according to [4]? “./common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java is based on LimitedInputStream.java from Google Guava Copyright (C) 2007 The Guava Authors” Thanks, Ethan Feng [1] https://github.com/apache/spark/blob/v3.3.1/NOTICE [2] https://github.com/apache/spark/blob/v3.3.1/NOTICE-binary [3] https://github.com/apache/spark/blob/v3.3.1/common/network-common/src/main/java/org/apache/spark/network/util/LimitedInputStream.java [4] https://infra.apache.org/licensing-howto.html Justin Mclean 于2023年1月25日周三 19:59写道： > > Hi, > > >1. [1] is copied and modified from Apache spark[2], we didn't > > modify the headers. > > Apache Spark has a NOTICE file, you’ll need to work out what parts need to be > added to your NOTICE file. > > Kind Regards, > Justin > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc3
Hi, >1. [1] is copied and modified from Apache spark[2], we didn't > modify the headers. Apache Spark has a NOTICE file, you’ll need to work out what parts need to be added to your NOTICE file. Kind Regards, Justin - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc3
Hi Justin, Thanks for your review, we'll fix the problems you mentioned. Following are our solutions, if anything is wrong please let us know. 1. [1] is copied and modified from Apache spark[2], we didn't modify the headers. We'll add this information to the LICENSE file in the source package, just like spark does[3]. We checked that there is no other 3rd party code in the release. 2. The license header in [4] is a mistake, we will replace it with Apache License 2.0. Thanks, Ethan Feng [1] ./common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java [2] https://github.com/apache/spark/blob/v3.1.1/common/network-common/src/main/java/org/apache/spark/network/util/LimitedInputStream.java [3] https://github.com/apache/spark/blob/v3.1.1/LICENSE [4] ./common/src/main/java/org/apache/celeborn/common/network/server/memory/ReadBufferListener.java Justin Mclean 于2023年1月24日周二 11:03写道： > > HI, > > Sorry it’s -1 (binding) form me as it contain 3rd party code that is not > mentioned in LICENSE. > > I checked: > - incubating in name > - signatures and hashes are file > - LICENSE is missing license for 3rd party code [1] (this file probably > incorrect has an ASF header as well) [2]. Is there any other 3rd party code > in the release? > - NOTICE is OK (but may need additional text if those 3rd party bits of code > include a NOTICE file) > - All files have ASF headers > - No unexpected binary files > - Can compile from source > > Kind Regards, > Justin > > 1. > ./common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java > 2. > ./common/src/main/java/org/apache/celeborn/common/network/server/memory/ReadBufferListener.java > > > - > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
Re: [VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc3
HI, Sorry it’s -1 (binding) form me as it contain 3rd party code that is not mentioned in LICENSE. I checked: - incubating in name - signatures and hashes are file - LICENSE is missing license for 3rd party code [1] (this file probably incorrect has an ASF header as well) [2]. Is there any other 3rd party code in the release? - NOTICE is OK (but may need additional text if those 3rd party bits of code include a NOTICE file) - All files have ASF headers - No unexpected binary files - Can compile from source Kind Regards, Justin 1. ./common/src/main/java/org/apache/celeborn/common/network/util/LimitedInputStream.java 2. ./common/src/main/java/org/apache/celeborn/common/network/server/memory/ReadBufferListener.java - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
[VOTE] Release Apache Celeborn(Incubating) 0.2.0-incubating-rc3
Hello Incubator Community, This is a call for a vote to release Apache Celeborn(Incubating) version 0.2.0-incubating-rc3 The Apache Celeborn community has voted on and approved a proposal to release Apache Celeborn(Incubating) version 0.2.0-incubating-rc3 We now kindly request the Incubator PMC members review and vote on this incubator release. Celeborn community vote thread: • https://lists.apache.org/thread/d964fnnw5wff4zjmrdo2srj6rqgb336g Vote result thread: • https://lists.apache.org/thread/3xc8dz0bp7bcfsk8m6l035mz6cx48yoz The release candidate: • https://dist.apache.org/repos/dist/dev/incubator/celeborn/v0.2.0-incubating-rc3 Git tag for the release: • https://github.com/apache/incubator-celeborn/releases/tag/v0.2.0-incubating-rc3 Public keys file: • https://dist.apache.org/repos/dist/release/incubator/celeborn/KEYS The change log is available in: • https://github.com/apache/incubator-celeborn/compare/v0.1.4...v0.2.0-incubating-rc3 The vote will be open for at least 72 hours or until the necessary number of votes are reached. Please vote accordingly: [ ] +1 approve [ ] +0 no opinion [ ] -1 disapprove with the reason More detailed checklist please refer: • https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist Steps to validate the release， Please refer to: • https://www.apache.org/info/verification.html Thanks, On behalf of Apache Celeborn(Incubating) community - To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org For additional commands, e-mail: general-h...@incubator.apache.org
