Re: [gentoo-dev] New eclass: opam.eclass

2017-08-02 Thread Alexis Ballier
> > > > > "${pkg}.install" || die > > > done > > > } > > > > > > opam_src_install() { > > > opam-install "${PN}" > > > # Handle opam putting doc in a subdir > > > if [ -d "${ED}/usr/share/doc/${PF}/${PN}" ] ; then > > > > Is PN always the correct subdirectory

Re: [gentoo-dev] New eclass: opam.eclass

2017-08-02 Thread Alexis Ballier
On Tue, 25 Jul 2017 16:18:10 +0200 Michał Górny wrote: > On pon, 2017-07-24 at 17:20 +0200, Alexis Ballier wrote: > > # Copyright 1999-2017 Gentoo Foundation > > # Distributed under the terms of the GNU General Public License v2 > > > > # @ECLASS: opam.eclass > > #

Re: [gentoo-dev] New eclass: opam.eclass

2017-07-25 Thread Michał Górny
On pon, 2017-07-24 at 17:20 +0200, Alexis Ballier wrote: > # Copyright 1999-2017 Gentoo Foundation > # Distributed under the terms of the GNU General Public License v2 > > # @ECLASS: opam.eclass > # @MAINTAINER: > # Gentoo ML Project > # @AUTHOR: > # Alexis Ballier

Re: [gentoo-dev] New eclass: opam.eclass

2017-07-25 Thread Michał Górny
On wto, 2017-07-25 at 12:48 +, Peter Stuge wrote: > Good work on the refactoring! > > Alexis Ballier wrote: > > > > if [ -d "${ED}/usr/share/doc/${PF}/${PN}" ] ; then > > > > > > It’s always been recommended to me that we should use the [[ … ]] > > > form. > > > > Doesn't make

Re: [gentoo-dev] New eclass: opam.eclass

2017-07-25 Thread Peter Stuge
Good work on the refactoring! Alexis Ballier wrote: > > > if [ -d "${ED}/usr/share/doc/${PF}/${PN}" ] ; then > > > > It’s always been recommended to me that we should use the [[ … ]] > > form. > > Doesn't make much difference here Some; you need neither quote nor {} in expansions within [[

Re: [gentoo-dev] New eclass: opam.eclass

2017-07-25 Thread Alexis Ballier
On Mon, 24 Jul 2017 18:11:39 -0400 "Aaron W. Swenson" wrote: > On 2017-07-24 17:20, Alexis Ballier wrote: > > Hey, > > > > Here is an eclass that would allow me to factor quite a bit of > > redundant code. > > > > … > > if [ -d "${ED}/usr/share/doc/${PF}/${PN}" ] ;

Re: [gentoo-dev] New eclass: opam.eclass

2017-07-24 Thread Aaron W. Swenson
On 2017-07-24 17:20, Alexis Ballier wrote: > Hey, > > Here is an eclass that would allow me to factor quite a bit of > redundant code. > > … > if [ -d "${ED}/usr/share/doc/${PF}/${PN}" ] ; then It’s always been recommended to me that we should use the [[ … ]] form. Otherwise, looks good

[gentoo-dev] New eclass: opam.eclass

2017-07-24 Thread Alexis Ballier
Hey, Here is an eclass that would allow me to factor quite a bit of redundant code. Potential users: https://qa-reports.gentoo.org/output/genrdeps/dindex/dev-ml/opam Examples of conversion: diff --git a/dev-ml/ocaml-cstruct/ocaml-cstruct-3.1.1.ebuild