RE: Windows testsuite failures

2020-01-17 Thread Ben Gamari
Simon Peyton Jones via ghc-devs writes: > Both Tamar and Omer are right. > > * Not doing CI on Windows is bad. It means that bugs get introduced, > and not discovered until later. This is Tamer’s point, and it is > valid. > * Holding up MRs because a failures in Windows CI that is

Re: Windows testsuite failures

2020-01-17 Thread Ben Gamari
Ömer Sinan Ağacan writes: >> Now we have rewritten the CI and it's pointing out actual issues in the >> compiler. And your suggestion is well let's just ignore it. > > When is the last time Windows CI caught an actual bug? All I see is random > system failures [1, 2, 3]. > > It must be catching

Re: Windows testsuite failures

2020-01-17 Thread Ben Gamari
Ömer Sinan Ağacan writes: > Hi Ben, > > Can we please disable Windows CI? I've spent more time fighting the CI than > doing useful work this week, it's really frustrating. > Yes, this recent spate is issues indeed took too long to solve. Unfortunately this particular issue took quite a while to

RE: Windows testsuite failures

2020-01-17 Thread Simon Peyton Jones via ghc-devs
a bug. How hard would it be to do that? Do we even know what the problem is? Simon From: ghc-devs On Behalf Of Phyx Sent: 17 January 2020 06:49 To: Ömer Sinan Ağacan Cc: ghc-devs Subject: Re: Windows testsuite failures Oh I spent a non-insignificant amount of time back in the phabricator days

Re: Windows testsuite failures

2020-01-16 Thread Phyx
On Fri, Jan 17, 2020 at 7:02 AM Ömer Sinan Ağacan wrote: > > Now we have rewritten the CI and it's pointing out actual issues in the > > compiler. And your suggestion is well let's just ignore it. > > When is the last time Windows CI caught an actual bug? All I see is random > system failures

Re: Windows testsuite failures

2020-01-16 Thread Ömer Sinan Ağacan
> Now we have rewritten the CI and it's pointing out actual issues in the > compiler. And your suggestion is well let's just ignore it. When is the last time Windows CI caught an actual bug? All I see is random system failures [1, 2, 3]. It must be catching *some* bugs, but that's a rare event

Re: Windows testsuite failures

2020-01-16 Thread Phyx
Oh I spent a non-insignificant amount of time back in the phabricator days to make the CI stable. Now because people were committing to master directly without going through CI it was always a cat and mouse game and I gave up eventually. Now we have rewritten the CI and it's pointing out actual

Re: Windows testsuite failures

2020-01-16 Thread Ömer Sinan Ağacan
We release more often than once in 6 months. We clearly have no idea how to test on Windows. If you know how to do it then feel free to submit a MR. Otherwise blocking every MR indefinitely is worse than testing Windows less frequently. Ömer Phyx , 17 Oca 2020 Cum, 09:10 tarihinde şunu yazdı: >

Re: Windows testsuite failures

2020-01-16 Thread Phyx
Sure because only testing once every 6 months is a very very good idea... Sent from my Mobile On Fri, Jan 17, 2020, 06:03 Ömer Sinan Ağacan wrote: > Hi Ben, > > Can we please disable Windows CI? I've spent more time fighting the CI than > doing useful work this week, it's really frustrating. >

Re: Windows testsuite failures

2020-01-16 Thread Ömer Sinan Ağacan
Hi Ben, Can we please disable Windows CI? I've spent more time fighting the CI than doing useful work this week, it's really frustrating. Since we have no idea how to fix it maybe we should test Windows only before a release, manually (and use bisect in case of regressions). Ömer Ben Gamari ,

Re: Windows testsuite failures

2018-09-25 Thread Phyx
o > that they don’t pollute the testsuite output? > > > Simon > > > > > > *From:* loneti...@gmail.com > *Sent:* 24 September 2018 07:13 > > > *To:* Simon Peyton Jones > *Subject:* RE: Windows testsuite failures > > > > >

RE: Windows testsuite failures

2018-09-24 Thread Simon Peyton Jones via ghc-devs
Tamar Thank you, that’s great! For the ones that need more work, can we mark them as expect-broken, so that they don’t pollute the testsuite output? Simon From: loneti...@gmail.com Sent: 24 September 2018 07:13 To: Simon Peyton Jones Subject: RE: Windows testsuite failures Hi Simon, I

Re: Windows testsuite failures

2018-09-20 Thread Phyx
Hi Simon, Thanks for the email. I haven't been building head much as I'm working on top of some older commits. From a quick look it seems like the plugin ones are probably testisms, the plugins aren't found so likely a missing path entry somewhere. The linker ones are are weird, I'll need to