Re: submodule instructions?

2020-01-17 Thread Ben Gamari
Richard Eisenberg writes: > Hi devs, > > Are there up-to-date instructions on how to deal with submodules in GHC? > > https://gitlab.haskell.org/ghc/ghc/wikis/working-conventions/git/submodules > > does give nice

RE: Windows testsuite failures

2020-01-17 Thread Ben Gamari
Simon Peyton Jones via ghc-devs writes: > Both Tamar and Omer are right. > > * Not doing CI on Windows is bad. It means that bugs get introduced, > and not discovered until later. This is Tamer’s point, and it is > valid. > * Holding up MRs because a failures in Windows CI that is

Re: Windows testsuite failures

2020-01-17 Thread Ben Gamari
Ömer Sinan Ağacan writes: > Hi Ben, > > Can we please disable Windows CI? I've spent more time fighting the CI than > doing useful work this week, it's really frustrating. > Yes, this recent spate is issues indeed took too long to solve. Unfortunately this particular issue took quite a while to

Re: Windows testsuite failures

2020-01-17 Thread Ben Gamari
Ömer Sinan Ağacan writes: >> Now we have rewritten the CI and it's pointing out actual issues in the >> compiler. And your suggestion is well let's just ignore it. > > When is the last time Windows CI caught an actual bug? All I see is random > system failures [1, 2, 3]. > > It must be catching

Re: Fixing type synonyms to Uniq(D)FM newtypes

2020-01-17 Thread Ben Gamari
Richard Eisenberg writes: > One advantage of the phantom-parameter approach is that it allows for nice > polymorphism. > >> lookupEnv :: Uniquable dom => UniqFM dom rng -> dom -> Maybe rng > > Now, we don't need lookupVarEnv separately from lookupNameEnv, but we > get the type-checking for

RE: Find constraints over type

2020-01-17 Thread Simon Peyton Jones via ghc-devs
Starting from any point in the typechecked syntax tree, you can look outwards to find binding sites for enclosing constraints, and then use whatever method you like to decide if they are relevant. Binding sites are: * ConPatOut; binds dictionaries from GADT matches * AbsBinds:

submodule instructions?

2020-01-17 Thread Richard Eisenberg
Hi devs, Are there up-to-date instructions on how to deal with submodules in GHC? https://gitlab.haskell.org/ghc/ghc/wikis/working-conventions/git/submodules does give nice information. It refers to

Re: Find constraints over type

2020-01-17 Thread Alejandro Serrano Mena
My goal is to add type information on hover within `ghcide`. Right now, when you select a variable, we give back the type as reported in the corresponding Var. However, when this type involved a type variable, it misses a lot of important information about the typing context in which we are

RE: Windows testsuite failures

2020-01-17 Thread Simon Peyton Jones via ghc-devs
Both Tamar and Omer are right. * Not doing CI on Windows is bad. It means that bugs get introduced, and not discovered until later. This is Tamer’s point, and it is valid. * Holding up MRs because a failures in Windows CI that is unrelated to the MR is also bad. It a frustrating

Re: [ANNOUNCE] GHC 8.8.2 is now available

2020-01-17 Thread Jens Petersen
On Fri, 17 Jan 2020, 00:35 Ben Gamari, wrote: > The GHC team is proud to announce the release of GHC 8.8.2. > Congrats I have built it already for the Fedora ghc:8.8 module stream: it should go into updates-testing-modular soon for F30, F31, and Rawhide. Thanks, Jens