more submodule questions

2020-01-27 Thread Richard Eisenberg
Hi devs, I recently found this text at the end of https://gitlab.haskell.org/ghc/ghc/wikis/working-conventions/git/submodules : --- The CI pipeline of ghc/ghc> includes a linting step to ensure that all submodules

gaining access to the `ghc` group

2020-01-27 Thread Richard Eisenberg
Hi devs, I'm onboarding a new contributor (Gert-Jan Bottu), whose patch (!2465) makes commensurate changes in Haddock. In order to use CI, then, he needs to be able to push a wip/ branch to our fork of Haddock. In order to do that, he needs to be in the `ghc` group. (I'm assuming -- but have no

RE: stage2 build fails

2020-01-27 Thread Simon Peyton Jones via ghc-devs
It would be good to know how to fix this. It's blocking my builds. For some reason it doesn't seem to kill CI Simon From: Simon Peyton Jones Sent: 25 January 2020 20:26 To: ghc-devs Subject: stage2 build fails I'm getting this with "sh validate -legacy" compiler/main/DynFlags.hs:1344:15: erro

Re: stage2 build fails

2020-01-27 Thread Sylvain Henry
Which stage 0 compiler are you using? It seems to be <= 8.10 and still has 8038cbd96f4 merged which seems contradictory. Anyway the alternative seems to be redundant from the beginning and should have been removed IMO. I have opened https://gitlab.haskell.org/ghc/ghc/merge_requests/2564 to fix

Re: stage2 build fails

2020-01-27 Thread Ben Gamari
Simon Peyton Jones via ghc-devs writes: > I'm getting this with "sh validate -legacy" > > compiler/main/DynFlags.hs:1344:15: error: [-Woverlapping-patterns, > -Werror=overlapping-patterns] > > Pattern match is redundant > > In an equation for 'settings': settings s | otherwise = ... > >

RE: stage2 build fails

2020-01-27 Thread Simon Peyton Jones via ghc-devs
| Indeed it would be nice to know which compiler you are using to | bootstrap. I suspect Sylvain is correct that the alternative can be | removed but first I would like to understand why this is arising only | now. I'm using 8.6.4 as my bootstrap compiler. But this message occurs only when co

RE: stage2 build fails

2020-01-27 Thread Ben Gamari
Simon Peyton Jones writes: > | Indeed it would be nice to know which compiler you are using to > | bootstrap. I suspect Sylvain is correct that the alternative can be > | removed but first I would like to understand why this is arising only > | now. > > I'm using 8.6.4 as my bootstrap compile

Re: gaining access to the `ghc` group

2020-01-27 Thread Ben Gamari
Richard Eisenberg writes: > Hi devs, > > I'm onboarding a new contributor (Gert-Jan Bottu), whose patch (!2465) > makes commensurate changes in Haddock. In order to use CI, then, he > needs to be able to push a wip/ branch to our fork of Haddock. In > order to do that, he needs to be in the `ghc`

Re: more submodule questions

2020-01-27 Thread Ben Gamari
Richard Eisenberg writes: > Hi devs, > > I recently found this text at the end of > https://gitlab.haskell.org/ghc/ghc/wikis/working-conventions/git/submodules > > : > > --- > The CI pipeline of ghc/ghc> > includes

Re: more submodule questions

2020-01-27 Thread Richard Eisenberg
> On Jan 27, 2020, at 8:19 PM, Ben Gamari wrote: > > The linter does not hold up builds for merge requests but will hold up a > "pre-merge" validation job (e.g. a validation of an MR created by > @marge-bot). This ensures that a patch containing a wip/ submodule > reference will not be merged t

Re: gaining access to the `ghc` group

2020-01-27 Thread Richard Eisenberg
> > I have updated the instructions on the submodules wiki page to reflect > this new feature. Does this look better? Perfect. Thank you! ___ ghc-devs mailing list ghc-devs@haskell.org http://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-devs

Intree gmp builds using Hadrian use system gmp headers

2020-01-27 Thread Carter Schonwald
Hey all, For those using Hadrian for platforms where intree gmp config is important, some sleuthing I’ve done over the past half seems to indicate that currently it’s not correct via Hadrian, but only via make. https://gitlab.haskell.org/ghc/ghc/issues/17756 I’m able to reproduce this on multiple

Re: Intree gmp builds using Hadrian use system gmp headers

2020-01-27 Thread Carter Schonwald
If folks can reproduce this issue on other platforms than OS X , id greatly appreciate it. If only to confirm that it’s as reproducible as I believe it is. I should mention that at least on OS X, it’s slightly easier to trigger the issue / stumble across it with gcc rather than clang (on OS X, cla