Re: Magicless file formats

2000-02-27 Thread Peter Kirchgessner
Sven Neumann wrote: Hi, If a properly named Targa file is not correctly loaded by GIMP, then another plug-in (for example faxg3) uses a file magic that fits this targa file. So which plug-in should load the file ? The one that has the correct file magic or the one that handles the

Re: Magicless file formats

2000-02-27 Thread Sven Neumann
Hi, OK, I should have read the e-mail with the patch more carefully. This handling looks good. So the patch actually has a good chance to get included. The probability would be even better if you could upload it to ftp://ftp.gimp.org/incoming as described in the README in that directory. At

Re: Magicless file formats

2000-02-27 Thread Mattias Engdegård
(CC:ed to authors) I went through the file plugins and added magic patterns to those who didn't register any, and corrected those already exisiting. The only case where I'm not 100% certain is the MPEG magic number; the ones chosen are from my /etc/magic file, and all mpegs I've looked at had

Re: Magicless file formats

2000-02-26 Thread Peter Kirchgessner
Mattias Engdegård wrote: Anyway, if the user finds that an application doesn't try to load a file whose name ends in .tga as a Targa file (or worse, attempts to load it as a Group 3 fax file), then the same user will assume that the application, or its programmers, or both, are stupid

Re: Magicless file formats

2000-02-26 Thread Sven Neumann
Hi, If a properly named Targa file is not correctly loaded by GIMP, then another plug-in (for example faxg3) uses a file magic that fits this targa file. So which plug-in should load the file ? The one that has the correct file magic or the one that handles the correct extension ? I would

Re: Magicless file formats

2000-02-26 Thread Mattias Engdegård
[ correct description of the patch ] The only problem I see with this patch are badly written file_plug_ins that don't provide a magic header but a bunch of extensions since the patch would significantly enhance the possibility that the wrong loader is used. Grepping for

Re: Magicless file formats

2000-02-25 Thread Peter Kirchgessner
Mattias Engdegård wrote: Anyway, if the user finds that an application doesn't try to load a file whose name ends in .tga as a Targa file (or worse, attempts to load it as a Group 3 fax file), then the same user will assume that the application, or its programmers, or both, are stupid beyond

Re: Magicless file formats

2000-02-25 Thread Mattias Engdegård
Anyway, if the user finds that an application doesn't try to load a file whose name ends in .tga as a Targa file (or worse, attempts to load it as a Group 3 fax file), then the same user will assume that the application, or its programmers, or both, are stupid beyond belief. And rightly so

Re: Magicless file formats

2000-02-24 Thread Federico Mena Quintero
Targa files have no magic header, and cannot be reliably identified that way. [snip] "New" Targa files have a magic string at the end of the file[1], plus a bunch of extra information. The Targa specification tells you how and where to expect it. It does says that for old files you are

Re: Magicless file formats

2000-02-24 Thread Mattias Engdegård
"New" Targa files have a magic string at the end of the file[1], plus a bunch of extra information. The Targa specification tells you how and where to expect it. It does says that for old files you are basically screwed :-( I know that, but since a) the Gimp magic pattern language doesn't seem