Junio C Hamano wrote:
Junio C Hamano gits...@pobox.com writes:
Felipe Contreras felipe.contre...@gmail.com writes:
So that all the tests pass.
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
git-rebase--cherry.sh | 17 -
1 file changed, 16
On Wed, May 29, 2013 at 12:51 AM, Martin von Zweigbergk
martinv...@gmail.com wrote:
On Tue, May 28, 2013 at 10:41 PM, Felipe Contreras
felipe.contre...@gmail.com wrote:
One change splits, the other change fixes, what's wrong with that?
I didn't say there was anything wrong. I was asking if
:-)
On Tue, May 28, 2013 at 11:05 PM, Felipe Contreras
felipe.contre...@gmail.com wrote:
On Wed, May 29, 2013 at 12:51 AM, Martin von Zweigbergk
martinv...@gmail.com wrote:
On Tue, May 28, 2013 at 10:41 PM, Felipe Contreras
felipe.contre...@gmail.com wrote:
One change splits, the other
Am 5/29/2013 5:24, schrieb Felipe Contreras:
+if [ -z $script ]; then
+ local -a locations
+ locations=(
+ '/etc/bash_completion.d/git' # fedora, old debian
+ '/usr/share/bash-completion/completions/git' # arch, ubuntu,
new debian
+
On Sun, May 19, 2013 at 02:17:35PM +0100, John Keeping wrote:
When using git cherry or git log --cherry-pick we often have a small
number of commits on one side and a large number on the other. In
revision.c::cherry_pick_list we store the patch IDs for the small side
before comparing the
When we are rebasing without options ('am' mode), the head rebased lives
in '$g/rebase-apply/head-name', so lets use that information so it's
reported the same way as if we were doing other rebases (-i or -m).
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
On Wed, May 29, 2013 at 1:17 AM, Johannes Sixt j.s...@viscovery.net wrote:
Am 5/29/2013 5:24, schrieb Felipe Contreras:
+if [ -z $script ]; then
+ local -a locations
+ locations=(
+ '/etc/bash_completion.d/git' # fedora, old debian
+
---
t/t3401-rebase-partial.sh | 24
t/t3420-rebase-topology-linear.sh | 58 +++
2 files changed, 58 insertions(+), 24 deletions(-)
diff --git a/t/t3401-rebase-partial.sh b/t/t3401-rebase-partial.sh
index 58f4823..7ba1797 100755
---
Update the following:
- Quote 'setup'
- Remove blank lines within test case body
- Use test_commit instead of custom quick_one
- Create branch topic from tag created by test_commit
---
t/t3406-rebase-message.sh | 30 +-
1 file changed, 9 insertions(+), 21
Helped-by: Johannes Sixt j...@kdbg.org
---
t/lib-rebase.sh | 15
t/t3420-rebase-topology-linear.sh | 78 +++
2 files changed, 93 insertions(+)
create mode 100755 t/t3420-rebase-topology-linear.sh
diff --git a/t/lib-rebase.sh
---
t/t3420-rebase-topology-linear.sh | 129 ++
1 file changed, 129 insertions(+)
diff --git a/t/t3420-rebase-topology-linear.sh
b/t/t3420-rebase-topology-linear.sh
index 40fe264..2429aa8 100755
--- a/t/t3420-rebase-topology-linear.sh
+++
t3406 is supposed to test messages from rebase operation, so let's
move tests in t3400 that fit that description into 3406. Most of the
functionality they tested, except for the messages, has now been
subsumed by t3420.
---
t/t3400-rebase.sh | 22 --
---
t/t3400-rebase.sh | 31 +
t/t3401-rebase-partial.sh | 45 ---
t/t3404-rebase-interactive.sh | 10 +-
t/t3409-rebase-preserve-merges.sh | 53
t/t3425-rebase-topology-merges.sh | 250 ++
5 files changed, 252
---
t/lib-rebase.sh | 17
t/t3420-rebase-topology-linear.sh | 85 +++
2 files changed, 102 insertions(+)
diff --git a/t/lib-rebase.sh b/t/lib-rebase.sh
index 62b3887..16eeb1c 100644
--- a/t/lib-rebase.sh
+++ b/t/lib-rebase.sh
@@
After way too long, here is finally a new version of the tests I sent
at: http://thread.gmane.org/gmane.comp.version-control.git/205796.
I have split the test up into two files. They stil take quite some
time to run.
Martin von Zweigbergk (7):
add simple tests of consistency across rebase
Hi all,
I have a commit like this:
commit 4d77a3cee01db0412956d40875c79f51ac745acc
tree 3443c9f633114c3bd2e015453a8c55a171e62b53
parent 340d808ade8a79857bec40770f0eb4f98224c53d
author
committer .
which modifies file A/B/C (ie specifically does not add, but changes
On Wed, May 29, 2013 at 1:39 AM, Martin von Zweigbergk
martinv...@gmail.com wrote:
After way too long, here is finally a new version of the tests I sent
at: http://thread.gmane.org/gmane.comp.version-control.git/205796.
I have split the test up into two files. They stil take quite some
time
On Wed, May 29, 2013 at 02:20:07AM -0400, Jeff King wrote:
In the best case, we compute no patch-ids at all. And even for the
average case, I'd expect our lazy calculation to only have to compute a
handful of ids.
Here is a not-well-tested version of the idea. I tried to contain the
changes
Am 5/29/2013 8:39, schrieb Martin von Zweigbergk:
+test_run_rebase () {
+ result=$1
+ shift
+ test_expect_$result rebase $* --onto --root with merge-base does not
go to root
+ reset_rebase
+ git rebase $* --onto m --root g
+ test_cmp_rev
On Tue, May 28, 2013 at 9:19 PM, Duy Nguyen pclo...@gmail.com wrote:
On Wed, May 29, 2013 at 10:41 AM, Duy Nguyen pclo...@gmail.com wrote:
The changes in this area since 1.8.2.3 seem to be Karsten's (I'm not
blaming, just wanted to narrow down the problem). The patterns of
interest seem to be
On Tue, May 28, 2013 at 10:20:48PM -0500, Felipe Contreras wrote:
It's _very_ slow in many cases, and there's really no point in fetching
*everything* from the remote just for completion. In many cases it might
be faster for the user to type the whole thing.
If the user manually specifies
On Wed, May 29, 2013 at 03:22:25AM -0400, Jeff King wrote:
revs=origin/master...origin/jk/submodule-subdirectory-ok
stock|you |me
---
real 0m0.501s | 0m0.078s | 0m0.098s
user 0m0.480s | 0m0.056s | 0m0.084s
sys 0m0.016s |
Am 5/29/2013 8:39, schrieb Martin von Zweigbergk:
+# a---b---c
+# \ \
+# d---e \
+#\ \ \
+# n---o---w---v
+# \
+# z
+#TODO: make all flavors of rebase use --topo-order
+test_run_rebase success 'e n o'
On Wed, May 29, 2013 at 04:47:35PM +1000, Erik de Castro Lopo wrote:
I have a commit like this:
commit 4d77a3cee01db0412956d40875c79f51ac745acc
tree 3443c9f633114c3bd2e015453a8c55a171e62b53
parent 340d808ade8a79857bec40770f0eb4f98224c53d
author
committer .
Felipe Contreras felipe.contre...@gmail.com writes:
Thomas Rast wrote:
Junio C Hamano gits...@pobox.com writes:
Thomas Rast Cc'ed as he has been the primary force behind this line
of notes usability.
Thanks for pointing this out to me.
Felipe Contreras felipe.contre...@gmail.com
On Wed, May 29, 2013 at 3:09 AM, Thomas Rast tr...@inf.ethz.ch wrote:
Felipe Contreras felipe.contre...@gmail.com writes:
Feel free to implement that. I'm just interested in 'git cherry-pick' being
usable for 'git rebase' purposes.
Which would have been obvious to all but the most casual
Michael Haggerty mhag...@alum.mit.edu writes:
Since string_list_add_one_ref() adds refname to the string list, but
the lifetime of refname is limited, it is important that the
string_list passed to string_list_add_one_ref() has strdup_strings
set. Document this fact.
All current callers do
Michael Haggerty mhag...@alum.mit.edu writes:
I read the entire series on Monday, and give it an Ack at maybe 90%
confidence level -- sorry, I was short on caffeine and sleep ;-)
I meant to verify this assertion:
I did a manual audit of the 50 (!) functions that are used as an
each_ref_fn
Felipe Contreras felipe.contre...@gmail.com writes:
On Wed, May 29, 2013 at 3:09 AM, Thomas Rast tr...@inf.ethz.ch wrote:
Felipe Contreras felipe.contre...@gmail.com writes:
Feel free to implement that. I'm just interested in 'git cherry-pick' being
usable for 'git rebase' purposes.
Which
I would be grateful for any thoughts about the follow problem.
Git status reports untracked files:
$ git status
# On branch master
# Untracked files:
# (use git add file... to include in what will be committed)
#
#
On Tue, May 28, 2013 at 01:51:09PM -0400, Jeff King wrote:
On Thu, May 23, 2013 at 03:01:43PM +0200, Ian Kumlien wrote:
git 1.8.2.1 is started by xinetd
[...]
I have found git receive-packs that has been running for days/weeks
without terminating
Attaching gdb and doing a trace
Scott Chacon wrote:
We're starting off in Berlin, May 9-11th. GitHub has secured
conference space at the Radisson Blu Berlin for those days. I have a
It's a pity that you did not announce the event on the msysgit mailing
list,
too, which is why I totally missed it until today, the
Thomas Koch wrote:
it's a common problem[1,2,3] in Maven (Java) projects and probably in other
environments too: You have the version number of your project written in the
pom.xml. When one merges changes upwards from the maint branche to master,
the
version numbers in maint and master are
Felipe Contreras wrote:
Junio C Hamano wrote:
Neil Horman nhor...@tuxdriver.com writes:
On Mon, May 27, 2013 at 11:52:18AM -0500, Felipe Contreras wrote:
We should free objects before leaving.
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
sequencer.c | 7 +--
1 file
Am 5/29/2013 8:39, schrieb Martin von Zweigbergk:
+# f
+# /
+# a---b---c---g---h
+# \
+# d---G---i
+#\ \
+# e---u
+#
+# uppercase = cherry-picked
+# h = reverted g
+test_expect_failure rebase -p --onto in merged history does not lose
On Wed, May 29, 2013 at 4:58 AM, Joachim Schmitz
j...@schmitz-digital.de wrote:
Felipe Contreras wrote:
Junio C Hamano wrote:
It probably is better to fold this patch into the other one when it
is rerolled to correct the option name gotcha on the tin.
Why? This patch is standalone and
For rr/rebase-autostash, which is stalled in pu. See $gmane/225689.
This is a super-minor fix anyway: if you disagree with something, change
it; there's no need to ask me.
As for the follow-up introducing a 'stash store', I will submit it in
good time: there's no hurry. I'm working on some
From: Felipe Contreras [mailto:felipe.contre...@gmail.com]
Sent: Wednesday, May 29, 2013 12:52 PM
To: Joachim Schmitz
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] sequencer: trivial fix
On Wed, May 29, 2013 at 4:58 AM, Joachim Schmitz
j...@schmitz-digital.de wrote:
Felipe Contreras
On 05/29/2013 06:16 AM, Felipe Contreras wrote:
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
git-rebase.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/git-rebase.sh b/git-rebase.sh
index 76900a0..9b5d78b 100755
--- a/git-rebase.sh
+++ b/git-rebase.sh
@@ -335,6
On Wed, May 29, 2013 at 3:40 AM, Thomas Rast tr...@inf.ethz.ch wrote:
Felipe Contreras felipe.contre...@gmail.com writes:
On Wed, May 29, 2013 at 3:09 AM, Thomas Rast tr...@inf.ethz.ch wrote:
Felipe Contreras felipe.contre...@gmail.com writes:
Feel free to implement that. I'm just interested
On Wed, May 29, 2013 at 6:13 AM, Joachim Schmitz
j...@schmitz-digital.de wrote:
From: Felipe Contreras [mailto:felipe.contre...@gmail.com]
Sent: Wednesday, May 29, 2013 12:52 PM
To: Joachim Schmitz
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] sequencer: trivial fix
On Wed, May 29, 2013
Junio C Hamano wrote:
* rr/rebase-autostash (2013-05-12) 7 commits
- rebase: implement --[no-]autostash and rebase.autostash
- rebase --merge: return control to caller, for housekeeping
- rebase -i: return control to caller, for housekeeping
- am: return control to caller, for
From: Felipe Contreras [mailto:felipe.contre...@gmail.com]
Sent: Wednesday, May 29, 2013 1:24 PM
To: Joachim Schmitz
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] sequencer: trivial fix
On Wed, May 29, 2013 at 6:13 AM, Joachim Schmitz
j...@schmitz-digital.de wrote:
From: Felipe
Felipe Contreras felipe.contre...@gmail.com writes:
On Wed, May 29, 2013 at 3:40 AM, Thomas Rast tr...@inf.ethz.ch wrote:
Felipe Contreras felipe.contre...@gmail.com writes:
On Wed, May 29, 2013 at 3:09 AM, Thomas Rast tr...@inf.ethz.ch wrote:
Felipe Contreras felipe.contre...@gmail.com
From: Joachim Schmitz [mailto:j...@schmitz-digital.de]
Sent: Wednesday, May 29, 2013 1:30 PM
To: 'Felipe Contreras'
Cc: 'git@vger.kernel.org'
Subject: RE: [PATCH 1/2] sequencer: trivial fix
snip
And for the record: I agree with you that these 2 things should rather not be
in a single
On Wed, May 29, 2013 at 6:34 AM, Thomas Rast tr...@inf.ethz.ch wrote:
Felipe Contreras felipe.contre...@gmail.com writes:
On Wed, May 29, 2013 at 3:40 AM, Thomas Rast tr...@inf.ethz.ch wrote:
Felipe Contreras felipe.contre...@gmail.com writes:
On Wed, May 29, 2013 at 3:09 AM, Thomas Rast
Jeff King p...@peff.net writes:
On Thu, May 23, 2013 at 10:05:03PM +0200, Matthieu Moy wrote:
My use-case is an invalid SSL certificate. Pulling from the wiki with a
recent version of libwww-perl fails, and git-remote-mediawiki gave no
clue about the reason. Give the mediawiki API detailed
My use-case is an invalid SSL certificate. Pulling from the wiki with a
recent version of libwww-perl fails, and git-remote-mediawiki gave no
clue about the reason. Give the mediawiki API detailed error message, and
since it is not so informative, hint the user about an invalid SSL
certificate on
So, did this patch make it anywhere? We could really use it.
Here's the use case. The original ee27ca4 patch broke our build system when
the git server was upgraded to Debian Wheezy last night. The builder fetches
source from the repo in two pieces using git archive, and we need to make
sure both
Thomas Rast wrote:
So until this changes, my $0.02 is a blanket NAK and a refusal to spend
my time reviewing.
Then don't review the damn thing. With Felipe, I have the following
rule of thumb: make some concrete suggestions and forget about
follow-ups. He's not going to accept any general
When we get 40 hex digits, we immediately assume it's an SHA-1. This
is the right thing to do because we have no way else to specify an
object. If there is a ref with the same object name, it will be
ignored. Warn the user about this case because the ref with full
object name is likely a mistake,
Felipe Contreras wrote:
Akin to 'am --skip' and 'rebase --skip'.
This ranged-cherry-pick can be useful for small ranges. As pointed
out by others on the list, it hemorrhages memory quite horribly (and
this problem is non-trivial to fix). Perhaps we should document this
in limitations or bugs
Hi all,
First of all I would like to thank you all for the great tool that is
git. I love it and it makes my days way better.
This is my first post on this mailing list so please apology if there
is something wrong.
I have noticed a regression in the behavior of ignore rules in 1.8.3.
I have
Felipe Contreras wrote:
if (opts-skip_empty is_index_unchanged() == 1) {
- warning(_(skipping %s... %s),
- find_unique_abbrev(commit-object.sha1,
DEFAULT_ABBREV),
- msg.subject);
+ if (!opts-quiet)
+
Dear List,
the manual of git init says: An initial HEAD file that references the
HEAD of the master branch is also created.
However, after creating the repository using git init there's no master
branch. How can make sure that master is created?
Thanks in advance,
Ákos Tajti
--
To
Ákos, Tajti akos.ta...@intland.com writes:
Dear List,
the manual of git init says: An initial HEAD file that references the
HEAD of the master branch is also created.
However, after creating the repository using git init there's no
master branch.
Right, but HEAD still points to it ;-). We
Felipe Contreras wrote:
I think a lot of the functionality of 'git rebase' should move to 'git
cherry-pick', and then all the 'git rebase' code can be simplified
greatly, and tests like these would help a lot.
What do we do about the leakages? Want to take on the task of fixing
the
Matthieu Moy wrote:
the manual of git init says: An initial HEAD file that references the
HEAD of the master branch is also created.
However, after creating the repository using git init there's no
master branch.
Right, but HEAD still points to it ;-). We sometimes call this an
unborn
Thanks for clarifying this thing for me! I don't really insist on having
a master branch it's just that I tried to pull from a repository bundle
and I got this error message:
Cannot merge multiple branches into empty head
The command was:
git pull ../dump.dmp refs/heads/*:refs/heads/*
Is
Ákos, Tajti akos.ta...@intland.com writes:
The command was:
git pull ../dump.dmp refs/heads/*:refs/heads/*
git pull does internally a git fetch followed by a git merge.
If you try to pull several branches at the same time, it means you want
to merge all of them together (octopus merge),
On Tue, May 28, 2013 at 09:32:59PM -0500, Felipe Contreras wrote:
Junio C Hamano wrote:
Neil Horman nhor...@tuxdriver.com writes:
On Mon, May 27, 2013 at 11:52:18AM -0500, Felipe Contreras wrote:
We should free objects before leaving.
Signed-off-by: Felipe Contreras
On Wed, May 29, 2013 at 7:09 AM, Ramkumar Ramachandra
artag...@gmail.com wrote:
Thomas Rast wrote:
So until this changes, my $0.02 is a blanket NAK and a refusal to spend
my time reviewing.
Then don't review the damn thing. With Felipe, I have the following
rule of thumb: make some concrete
Thanks! I ill try using fetch.
Ákos
2013.05.29. 15:08 keltezéssel, Matthieu Moy írta:
Ákos, Tajti akos.ta...@intland.com writes:
The command was:
git pull ../dump.dmp refs/heads/*:refs/heads/*
git pull does internally a git fetch followed by a git merge.
If you try to pull several
Ákos, Tajti wrote:
Cannot merge multiple branches into empty head
The command was:
git pull ../dump.dmp refs/heads/*:refs/heads/*
Is this a better way of doing this?
pull runs a fetch, which updated .git/FETCH_HEAD. Now, if
.git/FETCH_HEAD has just one branch (and other not-for-merge
On Tue, May 28, 2013 at 8:58 PM, Anthony Ramine n.ox...@gmail.com wrote:
Case folding is not done correctly when matching against the [:upper:]
character class and uppercased character ranges (e.g. A-Z).
Specifically, an uppercase letter fails to match against any of them
when case folding is
On Mon, May 27, 2013 at 11:52 PM, Felipe Contreras
felipe.contre...@gmail.com wrote:
We should free objects before leaving.
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
Micronit: perhaps you should move the free obejcts before leaving
(in do_pick_commit) to the subject instead of
On Wed, May 29, 2013 at 7:27 AM, Ramkumar Ramachandra
artag...@gmail.com wrote:
Felipe Contreras wrote:
Akin to 'am --skip' and 'rebase --skip'.
This ranged-cherry-pick can be useful for small ranges. As pointed
out by others on the list, it hemorrhages memory quite horribly (and
this
On Wed, May 29, 2013 at 7:33 AM, Ramkumar Ramachandra
artag...@gmail.com wrote:
Felipe Contreras wrote:
if (opts-skip_empty is_index_unchanged() == 1) {
- warning(_(skipping %s... %s),
- find_unique_abbrev(commit-object.sha1,
DEFAULT_ABBREV),
-
On Wed, May 29, 2013 at 7:31 PM, Nicolas Desprès
nicolas.desp...@gmail.com wrote:
I have noticed a regression in the behavior of ignore rules in 1.8.3.
Yeah, it looks like everybody suddenly realizes this regression soon
after the release, not before :( This has been reported three times so
far.
Felipe Contreras wrote:
Did you miss the -q option passed to 'git commit'?
Ah, yes.
It would help if you mentioned:
Introduce --quiet to suppress warning about skipped commits (when
using --skip-empty) and output from 'git commit'.
in the commit message.
Thanks.
--
To unsubscribe from
On Wed, May 29, 2013 at 8:25 AM, Duy Nguyen pclo...@gmail.com wrote:
On Mon, May 27, 2013 at 11:52 PM, Felipe Contreras
felipe.contre...@gmail.com wrote:
We should free objects before leaving.
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
Micronit: perhaps you should move the
Replied inline.
Regards,
--
Anthony Ramine
Le 29 mai 2013 à 15:22, Duy Nguyen a écrit :
On Tue, May 28, 2013 at 8:58 PM, Anthony Ramine n.ox...@gmail.com wrote:
Case folding is not done correctly when matching against the [:upper:]
character class and uppercased character ranges (e.g.
On Wed, May 29, 2013 at 8:32 AM, Ramkumar Ramachandra
artag...@gmail.com wrote:
Felipe Contreras wrote:
Did you miss the -q option passed to 'git commit'?
Ah, yes.
It would help if you mentioned:
Introduce --quiet to suppress warning about skipped commits (when
using --skip-empty) and
On Wed, May 29, 2013 at 8:34 PM, Felipe Contreras
felipe.contre...@gmail.com wrote:
On Wed, May 29, 2013 at 8:25 AM, Duy Nguyen pclo...@gmail.com wrote:
On Mon, May 27, 2013 at 11:52 PM, Felipe Contreras
felipe.contre...@gmail.com wrote:
We should free objects before leaving.
Signed-off-by:
On Wed, May 29, 2013 at 8:31 AM, Duy Nguyen pclo...@gmail.com wrote:
On Wed, May 29, 2013 at 7:31 PM, Nicolas Desprès
nicolas.desp...@gmail.com wrote:
I have noticed a regression in the behavior of ignore rules in 1.8.3.
Yeah, it looks like everybody suddenly realizes this regression soon
On 2013-05-28 19.04, Junio C Hamano wrote:
Can you tell me what the conclusion on the discussion on your two
other patches on 'pu'?
* rj/mingw-cygwin (2013-05-08) 2 commits
- cygwin: Remove the CYGWIN_V15_WIN32API build variable
- mingw: rename WIN32 cpp macro to GIT_WINDOWS_NATIVE
I
On Wed, May 29, 2013 at 8:42 AM, Duy Nguyen pclo...@gmail.com wrote:
On Wed, May 29, 2013 at 8:34 PM, Felipe Contreras
felipe.contre...@gmail.com wrote:
On Wed, May 29, 2013 at 8:25 AM, Duy Nguyen pclo...@gmail.com wrote:
On Mon, May 27, 2013 at 11:52 PM, Felipe Contreras
Felipe Contreras wrote:
What you are really complaining about is that I don't agree with
*every* single suggestion you make. And since you made them, they must
be sensible, and single I don't agree with you, I must not be
sensible, is that right?
Oh, I have no problems: I reviewed
On Wed, May 29, 2013 at 8:37 PM, Anthony Ramine n.ox...@gmail.com wrote:
Le 29 mai 2013 à 15:22, Duy Nguyen a écrit :
On Tue, May 28, 2013 at 8:58 PM, Anthony Ramine n.ox...@gmail.com wrote:
Case folding is not done correctly when matching against the [:upper:]
character class and uppercased
On Wed, May 29, 2013 at 7:50 AM, Ramkumar Ramachandra
artag...@gmail.com wrote:
Felipe Contreras wrote:
I think a lot of the functionality of 'git rebase' should move to 'git
cherry-pick', and then all the 'git rebase' code can be simplified
greatly, and tests like these would help a lot.
On Wed, May 29, 2013 at 3:31 PM, Duy Nguyen pclo...@gmail.com wrote:
On Wed, May 29, 2013 at 7:31 PM, Nicolas Desprès
nicolas.desp...@gmail.com wrote:
I have noticed a regression in the behavior of ignore rules in 1.8.3.
Yeah, it looks like everybody suddenly realizes this regression soon
On Wed, May 29, 2013 at 8:46 PM, Felipe Contreras
felipe.contre...@gmail.com wrote:
On Wed, May 29, 2013 at 8:42 AM, Duy Nguyen pclo...@gmail.com wrote:
On Wed, May 29, 2013 at 8:34 PM, Felipe Contreras
felipe.contre...@gmail.com wrote:
On Wed, May 29, 2013 at 8:25 AM, Duy Nguyen
On Wed, May 29, 2013 at 8:48 AM, Ramkumar Ramachandra
artag...@gmail.com wrote:
Felipe Contreras wrote:
There's nothing wrong with me choosing how best to spend my time. Really.
Ofcourse you are. You have arguably spent it very productively
solving a lot of user issues (especially
On Wed, May 29, 2013 at 8:54 AM, Duy Nguyen pclo...@gmail.com wrote:
On Wed, May 29, 2013 at 8:46 PM, Felipe Contreras
felipe.contre...@gmail.com wrote:
On Wed, May 29, 2013 at 8:42 AM, Duy Nguyen pclo...@gmail.com wrote:
On Wed, May 29, 2013 at 8:34 PM, Felipe Contreras
Hello,
When on a CIFS filesystem a git checkout does not replicate the executable
flag from the repository:
$ git clone git://git/abettersqlplus
Cloning into 'abettersqlplus'...
remote: Counting objects: 522, done.
remote: Compressing objects: 100% (342/342), done.
remote: Total 522
On Wed, May 29, 2013 at 02:01:59PM +0200, Matthieu Moy wrote:
I wonder if we can do something like:
our $mw_operation;
$mediawiki-{config}-{on_error} = sub {
[...]
die $err\n;
};
Probably, but that would hardcode the fact that mediawiki errors are
fatal, while in
On Wed, May 29, 2013 at 02:06:29PM +0200, Matthieu Moy wrote:
My use-case is an invalid SSL certificate. Pulling from the wiki with a
recent version of libwww-perl fails, and git-remote-mediawiki gave no
clue about the reason. Give the mediawiki API detailed error message, and
since it is not
The temporary directory prepared by difftool --dir-diff to
show the result of a change can be modified by the user via
the tree diff program, and we try hard not to lose changes
to them after tree diff program returns to us.
However, the set of files to be copied back is computed
differently
Michael Haggerty mhag...@alum.mit.edu writes:
The old version copied one entry to its destination position, then
deleted any matching entries from the tail of the array. This
required the tail of the array to be copied multiple times. It didn't
affect the complexity of the algorithm because
Am 29.05.2013 06:19, schrieb Duy Nguyen:
On Wed, May 29, 2013 at 10:41 AM, Duy Nguyen pclo...@gmail.com wrote:
The changes in this area since 1.8.2.3 seem to be Karsten's (I'm not
blaming, just wanted to narrow down the problem). The patterns of
interest seem to be
!/bin
/bin/*
!/bin/brew
Michael Haggerty mhag...@alum.mit.edu writes:
Change the callers that were already passing copies to
add_object_array_with_mode() to either skip the copy, or (if the
memory needed to be allocated anyway) freeing the memory itself.
A part of this commit effectively reverts
70d26c6e76
Felipe Contreras felipe.contre...@gmail.com writes:
Junio C Hamano gits...@pobox.com wrote:
Felipe Contreras felipe.contre...@gmail.com writes:
+wanted = get_config('remote-bzr.branches').rstrip().split(', ')
Two minor nits and one design suggestion:
- Why rstrip() not strip()?
Felipe Contreras felipe.contre...@gmail.com writes:
Junio C Hamano wrote:
Felipe Contreras felipe.contre...@gmail.com writes:
Let's show the output so it's clear why it failed.
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com
---
t/t3400-rebase.sh | 1 +
1 file changed,
Michael Haggerty mhag...@alum.mit.edu writes:
The commits leading up to this have (hopefully) fixed all of the
callers of the for_each_ref()-like functions. This commit does the
last step: documents what each_ref_fn callbacks can assume about
object lifetimes.
Signed-off-by: Michael
On Wed, May 29, 2013 at 11:42 AM, Junio C Hamano gits...@pobox.com wrote:
Felipe Contreras felipe.contre...@gmail.com writes:
Junio C Hamano gits...@pobox.com wrote:
Felipe Contreras felipe.contre...@gmail.com writes:
+wanted = get_config('remote-bzr.branches').rstrip().split(', ')
On Wed, May 29, 2013 at 11:52 AM, Junio C Hamano gits...@pobox.com wrote:
Felipe Contreras felipe.contre...@gmail.com writes:
Junio C Hamano wrote:
Felipe Contreras felipe.contre...@gmail.com writes:
Let's show the output so it's clear why it failed.
Signed-off-by: Felipe Contreras
Felipe Contreras felipe.contre...@gmail.com writes:
I do not see how it makes sense to copy how they deviate from us
back to our codebase, especially if we plan to eventually move some
of these tests out of contrib/ area, but even without such a plan in
the future.
They deviate from us, we
Felipe Contreras felipe.contre...@gmail.com writes:
Junio C Hamano wrote:
* fc/makefile (2013-05-26) 5 commits
- build: do not install git-remote-testpy
- build: add NO_INSTALL variable
- build: cleanup using $
- build: cleanup using $^
- build: trivial simplification
(this branch
Ramkumar Ramachandra artag...@gmail.com writes:
For rr/rebase-autostash, which is stalled in pu. See $gmane/225689.
This is a super-minor fix anyway: if you disagree with something, change
it; there's no need to ask me.
As I wasn't the one who were disagreeing, that would not work
well.
Junio C Hamano wrote:
As I wasn't the one who were disagreeing, that would not work
well.
I meant in the tiny details like echo + gettext versus gettext.
From the review of v3, nobody had any disagreements; just minor
suggestions: that's what this patch is about anyway.
--
To unsubscribe from
1 - 100 of 173 matches
Mail list logo
