Re: [BUG REPORT] git 2.9.0 clone --recursive fails on cloning a submodule

On zo, 2016-06-19 at 18:09 -0700, Stefan Beller wrote: > How often do we see a depth != 1 in practice? Travis clones with --depth=50 D. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [BUG REPORT] git 2.9.0 clone --recursive fails on cloning a submodule

> How often do we see a depth != 1 in practice? FYI: Here is an example of depth 10 from Swift Package Manager which is git-based https://github.com/apple/swift-package-manager/blob/61bdff3e9c2b8456be31861b4cda87a31440d517/Sources/Get/Git.swift try system(Git.tool, "clone",

Re: Managing sub-projects

On Sat, Jun 18, 2016 at 4:20 PM, Michael Eager wrote: > > Any other ways to do what I want without creating a separate forked > repo for each of the sub-projects? Or have I misunderstood one of > these schemes? I think forking is the way to go here, as you want to have new

Re: [BUG REPORT] git 2.9.0 clone --recursive fails on cloning a submodule

On Sun, Jun 19, 2016 at 5:13 PM, Jeff King wrote: > On Sun, Jun 19, 2016 at 01:51:56PM -0700, Junio C Hamano wrote: > >> Yup, something like this on top of d22eb04 to be merged before >> v2.9.1 for the maintenance track would be necessary. >> >> -- >8 -- >> Subject: clone: do not

Re: [BUG REPORT] git 2.9.0 clone --recursive fails on cloning a submodule

On Sun, Jun 19, 2016 at 01:51:56PM -0700, Junio C Hamano wrote: > Yup, something like this on top of d22eb04 to be merged before > v2.9.1 for the maintenance track would be necessary. > > -- >8 -- > Subject: clone: do not let --depth imply --shallow-submodules > > In v2.9.0, we prematurely

Re: What's cooking in git.git (Jun 2016, #05; Thu, 16)

Junio C Hamano writes: > Michael Haggerty writes: > >> According to [1], something in that test seems to have been trying to run >> >> git update-ref -d git-p4-tmp/6 >> >> Similarly in the other failed test. > > Ah, OK, that would try mucking with

Short-term plans for the post 2.9 cycle

Here are the list of topics that are in the "private edition" I use for every day work, grouped by where they sit in the the near-term plan of merging them up to 'next' and then to 'master'. These will be merged to 'master' soonish. ew/fast-import-unpack-limit

What's cooking in git.git (Jun 2016, #06; Sun, 19)

Here are the topics that have been cooking. Commits prefixed with '-' are only in 'pu' (proposed updates) while commits prefixed with '+' are in 'next'. The ones marked with '.' do not appear in any of the integration branches, but I am still holding onto them. The tip of 'next' will be rewound

Re: [PATCH] git-sh-setup.sh: fix missing double quotes variables

Junio C Hamano writes: > LE Manh Cuong writes: > >> It's really a good commit message, better than mine. >> >> So must I make another patch or you will update the commit message? >> >> PS: This is the first time I submit a patch to Git, so forgive

Re: [PATCH] git-sh-setup.sh: fix missing double quotes variables

LE Manh Cuong writes: > It's really a good commit message, better than mine. > > So must I make another patch or you will update the commit message? > > PS: This is the first time I submit a patch to Git, so forgive me > if I made any silly questions. I can locally

Re: [BUG REPORT] git 2.9.0 clone --recursive fails on cloning a submodule

Jeff King writes: > Stefan, I think it might be worth revisiting the default set by d22eb04 > to propagate shallowness from the super-project clone. In an ideal > world, we would be asking each submodule for the actual commit we are > interested in, and shallowness would not

Re: [PATCH] pathspec: prevent empty strings as pathspecs

Thanks for the quick responses on this patch! In response to Junio: > "At least you would need two-step process to introduce a change like > this to warn the people whose tools and workflows you are breaking. > That is, (1) in one release, you add code to only detect the case > you will be

Re: [PATCH 5/5] format-patch: avoid freopen()

On Sat, Jun 18, 2016 at 6:04 AM, Johannes Schindelin wrote: > We just taught the relevant functions to respect the diffopt.file field, > to allow writing somewhere else than stdout. Let's make use of it. > [...] > Signed-off-by: Johannes Schindelin

Re: What's cooking in git.git (Jun 2016, #05; Thu, 16)

> On 19 Jun 2016, at 20:49, Lars Schneider wrote: > > >> On 19 Jun 2016, at 20:13, Junio C Hamano wrote: >> >> Lars Schneider writes: >> >>> This seems to fix the issue: >>> >>> --- a/git-p4.py >>> +++ b/git-p4.py >>>

Re: What's cooking in git.git (Jun 2016, #05; Thu, 16)

> On 19 Jun 2016, at 20:13, Junio C Hamano wrote: > > Lars Schneider writes: > >> This seems to fix the issue: >> >> --- a/git-p4.py >> +++ b/git-p4.py >> @@ -2274,7 +2274,7 @@ class P4Sync(Command, P4UserMap): >>

Re: [PATCH v1] travis-ci: enable web server tests t55xx on Linux

Lars Schneider writes: > Hi Junio, > > is there any chance to pick this up? It would enable the web server > tests on Travis CI. There always are chances unless a patch was rejected with some reason, like "no, I do not like it" ;-) I do not see anybody commenting on

Re: What's cooking in git.git (Jun 2016, #05; Thu, 16)

Lars Schneider writes: > This seems to fix the issue: > > --- a/git-p4.py > +++ b/git-p4.py > @@ -2274,7 +2274,7 @@ class P4Sync(Command, P4UserMap): > self.useClientSpec_from_options = False > self.clientSpecDirs = None > self.tempBranches =

Re: What's cooking in git.git (Jun 2016, #05; Thu, 16)

Michael Haggerty writes: > According to [1], something in that test seems to have been trying to run > > git update-ref -d git-p4-tmp/6 > > Similarly in the other failed test. Ah, OK, that would try mucking with .git/git-p4-tmp/6 but that is not a place to have a ref.

Re: [PATCH] git-sh-setup.sh: fix missing double quotes variables

It's really a good commit message, better than mine. So must I make another patch or you will update the commit message? PS: This is the first time I submit a patch to Git, so forgive me if I made any silly questions. -- To unsubscribe from this list: send the line "unsubscribe git" in the body

Re: What's cooking in git.git (Jun 2016, #05; Thu, 16)

Michael Haggerty writes: >> Good timing. I was planning to kick split-under-lock and any of its >> dependents temporarily out of 'next', so that fixes can choose not >> to be incremental, and dependent topics can be rebased on top of the >> fixed fondation. Even if we do

Re: [PATCH] git-sh-setup.sh: fix missing double quotes variables

Junio C Hamano writes: > LE Manh Cuong writes: > >> It's not only people shooting their foot, but also from malicious user. >> Given that `curl url | sudo sh/bash` is often found in many instructions, >> an end user may not be noticed about the

Re: [PATCH v2 0/8] object_id part 4

On Sun, Jun 19, 2016 at 05:24:48AM -0400, Jeff King wrote: > On Sun, Jun 19, 2016 at 10:50:14AM +0200, Johannes Sixt wrote: > > To avoid future mistakes, can you write down how "transform plain structs > > before pointers to structs" looks like? Is it a particular order of > > Coccinelle rules?

Re: [PATCH v1] travis-ci: enable web server tests t55xx on Linux

> On 19 May 2016, at 10:45, larsxschnei...@gmail.com wrote: > > From: Lars Schneider > > Install the "apache" package to run the Git web server tests on > Travis-CI Linux build machines. The tests are already executed on OS X > build machines since the apache web

Re: [PATCH] perf: accommodate for MacOSX

> On 18 Jun 2016, at 15:03, Johannes Schindelin > wrote: > > As this developer has no access to MacOSX developer setups anymore, > Travis becomes the best bet to run performance tests on that OS. We don't run the performance tests on Travis CI right now. Maybe we

Re: What's cooking in git.git (Jun 2016, #05; Thu, 16)

> On 19 Jun 2016, at 17:04, Lars Schneider wrote: > > >> On 19 Jun 2016, at 09:59, Michael Haggerty wrote: >> >> On 06/18/2016 12:05 AM, Lars Schneider wrote: >>> On 17 Jun 2016, at 05:20, Junio C Hamano wrote:

Re: what is a snapshot?

From: "Ovatta Bianca" I read in every comparison of git vs other version control systems, that git does not record differences but takes "snapshots" I was wondering what a "snapshot" is ? Does git store at every commit the entire files which have been modified even if

Re: What's cooking in git.git (Jun 2016, #05; Thu, 16)

> On 19 Jun 2016, at 09:59, Michael Haggerty wrote: > > On 06/18/2016 12:05 AM, Lars Schneider wrote: >> >>> On 17 Jun 2016, at 05:20, Junio C Hamano wrote: >>> >>> ... >>> >>> * mh/split-under-lock (2016-05-13) 33 commits >>> ... >>> >>> Further

Re: [BUG REPORT] git 2.9.0 clone --recursive fails on cloning a submodule

On Sun, Jun 19, 2016 at 04:07:41PM +0300, Vadim Eisenberg wrote: > The problem is with other tools that use git, like Swift Package Manager - > https://swift.org/package-manager/. > Versions of git before 2.9.0 have no option --no-shallow-submodules. So > the tools that use git would have to

Fwd: what is a snapshot?

I read in every comparison of git vs other version control systems, that git does not record differences but takes "snapshots" I was wondering what a "snapshot" is ? Does git store at every commit the entire files which have been modified even if only a few bytes were changed out of a large file?

Greetings

Greetings, Please revert back to me for claim an unclaimed Fund USD10, 000, 000, left behind by my late client of same nationality of yours, before it gets confiscated by the authorities. I am waiting for swift response for more detail. Best regards, Church Christian Esq. Email:

Re: [BUG REPORT] git 2.9.0 clone --recursive fails on cloning a submodule

The problem is with other tools that use git, like Swift Package Manager - https://swift.org/package-manager/. Versions of git before 2.9.0 have no option --no-shallow-submodules. So the tools that use git would have to check if the version of git is greater than or equal 2.9.0 to know to

Re: [PATCH] git-sh-setup.sh: fix missing double quotes variables

> While I think enclosing the string in dq is an improvement (as I > said already), I still do think your use of the v-word is making a > mountain out of an anthill. Well, sorry if that word is annoyed. So, is this patch fine or I must re-phrase the title? -- To unsubscribe from this list: send

Re: [PATCH v2 2/2] log: add log.showSignature configuration variable

Hi Eric, Thanks for your review. On Sun, Jun 19, 2016 at 12:29 PM, Eric Sunshine wrote: > On Sat, Jun 18, 2016 at 8:25 AM, Mehul Jain wrote: >> diff --git a/t/t4202-log.sh b/t/t4202-log.sh >> @@ -900,6 +900,31 @@ test_expect_success GPG

Re: [PATCH v2] Refactor recv_sideband()

On Wed, 15 Jun 2016 at 09:14:54, Lukas Fleischer wrote: > What we could do is reintroduce the local prefix variable I had in v1 > and use that to store whether a prefix needs to be prepended or not. If > we do that and if we are fine with strbuf memory being (potentially) > allocated and

Re: What's cooking in git.git (May 2016, #08; Thu, 26)

On Sat, Jun 18, 2016 at 06:19:23PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > On Thu, May 26, 2016 at 03:50:14PM -0700, Junio C Hamano wrote: > > > >> * jk/upload-pack-hook (2016-05-24) 6 commits > >> - upload-pack: provide a hook for running pack-objects > >> -

Re: [BUG REPORT] git 2.9.0 clone --recursive fails on cloning a submodule

On Sun, Jun 19, 2016 at 10:17:36AM +0300, Vadim Eisenberg wrote: > /usr/local/bin/git clone --recursive --depth 10 > https://github.com/IBM-Swift/Kitura-net.git > Cloning into 'Kitura-net'... > remote: Counting objects: 253, done. > remote: Compressing objects: 100% (142/142), done. > remote:

Re: [PATCH] prune: keep files created after process start

On Sat, Jun 18, 2016 at 08:58:03PM -0700, Junio C Hamano wrote: > Eric Wong writes: > > > Avoid pruning files which were written after the prune process > > starts, as it possible to concurrently create new objects while > > "git prune" is running. > > > > Tested on git.git by

Re: [PATCH v2 0/8] object_id part 4

On Sun, Jun 19, 2016 at 10:50:14AM +0200, Johannes Sixt wrote: > Am 19.06.2016 um 00:13 schrieb brian m. carlson: > > * Adjust the Coccinelle patches to transform plain structs before > >pointers to structs to avoid misconversions. This addresses the issue > >that Peff caught originally.

Re: [PATCH v2 0/8] object_id part 4

Am 19.06.2016 um 00:13 schrieb brian m. carlson: * Adjust the Coccinelle patches to transform plain structs before pointers to structs to avoid misconversions. This addresses the issue that Peff caught originally. To avoid future mistakes, can you write down how "transform plain

Re: [PATCH] prune: keep files created after process start

Andreas Schwab wrote: > Eric Wong writes: > > > @@ -21,7 +22,7 @@ static int prune_tmp_file(const char *fullpath) > > struct stat st; > > if (lstat(fullpath, )) > > return error("Could not stat '%s'", fullpath); > > - if (st.st_mtime

Re: What's cooking in git.git (Jun 2016, #05; Thu, 16)

On 06/18/2016 08:20 PM, Junio C Hamano wrote: > Michael Haggerty writes: > >> On 06/17/2016 05:20 AM, Junio C Hamano wrote: >>> [...] >>> * mh/ref-iterators (2016-06-03) 13 commits >>> (merged to 'next' on 2016-06-06 at c8e79dc) >>> + ... >>> (this branch is used by

Re: What's cooking in git.git (Jun 2016, #05; Thu, 16)

On 06/18/2016 12:05 AM, Lars Schneider wrote: > >> On 17 Jun 2016, at 05:20, Junio C Hamano wrote: >> >> ... >> >> * mh/split-under-lock (2016-05-13) 33 commits >> (merged to 'next' on 2016-06-03 at 2e71330) >> + lock_ref_sha1_basic(): only handle REF_NODEREF mode >> +

[BUG REPORT] git 2.9.0 clone --recursive fails on cloning a submodule

/usr/local/bin/git clone --recursive --depth 10 https://github.com/IBM-Swift/Kitura-net.git Cloning into 'Kitura-net'... remote: Counting objects: 253, done. remote: Compressing objects: 100% (142/142), done. remote: Total 253 (delta 134), reused 188 (delta 86), pack-reused 0 Receiving objects:

Re: [PATCH] prune: keep files created after process start

Eric Wong writes: > @@ -21,7 +22,7 @@ static int prune_tmp_file(const char *fullpath) > struct stat st; > if (lstat(fullpath, )) > return error("Could not stat '%s'", fullpath); > - if (st.st_mtime > expire) > + if (st.st_mtime > expire ||

Re: [PATCH v2 2/2] log: add log.showSignature configuration variable

On Sat, Jun 18, 2016 at 8:25 AM, Mehul Jain wrote: > Users may want to always use "--show-signature" while using git-log and > related commands. > > When log.showSignature is set to true, git-log and related commands will > behave as if "--show-signature" was given to

Re: [PATCH] pathspec: prevent empty strings as pathspecs

David Turner writes: > The help for rev-parse --show-prefix says: > "When the command is invoked from a subdirectory, show the path of > the current directory relative to the top-level directory." > > This doesn't say what it does when invoked at the top-level. Maybe we >