Re: [PATCH v4 6/6] clean: teach clean -d to skip dirs containing ignored files

Samuel Lijin writes: > + for (j = i = 0; i < dir.nr;) { > + for (; > + j < dir.ignored_nr && > +0 <= cmp_dir_entry([i], [j]); > + j++); > + > + if ((j < dir.ignored_nr) && > +

Re: [PATCH v5] send-email: --batch-size to work around some SMTP server limit

Junio C Hamano 于 2017 年 5 月 22 日 星期一 写道: > I think this is almost perfect. > > I'd propose squashing the patch below to > > - Add cross reference between config and option > > - Spell configuration variables in camelCase to mimic other >sendemail.* variables > > - Spell SMTP in all

Re: [PATCH v4 4/6] dir: hide untracked contents of untracked dirs

Samuel Lijin writes: > + > + /* if DIR_SHOW_IGNORED_TOO, read_directory_recursive() will also pick > + * up untracked contents of untracked dirs; by default we discard these, > + * but given DIR_KEEP_UNTRACKED_CONTENTS we do not > + */ No need to resend

Re: [PATCH v2 2/2] sha1dc: optionally use sha1collisiondetection as a submodule

Junio C Hamano writes: > But when somebody (like me?) feels strongly enough, such a change > can always come on top of this patch, so let's have this > manual-configuration-only version as our first step. Just so that I have something I can come back to, here it is with a log

Re: [PATCH] usage: add NORETURN to BUG() function definitions

Junio C Hamano writes: > Ramsay Jones writes: > >> So, I don't know. Wait let me try your specific version: >> >> $ ~/sparse/sparse --version >> v0.5.0-207-g14964df >> $ ~/sparse/sparse usage.c >> usage.c:220:6: error: symbol 'BUG_fl' redeclared

Re: [PATCH] usage: add NORETURN to BUG() function definitions

Ramsay Jones writes: > So, I don't know. Wait let me try your specific version: > > $ ~/sparse/sparse --version > v0.5.0-207-g14964df > $ ~/sparse/sparse usage.c > usage.c:220:6: error: symbol 'BUG_fl' redeclared with different type > (originally declared at

Re: [PATCH v5] send-email: --batch-size to work around some SMTP server limit

I think this is almost perfect. I'd propose squashing the patch below to - Add cross reference between config and option - Spell configuration variables in camelCase to mimic other sendemail.* variables - Spell SMTP in all caps to mimic other parts of the manual - Suggest use of

Re: [PATCH] usage: add NORETURN to BUG() function definitions

On 22/05/17 02:43, Junio C Hamano wrote: > Ramsay Jones writes: > >> Commit d8193743e0 ("usage.c: add BUG() function", 12-05-2017) added the >> BUG() functions and macros as a replacement for calls to die("BUG: .."). >> The use of NORETURN on the declarations (in

Re: [PATCH] usage: add NORETURN to BUG() function definitions

Ramsay Jones writes: > Commit d8193743e0 ("usage.c: add BUG() function", 12-05-2017) added the > BUG() functions and macros as a replacement for calls to die("BUG: .."). > The use of NORETURN on the declarations (in git-compat-util.h) and the > lack of NORETURN on

Re: [PATCH v2 2/2] sha1dc: optionally use sha1collisiondetection as a submodule

Ævar Arnfjörð Bjarmason writes: > +# Define DC_SHA1_SUBMODULE in addition to DC_SHA1 to use the > +# sha1collisiondetection shipped as a submodule instead of the > +# non-submodule copy in sha1dc/. This is an experimental option used > +# by the git project to migrate to using

Re: [PATCH] ref-filter: treat CRLF as same as LF in find_subpos

DOAN Tran Cong Danh writes: > Starting from commit 949af06 (branch: use ref-filter printing APIs, > 2017-01-10), > `git branch -v` doesn't treat CRLF as line separator anymore. A seemingly good problem identification (but not quite; see below) ... > > Quote from git

Re: [PATCH v4 5/6] dir: expose cmp_name() and check_contains()

Samuel Lijin writes: > We want to use cmp_name() and check_contains() (which both compare > `struct dir_entry`s, the former in terms of the sort order, the latter > in terms of whether one lexically contains another) outside of dir.c, > so we have to (1) change their linkage

Re: [PATCH v3 05/30] log: make --regexp-ignore-case work with --perl-regexp

Ævar Arnfjörð Bjarmason writes: >> Looks good. >> >> I however wonder if it is a better approach in the longer term to >> treat the .ignore_case field just like .extended_regexp_option >> field, i.e. not committing immediately to .regflags but commit it >> after config and

[PATCH] usage: add NORETURN to BUG() function definitions

Commit d8193743e0 ("usage.c: add BUG() function", 12-05-2017) added the BUG() functions and macros as a replacement for calls to die("BUG: .."). The use of NORETURN on the declarations (in git-compat-util.h) and the lack of NORETURN on the function definitions, however, leads sparse to complain

Re: [PATCH v3 4/4] convert: add "status=delayed" to filter process protocol

> On 19 Apr 2017, at 20:55, Torsten Bögershausen wrote: > > >>> (Back to the roots) >>> Which criteria do you have in mind: When should a filter process the blob >>> and return it immediately, and when would it respond "delayed" ? >> >> See above: it's up to the filter. In case

Re: [WIP/RFC 00/23] repository object

On Thu, May 18, 2017 at 04:21:11PM -0700, Brandon Williams wrote: > This is still very much in a WIP state, though it does pass all tests. What > I'm hoping for here is to get a discussion started about the feasibility of a > change like this and hopefully to get the ball rolling. Is this a

[PATCH] ref-filter: treat CRLF as same as LF in find_subpos

Starting from commit 949af06 (branch: use ref-filter printing APIs, 2017-01-10), `git branch -v` doesn't treat CRLF as line separator anymore. Quote from git mailing-list: > Here is a recipe to reproduce the error: > >git init >git commit --allow-empty -m initial >git branch crlf

[PATCH] ref-filter: treat CRLF as same as LF in find_subpos

Starting from commit 949af06 (branch: use ref-filter printing APIs, 2017-01-10), `git branch -v` doesn't treat CRLF as line separator anymore. Quote from git mailing-list: > Here is a recipe to reproduce the error: > >git init >git commit --allow-empty -m initial >git branch crlf

[PATCH v5] send-email: --batch-size to work around some SMTP server limit

Some email servers (e.g. smtp.163.com) limit the number emails to be sent per session(connection) and this will lead to a faliure when sending many messages. Teach send-email to disconnect after sending a number of messages (configurable via the --batch-size= option), wait for a few seconds

[GSoC][PATCH v4 2/2] submodule: port subcommand foreach from shell to C

This aims to make git-submodule foreach a builtin. This is the very first step taken in this direction. Hence, 'foreach' is ported to submodule--helper, and submodule--helper is called from git-submodule.sh. The code is split up to have one function to obtain all the list of submodules. This

[GSoC][PATCH v4 1/2] t7407: test "submodule foreach --recursive" from subdirectory added

Additional test cases added to the submodule-foreach test suite to check the submodule foreach --recursive behavior from a subdirectory as this was missing from the test suite. Mentored-by: Christian Couder Mentored-by: Stefan Beller

[GSoC][PATCH v1 2/2] submodule: port submodule subcommand status

This aims to make git-submodule status a builtin. 'status' is ported to submodule--helper, and submodule--helper is called from git-submodule.sh. For the purpose of porting cmd_status, the code is split up such that one function obtains all the list of submodules, acting as the front-end of

[GSoC][PATCH v1 1/2] submodule: port set_name_rev from shell to C

Since later on we want to port submodule subcommand status, and since set_name_rev is part of cmd_status, hence this function is ported. It has been ported to function set_name_rev in C, which calls get_name_rev to get the revname, and after formatting it, set_name_prints it. And hence in this

URGENT

Ahoj drahý, Volám sa Katie Higginsová, zo Spojených štátov amerických. som Záujem o vás, predstavím svoje vlastné lepšie, akonáhle dostanem Vaša pošta dúfa, že počujete od vás. Vďaka a bozkám. Katie Higginsová.

Re: [WIP/RFC 00/23] repository object

On Thu, May 18, 2017 at 4:21 PM, Brandon Williams wrote: > This is still very much in a WIP state, though it does pass all tests. What > I'm hoping for here is to get a discussion started about the feasibility of a > change like this and hopefully to get the ball rolling. Is

Re: [PATCH v3 05/30] log: make --regexp-ignore-case work with --perl-regexp

On Sun, May 21, 2017 at 1:50 AM, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >> Make the --regexp-ignore-case option work with --perl-regexp. This >> never worked, and there was no test for this. Fix the bug and add a >> test. >> >> When PCRE

Re: [PATCH v3 15/30] perf: add a GIT_PERF_MAKE_COMMAND for when *_MAKE_OPTS won't do

On Sun, May 21, 2017 at 1:50 AM, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >> diff --git a/t/perf/README b/t/perf/README >> index 49ea4349be..b3d95042a8 100644 >> --- a/t/perf/README >> +++ b/t/perf/README >> @@ -60,8 +60,23 @@ You can set

Re: Options to avoid docs generation/installation

On Sun, May 21, 2017 at 4:56 AM, Neil Cafferkey wrote: > The INSTALL file says that docs are not built by default, but that's not my > experience. "make all" results in the generation of several Perl man pages, > e.g. "Git.3pm". Is it the case that the behaviour documented