[PATCH] mailmap: use Kaartic Sivaraam's new address

2017-11-02 Thread Kaartic Sivaraam
Map the old address to the new, hopefully more permanent one. Signed-off-by: Kaartic Sivaraam --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git a/.mailmap b/.mailmap index ab85e0d16..2634baef2 100644 --- a/.mailmap +++ b/.mailmap @@ -113,6 +113,7 @@

Re: [PATCHv2 6/7] builtin/describe.c: describe a blob

2017-11-02 Thread Junio C Hamano
Jacob Keller writes: > I think both questions are valuable, the first is "which commit last > had this blob", the second is "which commit first introduced this > blob", neither of which can always give a definitive answer. It really > depends on what question you're

Re: [RFC PATCH v3 3/4] branch: introduce dont_fail parameter for branchname validation

2017-11-02 Thread Kaartic Sivaraam
On Friday 03 November 2017 12:12 AM, Stefan Beller wrote: On Thu, Nov 2, 2017 at 1:39 AM, Kaartic Sivaraam wrote: On Thursday 02 November 2017 12:24 PM, Kaartic Sivaraam wrote: Signed-off-by: Kaartic Sivaraam Signed-off-by: Kaartic

Re: [RFC PATCH v3 4/4] builtin/branch: give more useful error messages when renaming

2017-11-02 Thread Kaartic Sivaraam
On Thursday 02 November 2017 07:51 PM, Eric Sunshine wrote: Nicely explained; easily understood. Good to hear that. Translators can correct me, but this smells like "sentence lego"[1], which we'd like to avoid. Translators lack full context when presented with bits and pieces of a

Re: [PATCHv3 0/7] git describe blob

2017-11-02 Thread Stefan Beller
On Thu, Nov 2, 2017 at 6:46 PM, Junio C Hamano wrote: > Jacob Keller writes: > >> I agree, "something" is better than "nothing", and we can work to >> improve "something" in the future, especially after we get more real >> use and see what people think.

Re: [PATCHv2] config: document blame configuration

2017-11-02 Thread Stefan Beller
On Thu, Nov 2, 2017 at 6:26 PM, SZEDER Gábor wrote: > On Thu, Nov 2, 2017 at 7:10 PM, Stefan Beller wrote: > >> +blame.blankBoundary:: >> + Show blank SHA-1 for boundary commits in linkgit:git-blame[1]. > > This is still SHA-1 instead of object id

Re: [PATCH 3/3] mingw: document the experimental standard handle redirection

2017-11-02 Thread Junio C Hamano
Johannes Schindelin writes: >> If I was correct in assuming that "2>&1" is just as foreign as >> ">/dev/null", then we should be shunning "2>&1" just like we shun >> ">/dev/null". That was all I meant to say. > > Did you know that `2>&1` works in Powershell? No.

Re: [PATCH 1/2] wrapper.c: consistently quote filenames in error messages

2017-11-02 Thread Junio C Hamano
Simon Ruderich writes: > On Thu, Nov 02, 2017 at 02:16:52PM +0900, Junio C Hamano wrote: >> Junio C Hamano writes: >>> This patch is incomplete without adjusting a handful of tests to >>> expect the updated messages, no? >> >> I'll squash these in while queuing, but there

Re: [PATCHv3 0/7] git describe blob

2017-11-02 Thread Junio C Hamano
Jacob Keller writes: > I agree, "something" is better than "nothing", and we can work to > improve "something" in the future, especially after we get more real > use and see what people think. Only question would be how much do we > need to document the current behavior

Re: [PATCHv2] config: document blame configuration

2017-11-02 Thread SZEDER Gábor
On Thu, Nov 2, 2017 at 7:10 PM, Stefan Beller wrote: > +blame.blankBoundary:: > + Show blank SHA-1 for boundary commits in linkgit:git-blame[1]. This is still SHA-1 instead of object id (or perhaps "commit object name" would be even better). Not sure whether oversight

[PATCH] setup.c: don't try to access '//HEAD' during repo discovery

2017-11-02 Thread SZEDER Gábor
Commit ce9b8aab5 (setup_git_directory_1(): avoid changing global state, 2017-03-13) changed how the git directory is discovered, and as a side effect when the discovery reaches the root directory Git tries to access paths like '//HEAD' and '//objects'. This interacts badly with Cygwin, which

Re: git tries to stat //HEAD when searching for a repo, leading to huge delays on Cygwin

2017-11-02 Thread Jeff King
On Thu, Nov 02, 2017 at 11:45:55PM +, Andrew Baumann wrote: > I have a workaround for this, but someone on stack overflow [1] > suggested reporting it upstream, so here you go: > > I have a fancy shell prompt that executes "git rev-parse > --is-inside-work-tree" to determine whether we're

Re: [PATCHv3 0/7] git describe blob

2017-11-02 Thread Jacob Keller
On Thu, Nov 2, 2017 at 12:41 PM, Stefan Beller wrote: > Thanks for the discussion on v2[1]. > > Interdiff is below, just fixing minor things. > > We'll keep the original algorithm for now, deferring an improvement on > the algorithm front towards a future developer. > I

RE: NEED A LOAN?

2017-11-02 Thread Chen Alex Prime Funds
Hello, Do you need a loan? Regards Chen Alex Prime Funds

git tries to stat //HEAD when searching for a repo, leading to huge delays on Cygwin

2017-11-02 Thread Andrew Baumann
Hi, I have a workaround for this, but someone on stack overflow [1] suggested reporting it upstream, so here you go: I have a fancy shell prompt that executes "git rev-parse --is-inside-work-tree" to determine whether we're currently inside a working directory. This causes git to walk up the

Re: [PATCH 00/14] WIP Partial clone part 3: clone, fetch, fetch-pack, upload-pack, and tests

2017-11-02 Thread Jonathan Tan
On Thu, 2 Nov 2017 20:31:15 + Jeff Hostetler wrote: > From: Jeff Hostetler > > This is part 3 of 3 for partial clone. > It assumes that part 1 [1] and part 2 [2] are in place. > > Part 3 is concerned with the commands: clone, fetch,

Re: [PATCH v3 7/7] remote-mediawiki: show progress while fetching namespaces

2017-11-02 Thread Antoine Beaupré
On 2017-11-02 22:31:02, Thomas Adam wrote: > On Thu, Nov 02, 2017 at 06:26:43PM -0400, Antoine Beaupré wrote: >> On 2017-11-02 22:18:07, Thomas Adam wrote: >> > Hi, >> > >> > On Thu, Nov 02, 2017 at 05:25:18PM -0400, Antoine Beaupré wrote: >> >> +print {*STDERR} "$#{$mw_pages} found in

Re: [PATCH v3 4/7] remote-mediawiki: skip virtual namespaces

2017-11-02 Thread Antoine Beaupré
On 2017-11-02 18:43:00, Eric Sunshine wrote: > On Thu, Nov 2, 2017 at 5:25 PM, Antoine Beaupré wrote: >> Virtual namespaces do not correspond to pages in the database and are >> automatically generated by MediaWiki. It makes little sense, >> therefore, to fetch pages from

Re: [PATCH v3 7/7] remote-mediawiki: show progress while fetching namespaces

2017-11-02 Thread Eric Sunshine
On Thu, Nov 2, 2017 at 5:25 PM, Antoine Beaupré wrote: > Without this, the fetch process seems hanged while we fetch page > listings across the namespaces. Obviously, it should be possible to > silence this with -q, but that's an issue already present everywhere > in the code

Re: [PATCH v3 6/7] remote-mediawiki: process namespaces in order

2017-11-02 Thread Eric Sunshine
On Thu, Nov 2, 2017 at 5:25 PM, Antoine Beaupré wrote: > Ideally, we'd process them in numeric order since that is more > logical, but we can't do that yet since this is where we find the > numeric identifiers in the first place. Lexicographic order is a good > compromise. > >

Re: [PATCH v3 5/7] remote-mediawiki: support fetching from (Main) namespace

2017-11-02 Thread Eric Sunshine
On Thu, Nov 2, 2017 at 5:25 PM, Antoine Beaupré wrote: > When we specify a list of namespaces to fetch from, by default the MW > API will not fetch from the default namespace, refered to as "(Main)" > in the documentation: > >

Re: [PATCH v3 4/7] remote-mediawiki: skip virtual namespaces

2017-11-02 Thread Eric Sunshine
On Thu, Nov 2, 2017 at 5:25 PM, Antoine Beaupré wrote: > Virtual namespaces do not correspond to pages in the database and are > automatically generated by MediaWiki. It makes little sense, > therefore, to fetch pages from those namespaces and the MW API doesn't > support

Re: [PATCH v3 7/7] remote-mediawiki: show progress while fetching namespaces

2017-11-02 Thread Thomas Adam
On Thu, Nov 02, 2017 at 06:26:43PM -0400, Antoine Beaupré wrote: > On 2017-11-02 22:18:07, Thomas Adam wrote: > > Hi, > > > > On Thu, Nov 02, 2017 at 05:25:18PM -0400, Antoine Beaupré wrote: > >> +print {*STDERR} "$#{$mw_pages} found in namespace > >> $local_namespace ($namespace_id)\n";

Re: [PATCH v3 7/7] remote-mediawiki: show progress while fetching namespaces

2017-11-02 Thread Antoine Beaupré
On 2017-11-02 22:18:07, Thomas Adam wrote: > Hi, > > On Thu, Nov 02, 2017 at 05:25:18PM -0400, Antoine Beaupré wrote: >> +print {*STDERR} "$#{$mw_pages} found in namespace $local_namespace >> ($namespace_id)\n"; > > How is this any different to using warn()? I appreciate you're using a >

Re: [PATCH 1/9] extension.partialclone: introduce partial clone extension

2017-11-02 Thread Jonathan Tan
On Thu, 2 Nov 2017 20:20:44 + Jeff Hostetler wrote: > From: Jeff Hostetler > > Introduce the ability to have missing objects in a repo. This > functionality is guarded by new repository extension options: >

Re: [PATCH v3 7/7] remote-mediawiki: show progress while fetching namespaces

2017-11-02 Thread Thomas Adam
Hi, On Thu, Nov 02, 2017 at 05:25:18PM -0400, Antoine Beaupré wrote: > +print {*STDERR} "$#{$mw_pages} found in namespace $local_namespace > ($namespace_id)\n"; How is this any different to using warn()? I appreciate you're using a globbed filehandle, but it seems superfluous to me.

Re: Regression[2.14.3->2.15]: Interactive rebase fails if submodule is modified

2017-11-02 Thread Orgad Shaneh
On Thu, Nov 2, 2017 at 8:34 PM, Stefan Beller wrote: > On Thu, Nov 2, 2017 at 1:30 AM, Orgad Shaneh wrote: >> I can't reproduce this with a minimal example, but it happens in my project. >> >> What I tried to do for reproducing is: >> rm -rf super sub >>

RE

2017-11-02 Thread hola
my name is Mrs. Alice Walton, a business woman an America Citizen and the heiress to the fortune of Walmart stores, born October 7, 1949. I have a mission for you worth $100,000,000.00(Hundred Million United State Dollars) which I intend using for CHARITY

[PATCH v3 1/7] remote-mediawiki: add namespace support

2017-11-02 Thread Antoine Beaupré
From: Kevin This introduces a new remote.origin.namespaces argument that is a space-separated list of namespaces. The list of pages extract is then taken from all the specified namespaces. Reviewed-by: Antoine Beaupré Signed-off-by: Antoine Beaupré

[PATCH v3 4/7] remote-mediawiki: skip virtual namespaces

2017-11-02 Thread Antoine Beaupré
Virtual namespaces do not correspond to pages in the database and are automatically generated by MediaWiki. It makes little sense, therefore, to fetch pages from those namespaces and the MW API doesn't support listing those pages. According to the documentation, those virtual namespaces are

[PATCH v3 0/7] remote-mediawiki: namespace support

2017-11-02 Thread Antoine Beaupré
This should be the final roll of patches for namespace support. I included the undef check even though that problem occurs elsewhere in the code. I also removed the needless "my" move. Hopefully that should be the last in the queue!

[PATCH v3 2/7] remote-mediawiki: allow fetching namespaces with spaces

2017-11-02 Thread Antoine Beaupré
From: Ingo Ruhnke we still want to use spaces as separators in the config, but we should allow the user to specify namespaces with spaces, so we use underscore for this. Reviewed-by: Antoine Beaupré Signed-off-by: Antoine Beaupré ---

[PATCH v3 3/7] remote-mediawiki: show known namespace choices on failure

2017-11-02 Thread Antoine Beaupré
If we fail to find a requested namespace, we should tell the user which ones we know about, since those were already fetched. This allows users to fetch all namespaces by specifying a dummy namespace, failing, then copying the list of namespaces in the config. Eventually, we should have a flag

[PATCH v3 6/7] remote-mediawiki: process namespaces in order

2017-11-02 Thread Antoine Beaupré
Ideally, we'd process them in numeric order since that is more logical, but we can't do that yet since this is where we find the numeric identifiers in the first place. Lexicographic order is a good compromise. Reviewed-by: Eric Sunshine Signed-off-by: Antoine Beaupré

[PATCH v3 7/7] remote-mediawiki: show progress while fetching namespaces

2017-11-02 Thread Antoine Beaupré
Without this, the fetch process seems hanged while we fetch page listings across the namespaces. Obviously, it should be possible to silence this with -q, but that's an issue already present everywhere in the code and should be fixed separately:

[PATCH v3 5/7] remote-mediawiki: support fetching from (Main) namespace

2017-11-02 Thread Antoine Beaupré
When we specify a list of namespaces to fetch from, by default the MW API will not fetch from the default namespace, refered to as "(Main)" in the documentation: https://www.mediawiki.org/wiki/Manual:Namespace#Built-in_namespaces I haven't found a way to address that "(Main)" namespace when

Re: [PATCH 4/7] remote-mediawiki: skip virtual namespaces

2017-11-02 Thread Antoine Beaupré
On 2017-11-02 10:24:40, Junio C Hamano wrote: > Antoine Beaupré writes: > >> It might still worth fixing this, but I'm not sure what the process is >> here - in the latest "what's cooking" Junio said this patchset would be >> merged in "next". Should I reroll the patchset to

Re: No log --no-decorate completion?

2017-11-02 Thread Stefan Beller
On Thu, Nov 2, 2017 at 1:25 PM, Max Rothman wrote: > No problem! Let me know if I've done something wrong with this patch, > I'm new to git's contributor process. Thanks for coming up with a patch! Yeah, the contribution process has some initial road blocks; I'll point

Re: [PATCH 5/7] remote-mediawiki: support fetching from (Main) namespace

2017-11-02 Thread Antoine Beaupré
On 2017-11-01 15:56:51, Eric Sunshine wrote: >> diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl >> b/contrib/mw-to-git/git-remote-mediawiki.perl >> @@ -264,9 +264,14 @@ sub get_mw_tracked_categories { >> sub get_mw_tracked_namespaces { >> my $pages = shift; >> foreach my

[PATCH 01/14] upload-pack: add object filtering for partial clone

2017-11-02 Thread Jeff Hostetler
From: Jeff Hostetler Teach upload-pack to negotiate object filtering over the protocol and to send filter parameters to pack-objects. This is intended for partial clone and fetch. The idea to make upload-pack configurable using uploadpack.allowFilter comes from Jonathan

[PATCH 07/14] fetch-pack: test support excluding large blobs

2017-11-02 Thread Jeff Hostetler
From: Jonathan Tan Created tests to verify fetch-pack and upload-pack support for excluding large blobs using --filter=blobs:limit= parameter. Signed-off-by: Jonathan Tan Signed-off-by: Jeff Hostetler ---

[PATCH 03/14] fetch: refactor calculation of remote list

2017-11-02 Thread Jeff Hostetler
From: Jonathan Tan Separate out the calculation of remotes to be fetched from and the actual fetching. This will allow us to include an additional step before the actual fetching in a subsequent commit. Signed-off-by: Jonathan Tan ---

[PATCH 13/14] fetch-pack: restore save_commit_buffer after use

2017-11-02 Thread Jeff Hostetler
From: Jonathan Tan In fetch-pack, the global variable save_commit_buffer is set to 0, but not restored to its original value after use. In particular, if show_log() (in log-tree.c) is invoked after fetch_pack() in the same process, show_log() will return before

[PATCH 06/14] pack-objects: test support for blob filtering

2017-11-02 Thread Jeff Hostetler
From: Jonathan Tan As part of an effort to improve Git support for very large repositories in which clients typically have only a subset of all version-controlled blobs, test pack-objects support for --filter=blobs:limit=, packing only blobs not exceeding that size

[PATCH 09/14] t5500: add fetch-pack tests for partial clone

2017-11-02 Thread Jeff Hostetler
From: Jonathan Tan Signed-off-by: Jonathan Tan Signed-off-by: Jeff Hostetler --- t/t5500-fetch-pack.sh | 36 1 file changed, 36 insertions(+) diff --git a/t/t5500-fetch-pack.sh

[PATCH 12/14] unpack-trees: batch fetching of missing blobs

2017-11-02 Thread Jeff Hostetler
From: Jonathan Tan When running checkout, first prefetch all blobs that are to be updated but are missing. This means that only one pack is downloaded during such operations, instead of one per missing blob. This operates only on the blob level - if a repository has a

[PATCH 14/14] index-pack: silently assume missing objects are promisor

2017-11-02 Thread Jeff Hostetler
From: Jeff Hostetler Teach index-pack to not complain about missing objects when the --promisor flag is given. The assumption is that index-pack is currently building the idx and promisor data and the is_promisor_object() query would fail anyway. Signed-off-by: Jeff

[PATCH 11/14] t5500: more tests for partial clone and fetch

2017-11-02 Thread Jeff Hostetler
From: Jonathan Tan Signed-off-by: Jonathan Tan Signed-off-by: Jeff Hostetler --- t/t5500-fetch-pack.sh | 60 +++ 1 file changed, 56 insertions(+), 4 deletions(-) diff

[PATCH 00/14] WIP Partial clone part 3: clone, fetch, fetch-pack, upload-pack, and tests

2017-11-02 Thread Jeff Hostetler
From: Jeff Hostetler This is part 3 of 3 for partial clone. It assumes that part 1 [1] and part 2 [2] are in place. Part 3 is concerned with the commands: clone, fetch, upload-pack, fetch-pack, remote-curl, index-pack, and the pack-protocol. Jonathan and I independently

[PATCH 02/14] clone, fetch-pack, index-pack, transport: partial clone

2017-11-02 Thread Jeff Hostetler
From: Jeff Hostetler Signed-off-by: Jeff Hostetler --- builtin/clone.c | 9 + builtin/fetch-pack.c | 4 builtin/index-pack.c | 10 ++ fetch-pack.c | 13 + fetch-pack.h | 2 ++

[PATCH 04/14] fetch: add object filtering for partial fetch

2017-11-02 Thread Jeff Hostetler
From: Jeff Hostetler Teach fetch to use the list-objects filtering parameters to allow a "partial fetch" following a "partial clone". Signed-off-by: Jeff Hostetler --- builtin/fetch.c | 66

[PATCH 08/14] fetch: add from_promisor and exclude-promisor-objects parameters

2017-11-02 Thread Jeff Hostetler
From: Jonathan Tan Teach fetch to use from-promisor and exclude-promisor-objects parameters with sub-commands. Initialize fetch_if_missing global variable. Signed-off-by: Jonathan Tan Signed-off-by: Jeff Hostetler

[PATCH 10/14] t5601: test for partial clone

2017-11-02 Thread Jeff Hostetler
From: Jonathan Tan Signed-off-by: Jonathan Tan Signed-off-by: Jeff Hostetler --- builtin/clone.c | 17 ++--- t/t5601-clone.sh | 49 + 2 files changed, 63

[PATCH 05/14] remote-curl: add object filtering for partial clone

2017-11-02 Thread Jeff Hostetler
From: Jeff Hostetler Signed-off-by: Jeff Hostetler --- Documentation/gitremote-helpers.txt | 4 remote-curl.c | 10 -- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git

Re: No log --no-decorate completion?

2017-11-02 Thread Max Rothman
No problem! Let me know if I've done something wrong with this patch, I'm new to git's contributor process. completion: add missing completions for log, diff, show * Add bash completion for the missing --no-* options on git log * Add bash completion for --textconv and --indent-heuristic families

[PATCH 8/9] sha1_file: support lazily fetching missing objects

2017-11-02 Thread Jeff Hostetler
From: Jonathan Tan Teach sha1_file to fetch objects from the remote configured in extensions.partialcloneremote whenever an object is requested but missing. The fetching of objects can be suppressed through a global variable. This is used by fsck and index-pack.

[PATCH 1/9] extension.partialclone: introduce partial clone extension

2017-11-02 Thread Jeff Hostetler
From: Jeff Hostetler Introduce the ability to have missing objects in a repo. This functionality is guarded by new repository extension options: `extensions.partialcloneremote` and `extensions.partialclonefilter`. See the update to

[PATCH 6/9] index-pack: refactor writing of .keep files

2017-11-02 Thread Jeff Hostetler
From: Jonathan Tan In a subsequent commit, index-pack will be taught to write ".promisor" files which are similar to the ".keep" files it knows how to write. Refactor the writing of ".keep" files, so that the implementation of writing ".promisor" files becomes easier.

[PATCH 3/9] fsck: support refs pointing to promisor objects

2017-11-02 Thread Jeff Hostetler
From: Jonathan Tan Teach fsck to not treat refs referring to missing promisor objects as an error when extensions.partialclone is set. For the purposes of warning about no default refs, such refs are still treated as legitimate refs. Signed-off-by: Jonathan Tan

[PATCH 2/9] fsck: introduce partialclone extension

2017-11-02 Thread Jeff Hostetler
From: Jonathan Tan Currently, Git does not support repos with very large numbers of objects or repos that wish to minimize manipulation of certain blobs (for example, because they are very large) very well, even if the user operates mostly on part of the repo, because

[PATCH 9/9] gc: do not repack promisor packfiles

2017-11-02 Thread Jeff Hostetler
From: Jonathan Tan Teach gc to stop traversal at promisor objects, and to leave promisor packfiles alone. This has the effect of only repacking non-promisor packfiles, and preserves the distinction between promisor packfiles and non-promisor packfiles. Signed-off-by:

[PATCH 5/9] fsck: support promisor objects as CLI argument

2017-11-02 Thread Jeff Hostetler
From: Jonathan Tan Teach fsck to not treat missing promisor objects provided on the CLI as an error when extensions.partialcloneremote is set. Signed-off-by: Jonathan Tan Signed-off-by: Jeff Hostetler ---

[PATCH 7/9] introduce fetch-object: fetch one promisor object

2017-11-02 Thread Jeff Hostetler
From: Jonathan Tan Introduce fetch-object, providing the ability to fetch one object from a promisor remote. This uses fetch-pack. To do this, the transport mechanism has been updated with 2 flags, "from-promisor" to indicate that the resulting pack comes from a

[PATCH 4/9] fsck: support referenced promisor objects

2017-11-02 Thread Jeff Hostetler
From: Jonathan Tan Teach fsck to not treat missing promisor objects indirectly pointed to by refs as an error when extensions.partialcloneremote is set. Signed-off-by: Jonathan Tan Signed-off-by: Jeff Hostetler ---

[PATCH 0/9] WIP Partial clone part 2: fsck and promisors

2017-11-02 Thread Jeff Hostetler
From: Jeff Hostetler This is part 2 of a proposed 3 part sequence for partial clone. Part 2 assumes part 1 [1] is in place. Part 2 is concerned with fsck, gc, initial support for dynamic object fetching, and tracking promisor objects. Jonathan Tan originally developed

Re: Git libsecret No Unlock Dialog Issue

2017-11-02 Thread Yaroslav Sapozhnyk
I've tested the code change locally and seems like it fixes the issue. Yaroslav On Thu, Nov 2, 2017 at 2:55 PM, Dennis Kaarsemaker wrote: > On Thu, 2017-11-02 at 11:35 -0700, Stefan Beller wrote: >> On Thu, Nov 2, 2017 at 9:00 AM, Yaroslav Sapozhnyk >>

Re: [PATCH v2 0/6] Partial clone part 1: object filtering

2017-11-02 Thread Jonathan Tan
On Thu, 2 Nov 2017 17:50:07 + Jeff Hostetler wrote: > From: Jeff Hostetler > > Here is V2 of the list-object filtering. It replaces [1] > and reflect a refactoring and simplification of the original. Thanks, overall this looks quite good. I

[PATCHv3 4/7] builtin/describe.c: rename `oid` to avoid variable shadowing

2017-11-02 Thread Stefan Beller
The function `describe` has already a variable named `oid` declared at the beginning of the function for an object id. Do not shadow that variable with a pointer to an object id. Signed-off-by: Stefan Beller --- builtin/describe.c | 8 1 file changed, 4

[PATCHv3 1/7] t6120: fix typo in test name

2017-11-02 Thread Stefan Beller
Signed-off-by: Stefan Beller --- t/t6120-describe.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t6120-describe.sh b/t/t6120-describe.sh index 1c0e8659d9..c8b7ed82d9 100755 --- a/t/t6120-describe.sh +++ b/t/t6120-describe.sh @@ -304,7 +304,7 @@

[PATCHv3 6/7] builtin/describe.c: factor out describe_commit

2017-11-02 Thread Stefan Beller
In the next patch we'll learn how to describe more than just commits, so factor out describing commits into its own function. That will make the next patches easy as we still need to describe a commit as part of describing blobs. While factoring out the functionality to describe_commit, make

[PATCHv3 3/7] revision.h: introduce blob/tree walking in order of the commits

2017-11-02 Thread Stefan Beller
The functionality to list tree objects in the order they were seen while traversing the commits will be used in the next commit, where we teach `git describe` to describe not only commits, but trees and blobs, too. Signed-off-by: Stefan Beller ---

[PATCHv3 5/7] builtin/describe.c: print debug statements earlier

2017-11-02 Thread Stefan Beller
For debuggers aid we'd want to print debug statements early, so introduce a new line in the debug output that describes the whole function, and then change the next debug output to describe why we need to search. Conveniently drop the arg from the second line; which will be useful in a follow up

[PATCHv3 7/7] builtin/describe.c: describe a blob

2017-11-02 Thread Stefan Beller
Sometimes users are given a hash of an object and they want to identify it further (ex.: Use verify-pack to find the largest blobs, but what are these? or [1]) "This is an interesting endeavor, because describing things is hard." -- me, upon writing this patch. When describing commits, we try

[PATCHv3 0/7] git describe blob

2017-11-02 Thread Stefan Beller
Thanks for the discussion on v2[1]. Interdiff is below, just fixing minor things. We'll keep the original algorithm for now, deferring an improvement on the algorithm front towards a future developer. Thanks, Stefan [1] https://public-inbox.org/git/20171031211852.13001-1-sbel...@google.com/

[PATCHv3 2/7] list-objects.c: factor out traverse_trees_and_blobs

2017-11-02 Thread Stefan Beller
With traverse_trees_and_blobs factored out of the main traverse function, the next patch can introduce an in-order revision walking with ease. In the next patch we'll call `traverse_trees_and_blobs` from within the loop walking the commits, such that we'll have one invocation of that function per

Re: [PATCH v2 4/6] list-objects: filter objects in traverse_commit_list

2017-11-02 Thread Jonathan Tan
On Thu, 2 Nov 2017 17:50:11 + Jeff Hostetler wrote: > +int parse_list_objects_filter(struct list_objects_filter_options > *filter_options, > + const char *arg) Returning void is fine, I think. It seems that all your code paths either

Re: Git libsecret No Unlock Dialog Issue

2017-11-02 Thread Dennis Kaarsemaker
On Thu, 2017-11-02 at 11:35 -0700, Stefan Beller wrote: > On Thu, Nov 2, 2017 at 9:00 AM, Yaroslav Sapozhnyk > wrote: > > When using Git on Fedora with locked password store > > credential-libsecret asks for username/password instead of displaying > > the unlock

Re: Git libsecret No Unlock Dialog Issue

2017-11-02 Thread Yaroslav Sapozhnyk
Sorry, should have mentioned that. It's packaged by Fedora - 2.13.6. Yaroslav On Thu, Nov 2, 2017 at 2:35 PM, Stefan Beller wrote: > On Thu, Nov 2, 2017 at 9:00 AM, Yaroslav Sapozhnyk > wrote: >> When using Git on Fedora with locked password

Re: [RFC PATCH v3 3/4] branch: introduce dont_fail parameter for branchname validation

2017-11-02 Thread Stefan Beller
On Thu, Nov 2, 2017 at 1:39 AM, Kaartic Sivaraam wrote: > On Thursday 02 November 2017 12:24 PM, Kaartic Sivaraam wrote: >> >> Signed-off-by: Kaartic Sivaraam >> Signed-off-by: Kaartic Sivaraam > > > I just

Re: Git libsecret No Unlock Dialog Issue

2017-11-02 Thread Stefan Beller
On Thu, Nov 2, 2017 at 9:00 AM, Yaroslav Sapozhnyk wrote: > When using Git on Fedora with locked password store > credential-libsecret asks for username/password instead of displaying > the unlock dialog. Git as packaged by Fedora or upstream Git (which version)? >

Re: Regression[2.14.3->2.15]: Interactive rebase fails if submodule is modified

2017-11-02 Thread Stefan Beller
On Thu, Nov 2, 2017 at 1:30 AM, Orgad Shaneh wrote: > I can't reproduce this with a minimal example, but it happens in my project. > > What I tried to do for reproducing is: > rm -rf super sub > mkdir sub; cd sub; git init > git commit --allow-empty -m 'Initial commit' > mkdir

Re: [PATCHv2 6/7] builtin/describe.c: describe a blob

2017-11-02 Thread Stefan Beller
On Thu, Nov 2, 2017 at 12:23 AM, Andreas Schwab wrote: > On Nov 01 2017, Johannes Schindelin wrote: > >> Sure, but it is still a tricky thing. Imagine >> >> - A1 - B1 - A2 - B2 - B3 >> >> where all the B* commits have the blob. Do you really

[PATCHv2] config: document blame configuration

2017-11-02 Thread Stefan Beller
The options are currently only referenced by the git-blame man page, also explain them in git-config, which is the canonical page to contain all config options. Signed-off-by: Stefan Beller --- * correct option to blame.showRoot * camelCased other options * use

Re: [BUG] git clean -d is too greedy

2017-11-02 Thread Hermanni Suominen
I was a bit trigger happy posting this, after digging a bit more this is a way more serious than I originally thought.   1) .gitignore exists in nested repo (either tracked or untracked)   2) .gitignore is excluded This can be any file, including those commonly excluded such as *~.

Re: On the nature of cover letters [WAS Re: [PATCH 0/6] Create Git/Packet.pm]

2017-11-02 Thread Stefan Beller
On Thu, Nov 2, 2017 at 1:01 AM, Jeff King wrote: > On Thu, Nov 02, 2017 at 04:48:45PM +0900, Junio C Hamano wrote: > >> Jeff King writes: >> >> > If the clutter is too much, it could also go into a git-notes ref >> > (that's not already implemented, but it seems

[PATCH v2 4/6] list-objects: filter objects in traverse_commit_list

2017-11-02 Thread Jeff Hostetler
From: Jeff Hostetler Create traverse_commit_list_filtered() and add filtering interface to allow certain objects to be omitted from the traversal. Update traverse_commit_list() to be a wrapper for the above with a null filter to minimize the number of callers that needed

[PATCH v2 5/6] rev-list: add list-objects filtering support

2017-11-02 Thread Jeff Hostetler
From: Jeff Hostetler Teach rev-list to use the filtering provided by the traverse_commit_list_filtered() interface to omit unwanted objects from the result. This feature is intended to help with partial clone. Object filtering is only allowed when one of the

[PATCH v2 3/6] oidset: add iterator methods to oidset

2017-11-02 Thread Jeff Hostetler
From: Jeff Hostetler Add the usual iterator methods to oidset. Add oidset_remove(). Signed-off-by: Jeff Hostetler --- oidset.c | 10 ++ oidset.h | 36 2 files changed, 46 insertions(+) diff --git

[PATCH v2 6/6] pack-objects: add list-objects filtering

2017-11-02 Thread Jeff Hostetler
From: Jeff Hostetler Teach pack-objects to use the filtering provided by the traverse_commit_list_filtered() interface to omit unwanted objects from the resulting packfile. This feature is intended for partial clone/fetch. Filtering requires the use of the "--stdout"

[PATCH v2 1/6] dir: allow exclusions from blob in addition to file

2017-11-02 Thread Jeff Hostetler
From: Jeff Hostetler Refactor add_excludes() to separate the reading of the exclude file into a buffer and the parsing of the buffer into exclude_list items. Add add_excludes_from_blob_to_list() to allow an exclude file be specified with an OID without assuming a local

[PATCH v2 0/6] Partial clone part 1: object filtering

2017-11-02 Thread Jeff Hostetler
From: Jeff Hostetler Here is V2 of the list-object filtering. It replaces [1] and reflect a refactoring and simplification of the original. After much discussion on the "list-object-filter-map" I've replaced it with a regular oidset -- the only need for the map was to

[PATCH v2 2/6] oidmap: add oidmap iterator methods

2017-11-02 Thread Jeff Hostetler
From: Jeff Hostetler Add the usual map iterator functions to oidmap. Signed-off-by: Jeff Hostetler --- oidmap.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/oidmap.h b/oidmap.h index 18f54cd..d3cd2bb 100644 ---

Re: [PATCH] imap-send: handle NULL return of next_arg()

2017-11-02 Thread René Scharfe
Am 02.11.2017 um 03:18 schrieb Junio C Hamano: > René Scharfe writes: > >> @@ -807,6 +816,8 @@ static int get_cmd_result(struct imap_store *ctx, struct >> imap_cmd *tcmd) >> if (cmdp->cb.cont || cmdp->cb.data) >>

[BUG] git clean -d is too greedy

2017-11-02 Thread Hermanni Suominen
Hi all, Since commit 6b1db4310 it is possible to make git clean -d to remove nested git repositories if 1) .gitignore exists in nested repo (either tracked or untracked) 2) .gitignore is excluded Regarding to 2) it doesn't matter if .gitignore is excluded from (another) .gitignore or

Re: [PATCH 3/3] mingw: document the experimental standard handle redirection

2017-11-02 Thread Johannes Schindelin
Hi Junio, On Thu, 2 Nov 2017, Junio C Hamano wrote: > Johannes Schindelin writes: > > >> > I feel this is the wrong way round. `>/dev/null` may sound very intuitive > >> > to you, but this feature is Windows only. Guess three times how intuitive > >> > it sounds to

Git libsecret No Unlock Dialog Issue

2017-11-02 Thread Yaroslav Sapozhnyk
When using Git on Fedora with locked password store credential-libsecret asks for username/password instead of displaying the unlock dialog. If the store is unlocked credential helper gets the credentials from the store though. -- Regards, Yaroslav Sapozhnyk

COMPENSATION SCAM VICTIM'S $5,000 EVERYDAY,

2017-11-02 Thread Mr. David Hassn
Attn: Beneficiary, I write to inform you that we already issued those documents to accompany your $5,000 payment each day. But the only problem we are having right here is your personal signatures which the Federal Administer of Fund Benin Republic requested that you must sign those documents

Re: [RFC PATCH v3 4/4] builtin/branch: give more useful error messages when renaming

2017-11-02 Thread Eric Sunshine
On Thu, Nov 2, 2017 at 2:54 AM, Kaartic Sivaraam wrote: > From: Kaartic Sivaraam > > When trying to rename an inexistent branch to with a name of a branch > that already exists the rename failed specifying the new branch name > exists

Re: [PATCH 1/3] bisect: fix memory leak and document `find_bisection()`

2017-11-02 Thread Martin Ågren
On 2 November 2017 at 05:54, Junio C Hamano wrote: > Martin Ågren writes: > >> `find_bisection()` rebuilds the commit list it is given by reversing it >> and skipping uninteresting commits. The uninteresting list entries are >> leaked. Free them to fix

Re: [PATCH] reduce_heads: fix memory leaks

2017-11-02 Thread Martin Ågren
On 2 November 2017 at 04:11, Junio C Hamano wrote: > Martin Ågren writes: > >> diff --git a/builtin/merge-base.c b/builtin/merge-base.c >> index 6dbd167d3..b1b7590c4 100644 >> --- a/builtin/merge-base.c >> +++ b/builtin/merge-base.c >> @@ -59,6 +59,8 @@

  1   2   >