Re: [PATCH 1/1] Mark messages for translations

Am 15.01.2018 um 06:44 schrieb Alexander Shopov: @@ -5,11 +5,11 @@ #include "run-command.h" const char git_usage_string[] = - "git [--version] [--help] [-C ] [-c name=value]\n" - " [--exec-path[=]] [--html-path] [--man-path] [--info-path]\n" - " [-p

Draft of Git Rev News edition 35

Hi, A draft of a new Git Rev News edition is available here: https://github.com/git/git.github.io/blob/master/rev_news/drafts/edition-35.md Everyone is welcome to contribute in any section either by editing the above page on GitHub and sending a pull request, or by commenting on this GitHub

Re: [BUG] test_must_fail: does not correctly detect failures - Was Git 2.16.0-rc2 Test Summary on NonStop

Am 15.01.2018 um 03:37 schrieb Randall S. Becker: On January 14, 2018 4:33 PM, I wrote: The exotic error code coming back from perl is 162. I can muck with it, if there was a value more useful to git. * 553 } else if (WIFEXITED(status)) { * 554 code =

[PATCH 1/1] Mark messages for translations

Reuse already translated messages if possible Do not translate messages aimed at developers of git Signed-off-by: Alexander Shopov --- git.c | 30 +++--- setup.c | 52 ++-- 2 files changed, 41

[PATCH 0/1] Marked end user messages for translation

I have marked several messages for translations in git.c and setup.c They pop from time to time on normal usage of git. The messages are aimed at end users and may help them solve issues. I have tried to keep the C formatting conventions in the two files. I have also reused messages which provides

RE: [BUG] test_must_fail: does not correctly detect failures - Was Git 2.16.0-rc2 Test Summary on NonStop

On January 14, 2018 4:33 PM, I wrote: > On January 14, 2018 1:41 PM Johannes Sixt wrote: > > Sent: > > Am 14.01.2018 um 17:50 schrieb Randall S. Becker: > > > Follow-up: This looks like the completion code from perl on NonStop > > > is not the same as expected by git in the case of failures. I

RE: [BUG] test_must_fail: does not correctly detect failures - Was Git 2.16.0-rc2 Test Summary on NonStop

> -Original Message- > From: Johannes Sixt [mailto:j...@kdbg.org] > Sent: On January 14, 2018 1:41 PM wrote: > Am 14.01.2018 um 17:50 schrieb Randall S. Becker: > > Follow-up: This looks like the completion code from perl on NonStop is > > not the same as expected by git in the case of

Re: [PATCH v2] l10n: de.po: translate 72 new messages

Acked-by: Matthias Rüster Thanks! Am 14.01.2018 um 08:46 schrieb Ralf Thielow: > Translate 72 new messages came from git.pot update in 18a907225 (l10n: > git.pot: v2.16.0 round 1 (64 new, 25 removed)) and 005c62fe4 (l10n: > git.pot: v2.16.0 round 2 (8 new, 4

[PATCH v2] packed_ref_cache: don't use mmap() for small files

Take a hint from commit ea68b0ce9f8 (hash-object: don't use mmap() for small files, 2010-02-21) and use read() instead of mmap() for small packed-refs files. This also fixes the problem[1] where xmmap() returns NULL for zero length[2], for which munmap() later fails. Alternatively, we could

Re: [BUG] test_must_fail: does not correctly detect failures - Was Git 2.16.0-rc2 Test Summary on NonStop

Am 14.01.2018 um 17:50 schrieb Randall S. Becker: Follow-up: This looks like the completion code from perl on NonStop is not the same as expected by git in the case of failures. I need to debug this to get more details to the team. We have had completion issues before relating to interpretation

RE: [PATCH] Remoted unnecessary void* from hashmap.h that caused compile warnings

On January 14, 2018 12:25 PM, Philip Oakley wrote: > To: randall.s.bec...@rogers.com; git@vger.kernel.org > Cc: Randall S. Becker > Subject: Re: [PATCH] Remoted unnecessary void* from hashmap.h that > caused compile warnings > > From: >

[PATCH] Removed unnecessary void* from hashmap.h that caused compile warnings

From: "Randall S. Becker" * hashmap.h: Revised the while loop in the hashmap_enable_item_counting to remove unneeded void* item. Signed-off-by: Randall S. Becker --- hashmap.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff

[PATCH v3 2/2] Doc/git-submodule: improve readability and grammar of a sentence

While at it, correctly quote important words. Signed-off-by: Kaartic Sivaraam --- Documentation/git-submodule.txt | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt

[PATCH v3 1/2] Doc/gitsubmodules: make some changes to improve readability and syntax

* Only mention porcelain commands in examples * Split a sentence for better readability * Add missing apostrophes * Clearly specify the advantages of using submodules * Avoid abbreviations * Use "Git" consistently * Improve readability of certain lines * Clarify when a submodule is

[PATCH v3 0/2] Doc/submodules: a few updates

Quoting from v1, These are just a few improvements that I thought would make the documentation related to submodules a little better in various way such as readability, consistency etc., These were things I noticed while reading thise documents. Changes since v2: - Made some

Re: [PATCH] Remoted unnecessary void* from hashmap.h that caused compile warnings

From: Subject: [PATCH] Remoted unnecessary void* from hashmap.h that caused compile warnings s/Remoted/Removed/ ? Maybe shorten to " hashmap.h: remove unnecessary void* " (ex the superflous spaces) -- Philip From: "Randall S. Becker"

RE: [BUG] test_must_fail: does not correctly detect failures - Was Git 2.16.0-rc2 Test Summary on NonStop

On January 13, 2018 3:17 PM, I wrote: > On January 13, 2018 2:31 PM, I wrote: > > On January 13, 2018 1:08 PM, I wrote: > > > Here’s where things are. This is probably the best git release so > > > far > > (ever). > > > After applying a4cdf02, I had 6 total breakages. 3 existing, 3 new. > > > Many

[PATCH v3 1/2] submodule: port submodule subcommand 'sync' from shell to C

Port the submodule subcommand 'sync' from shell to C using the same mechanism as that used for porting submodule subcommand 'status'. Hence, here the function cmd_sync() is ported from shell to C. This is done by introducing four functions: module_sync(), sync_submodule(), sync_submodule_cb() and

[PATCH v3 2/2] submodule: port submodule subcommand 'deinit' from shell to C

The same mechanism is used even for porting this submodule subcommand, as used in the ported subcommands till now. The function cmd_deinit in split up after porting into four functions: module_deinit(), for_each_listed_submodule(), deinit_submodule() and deinit_submodule_cb(). Mentored-by:

[PATCH v3 0/2] Incremental rewrite of git-submodules

Changes in v3: * For the variables: super_config_url and sub_origin_url, xstrdup() was used while assigning "" to them, before freeing. * In case of the function deinit_submodule, since the orignal code doesn't die upon failure of the function mkdir(), printf was used instead of die_errno.

[PATCH] Remoted unnecessary void* from hashmap.h that caused compile warnings

From: "Randall S. Becker" * The while loop in the inline method hashmap_enable_item_counting used an unneeded variable. The loop has been revised accordingly. Signed-off-by: Randall S. Becker --- hashmap.h | 3 +-- 1 file changed, 1

Re: [PATCH v3 4/3] read-cache: don't try to write index if we can't write shared index

On 01/14, Duy Nguyen wrote: > On Sun, Jan 14, 2018 at 5:37 AM, Thomas Gummerer wrote: > > In a0a967568e ("update-index --split-index: do not split if $GIT_DIR is > > read only", 2014-06-13), we tried to make sure we can still write an > > index, even if the shared index can

Re: [PATCH] travis-ci: build Git during the 'script' phase

On Sun, Jan 14, 2018 at 11:43:05AM +0100, SZEDER Gábor wrote: > On Sat, Jan 13, 2018 at 11:54 AM, Jeff King wrote: > > I think there's also a similar feature to include timings for each fold, > > which might be worth pursuing. > > If you look for 'travis_time' in the raw log,

Re: [PATCH] travis-ci: build Git during the 'script' phase

On Sun, Jan 14, 2018 at 11:37:07AM +0100, SZEDER Gábor wrote: > > +fold_cmd () { > > + local name=$1; shift > > + fold "$name" > > + "$@" > > + local ret=$? > > + unfold "$name" > > + return $ret > > +} > > We don't have to fiddle with the return value,

Re: [PATCH] travis-ci: build Git during the 'script' phase

On Sat, Jan 13, 2018 at 11:54 AM, Jeff King wrote: > I think there's also a similar feature to include timings for each fold, > which might be worth pursuing. If you look for 'travis_time' in the raw log, you'll find lines like these: travis_time:start:01ccbe40 $ some-command

Re: [PATCH] travis-ci: build Git during the 'script' phase

On Sat, Jan 13, 2018 at 11:32 AM, Jeff King wrote: > On Fri, Jan 12, 2018 at 02:32:54PM +0100, SZEDER Gábor wrote: > >> That's the just beginning of a looong list of executed test scripts in >> seemingly pseudo-random order. IMHO that's very rarely the interesting >> part; I, for

Re: [PATCH/RFC] diff: add --compact-summary option to complement --stat

On Sun, Jan 14, 2018 at 4:37 PM, Simon Ruderich wrote: > On Sat, Jan 13, 2018 at 08:22:11PM +0700, Nguyễn Thái Ngọc Duy wrote: >> [snip] >> >> For mode changes, executable bit is denoted as "(+x)" or "(-x)" when >> it's added or removed respectively. The same for when a

[PATCH 2/3] read-cache.c: move tempfile creation/cleanup out of write_shared_index

For one thing, we have more consistent cleanup procedure now and always keep errno intact. The real purpose is the ability to break out of write_locked_index() early when mks_tempfile() fails in the next patch. It's more awkward to do it if this mks_tempfile() is still inside

[PATCH 1/3] read-cache.c: change type of "temp" in write_shared_index()

This local variable 'temp' will be passed in from the caller in the next patch. To reduce patch noise, let's change its type now while it's still a local variable and get all the trival conversion out of the next patch. Signed-off-by: Nguyễn Thái Ngọc Duy --- read-cache.c |

[PATCH 3/3] read-cache: don't write index twice if we can't write shared index

In a0a967568e ("update-index --split-index: do not split if $GIT_DIR is read only", 2014-06-13), we tried to make sure we can still write an index, even if the shared index can not be written. We did so by just calling 'do_write_locked_index()' just before 'write_shared_index()'.

Re: [PATCH/RFC] diff: add --compact-summary option to complement --stat

On Sat, Jan 13, 2018 at 08:22:11PM +0700, Nguyễn Thái Ngọc Duy wrote: > [snip] > > For mode changes, executable bit is denoted as "(+x)" or "(-x)" when > it's added or removed respectively. The same for when a regular file is > replaced with a symlink "(+l)" or the other way "(-l)". This also >

Re: [PATCH v3 4/3] read-cache: don't try to write index if we can't write shared index

On Sun, Jan 14, 2018 at 5:37 AM, Thomas Gummerer wrote: > In a0a967568e ("update-index --split-index: do not split if $GIT_DIR is > read only", 2014-06-13), we tried to make sure we can still write an > index, even if the shared index can not be written. > > We did so by