GREAT NEWS!!

2018-04-04 Thread Amnesty International
We have a great news about your E-mail address!!! You Won $950,500.00 USD on Amnesty International Kenya online E-mail Promotion. For more details about your prize claims, file with the following; Names: Country: Tel: Regards, Mr. David Ford

[PATCH] specify encoding for sed command

2018-04-04 Thread Stephon Harris
Fixes issue with seeing `sed: RE error: illegal byte sequence` when running git-completion.bash --- contrib/completion/git-completion.bash | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index

[PATCH v4 3/3] builtin/config: introduce `color` type specifier

2018-04-04 Thread Taylor Blau
As of this commit, the canonical way to retreive an ANSI-compatible color escape sequence from a configuration file is with the `--get-color` action. This is to allow Git to "fall back" on a default value for the color should the given section not exist in the specified configuration(s). With

[PATCH v4 2/3] config.c: introduce 'git_config_color' to parse ANSI colors

2018-04-04 Thread Taylor Blau
In preparation for adding `--type=color` to the `git-config(1)` builtin, let's introduce a color parsing utility, `git_config_color` in a similar fashion to `git_config_`. Signed-off-by: Taylor Blau --- config.c | 10 ++ config.h | 1 + 2 files changed, 11

[PATCH v4 1/3] builtin/config: introduce `--default`

2018-04-04 Thread Taylor Blau
For some use cases, callers of the `git-config(1)` builtin would like to fallback to default values when the variable asked for does not exist. In addition, users would like to use existing type specifiers to ensure that values are parsed correctly when they do exist in the configuration. For

[PATCH v4 0/3] Teach `--default` to `git-config(1)`

2018-04-04 Thread Taylor Blau
Hi, Attached is a fourth re-roll of my series to add "--default" and "--type=color" to "git config" in order to replace: $ git config --get-color [default] with $ git config [--default=] --type=color Since the last revision, I have: - Rebased it upon the latest changes from my series

Re: [PATCH v3 3/3] builtin/config: introduce `color` type specifier

2018-04-04 Thread Taylor Blau
On Fri, Mar 30, 2018 at 11:09:43AM -0700, Junio C Hamano wrote: > Taylor Blau writes: > > > @@ -184,6 +183,7 @@ Valid `[type]`'s include: > > --bool-or-int:: > > --path:: > > --expiry-date:: > > +--color:: > >Historical options for selecting a type specifier. Prefer

Re: [PATCH v3 2/3] config.c: introduce 'git_config_color' to parse ANSI colors

2018-04-04 Thread Taylor Blau
On Fri, Mar 30, 2018 at 04:26:09PM -0400, Eric Sunshine wrote: > On Wed, Mar 28, 2018 at 9:16 PM, Taylor Blau wrote: > > In preparation for adding `--color` to the `git-config(1)` builtin, > > let's introduce a color parsing utility, `git_config_color` in a similar > > fashion

Re: [PATCH v3 1/3] builtin/config: introduce `--default`

2018-04-04 Thread Taylor Blau
On Fri, Mar 30, 2018 at 04:23:56PM -0400, Eric Sunshine wrote: > On Wed, Mar 28, 2018 at 9:16 PM, Taylor Blau wrote: > > This commit (and those following it in this series) aim to eventually > > replace `--get-color` with a consistent alternative. By introducing > >

Re: [PATCH v3 1/3] builtin/config: introduce `--default`

2018-04-04 Thread Taylor Blau
On Fri, Mar 30, 2018 at 11:06:22AM -0700, Junio C Hamano wrote: > Taylor Blau writes: > > > For some use cases, callers of the `git-config(1)` builtin would like to > > fallback to default values when the slot asked for does not exist. In > > addition, users would like to use

[PATCH v5 2/5] stash: convert apply to builtin

2018-04-04 Thread Joel Teichroeb
Add a bulitin helper for performing stash commands. Converting all at once proved hard to review, so starting with just apply let conversion get started without the other command being finished. The helper is being implemented as a drop in replacement for stash so that when it is complete it can

[PATCH v5 5/5] stash: convert pop to builtin

2018-04-04 Thread Joel Teichroeb
Add stash pop to the helper and delete the pop_stash, drop_stash, assert_stash_ref and pop_stash functions from the shell script now that they are no longer needed. Signed-off-by: Joel Teichroeb --- builtin/stash--helper.c | 41

[PATCH v5 3/5] stash: convert drop and clear to builtin

2018-04-04 Thread Joel Teichroeb
Add the drop and clear commands to the builtin helper. These two are each simple, but are being added together as they are quite related. We have to unfortunately keep the drop and clear functions in the shell script as functions are called with parameters internally that are not valid when the

[PATCH v5 0/5] Convert some stash functionality to a builtin

2018-04-04 Thread Joel Teichroeb
I've been working on converting all of git stash to be a builtin, however it's hard to get it all working at once with limited time, so I've moved around half of it to a new stash--helper builtin and called these functions from the shell script. Once this is stabalized, it should be easier to

[PATCH v5 1/5] stash: improve option parsing test coverage

2018-04-04 Thread Joel Teichroeb
In preparation for converting the stash command incrementally to a builtin command, this patch improves test coverage of the option parsing. Both for having too many parameters, or too few. Signed-off-by: Joel Teichroeb --- t/t3903-stash.sh | 35

[PATCH v5 4/5] stash: convert branch to builtin

2018-04-04 Thread Joel Teichroeb
Add stash branch to the helper and delete the apply_to_branch function from the shell script. Signed-off-by: Joel Teichroeb --- builtin/stash--helper.c | 51 + git-stash.sh| 17 ++--- 2 files changed, 53

[PATCH v4 2/2] builtin/config.c: prefer `--type=bool` over `--bool`, etc.

2018-04-04 Thread Taylor Blau
`git config` has long allowed the ability for callers to provide a 'type specifier', which instructs `git config` to (1) ensure that incoming values are satisfiable under that type, and (2) that outgoing values are canonicalized under that type. In another series, we propose to add extend this

[PATCH v4 2/2] builtin/config.c: prefer `--type=bool` over `--bool`, etc.

2018-04-04 Thread Taylor Blau
`git config` has long allowed the ability for callers to provide a 'type specifier', which instructs `git config` to (1) ensure that incoming values are satisfiable under that type, and (2) that outgoing values are canonicalized under that type. In another series, we propose to add extend this

[PATCH v4 1/2] builtin/config.c: treat type specifiers singularly

2018-04-04 Thread Taylor Blau
Internally, we represent `git config`'s type specifiers as a bitset using OPT_BIT. 'bool' is 1<<0, 'int' is 1<<1, and so on. This technique allows for the representation of multiple type specifiers in the `int types` field, but this multi-representation is left unused. In fact, `git config` will

[PATCH v4 0/2] builtin/config.c: prefer `--type=bool` over `--bool`, etc.

2018-04-04 Thread Taylor Blau
Hi, I have attached a fourth re-roll of my series to introduce "--type=" in "git config", and prefer it to "--". In particular, since the last update, I have changed the following: - Clearer wording in the second patch per Eric's suggestion. - Stopped spelling the required argument to

Re: [PATCH v3 1/2] builtin/config.c: treat type specifiers singularly

2018-04-04 Thread Taylor Blau
On Wed, Apr 04, 2018 at 03:57:12AM -0400, Eric Sunshine wrote: > On Wed, Apr 4, 2018 at 2:07 AM, Taylor Blau wrote: > > [...] > > In fact, `git config` will not accept multiple type specifiers at a > > time, as indicated by: > > > > $ git config --int --bool some.section > >

Re: [PATCH v3 2/2] builtin/config.c: prefer `--type=bool` over `--bool`, etc.

2018-04-04 Thread Taylor Blau
On Wed, Apr 04, 2018 at 03:27:48AM -0400, Eric Sunshine wrote: > On Wed, Apr 4, 2018 at 2:07 AM, Taylor Blau wrote: > > In this patch, we prefer `--type=[int|bool|bool-or-int|...]` over > > `--int`, `--bool`, and etc. This allows the aforementioned other patch > > to add

[PATCH v10] ls-remote: create '--sort' option

2018-04-04 Thread Harald Nordgren
Create a '--sort' option for ls-remote, based on the one from for-each-ref. This e.g. allows ref names to be sorted by version semantics, so that v1.2 is sorted before v1.10. Signed-off-by: Harald Nordgren --- Notes: Use 'ref_array_item_push' to fix 'REALLOC_ARRAY'

[PATCH v9] ls-remote: create '--sort' option

2018-04-04 Thread Harald Nordgren
Create a '--sort' option for ls-remote, based on the one from for-each-ref. This e.g. allows ref names to be sorted by version semantics, so that v1.2 is sorted before v1.10. Signed-off-by: Harald Nordgren --- Notes: Create 'ref_array_push' function in ref-filter

Re: [PATCH v8] ls-remote: create '--sort' option

2018-04-04 Thread Harald Nordgren
Without digging to much into the `ref-filter` code itself, it seems like there is an opportunity to generalize and unfify the logic between these two cases. As well as using `ALLOC_GROW`. But maybe that is best left as a follow-up task? Especially since this patch focuses on `ls-remote`. Seems

[PATCH v8] ls-remote: create '--sort' option

2018-04-04 Thread Harald Nordgren
Create a '--sort' option for ls-remote, based on the one from for-each-ref. This e.g. allows ref names to be sorted by version semantics, so that v1.2 is sorted before v1.10. Signed-off-by: Harald Nordgren --- Notes: Partial fixes from Jeff King's comments

GREAT NEWS!!

2018-04-04 Thread Amnesty International
We have a great news about your E-mail address!!! You Won $950,500.00 USD on Amnesty International Kenya online E-mail Promotion. For more details about your prize claims, file with the following; Names: Country: Tel: Regards, Mr. David Ford

GREAT NEWS!!

2018-04-04 Thread Amnesty International
We have a great news about your E-mail address!!! You Won $950,500.00 USD on Amnesty International Kenya online E-mail Promotion. For more details about your prize claims, file with the following; Names: Country: Tel: Regards, Mr. David Ford

Re: Timing issue in t5570 "daemon log records all attributes"

2018-04-04 Thread Jan Palus
On 03.04.2018 16:32, Jeff King wrote: > I'm tempted to say we should just scrap this test. It was added > relatively recently and only shows the fix for a pretty minor bug. > It's probably not worth the contortions to make it race-proof. Thanks for your reply Jeff. It appears race condition in

Re: [RFC PATCH v3 2/2] t7406: add test for non-default branch in submodule

2018-04-04 Thread Stefan Beller
On Wed, Apr 4, 2018 at 1:37 PM, Eddy Petrișor wrote: >> This patch only contains the test, I presume this goes on top of >> https://public-inbox.org/git/20180403222053.23132-1-eddy.petri...@codeaurora.org/ >> which you plan to later submit as one patch including both the

Re: [PATCH] send-email: fix docs regarding storing password with git credential

2018-04-04 Thread Jeff King
On Tue, Apr 03, 2018 at 12:23:48AM +0100, Michal Nazarewicz wrote: > First of all, ‘git credential fill’ does not store credentials > but is used to *read* them. The command which adds credentials > to the helper’s store is ‘git credential approve’. Yep, makes sense (I wish we had just called

Re: [PATCH] send-email: report host and port separately when calling git credential

2018-04-04 Thread Jeff King
On Mon, Apr 02, 2018 at 03:05:35PM -0700, Junio C Hamano wrote: > "git help credential" mentions protocol, host, path, username and > password (and also url which is a short-hand for setting protocol > and host), but not "port". And common sense tells me, when a system > allows setting host but

Re: commit -> public-inbox link helper

2018-04-04 Thread Johannes Schindelin
Hi Mike, as I said here: On Wed, 4 Apr 2018, Mike Rappazzo wrote: > On Wed, Apr 4, 2018 at 12:35 PM, Johannes Schindelin > wrote: > > > > [...] > > > > With --open, it opens the mail in a browser (macOS support is missing, > > mainly because I cannot test: just add

Re: commit -> public-inbox link helper

2018-04-04 Thread Johannes Schindelin
Hi Peff, On Wed, 4 Apr 2018, Jeff King wrote: > On Wed, Apr 04, 2018 at 06:35:59PM +0200, Johannes Schindelin wrote: > > > I found myself in dear need to quickly look up mails in the public-inbox > > mail archive corresponding to any given commit in git.git. Some time ago, > > I wrote a shell

Re: What's cooking in git.git (Mar 2018, #06; Fri, 30)

2018-04-04 Thread Jeff King
On Sat, Mar 31, 2018 at 08:41:11PM +0200, Ævar Arnfjörð Bjarmason wrote: > > [...] > > * jk/drop-ancient-curl (2017-08-09) 5 commits > > - http: #error on too-old curl > > - curl: remove ifdef'd code never used with curl >=7.19.4 > > - http: drop support for curl < 7.19.4 > > - http: drop

Re: [RFC PATCH v3 2/2] t7406: add test for non-default branch in submodule

2018-04-04 Thread Eddy Petrișor
2018-04-04 21:36 GMT+03:00 Stefan Beller : > On Tue, Apr 3, 2018 at 3:26 PM, Eddy Petrișor wrote: >> Notes: >> I am aware this test is not probably the best one and maybe I >> should have first one test that does a one level non-default, before >>

Re: [PATCH] Change permissions on git-completion.bash

2018-04-04 Thread Ævar Arnfjörð Bjarmason
On Wed, Apr 04 2018, Stephon Harris wrote: > Updating git-completion.bash to include instructions to change the > permissions on the file when sourcing it in your .bashrc or .zshrc > file. But why is this needed? Files sourced by shells don't need to be executable, and quoting the bash manual

[PATCH] Change permissions on git-completion.bash

2018-04-04 Thread Stephon Harris
Updating git-completion.bash to include instructions to change the permissions on the file when sourcing it in your .bashrc or .zshrc file. --- contrib/completion/git-completion.bash | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/contrib/completion/git-completion.bash

Re: commit -> public-inbox link helper

2018-04-04 Thread Mike Rappazzo
On Wed, Apr 4, 2018 at 12:35 PM, Johannes Schindelin wrote: > Hi team, > > I found myself in dear need to quickly look up mails in the public-inbox > mail archive corresponding to any given commit in git.git. Some time ago, > I wrote a shell script to help me with

Re: [PATCH 7/6] ref-filter: use generation number for --contains

2018-04-04 Thread Jeff King
On Wed, Apr 04, 2018 at 03:45:30PM -0400, Derrick Stolee wrote: > On 4/4/2018 3:42 PM, Jeff King wrote: > > On Wed, Apr 04, 2018 at 03:22:01PM -0400, Derrick Stolee wrote: > > > > > That is the idea. I should make this clearer in all of my commit messages. > > Yes, please. :) And maybe in the

Re: [PATCH 7/6] ref-filter: use generation number for --contains

2018-04-04 Thread Derrick Stolee
On 4/4/2018 3:42 PM, Jeff King wrote: On Wed, Apr 04, 2018 at 03:22:01PM -0400, Derrick Stolee wrote: That is the idea. I should make this clearer in all of my commit messages. Yes, please. :) And maybe in the documentation of the file format, if it's not there (I didn't check). It's a very

Re: [PATCH 7/6] ref-filter: use generation number for --contains

2018-04-04 Thread Jeff King
On Wed, Apr 04, 2018 at 03:22:01PM -0400, Derrick Stolee wrote: > > I don't know that the reachability property is explicitly promised by > > your work, but it seems like it would be a natural fallout (after all, > > you have to know the generation of each ancestor in order to compute the > >

Re: [PATCH 7/6] ref-filter: use generation number for --contains

2018-04-04 Thread Derrick Stolee
On 4/4/2018 3:16 PM, Jeff King wrote: On Wed, Apr 04, 2018 at 03:06:26PM -0400, Derrick Stolee wrote: @@ -1615,8 +1619,20 @@ static enum contains_result contains_tag_algo(struct commit *candidate, struct contains_cache *cache) { struct

Re: [PATCH 7/6] ref-filter: use generation number for --contains

2018-04-04 Thread Jeff King
On Wed, Apr 04, 2018 at 03:06:26PM -0400, Derrick Stolee wrote: > > > @@ -1615,8 +1619,20 @@ static enum contains_result > > > contains_tag_algo(struct commit *candidate, > > > struct contains_cache > > > *cache) > > > { > > > struct

Re: [PATCH 7/6] ref-filter: use generation number for --contains

2018-04-04 Thread Derrick Stolee
On 4/4/2018 2:22 PM, Jeff King wrote: On Wed, Apr 04, 2018 at 11:45:53AM -0400, Derrick Stolee wrote: @@ -1615,8 +1619,20 @@ static enum contains_result contains_tag_algo(struct commit *candidate, struct contains_cache *cache) { struct

Re: [PATCH 8/6] commit: use generation numbers for in_merge_bases()

2018-04-04 Thread Jeff King
On Wed, Apr 04, 2018 at 02:53:45PM -0400, Derrick Stolee wrote: > > I'd have to do some timings, but I suspect we may want to switch to the > > "tag --contains" algorithm anyway. This still does N independent > > merge-base operations, one per ref. So with enough refs, you're still > > better off

Re: [PATCH v7] ls-remote: create '--sort' option

2018-04-04 Thread Jeff King
On Wed, Apr 04, 2018 at 07:18:42PM +0200, Harald Nordgren wrote: > Jeff, you are right that 'git ls-remote --sort=committerdate' will not > work. Do you think we need to do something about this, or it's fine > that it fails the way you showed? It's a reasonable-sized footgun, but one that I

Re: [PATCH v7] ls-remote: create '--sort' option

2018-04-04 Thread Jeff King
On Wed, Apr 04, 2018 at 07:11:53PM +0200, Harald Nordgren wrote: > @@ -60,6 +60,16 @@ OPTIONS > upload-pack only shows the symref HEAD, so it will be the only > one shown by ls-remote. > > +--sort=:: > + Sort based on the key given. Prefix `-` to sort in > + descending

Re: [PATCH 8/6] commit: use generation numbers for in_merge_bases()

2018-04-04 Thread Derrick Stolee
On 4/4/2018 2:24 PM, Jeff King wrote: On Wed, Apr 04, 2018 at 11:48:42AM -0400, Derrick Stolee wrote: diff --git a/commit.c b/commit.c index 858f4fdbc9..2566cba79f 100644 --- a/commit.c +++ b/commit.c @@ -1059,12 +1059,19 @@ int in_merge_bases_many(struct commit *commit, int nr_reference,

Re: [RFC PATCH v3 2/2] t7406: add test for non-default branch in submodule

2018-04-04 Thread Stefan Beller
On Tue, Apr 3, 2018 at 3:26 PM, Eddy Petrișor wrote: > Notes: > I am aware this test is not probably the best one and maybe I > should have first one test that does a one level non-default, before > trying a test with 2 levels of submodules, but I wanted to express

Re: commit -> public-inbox link helper

2018-04-04 Thread Jeff King
On Wed, Apr 04, 2018 at 06:35:59PM +0200, Johannes Schindelin wrote: > Hi team, > > I found myself in dear need to quickly look up mails in the public-inbox > mail archive corresponding to any given commit in git.git. Some time ago, > I wrote a shell script to help me with that, and I found

Re: [PATCH 8/6] commit: use generation numbers for in_merge_bases()

2018-04-04 Thread Jeff King
On Wed, Apr 04, 2018 at 11:48:42AM -0400, Derrick Stolee wrote: > > diff --git a/commit.c b/commit.c > > index 858f4fdbc9..2566cba79f 100644 > > --- a/commit.c > > +++ b/commit.c > > @@ -1059,12 +1059,19 @@ int in_merge_bases_many(struct commit *commit, int > > nr_reference, struct commit * > >

Re: [PATCH 7/6] ref-filter: use generation number for --contains

2018-04-04 Thread Jeff King
On Wed, Apr 04, 2018 at 11:45:53AM -0400, Derrick Stolee wrote: > @@ -1615,8 +1619,20 @@ static enum contains_result contains_tag_algo(struct > commit *candidate, > struct contains_cache *cache) > { > struct contains_stack contains_stack = { 0,

Re: [PATCH v7] ls-remote: create '--sort' option

2018-04-04 Thread Harald Nordgren
Links to previous revisions: [1] https://public-inbox.org/git/20180402174614.ga28...@sigill.intra.peff.net/T/#m108fe8c83f3558afaea8e317e680f7eaa136e9a9 [2] https://public-inbox.org/git/20180402211920.ga32...@sigill.intra.peff.net/T/#ma9ec4e0ce664160086e535c012e20d76822c60e5 ... [4]

Re: js/runtime-prefix-windows, was Re: What's cooking in git.git (Mar 2018, #06; Fri, 30)

2018-04-04 Thread Johannes Sixt
Am 03.04.2018 um 15:12 schrieb Johannes Schindelin: On Fri, 30 Mar 2018, Junio C Hamano wrote: * js/runtime-prefix-windows (2018-03-27) 2 commits - mingw/msvc: use the new-style RUNTIME_PREFIX helper - exec_cmd: provide a new-style RUNTIME_PREFIX helper for Windows (this branch uses

Re: [PATCH v7] ls-remote: create '--sort' option

2018-04-04 Thread Harald Nordgren
I updated the code to use 'ALLOC_GROW'. I makes sense, I now I realize why array.alloc is there ;) Jeff, you are right that 'git ls-remote --sort=committerdate' will not work. Do you think we need to do something about this, or it's fine that it fails the way you showed? On Wed, Apr 4, 2018 at

[PATCH v7] ls-remote: create '--sort' option

2018-04-04 Thread Harald Nordgren
Create a '--sort' option for ls-remote, based on the one from for-each-ref. This e.g. allows ref names to be sorted by version semantics, so that v1.2 is sorted before v1.10. Signed-off-by: Harald Nordgren --- Notes: Started using 'ALLOC_GROW'

Errors testing on macOS High Sierra version 10.13.4

2018-04-04 Thread Wink Saville
I built git on a mac osx laptop and got some errors when testing. I ran ./ci/run-build-and-tests.sh and three of the tests had failures that appear to be associated with character encoding: ... BUILTIN git-whatchanged SUBDIR git-gui SUBDIR gitk-git SUBDIR templates + make --quiet

Re: [PATCH 8/6] commit: use generation numbers for in_merge_bases()

2018-04-04 Thread Brandon Williams
On 04/04, Derrick Stolee wrote: > On 4/4/2018 11:45 AM, Derrick Stolee wrote: > > The containment algorithm for 'git branch --contains' is different > > from that for 'git tag --contains' in that it uses is_descendant_of() > > instead of contains_tag_algo(). The expensive portion of the branch > >

Re: Socket activation for GitWeb FastCGI with systemd?

2018-04-04 Thread Alex Ivanov
03.04.2018, 23:04, "Jacob Keller" : > On Tue, Apr 3, 2018 at 11:53 AM, Alex Ivanov wrote: >>  Hi. >>  I want to use systemd as fastcgi spawner for gitweb + nginx. >>  The traffic is low and number of users is limited + traversal bots. For >> that reason

commit -> public-inbox link helper

2018-04-04 Thread Johannes Schindelin
Hi team, I found myself in dear need to quickly look up mails in the public-inbox mail archive corresponding to any given commit in git.git. Some time ago, I wrote a shell script to help me with that, and I found myself using it a couple of times, so I think it might be useful for others, too.

Re: [PATCH] completion: improve ls-files filter performance

2018-04-04 Thread Johannes Schindelin
Hi drizzd, On Wed, 4 Apr 2018, Clemens Buchacher wrote: > From the output of ls-files, we remove all but the leftmost path > component and then we eliminate duplicates. We do this in a while loop, > which is a performance bottleneck when the number of iterations is large > (e.g. for 6 files

Re: [PATCH 8/6] commit: use generation numbers for in_merge_bases()

2018-04-04 Thread Derrick Stolee
On 4/4/2018 11:45 AM, Derrick Stolee wrote: The containment algorithm for 'git branch --contains' is different from that for 'git tag --contains' in that it uses is_descendant_of() instead of contains_tag_algo(). The expensive portion of the branch algorithm is computing merge bases. When a

[PATCH 7/6] ref-filter: use generation number for --contains

2018-04-04 Thread Derrick Stolee
A commit A can reach a commit B only if the generation number of A is strictly larger than the generation number of B. This condition allows significantly short-circuiting commit-graph walks. Use generation number for '--contains' type queries. On a copy of the Linux repository where HEAD is

[PATCH 8/6] commit: use generation numbers for in_merge_bases()

2018-04-04 Thread Derrick Stolee
The containment algorithm for 'git branch --contains' is different from that for 'git tag --contains' in that it uses is_descendant_of() instead of contains_tag_algo(). The expensive portion of the branch algorithm is computing merge bases. When a commit-graph file exists with generation numbers

Re: [PATCH 0/3] Lazy-load trees when reading commit-graph

2018-04-04 Thread Derrick Stolee
On 4/3/2018 4:20 PM, Jeff King wrote: On Tue, Apr 03, 2018 at 09:14:50AM -0400, Derrick Stolee wrote: I'm not sure what the exact solution would be, but I imagine something like variable-sized "struct commit"s with the parent pointers embedded, with some kind of flag to indicate the number of

Hey

2018-04-04 Thread Nina Granzotto
Apply for a loan at 3% reply to this Email for more Info

Gruß

2018-04-04 Thread Vladimir Volf
Gruß In einer kurzen Einleitung bin ich der Anwalt Vladimir Volf aus zamberk Tschechische Republik, aber jetzt lebe ich in London, ich habe dir eine E-Mail über meinen verstorbenen Klienten geschickt, aber ich habe keine Antwort von dir erhalten, der Verstorbene ist ein Bürger Von deinem Land mit

Re: [PATCH v3 2/2] t3200: verify "branch --list" sanity when rebasing from detached HEAD

2018-04-04 Thread Eric Sunshine
On Tue, Apr 3, 2018 at 10:47 AM, Kaartic Sivaraam wrote: > From: Eric Sunshine > > "git branch --list" shows an in-progress rebase as: > > * (no branch, rebasing ) > master > ... > > However, if the rebase is started from a detached

Re: [PATCH v3 1/2] builtin/config.c: treat type specifiers singularly

2018-04-04 Thread Eric Sunshine
On Wed, Apr 4, 2018 at 2:07 AM, Taylor Blau wrote: > [...] > In fact, `git config` will not accept multiple type specifiers at a > time, as indicated by: > > $ git config --int --bool some.section > error: only one type at a time. > > This patch uses `OPT_SET_INT` to prefer

[PATCH] completion: improve ls-files filter performance

2018-04-04 Thread Clemens Buchacher
>From the output of ls-files, we remove all but the leftmost path component and then we eliminate duplicates. We do this in a while loop, which is a performance bottleneck when the number of iterations is large (e.g. for 6 files in linux.git). $ COMP_WORDS=(git status -- ar) COMP_CWORD=3;

Re: [PATCH v3 2/2] builtin/config.c: prefer `--type=bool` over `--bool`, etc.

2018-04-04 Thread Eric Sunshine
On Wed, Apr 4, 2018 at 2:07 AM, Taylor Blau wrote: > `git config` has long allowed the ability for callers to provide a 'type > specifier', which instructs `git config` to (1) ensure that incoming > values are satisfiable under that type, and (2) that outgoing values are >

[PATCH v3 1/2] builtin/config.c: treat type specifiers singularly

2018-04-04 Thread Taylor Blau
Internally, we represent `git config`'s type specifiers as a bitset using OPT_BIT. 'bool' is 1<<0, 'int' is 1<<1, and so on. This technique allows for the representation of multiple type specifiers in the `int types` field, but this multi-representation is left unused. In fact, `git config` will

[PATCH v3 2/2] builtin/config.c: prefer `--type=bool` over `--bool`, etc.

2018-04-04 Thread Taylor Blau
`git config` has long allowed the ability for callers to provide a 'type specifier', which instructs `git config` to (1) ensure that incoming values are satisfiable under that type, and (2) that outgoing values are canonicalized under that type. In another series, we propose to add extend this

[PATCH v3 0/2] builtin/config.c: prefer `--type=bool` over `--bool`, etc.

2018-04-04 Thread Taylor Blau
Hi, Here is a v3 of a series to (1) treat type specifiers in `git config` as singulars rather than a collection of bits, and (2) to prefer --type= over --. I have made the following changes since v2: - Fix some misspellings in Documentation/git-config.txt (cc: René). - Handle --no-type