Compliments of the day ;
I have a business proposition for you which I sent you previously,I do not
know if you received it?
Please do find it proper to write me if your email is still active.
Yours Faithfully,
Barr. Alexander Stewart.
From: Alex Riesen <raa.l...@gmail.com>
Currently, selecting a name in the file list (bottom right) panel in
"Tree" mode does not do anything useful if the name is a submodule.
If gitk is currently showing a commit, the submodule names are not shown
at all (which is very confusi
From: Alex Riesen <raa.l...@gmail.com>
Similar to a git gui feature which visualizes history in a submodule,
the submodules cause the gitk be started inside the submodule.
Signed-off-by: Alex Riesen <raa.l...@gmail.com>
---
gitk | 12
1 file changed, 12 insertions(+)
From: Alex Riesen <raa.l...@gmail.com>
Currently, the submodule entries in the file list panel are mostly ignored.
This series attempts to improve the situation by showing part of submodule
history when focusing it in the file list panel and by adding a menu element
to start gitk in the sub
r fixes/enhancements.
I might do, just want to hear more opinions on the matter: someone might have
good reasons for the current behaviour and consider a bug the fact that Patch
mode behaves differently, for instance.
And as I completely screwed up the resend of the series, there will definitely
be a re-
Sorry for broken threading... I'll have to work on that.
---
Diese E-Mail wurde von Avast Antivirus-Software auf Viren geprüft.
https://www.avast.com/antivirus
From: Alex Riesen <raa.l...@gmail.com>
Similar to a git gui feature which visualizes history in a submodule,
the submodules cause the gitk be started inside the submodule.
---
gitk | 12
1 file changed, 12 insertions(+)
diff --git a/gitk b/gitk
index 742f36b..c430dfe
From: Alex Riesen <raa.l...@gmail.com>
Currently, selecting a name in the file list (bottom right) panel in
"Tree" mode does not do anything useful if the name is a submodule.
If gitk is currently showing a commit, the submodule names are not shown
at all (which is very confusi
Currently, the submodule entries in the file list panel are mostly ignored.
This series attempts to improve the situation by showing part of submodule
history when focusing it in the file list panel and by adding a menu element
to start gitk in the submodule (similar to git gui).
Alex Riesen (2
From: Alex Riesen <raa.l...@gmail.com>
The previous behavior conflicts with the "Patch" mode of the panel,
which always shows the changes from the top-level of the repository.
It is also impossible to get back to the full listing without restarting
gitk.
---
Bert Wesarg, Wed, Ma
Stefan Beller, Tue, May 08, 2018 19:07:29 +0200:
> On Tue, May 8, 2018 at 5:22 AM, Alex Riesen
> <alexander.rie...@cetitec.com> wrote:
> > Currently, the submodules either are not shown at all (if listing a
> > committed tree) or a Tcl error appears (when clicking on a subm
Bert Wesarg, Tue, May 08, 2018 15:17:03 +0200:
> On Tue, May 8, 2018 at 2:22 PM, Alex Riesen <alexander.rie...@cetitec.com>
> wrote:
> > +proc flist_gitk {} {
> > +global flist_menu_file findstring gdttype
> > +
> > +set x [shellquote $flist_menu_file]
From: Alex Riesen <raa.l...@gmail.com>
Similar to a git gui feature which visualizes history in a submodule,
the submodules cause the gitk be started inside the submodule.
Signed-off-by: Alex Riesen <raa.l...@gmail.com>
---
gitk | 12
1 file changed, 12 insertions(+)
From: Alex Riesen <raa.l...@gmail.com>
Currently, the submodules either are not shown at all (if listing a
committed tree) or a Tcl error appears (when clicking on a submodule
from the index list).
This will make it show first arbitrarily chosen number of commits,
which might be only marg
Currently, the submodule entries in the file list panel are mostly ignored.
This series attempts to improve the situation by showing part of submodule
history when focusing it in the file list panel and by adding a menu element
to start gitk in the submodule (similar to git gui).
[1/2]: gitk:
03.04.2018, 23:04, "Jacob Keller" <jacob.kel...@gmail.com>:
> On Tue, Apr 3, 2018 at 11:53 AM, Alex Ivanov <gnido...@ya.ru> wrote:
>> Hi.
>> I want to use systemd as fastcgi spawner for gitweb + nginx.
>> The traffic is low and number of users is li
Hi.
I want to use systemd as fastcgi spawner for gitweb + nginx.
The traffic is low and number of users is limited + traversal bots. For that
reason I've decided to use following mimimal services
gitweb.socket
[Unit]
Description=GitWeb Socket
[Socket]
ListenStream=/run/gitweb.sock
Accept=false
It was great to meet some of you in person! Some notes from the
Contributor Summit at Git Merge are below. Taken in haste, so
my apologies if there are any mis-statements.
- Alex
"Does anyone think th
PayPal
Dear,
YoursaccountshassBeenslimited!
-To getsbacksintosyourspaypalsaccount,syousneedstosconfirmsyoursidentity.
-it'sseasy !
1. Clicksonstheslinksbelow.
2.
Confirmsthatsyou'resthesownersofsthesaccount,sandsthensfollowsthesinstructions.
Confirm Your account
Sincerely
,
PayPal
Dear,
YoursaccountshassBeenslimited!
-To getsbacksintosyourspaypalsaccount,syousneedstosconfirmsyoursidentity.
-it'sseasy !
1. Clicksonstheslinksbelow.
2.
Confirmsthatsyou'resthesownersofsthesaccount,sandsthensfollowsthesinstructions.
Confirm Your account
Sincerely
,
--
Hello,
I have a project i want to bring to you.. please respond for details
Alex
Matthieu Moy <g...@matthieu-moy.fr> writes:
> We now use Mail::Address unconditionaly, hence parse_mailboxes is now
> dead code. Remove it and its tests.
>
> Signed-off-by: Matthieu Moy <g...@matthieu-moy.fr>
Reviewed-by: Alex Bennée <alex.ben...@linaro.org&g
l::Address as a hard dependency,
> but it's easy enough to save the trouble of extra-dependency to the end
> user or packager.
>
> Signed-off-by: Matthieu Moy <g...@matthieu-moy.fr>
Reviewed-by: Alex Bennée <alex.ben...@linaro.org>
> ---
> No ch
Matthieu Moy <g...@matthieu-moy.fr> writes:
> From: Alex Bennée <alex.ben...@linaro.org>
>
> We had a regression that broke Linux's get_maintainer.pl. Using
> Mail::Address to parse email addresses fixed it, but let's protect
> against future regressions.
>
>
example.com> Jane Doe]);
> -
> -my @known_failure_list = (q[Jane\ Doe <j...@example.com>],
> - q["Doe, Ja"ne <j...@example.com>],
> - q["Doe, Katarina" Jane <j...@example.com>],
> - q[Jane j...@example.com],
> - q["Jane "Kat"a" ri"na" ",Doe" <j...@example.com>],
> - q[Jane Doe],
> - q[Jane "Doe <j...@example.com>"],
> - q[\"Jane Doe <j...@example.com>],
> - q[Jane\"\" Doe <j...@example.com>],
> - q['Jane "Katarina\" \' Doe' <j...@example.com>]);
> -
> -foreach my $str (@success_list) {
> - my @expected = map { $_->format } Mail::Address->parse("$str");
> - my @actual = Git::parse_mailboxes("$str");
> - is_deeply(\@expected, \@actual, qq[same output : $str]);
> -}
> -
> -TODO: {
> - local $TODO = "known breakage";
> - foreach my $str (@known_failure_list) {
> - my @expected = map { $_->format } Mail::Address->parse("$str");
> - my @actual = Git::parse_mailboxes("$str");
> - is_deeply(\@expected, \@actual, qq[same output : $str]);
> - }
> -}
> -
> -my $is_passing = eval { Test::More->is_passing };
> -exit($is_passing ? 0 : 1) unless $@ =~ /Can't locate object method/;
--
Alex Bennée
; was fixed alongside some of the other .stamp work you did).
As a datapoint, I've seen it fairly regularly with -j8 in 2.15.1
builds from a clean tree that I've been doing recently. I'm looking
forward to not having to make the choice between "maybe run it twice"
or "compile slower" -- this looks great!
- Alex
Ævar Arnfjörð Bjarmason, Wed, Dec 20, 2017 19:24:19 +0100:
> diff --git a/INSTALL b/INSTALL
> index ffb071e9f0..808e07b659 100644
> --- a/INSTALL
> +++ b/INSTALL
> @@ -84,9 +84,24 @@ Issues of note:
>
> GIT_EXEC_PATH=`pwd`
> PATH=`pwd`:$PATH
> - GITPERLLIB=`pwd`/perl/blib/lib
> +
set
bits.
Barring objections from Dscho or Ben, I'll reroll with a version that
shows something like:
fsmonitor last update 1513821151547101894 (5 seconds ago)
5 files valid / 10 files invalid
- Alex
On Mon, 18 Dec 2017, Alex Vandiver wrote:
> dd9005a0a ("fsmonitor: delay updating state until after split index is
> merged", 2017-10-27) began deferring the setting of the
> CE_FSMONITOR_VALID flag until later, such that do_read_index() does
> not perform those steps. Th
On Tue, 19 Dec 2017, Junio C Hamano wrote:
> Alex Vandiver <ale...@dropbox.com> writes:
>
> > Subject: Re: [PATCH 2/6] fsmonitor: Add dir.h include, for
> > untracked_cache_invalidate_path
>
> Perhaps
>
> "Subject: fsmonitor.h: include dir.h"
These were mistakenly left in when the test was introduced, in
1487372d3 ("fsmonitor: store fsmonitor bitmap before splitting index",
2017-11-09)
Signed-off-by: Alex Vandiver <ale...@dropbox.com>
---
t/t7519-status-fsmonitor.sh | 2 --
1 file changed, 2 deletions(-)
diff --git
it shell prompt when
GIT_PS1_SHOWDIRTYSTATE is set.
Signed-off-by: Alex Vandiver <ale...@dropbox.com>
---
builtin/add.c | 2 +-
diff-lib.c| 6 ++
diff.h| 2 ++
3 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/builtin/add.c b/builtin/add.c
index bf01d89e2..bba20b46e 100644
--- a/b
e "echo" was purely to clean up STDERR as I was running the
test interactively. It serves no purpose, which is why it was hard
to understand its benefit. :)
Apologies for missing this (and in not replying here earlier!). I'll
send a commit that drops these.
- Alex
> > +# test that s
e.
I less bothered my the potentially shipping a git specific copy than
ensuring the packagers pick up the dependency when they do their builds.
Do we already have a mechanism for testing for non-core perl modules
during the "configure" phase of git?
--
Alex Bennée
to send a reversion patch because to be honest
hacking on a bunch of perl to handle special mail cases is not my idea
of fun spare time hacking ;-)
I guess the full solution is to make Mail::Address a hard dependency?
--
Alex Bennée
88
So that is about 88 perl modules used in the code base. How many of them
are not part of the core perl distribution?
Should the solution be to just make Mail::Address a hard dependency and
not have the fallback?
--
Alex Bennée
Eric Sunshine <sunsh...@sunshineco.com> writes:
> A few more comments/observations...
>
> On Thu, Nov 16, 2017 at 10:48 AM, Alex Bennée <alex.ben...@linaro.org> wrote:
>> diff --git a/perl/Git.pm b/perl/Git.pm
>> @@ -93
Signed-off-by: Alex Bennée <alex.ben...@linaro.org>
Cc: Eric Sunshine <sunsh...@sunshineco.com>
---
perl/Git.pm | 3 +++
t/t9000/test.pl | 3 ++-
t/t9001-send-email.sh | 16
3 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/perl/Git.pm b/perl/
Signed-off-by: Alex Bennée <alex.ben...@linaro.org>
Cc: Eric Sunshine <sunsh...@sunshineco.com>
---
perl/Git.pm | 3 +++
t/t9000/test.pl | 3 ++-
t/t9001-send-email.sh | 16
3 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/perl/Git.pm b/perl/
Eric Sunshine <sunsh...@sunshineco.com> writes:
> On Thu, Nov 16, 2017 at 10:48 AM, Alex Bennée <alex.ben...@linaro.org> wrote:
>> Getting rid of Mail::Address regressed behaviour with common
>> get_maintainer scripts such as the Linux kernel. Fix the missed co
Alex Bennée <alex.ben...@linaro.org> writes:
> Getting rid of Mail::Address regressed behaviour with common
> get_maintainer scripts such as the Linux kernel. Fix the missed corner
> case and add a test for it.
>
> diff --git a/t/t9001-send-email.sh b/t/t9001-send-email
Getting rid of Mail::Address regressed behaviour with common
get_maintainer scripts such as the Linux kernel. Fix the missed corner
case and add a test for it.
Fixes: cc9075067776ebd34cc08f31bf78bb05f12fd879
Signed-off-by: Alex Bennée <alex.ben...@linaro.org>
---
perl/Git.pm
to it. Specifically, it seems like this
problem is likely more widespread than this one place, so adjusting it
in the example hook may just be leaving the same dangerous edge for
others to stumble across later.
- Alex
itor_dirty is kept from being leaked by
being freed when the extension data is written -- which always happens
precisely once, no matter the split index configuration.
Signed-off-by: Alex Vandiver <ale...@dropbox.com>
---
fsmonitor.c | 20
fsmonitor.h
through a shell.
Signed-off-by: Alex Vandiver <ale...@dropbox.com>
---
t/t7519/fsmonitor-watchman | 3 ++-
templates/hooks--fsmonitor-watchman.sample | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/t/t7519/fsmonitor-watchman b/t/t7519/fsmonitor-watchman
Hello,
Do you need a loan?
Regards
Chen Alex
Prime Funds
Schindelin wrote:
> ... to which end we introduced the DEVELOPER flag to catch these: if you
> call
>
> make DEVELOPER=1
Aha! Thanks for the tip; I'll be sure to use that from now on.
- Alex
diagnose suspected problems.
Agree -- that seems like a better home for this logic.
> > I am working on other, more substantial savings for index load times
> > (stay tuned) but this seemed like a small simple way to help speed
> > things up.
I'm interested to hear more about what direction you're looking in here.
- Alex
the CWD to the top of the working directory, for consistency.
Signed-off-by: Alex Vandiver <ale...@dropbox.com>
---
fsmonitor.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fsmonitor.c b/fsmonitor.c
index 7c1540c05..4ea44dcc6 100644
--- a/fsmonitor.c
+++ b/fsmonitor.c
@@ -121,6 +121,7 @@
Updates since v2:
- Fix tab which crept into 1/4
- Fixed the benchmarking code in the commit message in 2/4 to just
always load JSON::XS -- the previous version was the version where
I'd broken that to force loading of JSON::PP.
- Remove the --no-pretty from the t/ version of
Signed-off-by: Alex Vandiver <ale...@dropbox.com>
---
Documentation/git.txt | 4
1 file changed, 4 insertions(+)
diff --git a/Documentation/git.txt b/Documentation/git.txt
index 1fca63634..720db196e 100644
--- a/Documentation/git.txt
+++ b/Documentation/git.txt
@@ -594,6 +
tmap until after tweak_split_index
has been called to merge in the base index as well.
The new fsmonitor_dirty is kept from being leaked by dint of being
cleaned up in post_read_index_from, which is guaranteed to be called
after do_read_index in read_index_from.
Signed-off-by: Alex Van
, "$ENV{PWD}", {}]|;
print CHLD_IN $query;
close CHLD_IN;
my $response = do {local $/; };
JSON::XS->new->utf8->decode($response);
Signed-off-by: Alex Vandiver <ale...@dropbox.com>
---
templates/hooks--fsmonitor-watchman.sample | 2 +-
1 file changed,
subdirectories.
Weird. I double-checked and I see the same behavior with watchman
4.9.0 as with 4.7.0 that I had been using previously. I wonder if
something's different between `git` in `next` from wherever your
branch was based.
- Alex
On Thu, 26 Oct 2017, Ben Peart wrote:
> On 10/25/2017 9:31 PM, Alex Vandiver wrote:
> > diff --git a/t/t7519/fsmonitor-watchman b/t/t7519/fsmonitor-watchman
> > index a3e30bf54..79f24325c 100755
> > --- a/t/t7519/fsmonitor-watchman
> > +++ b/t/t7519/fsmonitor-
On Thu, 26 Oct 2017, Ben Peart wrote:
> On 10/25/2017 9:31 PM, Alex Vandiver wrote:
> > diff --git a/fsmonitor.c b/fsmonitor.c
> > index 7c1540c05..0d26ff34f 100644
> > --- a/fsmonitor.c
> > +++ b/fsmonitor.c
> > @@ -121,6 +121,7 @@ static int query_fsmonitor(int
On Wed, 25 Oct 2017, Alex Vandiver wrote:
> The fsmonitor command inherits the PWD of its caller, which may be
> anywhere in the working copy. This makes is difficult for the
> fsmonitor command to operate on the whole repository. Specifically,
> for the watchman integration, this
the CWD to the top of the working directory, for consistency.
Signed-off-by: Alex Vandiver <ale...@dropbox.com>
---
fsmonitor.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fsmonitor.c b/fsmonitor.c
index 7c1540c05..0d26ff34f 100644
--- a/fsmonitor.c
+++ b/fsmonitor.c
@@ -121,6 +121,7 @@
tmap until after tweak_split_index
has been called to merge in the base index as well.
The new fsmonitor_dirty is kept from being leaked by dint of being
cleaned up in post_read_index_from, which is guaranteed to be called
after do_read_index in read_index_from.
Signed-off-by: Alex Van
Signed-off-by: Alex Vandiver <ale...@dropbox.com>
---
Documentation/git.txt | 4
1 file changed, 4 insertions(+)
diff --git a/Documentation/git.txt b/Documentation/git.txt
index 1fca63634..720db196e 100644
--- a/Documentation/git.txt
+++ b/Documentation/git.txt
@@ -594,6 +
]|;
print CHLD_IN $query;
close CHLD_IN;
my $response = do {local $/; };
my $json_pkg;
eval {
require JSON::XSomething;
$json_pkg = "JSON::XSomething";
1;
} or do {
require JSON::PP;
$json_pkg = "JSON::PP";
}
Updated based on comments from Dscho and Ben. Thanks for those!
- Alex
o lower the
impact of tracing to let it be more prevalent, but I'd rather not
block these changes on that.
Thanks for the comments!
- Alex
stalled; without it installed, the runtime is so long
that I gave up waiting for it.
Anyways, I'll put that in the commit message in the re-roll.
- Alex
[1] https://metacpan.org/release/Dumbbench
0"
}
As I understand it, that means that it then loses all performance
gains in the new directory, as it spits out "all dirty."
- Alex
tmap until after tweak_split_index
has been called to merge in the base index as well.
Signed-off-by: Alex Vandiver <ale...@dropbox.com>
---
cache.h | 1 +
fsmonitor.c | 38 --
read-cache.c | 4
3 files changed, 29 insertions(+), 14 deletion
Signed-off-by: Alex Vandiver <ale...@dropbox.com>
---
t/t7519/fsmonitor-watchman | 3 ++-
templates/hooks--fsmonitor-watchman.sample | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/t/t7519/fsmonitor-watchman b/t/t7519/fsmonitor-watchman
index a3e
A few fixes found from playing around with the fsmonitor branch in
next.
- Alex
Signed-off-by: Alex Vandiver <ale...@dropbox.com>
---
Documentation/git.txt | 4
1 file changed, 4 insertions(+)
diff --git a/Documentation/git.txt b/Documentation/git.txt
index 1fca63634..720db196e 100644
--- a/Documentation/git.txt
+++ b/Documentation/git.txt
@@ -594,6 +
This provides small performance savings.
Signed-off-by: Alex Vandiver <ale...@dropbox.com>
---
t/t7519/fsmonitor-watchman | 2 +-
templates/hooks--fsmonitor-watchman.sample | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/t7519/fsmonitor-watchman b/t
ltered.
- Alex
this information from
repositories, with a standard git install. That directory only
contains developer tools, which aren't part of the install, no?
- Alex
. But this also doesn't seem worthy of a new top-level command.
Do folks have feelings about surfacing this information, and where such
logic should live?
- Alex
--
>From 445d45027bb5b7823338cf111910d2884af6318b Mon Sep 17 00:00:00 2001
From: Alex Vandiver <ale...@dropbox.com>
Date: Tue, 3 Oct 2017 23:27:46 -0700
Subject: [PATCH] fsmonitor: Read entirety of watchman output
In perl, setting $/ sets the string that is used as the "record
separator," which sets the boun
oothpaste.net>
>> ---
>> Changes from v2:
>> * Add a test. I tested that the config parsing both works with
>> additional options and also can be overridden from the command line.
>
> Thanks, all.
>
> Will queue with Acked-by by Alex and Reviewed-by by Jonathan.
That sounds great, thank you.
-Alex
nce it's not
practical to add tests for similar bugs for every command and
configuration option in Git, we'll just have to be a little more
vigilant about code review.
Again, I apologize for the trouble.
-Alex
if (!strcmp(var, "log.showroot")) {
> default_show_root = git_config_bool(var, value);
Signed-off-by: Alex Henrie <alexhenri...@gmail.com>
} else {
> + } else if (decoration_style == -1) {
> decoration_style = auto_decoration_style();
> }
> if (!strcmp(var, "log.showroot")) {
Sorry for the mistake. On second thought, I think we should set
decoration_style = auto_decoration_style() in init_log_defaults.
-Alex
Any news about this patch?
2017-03-21 22:24 GMT+01:00 Alex Hoffman <s...@gal.ro>:
> Hi, Brian,
>
> We definitely prefer the wrapper function oid_to_hex() to
> sha1_to_hex(). Thanks for feedback.
> Below is the updated patch:
>
> ---
> bisect.c | 6 +++---
> 1
Signed-off-by: Alex Henrie <alexhenri...@gmail.com>
---
builtin/log.c | 9 -
t/t4202-log.sh | 10 +-
2 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/builtin/log.c b/builtin/log.c
index 281af8c1e..d755a5960 100644
--- a/builtin/log.c
+++ b/builtin/log.c
@@
2017-03-23 12:03 GMT-06:00 Junio C Hamano <gits...@pobox.com>:
> Alex Henrie <alexhenri...@gmail.com> writes:
>
>> Yes, that makes sense. I assume that when you talk about 'next', you
>> mean 'master'?
>
> No, I do mean 'next'. See "A note from the mai
2017-03-23 9:54 GMT-06:00 Junio C Hamano <gits...@pobox.com>:
> Alex Henrie <alexhenri...@gmail.com> writes:
>
>> 2017-03-22 10:54 GMT-06:00 Junio C Hamano <gits...@pobox.com>:
>>> Alex Henrie <alexhenri...@gmail.com> writes:
>>>> No p
2017-03-22 10:54 GMT-06:00 Junio C Hamano <gits...@pobox.com>:
> Alex Henrie <alexhenri...@gmail.com> writes:
>> No problem. Do I need to submit a second version of the patch with a
>> test for `git -p log`?
>
> You do want to protect this "without an option
r, perhaps testing the
>> output from "git -p log" would be sufficient?
>
> BTW,
>
>>
>> +static int auto_decoration_style()
>> +{
>> + return (isatty(1) || pager_in_use()) ? DECORATE_SHORT_REFS : 0;
>> +}
>
> FYI, I fixed this to
>
> static int auto_decoration_style(void)
>
> while queuing to make it compile.
No problem. Do I need to submit a second version of the patch with a
test for `git -p log`?
-Alex
Hi, Brian,
We definitely prefer the wrapper function oid_to_hex() to
sha1_to_hex(). Thanks for feedback.
Below is the updated patch:
---
bisect.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/bisect.c b/bisect.c
index 30808cadf..7b65acbcd 100644
--- a/bisect.c
+++
from log.decorate=no to log.decorate=auto.
Signed-off-by: Alex Henrie <alexhenri...@gmail.com>
---
builtin/log.c | 9 -
t/t4202-log.sh | 2 +-
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/builtin/log.c b/builtin/log.c
index 281af8c1e..ddb4515dc 100644
--- a/b
---
bisect.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/bisect.c b/bisect.c
index 30808cadf..6feed8533 100644
--- a/bisect.c
+++ b/bisect.c
@@ -131,7 +131,7 @@ static void show_list(const char *debug, int
counted, int nr,
unsigned flags =
> isn't that spelt `--ancestry-path` ?
> (--ancestry-path has it's own issues such as needing an --first-parent-show
> option, but that's possibly a by the by)
Indeed it is spelled `--ancestry-path`. And interestingly enough you
may use it multiple times with the wanted effect in our case (e.g
> If `git bisect` is/would be affected by `git log` history-related options
> then this is what `--strict-ancestor` option gives/would give.
Exactly my thoughts. All that needs to be changed in the 2nd problem
is the graph where to search.
But first we must agree about the usefulness of the 2nd
I see two different problems each with a different assumption (see the
definition of "bisectable" in the email of Junio C Hamano):
1. (Current) Assume the entire history graph is bisectable. DO: Search
where in the entire graph the first 'trait'/transition occurs.
2. (New) Assume only the graph
> Then you must adjust your definition of "good": All commits that do not have
> the feature, yet, are "good": since they do not have the feature in the
> first place, they cannot have the breakage that you found in the feature.
>
> That is exactly the situation in your original example! But you
Below is a correction of the first proposed algorithm:
>--o1--o2--o3--G --X1
>\\
> x1--x2--x3--x4--X2--B--
> \ /
> y1--y2--y3
>
Step 1a. (Unchanged) keep only the commits that:
a) are ancestor of the "bad" commit (including the "bad" commit
> At the end of the git-bisect man page (in the SEE ALSO section) there
> is a link to
> https://github.com/git/git/blob/master/Documentation/git-bisect-lk2009.txt
> which has a lot of details about how bisect works.
>
Thanks for pointing out the SEE ALSO section. I think it makes sense
to
> But this is not how Git works. Git computes graph differences, i.e., it
> subtracts from the commits reachable from v.bad those that are reachable
> from v.good. This leaves more than just those on some path from v.good to
> v.bad. And it should work this way. Consider this history:
>
>
underline that
git bisect was designed to work with multiple good commits and one bad
commit (also multiple paths), but probably NOT with multiple paths
between the same pair of good and bad commits.
VG
2017-02-18 10:12 GMT+01:00 Johannes Sixt <j...@kdbg.org>:
> Am 18.02.2017
Hi there,
According to the documentation "git bisect" is designed "to find the
commit that introduced a bug" .
I have found a situation in which it does not returns the commit I expected.
In order to reproduce the problem:
1. mkdir test; cd test;
git clone
"deepen by excluding" does not make sense because excluding a revision
does not deepen a repository; it makes the repository more shallow.
Signed-off-by: Alex Henrie <alexhenri...@gmail.com>
---
builtin/clone.c | 2 +-
builtin/fetch.c | 2 +-
2 files changed, 2 insertions
The article "the" is required here.
Signed-off-by: Alex Henrie <alexhenri...@gmail.com>
---
builtin/receive-pack.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
index e6b3879..6b97cbd 100644
--- a/builti
Multiple revisions cannot be a single ancestor.
Signed-off-by: Alex Henrie <alexhenri...@gmail.com>
---
bisect.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bisect.c b/bisect.c
index 21bc6da..8e63c40 100644
--- a/bisect.c
+++ b/bisect.c
@@ -747,7 +747,7 @@ stati
stash-branch
git commit -m "commit to branch instead of stash" )
} 2>&1 | tee stash-test.log
===== END stash-test.sh
Thanks,
-Alex Reed
1 - 100 of 227 matches
Mail list logo
