Re: What's cooking in git.git (May 2017, #08; Mon, 29)

On Mon, May 29, 2017 at 3:23 AM, Junio C Hamano wrote: > * df/dir-iter-remove-subtree (2017-05-29) 5 commits > . remove_subtree(): reimplement using iterators > . dir_iterator: rewrite state machine model > . dir_iterator: refactor dir_iterator_advance > . remove_subtree():

Re: [PATCH 0/3] Port git-add--interactive.perl:status_cmd to C

On Fri, May 5, 2017 at 7:38 PM, Johannes Schindelin wrote: > But maybe you want to keep the naming a little more consistent with the > Perl script, e.g. instead of calling the function `print_modified()` call > it already `list()` (and rename it later to

Re: [PATCH 2/3] add--interactive: add builtin helper for interactive add

On Fri, May 5, 2017 at 7:30 PM, Johannes Schindelin wrote: >> +static int git_add_interactive_config(const char *var, > > Not git_add_interactive__helper_config()? ;-) I don't get if you mean this ironically (because of the verbosity) or if you do think this would be

[RFC] [GSoC] Port git-add--interactive.perl:status_cmd to C

Hey there, So, in the GSoC proposal I sent about porting git-add--interactive to C[1], I expected I would be able to do a couple of small patches to git-add to familiarize myself with the Git API and have a better clue of how the porting process would go by. Due to the unexpected size my

Re: [PATCH v8 0/5] [GSoC] remove_subtree(): reimplement using iterators

Hey there! I'm sorry for bothering you, but any chance you might have overlooked this patch for a review? (I'm just not familiar with how long patches usually take to be reviewed, and since I always got an answer within two days of sending it I wondered if you may have just not noticed it.) --

Re: [PATCH v7 4/5] dir_iterator: refactor state machine model

On Mon, Apr 3, 2017 at 12:36 AM, Michael Haggerty wrote: > As far as I can tell, you got the logic in this complicated big loop > correct on the first try (well, if we ignore v6 :-) ), even as you added > new features. I think that's good evidence that the new structure is >

Re: [GSoC] Proposal: turn git-add--interactive.perl into a builtin

On Sun, Apr 2, 2017 at 4:43 PM, Johannes Schindelin wrote: > We ask to accomplish a microproject before evaluating the proposals for > one reason: to have a good understanding how well the students would > interact with the project if they were accepted. As such, the >

Re: [PATCH v6 4/5] dir_iterator: refactor state machine model

Gah, I just realized I failed to correct refs/files-backend.c's behavior and kept 0 instead of DIR_ITERATOR_PRE_ORDER_TRAVERSAL as its flag. I'll correct this on a v7, but I'll wait for the rest of your reviews before sending that revision. On Sun, Apr 2, 2017 at 1:35 AM, Daniel Ferreira

Re: [PATCH v4 2/5] dir_iterator: iterate over dir after its contents

Why exactly would it not be applicable to read_directory_recursively()? On Thu, Mar 30, 2017 at 8:08 AM, Duy Nguyen wrote: > On Thu, Mar 30, 2017 at 1:39 PM, Michael Haggerty > wrote: >> * DIR_ITERATOR_RECURSE -- recurse into subdirectories >> >> would

Re: [GSoC] Proposal: turn git-add--interactive.perl into a builtin

/1dvF2PNRQvvZ351jCdKzOLs7tzaDqhR7ci7TDgzYQg9I/edit?usp=sharing. -- Daniel. On Fri, Mar 31, 2017 at 2:07 AM, Daniel Ferreira (theiostream) <bnm...@gmail.com> wrote: > Hi Stefan & Johannes, > > Thank you for the precious feedback on the proposal. I don't see much > sense in sending a full "

Re: [GSoC] Proposal: turn git-add--interactive.perl into a builtin

> >> On Sat, Mar 25, 2017 at 8:15 PM, Daniel Ferreira (theiostream) >> <bnm...@gmail.com> wrote: >> >> > SYNOPSIS >> > There are many advantages to converting parts of git that are still >> > scripts to C builtins, among which execution speed,

Re: [PATCH v5 4/6] dir_iterator: add tests for dir_iterator API

On Thu, Mar 30, 2017 at 5:05 AM, Michael Haggerty wrote: > Oh I forgot to mention, in the Git project we don't allow declarations > to be mixed with code. Apparently there's some ancient compiler > somewhere that doesn't allow it. Declarations always have to be > together,

Re: [PATCH v5 4/6] dir_iterator: add tests for dir_iterator API

On Thu, Mar 30, 2017 at 4:46 AM, Michael Haggerty wrote: > Is there a special reason to write the date to the file as opposed to, say > > touch dir/b > > ? (Some people use `: >dir/b` for this purpose, though I've never found > out why.) If you write the date to the

[GSoC] Proposal: turn git-add--interactive.perl into a builtin

Hi there. First of all, I'd like to thank all of the support up to now with my microproject :). Here's a first draft of my proposal for Google Summer of Code '17, based on the "Convert scripts to builtins" idea. Please let me know what you think. --- SYNOPSIS There are many advantages to

Re: [PATCH v2] [GSoC] remove_subtree(): reimplement using iterators

You are correct, which shows that since all tests pass, we need to come up with better cases for this function. As for a solution, I believe that the best way to go for it is to dir_iterator's implementation to have an "Option to iterate over directory paths before vs. after their contents"

Re: [PATCH] [GSoC] remove_subtree(): reimplement using iterators

> On Fri, Mar 24, 2017 at 2:02 PM, Stefan Beller wrote: > Welcome to the Git community! Thank you! > Please use a more imperative style. (e.g. s/Uses/Use/ ... > s/and simplfying/which simplifies/) Thank you. Will do in a second version of this patch. > Thanks for this