Re: [PATCH 17/19] Portable alloca for Git

2014-02-28 Thread Erik Faye-Lund
On Fri, Feb 28, 2014 at 6:00 PM, Kirill Smelkov k...@mns.spb.ru wrote: On Fri, Feb 28, 2014 at 02:50:04PM +0100, Erik Faye-Lund wrote: On Fri, Feb 28, 2014 at 2:44 PM, Erik Faye-Lund kusmab...@gmail.com wrote: On Mon, Feb 24, 2014 at 5:21 PM, Kirill Smelkov k...@mns.spb.ru wrote: diff --git

Re: [msysGit] Git for Windows 1.9.0 (fwd)

2014-02-18 Thread Erik Faye-Lund
On Tue, Feb 18, 2014 at 3:33 AM, Mike Hommey m...@glandium.org wrote: On Tue, Feb 18, 2014 at 12:52:28AM +0100, Johannes Schindelin wrote: Hopefully the Postfix Greylisting Policy Server will not try again to greylist me, as it might however do without violating the RFC. -- Forwarded

Re: pack bitmap woes on Windows

2014-02-12 Thread Erik Faye-Lund
On Wed, Feb 12, 2014 at 8:27 AM, Johannes Sixt j.s...@viscovery.net wrote: Running test suite of 'next' on Windows fails in t5310-pack-bitmaps with the following symptoms. I haven't followed the topic. Have there been patches floating that addressed the problem in one way or another? (gdb)

Re: Make the git codebase thread-safe

2014-02-12 Thread Erik Faye-Lund
On Wed, Feb 12, 2014 at 2:54 AM, Stefan Zager sza...@chromium.org wrote: We in the chromium project have a keen interest in adding threading to git in the pursuit of performance for lengthy operations (checkout, status, blame, ...). Our motivation comes from hitting some performance walls

Re: pack bitmap woes on Windows

2014-02-12 Thread Erik Faye-Lund
On Wed, Feb 12, 2014 at 3:09 PM, Duy Nguyen pclo...@gmail.com wrote: On Wed, Feb 12, 2014 at 8:23 PM, David Kastrup d...@gnu.org wrote: Johannes Sixt j.s...@viscovery.net writes: Am 2/12/2014 13:55, schrieb David Kastrup: Johannes Sixt j.s...@viscovery.net writes: Running test suite of

Re: pack bitmap woes on Windows

2014-02-12 Thread Erik Faye-Lund
On Wed, Feb 12, 2014 at 3:22 PM, Erik Faye-Lund kusmab...@gmail.com wrote: On Wed, Feb 12, 2014 at 3:09 PM, Duy Nguyen pclo...@gmail.com wrote: On Wed, Feb 12, 2014 at 8:23 PM, David Kastrup d...@gnu.org wrote: Johannes Sixt j.s...@viscovery.net writes: Am 2/12/2014 13:55, schrieb David

Re: Make the git codebase thread-safe

2014-02-12 Thread Erik Faye-Lund
On Wed, Feb 12, 2014 at 7:20 PM, Stefan Zager sza...@google.com wrote: On Wed, Feb 12, 2014 at 3:59 AM, Erik Faye-Lund kusmab...@gmail.com wrote: On Wed, Feb 12, 2014 at 2:54 AM, Stefan Zager sza...@chromium.org wrote: We are particularly concerned with the performance of msysgit, and we have

Re: Make the git codebase thread-safe

2014-02-12 Thread Erik Faye-Lund
On Wed, Feb 12, 2014 at 7:34 PM, Stefan Zager sza...@google.com wrote: On Wed, Feb 12, 2014 at 10:27 AM, Erik Faye-Lund kusmab...@gmail.com wrote: On Wed, Feb 12, 2014 at 7:20 PM, Stefan Zager sza...@google.com wrote: I don't want to steal the thunder of my coworker, who wrote

Re: [PATCH v2 2/2] gc: config option for running --auto in background

2014-02-10 Thread Erik Faye-Lund
On Sat, Feb 8, 2014 at 8:08 AM, Nguyễn Thái Ngọc Duy pclo...@gmail.com wrote: `gc --auto` takes time and can block the user temporarily (but not any less annoyingly). Make it run in background on systems that support it. The only thing lost with running in background is printouts. But gc

Re: [PATCH v2 1/2] daemon: move daemonize() to libgit.a

2014-02-10 Thread Erik Faye-Lund
On Sat, Feb 8, 2014 at 8:08 AM, Nguyễn Thái Ngọc Duy pclo...@gmail.com wrote: Signed-off-by: Nguyễn Thái Ngọc Duy pclo...@gmail.com diff --git a/setup.c b/setup.c index 6c3f85f..b09a412 100644 --- a/setup.c +++ b/setup.c @@ -787,3 +787,27 @@ void sanitize_stdfds(void) if (fd 2)

Re: [PATCH v2 2/2] gc: config option for running --auto in background

2014-02-10 Thread Erik Faye-Lund
On Mon, Feb 10, 2014 at 2:17 PM, Duy Nguyen pclo...@gmail.com wrote: On Mon, Feb 10, 2014 at 6:03 PM, Erik Faye-Lund kusmab...@gmail.com wrote: `gc --auto` takes time and can block the user temporarily (but not any - if (!quiet) - fprintf(stderr

Re: Feature Request Google Authenticator Support

2014-01-30 Thread Erik Faye-Lund
On Thu, Jan 30, 2014 at 5:07 AM, Max Rahm ac90b...@gmail.com wrote: Github supports google authenticator 2-step authentication. I enabled it and how can't figure out how to connect to my github account through git. I've looked pretty hard in the man pages and on google and can't seem to find

Re: [msysGit] Consecutive git gc fails on Windows network share

2014-01-21 Thread Erik Faye-Lund
On Tue, Jan 21, 2014 at 5:57 PM, Johannes Schindelin johannes.schinde...@gmx.de wrote: Hi kusma, On Tue, 21 Jan 2014, Erik Faye-Lund wrote: On Tue, Jan 21, 2014 at 12:25 AM, Johannes Schindelin johannes.schinde...@gmx.de wrote: On Mon, 20 Jan 2014, Torsten Bögershausen wrote: b) add

Re: [msysGit] Consecutive git gc fails on Windows network share

2014-01-20 Thread Erik Faye-Lund
On Tue, Jan 21, 2014 at 12:25 AM, Johannes Schindelin johannes.schinde...@gmx.de wrote: On Mon, 20 Jan 2014, Torsten Bögershausen wrote: b) add +++ at the places where you added the stat() and chmod(), c) and to send the question is this a good implementation ? to upstream git. I think

[PATCH 1/2] prefer xwrite instead of write

2014-01-17 Thread Erik Faye-Lund
Our xwrite wrapper already deals with a few potential hazards, and are as such more robust. Prefer it instead of write to get the robustness benefits everywhere. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com --- With this patch, we don't call write directly any more; all calls goes via

[PATCH 2/2] mingw: remove mingw_write

2014-01-17 Thread Erik Faye-Lund
Since 0b6806b9 (xread, xwrite: limit size of IO to 8MB), this wrapper is no longer needed, as read and write are already split into small chunks. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com --- compat/mingw.c | 17 - compat/mingw.h | 3 --- 2 files changed, 20 deletions

Re: [PATCH 1/2] prefer xwrite instead of write

2014-01-17 Thread Erik Faye-Lund
On Fri, Jan 17, 2014 at 8:07 PM, Junio C Hamano gits...@pobox.com wrote: Jonathan Nieder jrnie...@gmail.com writes: Hi, Erik Faye-Lund wrote: --- a/builtin/merge.c +++ b/builtin/merge.c @@ -367,7 +367,7 @@ static void squash_message(struct commit *commit, struct commit_list *remotehead

Re: Synchronize git-credential-wincred from msysgit

2014-01-12 Thread Erik Faye-Lund
On Sun, Jan 12, 2014 at 12:59 PM, 乙酸鋰 ch3co...@gmail.com wrote: Hi, Please cherry pick from msysgit/git commit 3c8cbb4edc8f577940c52115c992d17575587f99 to synchronize git-credential-wincred This was the change they made half year ago. It's actually a two-patch series. Cover-letter:

Re: [PATCH] Fix safe_create_leading_directories() for Windows

2014-01-07 Thread Erik Faye-Lund
On Thu, Jan 2, 2014 at 9:46 PM, Johannes Schindelin johannes.schinde...@gmx.de wrote: Hi Sebastian, On Thu, 2 Jan 2014, Sebastian Schuberth wrote: On 02.01.2014 18:33, Johannes Schindelin wrote: -- snip -- On Linux, we can get away with assuming that the directory separator is a

Re: [msysGit] Fwd: static initializers

2014-01-06 Thread Erik Faye-Lund
On Mon, Jan 6, 2014 at 11:05 PM, Stefan Zager sza...@google.com wrote: Forwarding to msysgit for any guidance about win equivalents for PTHREAD_MUTEX_INITIALIZER or __attribute__((constructor)). As you've probably already guessed, PTHREAD_MUTEX_INITIALIZER isn't supported in our

Re: Crash on context menu

2013-12-26 Thread Erik Faye-Lund
On Thu, Dec 26, 2013 at 2:16 PM, George Bateman georgebatema...@gmail.com wrote: Win7 SP1; Git identifies itself as version 1.8.4-preview20130916. I copied the Git Bash shortcut from the start menu to the root of a Git repository (no remote part). I use the advanced context menu. For other

Re: [PATCH v4 23/23] compat/mingw.h: Fix the MinGW and msvc builds

2013-12-25 Thread Erik Faye-Lund
On Sat, Dec 21, 2013 at 3:00 PM, Jeff King p...@peff.net wrote: From: Ramsay Jones ram...@ramsay1.demon.co.uk Signed-off-by: Ramsay Jones ram...@ramsay1.demon.co.uk Signed-off-by: Junio C Hamano gits...@pobox.com Signed-off-by: Jeff King p...@peff.net --- compat/mingw.h | 1 + 1 file

Re: write() _will_ fail on Mac OS X/XNU if nbytes INT_MAX

2013-11-20 Thread Erik Faye-Lund
I know I'm extremely late to the party, and this patch has already landed, but... On Sat, May 11, 2013 at 1:05 AM, Junio C Hamano gits...@pobox.com wrote: Filipe Cabecinhas fil...@gmail.com writes: Due to a bug in the Darwin kernel, write() calls have a maximum size of INT_MAX bytes. This

Re: Check out doesn't set x-flag on CIFS

2013-11-20 Thread Erik Faye-Lund
On Wed, May 29, 2013 at 4:16 PM, Andre Esser andre.es...@geneity.co.uk wrote: Hello, When on a CIFS filesystem a git checkout does not replicate the executable flag from the repository: $ git clone git://git/abettersqlplus Cloning into 'abettersqlplus'... remote: Counting objects:

Re: Check out doesn't set x-flag on CIFS

2013-11-20 Thread Erik Faye-Lund
Sigh, it seems replying from Gmail on my phone culled the CC-list. Sorry about that, and here's the rest of the discussion in case someone else is interested: On Wed, Nov 20, 2013 at 1:38 PM, Andre Esser andre.es...@geneity.co.uk wrote: On 2013-11-20 12:23, Erik Faye-Lund wrote: On Wed, Nov 20

Re: [PATCH v2 01/10] test-chmtime: Fix exit code on Windows

2013-11-20 Thread Erik Faye-Lund
On Fri, Jun 7, 2013 at 10:53 PM, Johannes Sixt j...@kdbg.org wrote: MinGW's bash does not recognize an exit code -1 as failure. See also 47e3de0e (MinGW: truncate exit()'s argument to lowest 8 bits) and 2488df84 (builtin run_command: do not exit with -1). Exit code 1 is good enough.

Re: [PATCH] pager: turn on cat optimization for DEFAULT_PAGER

2013-11-20 Thread Erik Faye-Lund
On Tue, Sep 3, 2013 at 9:41 AM, Jeff King p...@peff.net wrote: On Mon, Sep 02, 2013 at 10:27:48PM -0400, Dale R. Worley wrote: I guess the else could and should be dropped. If you do so (and possibly insert a blank line between the DEFAULT_PAGER case and the pager = NULL case), you get a

Re: [PATCH] pager: turn on cat optimization for DEFAULT_PAGER

2013-11-20 Thread Erik Faye-Lund
On Wed, Nov 20, 2013 at 6:30 PM, Jeff King p...@peff.net wrote: On Wed, Nov 20, 2013 at 06:24:45PM +0100, Erik Faye-Lund wrote: diff --git a/pager.c b/pager.c index c1ecf65..fa19765 100644 --- a/pager.c +++ b/pager.c @@ -54,7 +54,7 @@ const char *git_pager(int stdout_is_tty

Re: [PATCH] pager: turn on cat optimization for DEFAULT_PAGER

2013-11-20 Thread Erik Faye-Lund
On Wed, Nov 20, 2013 at 6:33 PM, Junio C Hamano gits...@pobox.com wrote: Erik Faye-Lund kusmab...@gmail.com writes: ... is set to empty., 2006-04-16). At that time, the line directly above used: if (!pager) pager = less; as a fallback, meaning that it could not possibly

Re: [PATCH 1/2] entry.c: convert checkout_entry to use strbuf

2013-10-23 Thread Erik Faye-Lund
On Wed, Oct 23, 2013 at 7:29 PM, Jeff King p...@peff.net wrote: On Wed, Oct 23, 2013 at 07:55:06PM +0700, Nguyen Thai Ngoc Duy wrote: The old code does not do boundary check so any paths longer than PATH_MAX can cause buffer overflow. Replace it with strbuf to handle paths of arbitrary

Re: [msysGit] [PATCH] Prevent buffer overflows when path is too big

2013-10-21 Thread Erik Faye-Lund
On Mon, Oct 21, 2013 at 9:02 PM, Johannes Sixt j...@kdbg.org wrote: Am 21.10.2013 03:31, schrieb Duy Nguyen: On Mon, Oct 21, 2013 at 12:57 AM, Antoine Pelisse apeli...@gmail.com wrote: My main motive was to not *stop* the process when a long path is met. Because somebody created a repository

Re: [PATCH] mingw-multibyte: fix memory acces violation and path length limits.

2013-10-03 Thread Erik Faye-Lund
On Thu, Oct 3, 2013 at 7:25 PM, Antoine Pelisse apeli...@gmail.com wrote: I've not followed the thread so much but, in that entry.c::checkout_entry,() we do: memcpy(path, state-base_dir, len); strcpy(path + len, ce-name); which can of course result in memory violation if PATH is not long

Re: [PATCH] mingw-multibyte: fix memory acces violation and path length limits.

2013-09-30 Thread Erik Faye-Lund
On Mon, Sep 30, 2013 at 7:00 PM, René Scharfe l@web.de wrote: Am 29.09.2013 04:56, schrieb Wataru Noguchi: Hi, Thanks for comments. My currently working repository is https://github.com/wnoguchi/git/tree/hotfix/mingw-multibyte-path-checkout-failure I have revert commits to 1f10da3.

Re: CPPCheck found 24 high risk bugs in Git v.1.8.3.4

2013-08-20 Thread Erik Faye-Lund
On Tue, Aug 20, 2013 at 8:44 PM, Andreas Schwab sch...@linux-m68k.org wrote: Erik Faye-Lund kusmab...@gmail.com writes: diff --git a/compat/win32/syslog.c b/compat/win32/syslog.c index d015e43..0641f4e 100644 --- a/compat/win32/syslog.c +++ b/compat/win32/syslog.c @@ -43,11 +43,14 @@ void

Re: CPPCheck found 24 high risk bugs in Git v.1.8.3.4

2013-08-20 Thread Erik Faye-Lund
On Tue, Aug 20, 2013 at 10:34 PM, René Scharfe l@web.de wrote: Am 20.08.2013 20:44, schrieb Andreas Schwab: Erik Faye-Lund kusmab...@gmail.com writes: diff --git a/compat/win32/syslog.c b/compat/win32/syslog.c index d015e43..0641f4e 100644 --- a/compat/win32/syslog.c +++ b/compat/win32

Re: CPPCheck found 24 high risk bugs in Git v.1.8.3.4

2013-08-20 Thread Erik Faye-Lund
On Wed, Aug 21, 2013 at 1:01 AM, Andreas Schwab sch...@linux-m68k.org wrote: Erik Faye-Lund kusmab...@gmail.com writes: I don't see how it's undefined. It's using the memory that 'pos' *points to* that is undefined, no? The difference between 'pos' and 'str' should still be the same, it's

Re: CPPCheck found 24 high risk bugs in Git v.1.8.3.4

2013-08-19 Thread Erik Faye-Lund
This one seems real, although it's quite theoretical. It should only happen in cases where the log-message contains %1, the initial malloc passed and reallocing two more bytes failed. However, what's much more of a disaster: pos is used after the call to realloc might have moved the memory! I

Re: git clone doesn't work in symlink dir roots on Windows

2013-08-11 Thread Erik Faye-Lund
On Sun, Aug 11, 2013 at 9:28 AM, Sedat Kapanoglu se...@eksiteknoloji.com wrote: Thanks folks. So that this won't be fixed, I added a new QA to MsysGit FAQ at https://github.com/msysgit/msysgit/wiki/Frequently-Asked-Questions , I appreciate if you can review and correct if needed. I hope it

Re: git clone doesn't work in symlink dir roots on Windows

2013-08-10 Thread Erik Faye-Lund
On Sat, Aug 10, 2013 at 6:34 PM, Fredrik Gustafsson iv...@iveqy.com wrote: On Sat, Aug 10, 2013 at 07:22:03PM +0300, Sedat Kapanoglu wrote: git is a disk intense program, so this setup is not sane at all. With that said I know that git on windows historically had problems with working on

Re: [PATCH] mingw: make mingw_signal return the correct handler

2013-06-10 Thread Erik Faye-Lund
On Mon, Jun 10, 2013 at 7:48 AM, Johannes Sixt j.s...@viscovery.net wrote: From: Erik Faye-Lund kusmab...@gmail.com Returning the SIGALRM handler for SIGINT is not very useful. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com Signed-off-by: Johannes Sixt j...@kdbg.org --- Am 6/7/2013 16

Re: [PATCH] t0005: skip signal death exit code test on Windows

2013-06-10 Thread Erik Faye-Lund
On Mon, Jun 10, 2013 at 7:30 AM, Johannes Sixt j.s...@viscovery.net wrote: Am 6/9/2013 22:31, schrieb Junio C Hamano: Jeff King p...@peff.net writes: I'm a little negative on handling just SIGTERM. That would make the test pass, but does it really address the overall issue? To me, the

Re: [PATCH] t0005: skip signal death exit code test on Windows

2013-06-07 Thread Erik Faye-Lund
On Thu, Jun 6, 2013 at 7:40 PM, Jeff King p...@peff.net wrote: On Thu, Jun 06, 2013 at 10:21:47AM -0700, Junio C Hamano wrote: The particular deficiency is that when a signal is raise()d whose SIG_DFL action will cause process death (SIGTERM in this case), the implementation of raise()

Re: [PATCH] t0005: skip signal death exit code test on Windows

2013-06-07 Thread Erik Faye-Lund
On Fri, Jun 7, 2013 at 12:24 PM, Johannes Sixt j.s...@viscovery.net wrote: Am 6/7/2013 12:12, schrieb Erik Faye-Lund: On Thu, Jun 6, 2013 at 7:40 PM, Jeff King p...@peff.net wrote: On Thu, Jun 06, 2013 at 10:21:47AM -0700, Junio C Hamano wrote: The particular deficiency is that when a signal

Re: [PATCH] t0005: skip signal death exit code test on Windows

2013-06-07 Thread Erik Faye-Lund
On Fri, Jun 7, 2013 at 2:19 PM, Johannes Sixt j.s...@viscovery.net wrote: Am 6/7/2013 14:00, schrieb Erik Faye-Lund: On Fri, Jun 7, 2013 at 12:24 PM, Johannes Sixt j.s...@viscovery.net wrote: Am 6/7/2013 12:12, schrieb Erik Faye-Lund: On Thu, Jun 6, 2013 at 7:40 PM, Jeff King p...@peff.net

Re: [PATCH] t0005: skip signal death exit code test on Windows

2013-06-07 Thread Erik Faye-Lund
On Fri, Jun 7, 2013 at 3:07 PM, Johannes Sixt j.s...@viscovery.net wrote: Am 6/7/2013 14:46, schrieb Erik Faye-Lund: On Fri, Jun 7, 2013 at 2:19 PM, Johannes Sixt j.s...@viscovery.net wrote: Am 6/7/2013 14:00, schrieb Erik Faye-Lund: On Fri, Jun 7, 2013 at 12:24 PM, Johannes Sixt j.s

Re: [PATCH v2 0/2] avoid bogus recursion detected in die handler message

2013-04-23 Thread Erik Faye-Lund
On Tue, Apr 16, 2013 at 9:44 PM, Jeff King p...@peff.net wrote: On Tue, Apr 16, 2013 at 04:13:56PM +0200, Johannes Sixt wrote: I'm not clear on what you are suggesting. That we protect only the main thread from recursion, or that we drop the check entirely? Or that we implement

Re: [PATCH master] convert: The native line-ending is \r\n on MinGW

2013-04-16 Thread Erik Faye-Lund
On Mon, Apr 15, 2013 at 11:43 PM, Junio C Hamano gits...@pobox.com wrote: Erik Faye-Lund kusmab...@gmail.com writes: This is absolutely the right thing to do. However, stuff have changed a bit since the patch was written; this change now needs to go in config.mak.uname instead of config.mak

Re: [PATCH] Extend runtime prefix computation

2013-04-16 Thread Erik Faye-Lund
On Wed, Mar 6, 2013 at 9:19 AM, Michael Weiser m.wei...@science-computing.de wrote: Hello Junio, On Tue, Mar 05, 2013 at 08:13:50AM -0800, Junio C Hamano wrote: Support determining the binaries' installation path at runtime even if called without any path components (i.e. via search path).

Re: [PATCH master] convert: The native line-ending is \r\n on MinGW

2013-04-15 Thread Erik Faye-Lund
On Mon, Apr 15, 2013 at 11:00 PM, Junio C Hamano gits...@pobox.com wrote: Junio C Hamano gits...@pobox.com writes: Jonathan Nieder jrnie...@gmail.com writes: If you try this: 1. Install Git for Windows (from the msysgit project) 2. Put [core] autocrlf = false

Re: [PATCH 3/4] drop some obsolete x = x compiler warning hacks

2013-03-21 Thread Erik Faye-Lund
On Thu, Mar 21, 2013 at 12:10 PM, Jeff King p...@peff.net wrote: In cases where the setting and access of a variable are protected by the same conditional flag, older versions of gcc would generate a might be used unitialized warning. We silence the warning by initializing the variable to

Re: [PATCH/RFC] http_init: only initialize SSL for https

2013-03-18 Thread Erik Faye-Lund
On Sun, Mar 17, 2013 at 11:27 PM, Junio C Hamano gits...@pobox.com wrote: Daniel Stenberg dan...@haxx.se writes: On Sun, 17 Mar 2013, Antoine Pelisse wrote: With redirects taken into account, I can't think of any really good way around avoiding this init... Is there any way for curl to

Re: [PATCH/RFC] http_init: only initialize SSL for https

2013-03-18 Thread Erik Faye-Lund
On Mon, Mar 18, 2013 at 11:38 AM, Erik Faye-Lund kusmab...@gmail.com wrote: On Sun, Mar 17, 2013 at 11:27 PM, Junio C Hamano gits...@pobox.com wrote: Daniel Stenberg dan...@haxx.se writes: On Sun, 17 Mar 2013, Antoine Pelisse wrote: With redirects taken into account, I can't think of any

[PATCH/RFC] http_init: only initialize SSL for https

2013-03-14 Thread Erik Faye-Lund
0m0.015s Signed-off-by: Erik Faye-Lund erik.faye-l...@hue.no --- http.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/http.c b/http.c index 3b312a8..528a736 100644 --- a/http.c +++ b/http.c @@ -343,7 +343,8 @@ void http_init(struct remote *remote, const char *url, int

Re: [PATCH/RFC] http_init: only initialize SSL for https

2013-03-14 Thread Erik Faye-Lund
On Thu, Mar 14, 2013 at 2:51 PM, Erik Faye-Lund kusmab...@gmail.com wrote: Since ancient times, we have been calling curl_global_init with the CURL_GLOBAL_ALL-flag, which initializes SSL (and the Win32 socket stack on Windows). Initializing SSL takes quite some time on Windows, so let's avoid

Re: [msysGit] [PATCH/RFC] http_init: only initialize SSL for https

2013-03-14 Thread Erik Faye-Lund
On Thu, Mar 14, 2013 at 4:23 PM, Johannes Schindelin johannes.schinde...@gmx.de wrote: Hi kusma, On Thu, 14 Mar 2013, Erik Faye-Lund wrote: Since ancient times, we have been calling curl_global_init with the CURL_GLOBAL_ALL-flag, which initializes SSL (and the Win32 socket stack on Windows

Re: [PATCH/RFC] http_init: only initialize SSL for https

2013-03-14 Thread Erik Faye-Lund
On Thu, Mar 14, 2013 at 11:45 PM, Junio C Hamano gits...@pobox.com wrote: Johannes Schindelin johannes.schinde...@gmx.de writes: Apparently, ftps is also handled by cURL and most likely requires SSL. How about optimizing for the common case and instead of prefixcmp(url, https:)) ask for

git-am and CRLF

2013-03-13 Thread Erik Faye-Lund
I recently tried to apply a patch-series to a repo that is unfortunately full of CRLF files, and was a bit surprised that it didn't work at all. So I made a small repro-case, and it seems CRLF new-lines is indeed the problem. Any clue how to fix it? The way I see it, we should simply be able top

Re: git-am and CRLF

2013-03-13 Thread Erik Faye-Lund
On Wed, Mar 13, 2013 at 6:42 PM, Brandon Casey draf...@gmail.com wrote: On Wed, Mar 13, 2013 at 9:54 AM, Erik Faye-Lund kusmab...@gmail.com wrote: I recently tried to apply a patch-series to a repo that is unfortunately full of CRLF files, and was a bit surprised that it didn't work at all

Re: [RFC/PATCH] Documentation/technical/api-fswatch.txt: start with outline

2013-03-12 Thread Erik Faye-Lund
On Tue, Mar 12, 2013 at 10:43 AM, Ramkumar Ramachandra artag...@gmail.com wrote: Heiko Voigt wrote: While talking about platform independence. How about Windows? AFAIK there are no file based sockets. How about using shared memory, thats available, instead? It would greatly reduce the needed

Re: [PATH/RFC] Revert compat: add strtok_r()

2013-02-26 Thread Erik Faye-Lund
On Mon, Feb 25, 2013 at 7:55 AM, Junio C Hamano gits...@pobox.com wrote: Care to tie the loose end on this one, with a sign-off? Yes, I'll get right to it, sorry for the delay! -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org

Re: [PATCH v2 0/2] improve-wincred-compatibility

2013-02-26 Thread Erik Faye-Lund
On Tue, Feb 26, 2013 at 12:51 AM, Junio C Hamano gits...@pobox.com wrote: My question was if msysgit folks want me to take your patch (which I cannot test myself) and then merge my tree to the msysgit tree as part of their regular updates to catch up with 1.8.2 (and future releases), or they

[PATCH v2] Revert compat: add strtok_r()

2013-02-26 Thread Erik Faye-Lund
This reverts commit 78457bc0ccc1af8b9eb776a0b17986ebd50442bc. commit 28c5d9e (vcs-svn: drop string_pool) previously removed the only call-site for strtok_r. So let's get rid of the compat implementation as well. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com Reviewed-by: Jonathan Nieder jrnie

Re: [PATCH] Fix in Git.pm cat_blob crashes on large files (reviewed by Jeff King)

2013-02-22 Thread Erik Faye-Lund
On Fri, Feb 22, 2013 at 6:03 PM, Joshua Clayton stillcompil...@gmail.com wrote: Read and write each 1024 byte buffer, rather than trying to buffer the entire content of the file. Previous code would crash on all files 2 Gib, when the offset variable became negative (perhaps below the level of

Re: Is this a bug?

2013-02-19 Thread Erik Faye-Lund
On Tue, Feb 19, 2013 at 10:32 AM, David Wade da...@statoil.com wrote: Hi, I wrote a commit message beginning with a hash (#) character, like this: 'git commit -m #ifdef ' Everything went okay when committing, but then I tried 'git commit -amend' and without editing the commit message

[PATH/RFC] parse-options: report invalid UTF-8 switches

2013-02-11 Thread Erik Faye-Lund
-8 characters on it. Make the reporting code grok UTF-8 in the option sequence, and write a variable-width output sequence. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com --- As being both clumsy and Norwegian, I some times to enter the Norwegian bizarro-letters ('æ', 'ø' and 'å') instead

Re: [PATH/RFC] parse-options: report invalid UTF-8 switches

2013-02-11 Thread Erik Faye-Lund
On Mon, Feb 11, 2013 at 2:43 PM, Matthieu Moy matthieu@grenoble-inp.fr wrote: Erik Faye-Lund kusmab...@gmail.com writes: --- a/parse-options.c +++ b/parse-options.c @@ -3,6 +3,7 @@ #include cache.h #include commit.h #include color.h +#include utf8.h static int

Re: [PATH/RFC] parse-options: report invalid UTF-8 switches

2013-02-11 Thread Erik Faye-Lund
On Mon, Feb 11, 2013 at 5:28 PM, Torsten Bögershausen tbo...@web.de wrote: On 11.02.13 14:34, Erik Faye-Lund wrote: Even though parse-options doesn't support UTF-8 switches (which makes sense; non-ascii switches would be difficult to enter on some keyboard layouts), it can be useful to report

Re: [PATH/RFC] parse-options: report invalid UTF-8 switches

2013-02-11 Thread Erik Faye-Lund
On Mon, Feb 11, 2013 at 6:07 PM, Junio C Hamano gits...@pobox.com wrote: Erik Faye-Lund kusmab...@gmail.com writes: However, since git only looks at one byte at the time for short-options, it ends up reporting a partial UTF-8 sequence in such cases, leading to corruption of the output

Re: [PATH/RFC] parse-options: report invalid UTF-8 switches

2013-02-11 Thread Erik Faye-Lund
On Mon, Feb 11, 2013 at 6:19 PM, Jeff King p...@peff.net wrote: On Mon, Feb 11, 2013 at 09:07:53AM -0800, Junio C Hamano wrote: Erik Faye-Lund kusmab...@gmail.com writes: However, since git only looks at one byte at the time for short-options, it ends up reporting a partial UTF-8 sequence

[PATCHv2] parse-options: report uncorrupted multi-byte options

2013-02-11 Thread Erik Faye-Lund
the reporting code report the whole argument-string when a non-ASCII short-option is detected. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com Improved-by: Jeff King p...@peff.net --- Here's a second attempt at fixing error-reporting with UTF-8 encoded input, this time without corrupting other non-ascii

Re: inotify to minimize stat() calls

2013-02-10 Thread Erik Faye-Lund
On Sun, Feb 10, 2013 at 12:17 PM, Duy Nguyen pclo...@gmail.com wrote: On Sun, Feb 10, 2013 at 12:24:58PM +0700, Duy Nguyen wrote: On Sun, Feb 10, 2013 at 12:10 AM, Ramkumar Ramachandra artag...@gmail.com wrote: Finn notes in the commit message that it offers no speedup, because .gitignore

Re: git-svn problems with white-space in tag names

2013-02-06 Thread Erik Faye-Lund
On Sun, Jan 27, 2013 at 3:12 PM, Hans-Juergen Euler waas.n...@gmail.com wrote: This seems to be a problem of the windows version. At least with its complete severity. Installed git on Ubuntu in a virtual machine was able to clone the subversion repos past the tag with the white-space at the

Re: [RFC] test-lib.sh: No POSIXPERM for cygwin

2013-02-06 Thread Erik Faye-Lund
On Sun, Jan 27, 2013 at 3:57 PM, Torsten Bögershausen tbo...@web.de wrote: t0070 and t1301 fail when running the test suite under cygwin. Skip the failing tests by unsetting POSIXPERM. But is this the real reason? I thought Cygwin implemented POSIX permissions...? -- To unsubscribe from this

Re: [PATCH v3 2/8] git_remote_helpers: fix input when running under Python 3

2013-02-05 Thread Erik Faye-Lund
On Fri, Jan 25, 2013 at 9:23 PM, Brandon Casey draf...@gmail.com wrote: On Wed, Jan 23, 2013 at 12:36 PM, Junio C Hamano gits...@pobox.com wrote: Sverre Rabbelier srabbel...@gmail.com writes: On Wed, Jan 23, 2013 at 11:47 AM, John Keeping j...@keeping.me.uk wrote: When did we last revisit

[PATH/RFC] Revert compat: add strtok_r()

2013-02-01 Thread Erik Faye-Lund
This reverts commit 78457bc0ccc1af8b9eb776a0b17986ebd50442bc. commit 28c5d9e (vcs-svn: drop string_pool) previously removed the only call-site for strtok_r. So let's get rid of the compat implementation as well. Conflicts: Makefile config.mak.in configure.ac --- I just

Re: [PATH/RFC] Revert compat: add strtok_r()

2013-02-01 Thread Erik Faye-Lund
On Fri, Feb 1, 2013 at 11:33 AM, Erik Faye-Lund kusmab...@gmail.com wrote: This reverts commit 78457bc0ccc1af8b9eb776a0b17986ebd50442bc. commit 28c5d9e (vcs-svn: drop string_pool) previously removed the only call-site for strtok_r. So let's get rid of the compat implementation as well

Re: [feature request] git-daemon http connection filtering of client types

2013-01-31 Thread Erik Faye-Lund
On Thu, Jan 31, 2013 at 1:46 PM, porpen+...@gmail.com wrote: Hey folks, When I checked for false positives in my spam this morning, I spotted an interesting malformed img link at the top of a spam message. {snip} http://git.{snip}.n2.nabble.com/file/{snip}/t3.jpg Employ a medal tiffany

Re: git-svn does not like format=4

2013-01-23 Thread Erik Faye-Lund
On Wed, Jan 23, 2013 at 11:43 AM, Hans-Juergen Euler waas.n...@gmail.com wrote: it's part of a sequence of problems you can find on groups.google.com/d/topic/git-users/kfMFZ3uEFsM/discussion windows 7 64 bit Git version 1.8.0 git bash and git gui installed and using using subversion

Re: GIT get corrupted on lustre

2013-01-23 Thread Erik Faye-Lund
On Tue, Jan 22, 2013 at 11:14 PM, Thomas Rast tr...@student.ethz.ch wrote: Eric Chamberland eric.chamberl...@giref.ulaval.ca writes: Other than that I agree with Junio, from what we've seen so far, Lustre returns EINTR on all sorts of calls that simply aren't allowed to do so. I don't think

Re: GIT get corrupted on lustre

2013-01-23 Thread Erik Faye-Lund
On Wed, Jan 23, 2013 at 4:32 PM, Thomas Rast tr...@student.ethz.ch wrote: Erik Faye-Lund kusmab...@gmail.com writes: On Tue, Jan 22, 2013 at 11:14 PM, Thomas Rast tr...@student.ethz.ch wrote: Eric Chamberland eric.chamberl...@giref.ulaval.ca writes: Other than that I agree with Junio, from

Re: GIT get corrupted on lustre

2013-01-23 Thread Erik Faye-Lund
On Wed, Jan 23, 2013 at 4:44 PM, Thomas Rast tr...@inf.ethz.ch wrote: Erik Faye-Lund kusmab...@gmail.com writes: On Wed, Jan 23, 2013 at 4:32 PM, Thomas Rast tr...@student.ethz.ch wrote: Erik Faye-Lund kusmab...@gmail.com writes: POSIX allows error codes to be generated other than those

Re: [msysGit] Re: Bug in EOL conversion?

2013-01-23 Thread Erik Faye-Lund
On Wed, Jan 23, 2013 at 10:55 PM, Philip Oakley philipoak...@iee.org wrote: The msysgit list msys...@googlegroups.com may be a better place for this. It is likely that you have a windows specific EOL conversion set within the wider config's (i.e. --system, --global). You may have

Re: GIT get corrupted on lustre

2013-01-21 Thread Erik Faye-Lund
On Fri, Jan 18, 2013 at 6:50 PM, Eric Chamberland eric.chamberl...@giref.ulaval.ca wrote: Good idea! I did a strace and here is the output with the error: http://www.giref.ulaval.ca/~ericc/strace_git_error.txt Hope it will be insightful! This trace doesn't seem to contain child-processes,

Re: [PATCH v2 0/2] improve-wincred-compatibility

2013-01-11 Thread Erik Faye-Lund
/wincred/git-credential-wincred.c| 206 - 1 file changed, 75 insertions(+), 131 deletions(-) Wonderful! Acked-by: Erik Faye-Lund kusmab...@gmail.com -- To unsubscribe from this list: send the line unsubscribe git in the body of a message to majord...@vger.kernel.org

Re: [PATCH] wincred: improve compatibility with windows versions

2013-01-08 Thread Erik Faye-Lund
On Tue, Jan 8, 2013 at 5:20 PM, Karsten Blees karsten.bl...@gmail.com wrote: Am 04.01.2013 22:57, schrieb Erik Faye-Lund: The only reason why I used Cred[Un]PackAuthenticationBuffer, were that I wasn't aware that it was possible any other way. I didn't even know there was a Windows Credential

Re: [BUG/PATCH] setup: Copy an environment variable to avoid overwrites

2013-01-07 Thread Erik Faye-Lund
On Sat, Jan 5, 2013 at 1:35 AM, David Michael fedora@gmail.com wrote: It is possible for this pointer of the GIT_DIR environment variable to survive unduplicated until further getenv calls are made. The standards allow for subsequent calls of getenv to overwrite the string located at its

Re: [PATCH] wincred: improve compatibility with windows versions

2013-01-04 Thread Erik Faye-Lund
On Fri, Jan 4, 2013 at 9:28 PM, Karsten Blees karsten.bl...@gmail.com wrote: On WinXP, the windows credential helper doesn't work at all (due to missing Cred[Un]PackAuthenticationBuffer APIs). On Win7, the credential format used by wincred is incompatible with native Windows tools (such as the

Re: sys/param.h

2012-12-19 Thread Erik Faye-Lund
On Tue, Dec 18, 2012 at 6:01 PM, Junio C Hamano gits...@pobox.com wrote: Johannes Sixt j.s...@viscovery.net writes: Junio C Hamano wrote: It could turn out that we may be able to get rid of sys/param.h altogether, but one step at a time. Inputs from people on minority platforms are very

[PATCHv2] mingw_rmdir: do not prompt for retry when non-empty

2012-12-10 Thread Erik Faye-Lund
into the prompting-loop. Fix this by setting errno, and guarding the prompting-loop with an errno-check. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com --- Here's the second version of this patch, sorry for the slight delay. compat/mingw.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion

Re: [PATCHv2] mingw_rmdir: do not prompt for retry when non-empty

2012-12-10 Thread Erik Faye-Lund
On Mon, Dec 10, 2012 at 5:25 PM, Junio C Hamano gits...@pobox.com wrote: Erik Faye-Lund kusmab...@gmail.com writes: in ab1a11be (mingw_rmdir: set errno=ENOTEMPTY when appropriate), a check was added to prevent us from retrying to delete a directory that is both in use and non-empty. However

Re: [PATCH] mingw_rmdir: do not prompt for retry when non-empty

2012-12-05 Thread Erik Faye-Lund
Sorry for a late reply. On Tue, Dec 4, 2012 at 5:35 PM, Johannes Schindelin johannes.schinde...@gmx.de wrote: Hi kusma, On Tue, 4 Dec 2012, Erik Faye-Lund wrote: in ab1a11be (mingw_rmdir: set errno=ENOTEMPTY when appropriate), a check was added to prevent us from retrying to delete

Re: [PATCH] mingw_rmdir: do not prompt for retry when non-empty

2012-12-05 Thread Erik Faye-Lund
On Wed, Dec 5, 2012 at 5:02 PM, Johannes Schindelin johannes.schinde...@gmx.de wrote: Hi kusma, On Wed, 5 Dec 2012, Erik Faye-Lund wrote: Sorry for a late reply. Yeah, sorry, my replies tend to be delayed a lot. For the record: your reply was not at all late. On Tue, Dec 4, 2012 at 5:35

[PATCH v2 0/6] win32: support echo for terminal-prompt

2012-12-04 Thread Erik Faye-Lund
behalf. I'm sorry about that. * 3/6: This patch got a fixup for the disable_echo function signature squashed in. I forgot void for the empty parameter list. Thanks to Junio for noticing. Otherwise, things are unchanged. Erik Faye-Lund (6): mingw: correct exit-code for SIGALRM's

[PATCH v2 1/6] mingw: correct exit-code for SIGALRM's SIG_DFL

2012-12-04 Thread Erik Faye-Lund
Make sure SIG_DFL for SIGALRM exits with 128 + SIGALRM so other processes can diagnose why it exits. While we're at it, make sure we only write to stderr if it's a terminal, and change the output to match that of Linux. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com --- compat/mingw.c | 7

[PATCH v2 2/6] mingw: make fgetc raise SIGINT if apropriate

2012-12-04 Thread Erik Faye-Lund
Set a control-handler to prevent the process from terminating, and simulate SIGINT so it can be handled by a signal-handler as usual. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com --- compat/mingw.c | 76 ++ compat/mingw.h | 6 + 2

[PATCH v2 3/6] compat/terminal: factor out echo-disabling

2012-12-04 Thread Erik Faye-Lund
By moving the echo-disabling code to a separate function, we can implement OS-specific versions of it for non-POSIX platforms. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com --- compat/terminal.c | 43 +-- 1 file changed, 25 insertions(+), 18 deletions

[PATCH v2 4/6] compat/terminal: separate input and output handles

2012-12-04 Thread Erik Faye-Lund
On Windows, the terminal cannot be opened in read-write mode, so we need distinct pairs for reading and writing. Since this works fine on other platforms as well, always open them in pairs. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com --- compat/terminal.c | 29

[PATCH v2 5/6] mingw: reuse tty-version of git_terminal_prompt

2012-12-04 Thread Erik Faye-Lund
. Since we set files to be opened in binary-mode by default on Windows, introduce a FORCE_TEXT macro that expands to the t modifier that forces the terminal to be opened in text-mode so we do not have to deal with CRLF issues. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com --- compat/terminal.c | 69

[PATCH v2 6/6] mingw: get rid of getpass implementation

2012-12-04 Thread Erik Faye-Lund
There's no remaining call-sites, and as pointed out in the previous commit message, it's not quite ideal. So let's just lose it. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com --- compat/mingw.c | 15 --- compat/mingw.h | 2 -- 2 files changed, 17 deletions(-) diff --git

[PATCH] mingw_rmdir: do not prompt for retry when non-empty

2012-12-04 Thread Erik Faye-Lund
. Signed-off-by: Erik Faye-Lund kusmab...@gmail.com --- Here's a quick patch for a small issue I recently encountered; when deleting a file from inside a directory, we currently end up prompting the user if (s)he want us to retry deleting the directory they are in. compat/mingw.c | 4 ++-- 1 file

<    1   2   3   >