Re: [RFC] make --set-upstream work for local branches not in refs/heads

2014-03-06 Thread Krzesimir Nowak
On Tue, 2014-03-04 at 11:44 -0800, Junio C Hamano wrote: Krzesimir Nowak krzesi...@endocode.com writes: It might be possible (in Gerrited setups) to have local branches outside refs/heads/, like for example in following fetch config: [remote origin] url = ssh://u...@example.com/my

[RFC] make --set-upstream work for local branches not in refs/heads

2014-03-04 Thread Krzesimir Nowak
of local hierarchies (if it is possible at all). And it probably should get a better name. And probably something else. What do you think? Krzesimir Nowak (1): RFC: make --set-upstream work for branches not in refs/heads/ transport.c | 41 ++--- 1 file changed

[PATCH] RFC: make --set-upstream work for branches not in refs/heads/

2014-03-04 Thread Krzesimir Nowak
--- transport.c | 41 ++--- 1 file changed, 34 insertions(+), 7 deletions(-) diff --git a/transport.c b/transport.c index ca7bb44..ac933ee 100644 --- a/transport.c +++ b/transport.c @@ -143,6 +143,25 @@ static void insert_packed_refs(const char *packed_refs,

[PATCH v7 0/4] Show extra branch refs in gitweb

2013-12-11 Thread Krzesimir Nowak
directories. Krzesimir Nowak (4): gitweb: Move check-ref-format code into separate function gitweb: Return 1 on validation success instead of passed input gitweb: Add a feature for adding more branch refs gitweb: Denote non-heads, non-remotes branches Documentation/gitweb.conf.txt | 37

[PATCH v7 1/4] gitweb: Move check-ref-format code into separate function

2013-12-11 Thread Krzesimir Nowak
This check will be used in more than one place later. Signed-off-by: Krzesimir Nowak krzesi...@endocode.com --- gitweb/gitweb.perl | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 68c77f6..46bd6ac 100755

[PATCH v7 3/4] gitweb: Add a feature for adding more branch refs

2013-12-11 Thread Krzesimir Nowak
Allow extra-branch-refs feature to tell gitweb to show refs from additional hierarchies in addition to branches in the list-of-branches view. Signed-off-by: Krzesimir Nowak krzesi...@endocode.com --- Documentation/gitweb.conf.txt | 37 gitweb/gitweb.perl| 80

[PATCH v7 4/4] gitweb: Denote non-heads, non-remotes branches

2013-12-11 Thread Krzesimir Nowak
-by: Krzesimir Nowak krzesi...@endocode.com --- gitweb/gitweb.perl | 34 +- 1 file changed, 29 insertions(+), 5 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 222699a..3bc0f0b 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -3730,8

[PATCH v7 2/4] gitweb: Return 1 on validation success instead of passed input

2013-12-11 Thread Krzesimir Nowak
Users of validate_* passing 0 might get failures on correct name because of coercion of 0 to false in code like: die_error(500, invalid ref) unless (check_ref_format (0)); Also, the validate_foo subs are renamed to is_valid_foo. Signed-off-by: Krzesimir Nowak krzesi...@endocode.com --- gitweb

Re: [PATCH 4/5] gitweb: Add a feature for adding more branch refs

2013-12-10 Thread Krzesimir Nowak
On Thu, 2013-12-05 at 11:00 +0100, Krzesimir Nowak wrote: On Wed, 2013-12-04 at 19:06 +0100, Jakub Narębski wrote: On Wed, Dec 4, 2013 at 2:43 PM, Krzesimir Nowak krzesi...@endocode.com wrote: ++ +It is an error to specify a ref that does not pass git check-ref-format +scrutiny

Re: [PATCH 1/5] gitweb: Add a comment explaining the meaning of $/

2013-12-05 Thread Krzesimir Nowak
On Wed, 2013-12-04 at 12:28 -0800, Junio C Hamano wrote: Martin Langhoff martin.langh...@gmail.com writes: On Wed, Dec 4, 2013 at 10:46 AM, Krzesimir Nowak krzesi...@endocode.com wrote: On Wed, 2013-12-04 at 16:11 +0100, Jakub Narębski wrote: On Wed, Dec 4, 2013 at 2:42 PM, Krzesimir

Re: [PATCH 2/5] gitweb: Move check-ref-format code into separate function

2013-12-05 Thread Krzesimir Nowak
On Wed, 2013-12-04 at 12:31 -0800, Junio C Hamano wrote: Krzesimir Nowak krzesi...@endocode.com writes: This check will be used in more than one place later. Signed-off-by: Krzesimir Nowak krzesi...@endocode.com Reviewed-by: Junio C Hamano gits...@pobox.com Again, I do not think I

Re: [PATCH 2/5] gitweb: Move check-ref-format code into separate function

2013-12-05 Thread Krzesimir Nowak
On Wed, 2013-12-04 at 16:56 +0100, Jakub Narębski wrote: On Wed, Dec 4, 2013 at 2:43 PM, Krzesimir Nowak krzesi...@endocode.com wrote: This check will be used in more than one place later. Signed-off-by: Krzesimir Nowak krzesi...@endocode.com Reviewed-by: Junio C Hamano gits

Re: [PATCH 3/5] gitweb: Return plain booleans in validation methods

2013-12-05 Thread Krzesimir Nowak
On Wed, 2013-12-04 at 17:07 +0100, Jakub Narębski wrote: On Wed, Dec 4, 2013 at 2:43 PM, Krzesimir Nowak krzesi...@endocode.com wrote: Users of validate_* passing 0 might get failures on correct name because of coercion of 0 to false in code like: die_error(500, invalid ref) unless

Re: [PATCH 4/5] gitweb: Add a feature for adding more branch refs

2013-12-05 Thread Krzesimir Nowak
On Wed, 2013-12-04 at 19:06 +0100, Jakub Narębski wrote: On Wed, Dec 4, 2013 at 2:43 PM, Krzesimir Nowak krzesi...@endocode.com wrote: Allow extra-branch-refs feature to tell gitweb to show refs from additional hierarchies in addition to branches in the list-of-branches view. Signed

[PATCH 1/5] gitweb: Add a comment explaining the meaning of $/

2013-12-04 Thread Krzesimir Nowak
So future reader will know what does it mean without running perldoc perlvar. Signed-off-by: Krzesimir Nowak krzesi...@endocode.com --- gitweb/gitweb.perl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 68c77f6..ee61f9e 100755 --- a/gitweb

[PATCH 4/5] gitweb: Add a feature for adding more branch refs

2013-12-04 Thread Krzesimir Nowak
Allow extra-branch-refs feature to tell gitweb to show refs from additional hierarchies in addition to branches in the list-of-branches view. Signed-off-by: Krzesimir Nowak krzesi...@endocode.com Reviewed-by: Junio C Hamano gits...@pobox.com Reviewed-by: Jakub Narębski jna...@gmail.com

[PATCH 3/5] gitweb: Return plain booleans in validation methods

2013-12-04 Thread Krzesimir Nowak
Users of validate_* passing 0 might get failures on correct name because of coercion of 0 to false in code like: die_error(500, invalid ref) unless (check_ref_format (0)); Signed-off-by: Krzesimir Nowak krzesi...@endocode.com --- gitweb/gitweb.perl | 45

Re: [PATCH 0/3] Show extra branch refs in gitweb

2013-12-04 Thread Krzesimir Nowak
On Tue, 2013-12-03 at 15:56 +0100, Krzesimir Nowak wrote: First patch just splits some code to a function, second patch adds the extra-branch-refs feature and third one adds some visual differentation of branches from non-standard ref directories. Krzesimir Nowak (3): gitweb: Move check

Re: [PATCH 1/5] gitweb: Add a comment explaining the meaning of $/

2013-12-04 Thread Krzesimir Nowak
On Wed, 2013-12-04 at 16:11 +0100, Jakub Narębski wrote: On Wed, Dec 4, 2013 at 2:42 PM, Krzesimir Nowak krzesi...@endocode.com wrote: So future reader will know what does it mean without running perldoc perlvar. Hmmm... shouldn't future reader know it anyway? It is not that cryptic

Re: [PATCH v3] gitweb: Add an option for adding more branch refs

2013-12-03 Thread Krzesimir Nowak
On Mon, 2013-12-02 at 18:34 +0100, Jakub Narębski wrote: W dniu 2013-12-02 13:06, Krzesimir Nowak pisze: On Mon, 2013-12-02 at 01:21 +0100, Jakub Narębski wrote: On Thu, Nov 28, 2013 at 12:44 PM, Krzesimir Nowak krzesi...@endocode.com wrote: Allow @additional_branch_refs configuration

[PATCH 1/3] gitweb: Move check-ref-format code into separate function

2013-12-03 Thread Krzesimir Nowak
This check will be used in more than one place later. Signed-off-by: Krzesimir Nowak krzesi...@endocode.com Reviewed-by: Junio C Hamano gits...@pobox.com Reviewed-by: Jakub Narębski jna...@gmail.com Reviewed-by: Eric Sunshine sunsh...@sunshineco.com --- gitweb/gitweb.perl | 17

[PATCH 3/3] gitweb: Denote non-heads, non-remotes branches.

2013-12-03 Thread Krzesimir Nowak
-by: Krzesimir Nowak krzesi...@endocode.com Reviewed-by: Junio C Hamano gits...@pobox.com Reviewed-by: Jakub Narębski jna...@gmail.com Reviewed-by: Eric Sunshine sunsh...@sunshineco.com --- gitweb/gitweb.perl | 27 +-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git

[PATCH 2/3] gitweb: Add a feature for adding more branch refs

2013-12-03 Thread Krzesimir Nowak
Allow extra-branch-refs feature to tell gitweb to show refs from additional hierarchies in addition to branches in the list-of-branches view. Signed-off-by: Krzesimir Nowak krzesi...@endocode.com Reviewed-by: Junio C Hamano gits...@pobox.com Reviewed-by: Jakub Narębski jna...@gmail.com Reviewed

[PATCH 0/3] Show extra branch refs in gitweb

2013-12-03 Thread Krzesimir Nowak
First patch just splits some code to a function, second patch adds the extra-branch-refs feature and third one adds some visual differentation of branches from non-standard ref directories. Krzesimir Nowak (3): gitweb: Move check-ref-format code into separate function gitweb: Add a feature

Re: [PATCH v3] gitweb: Add an option for adding more branch refs

2013-12-03 Thread Krzesimir Nowak
On Tue, 2013-12-03 at 14:02 +0100, Jakub Narębski wrote: On Tue, Dec 3, 2013 at 11:53 AM, Krzesimir Nowak krzesi...@endocode.com wrote: On Mon, 2013-12-02 at 18:34 +0100, Jakub Narębski wrote: W dniu 2013-12-02 13:06, Krzesimir Nowak pisze: On Mon, 2013-12-02 at 01:21 +0100, Jakub

Re: [PATCH v3] gitweb: Add an option for adding more branch refs

2013-12-02 Thread Krzesimir Nowak
On Thu, 2013-11-28 at 20:13 -0500, Eric Sunshine wrote: On Thu, Nov 28, 2013 at 6:44 AM, Krzesimir Nowak krzesi...@endocode.com wrote: Allow @additional_branch_refs configuration variable to tell gitweb to show refs from additional hierarchies in addition to branches in the list

Re: [PATCH v3] gitweb: Add an option for adding more branch refs

2013-12-02 Thread Krzesimir Nowak
On Mon, 2013-12-02 at 01:21 +0100, Jakub Narębski wrote: On Thu, Nov 28, 2013 at 12:44 PM, Krzesimir Nowak krzesi...@endocode.com wrote: Allow @additional_branch_refs configuration variable to tell gitweb to show refs from additional hierarchies in addition to branches in the list

Re: [PATCH v2] gitweb: Add an option for adding more branch refs

2013-11-28 Thread Krzesimir Nowak
On Wed, 2013-11-27 at 12:55 -0800, Junio C Hamano wrote: Eric Sunshine sunsh...@sunshineco.com writes: On Wed, Nov 27, 2013 at 3:34 PM, Eric Sunshine sunsh...@sunshineco.com wrote: On Wed, Nov 27, 2013 at 10:30 AM, Krzesimir Nowak krzesi...@endocode.com wrote: Overriding

[PATCH v3] gitweb: Add an option for adding more branch refs

2013-11-28 Thread Krzesimir Nowak
Allow @additional_branch_refs configuration variable to tell gitweb to show refs from additional hierarchies in addition to branches in the list-of-branches view. Signed-off-by: Krzesimir Nowak krzesi...@endocode.com --- Documentation/gitweb.conf.txt | 13 gitweb/gitweb.perl

Re: [PATCH] gitweb: Add an option for adding more branch refs

2013-11-27 Thread Krzesimir Nowak
On Tue, 2013-11-26 at 13:48 -0800, Junio C Hamano wrote: Krzesimir Nowak krzesi...@endocode.com writes: Overriding an @additional_branch_refs configuration variable with value ('wip') will make gitweb to show branches that appear in refs/heads and refs/wip (refs/heads is hardcoded). Might

[PATCH v2] gitweb: Add an option for adding more branch refs

2013-11-27 Thread Krzesimir Nowak
Overriding an @additional_branch_refs configuration variable with value ('wip') will make gitweb to show branches that appear in refs/heads and refs/wip (refs/heads is hardcoded). Might be useful for gerrit setups where user branches are not stored under refs/heads/. Signed-off-by: Krzesimir

Re: [PATCH] gitweb: Add an option for adding more branch refs

2013-11-27 Thread Krzesimir Nowak
On Wed, 2013-11-27 at 16:56 +0100, Jakub Narębski wrote: Krzesimir Nowak wrote: Overriding an @additional_branch_refs configuration variable with value ('wip') will make gitweb to show branches that appear in refs/heads and refs/wip (refs/heads is hardcoded). Might be useful for gerrit

[PATCH] gitweb: Add an option for adding more branch refs

2013-11-26 Thread Krzesimir Nowak
Overriding an @additional_branch_refs configuration variable with value ('wip') will make gitweb to show branches that appear in refs/heads and refs/wip (refs/heads is hardcoded). Might be useful for gerrit setups where user branches are not stored under refs/heads/. Signed-off-by: Krzesimir

Re: [PATCH] gitweb: Make showing branches configurable

2013-11-26 Thread Krzesimir Nowak
On Mon, 2013-11-25 at 11:32 -0800, Junio C Hamano wrote: Krzesimir Nowak krzesi...@endocode.com writes: On Fri, 2013-11-22 at 09:34 -0800, Junio C Hamano wrote: Krzesimir Nowak krzesi...@endocode.com writes: Running 'make GITWEB_WANTED_REFS=heads wip gitweb.cgi' will create

Re: [PATCH] gitweb: Make showing branches configurable

2013-11-25 Thread Krzesimir Nowak
On Fri, 2013-11-22 at 09:34 -0800, Junio C Hamano wrote: Krzesimir Nowak krzesi...@endocode.com writes: Running 'make GITWEB_WANTED_REFS=heads wip gitweb.cgi' will create a gitweb CGI script showing branches that appear in refs/heads/ and in refs/wip/. Might be useful for gerrit setups

[PATCH] gitweb: Make showing branches configurable

2013-11-22 Thread Krzesimir Nowak
Running 'make GITWEB_WANTED_REFS=heads wip gitweb.cgi' will create a gitweb CGI script showing branches that appear in refs/heads/ and in refs/wip/. Might be useful for gerrit setups where user branches are not stored under refs/heads/. Signed-off-by: Krzesimir Nowak krzesi...@endocode.com