Since due to some reason, the previous patch-series list was
unavailable on the mailing list, I have re-posted the series.
It is available at:
https://public-inbox.org/git/20180202045745.5076-1-pc44...@gmail.com/
Thanks,
Prathamesh Chavan
eller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 151
git-submodule.sh| 39 +---
2 files changed, 152 insertions(+), 38 deletions(-)
diff --git a/builtin/su
' variable available and
document it as a deprecated synonym of 'sm_path'.
Discussed-with: Ramsay Jones <ram...@ramsayjones.plus.com>
Signed-off-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
Documentation/git-submodule.txt | 10 ++--
It was observed that the variable '$displaypath' was accessible but
undocumented. Hence, document it.
Discussed-with: Ramsay Jones <ram...@ramsayjones.plus.com>
Signed-off-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
;
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
Documentation/git-submodule.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt
index a23baef62..8e7930ebc 100644
--- a/Documentation/git-s
Build #202
Prathamesh Chavan (5):
submodule foreach: correct '$path' in nested submodules from a
subdirectory
submodule foreach: document '$sm_path' instead of '$path'
submodule foreach: clarify the '$toplevel' variable documentation
submodule foreach: document variable '$displaypath
some automation that can break silently.
Discussed-with: Ramsay Jones <ram...@ramsayjones.plus.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
Signed-off-by: Stefan Beller <sbel...@google.com>
---
git-submodule.sh | 1 -
t/t7407-submodule-foreach.sh | 36
Build #202
Prathamesh Chavan (5):
submodule foreach: correct '$path' in nested submodules from a
subdirectory
submodule foreach: document '$sm_path' instead of '$path'
submodule foreach: clarify the '$toplevel' variable documentation
submodule foreach: document variable '$displaypath
It was observed that the variable '$displaypath' was accessible but
undocumented. Hence, document it.
Discussed-with: Ramsay Jones <ram...@ramsayjones.plus.com>
Signed-off-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
eller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 151
git-submodule.sh| 39 +---
2 files changed, 152 insertions(+), 38 deletions(-)
diff --git a/builtin/su
;
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
Documentation/git-submodule.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt
index a23baef62..8e7930ebc 100644
--- a/Documentation/git-s
some automation that can break silently.
Discussed-with: Ramsay Jones <ram...@ramsayjones.plus.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
Signed-off-by: Stefan Beller <sbel...@google.com>
---
git-submodule.sh | 1 -
t/t7407-submodule-foreach.sh | 36
' variable available and
document it as a deprecated synonym of 'sm_path'.
Discussed-with: Ramsay Jones <ram...@ramsayjones.plus.com>
Signed-off-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
Documentation/git-submodule.txt | 10 ++--
() and print_default_remote().
The function print_default_remote() is introduced for getting
the default remote as stdout.
Mentored-by: Christian Couder <christian.cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
-by: Christian Couder <christian.cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 147
git-submodule.sh| 55 +
2
die_errno.
As before you can find this series at:
https://github.com/pratham-pc/git/commits/patch-series-2
And its build report is available at:
https://travis-ci.org/pratham-pc/git/builds/
Branch: patch-series-2
Build #197
Prathamesh Chavan (2):
submodule: port submodule subcommand 'sync' from
-by: Christian Couder <christian.cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 147
git-submodule.sh| 55 +
2
() and print_default_remote().
The function print_default_remote() is introduced for getting
the default remote as stdout.
Mentored-by: Christian Couder <christian.cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
ox.org/git/xmqq7esq4tf6@gitster.mtv.corp.google.com/
Prathamesh Chavan (2):
submodule: port submodule subcommand 'sync' from shell to C
submodule: port submodule subcommand 'deinit' from shell to C
builtin/submodule--helper.c | 342
git-su
On Wed, Jan 10, 2018 at 2:54 AM, Junio C Hamano <gits...@pobox.com> wrote:
> Prathamesh Chavan <pc44...@gmail.com> writes:
>
>> The same mechanism is used even for porting this submodule
>> subcommand, as used in the ported subcommands till now.
>> The function
-by: Christian Couder <christian.cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 153
git-submodule.sh| 55 +---
2
() and print_default_remote().
The function print_default_remote() is introduced for getting
the default remote as stdout.
Mentored-by: Christian Couder <christian.cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
: patch-series-2
Build #195
[1]: https://public-inbox.org/git/20170807211900.15001-6-pc44...@gmail.com/
[2]: https://public-inbox.org/git/20170807211900.15001-7-pc44...@gmail.com/
[3]: https://public-inbox.org/git/20171006132415.2876-4-pc44...@gmail.com/
Prathamesh Chavan (2):
submodule: port
cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 35 +++
1 file changed, 23 insertions(+), 12 deletions(-)
diff --git a/builtin/submodule--helper.c b
also push on github and are available at:
https://github.com/pratham-pc/git/commits/patch-series-1-next
Prathamesh Chavan (3):
submodule--helper: introduce get_submodule_displaypath()
submodule--helper: introduce for_each_listed_submodule()
submodule: port submodule subcommand 'status' from
oogle.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 40 +++-
1 file changed, 35 insertions(+), 5 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index 56c1c52e2..29e3fde16 10
ntored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 198
git-submodule.sh| 61 +-
2 files changed, 199 insertions(+), 60 deletions(-)
di
ntored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 207
git-submodule.sh| 61 +
2 files changed, 208 insertions(+), 60 deletions(-)
di
oogle.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 39 ++-
1 file changed, 34 insertions(+), 5 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index cdae54426..20a1ef868 10
cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 35 +++
1 file changed, 23 insertions(+), 12 deletions(-)
diff --git a/builtin/submodule--helper.c b
this series at:
https://github.com/pratham-pc/git/commits/patch-series-1
And its build report is available at:
https://travis-ci.org/pratham-pc/git/builds/
Branch: patch-series-1
Build #184
Prathamesh Chavan (3):
submodule--helper: introduce get_submodule_displaypath()
submodule--helper
oogle.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 36
1 file changed, 28 insertions(+), 8 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index d24ac9028..d12790b5c 10
cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 38 ++
1 file changed, 26 insertions(+), 12 deletions(-)
diff --git a/builtin/submodule--helper.c b
and printing.
Mentored-by: Christian Couder <christian.cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 63 +
git-submodule.
: patch-series-1
Build #179
Thanks, Han-Wen Nienhuys for reviewing the previous patch series.
Prathamesh Chavan (4):
submodule--helper: introduce get_submodule_displaypath()
submodule--helper: introduce for_each_listed_submodule()
submodule: port set_name_rev() from shell to C
submodule
as it is no longer used.
Mentored-by: Christian Couder <christian.cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 162 +++-
git-submodule.s
Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 155
git-submodule.sh| 49 +-
2 files changed, 156 insertions(+), 48 deletions(-)
diff --git a
oogle.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 36
1 file changed, 28 insertions(+), 8 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index e25854371..ea99d8e39 10
cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 37 +
1 file changed, 25 insertions(+), 12 deletions(-)
diff --git a/builtin/submodule--helper.c b
and printing.
Mentored-by: Christian Couder <christian.cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 63 +
git-submodule.sh|
Prathamesh Chavan (4):
submodule--helper: introduce get_submodule_displaypath()
submodule--helper: introduce for_each_listed_submodule()
submodule: port set_name_rev() from shell to C
submodule: port submodule subcommand 'status' from shell to C
builtin/submodule--helper.c | 289
;
Thanks.
I'll see the dirty merges and will resend the whole series after reviewing
the dirty merge and sending a new one with/without changes as required.
Thanks,
Prathamesh Chavan
Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 156
git-submodule.sh| 49 +-
2 files changed, 157 insertions(+), 48 deletions(-)
diff --git a
oogle.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 39 +--
1 file changed, 29 insertions(+), 10 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index e666f84ba..8cd81b144 10
and printing.
Mentored-by: Christian Couder <christian.cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 63 +
git-submodule.sh|
cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 38 +-
1 file changed, 25 insertions(+), 13 deletions(-)
diff --git a/builtin/submodule--helper.c b
this series at:
https://github.com/pratham-pc/git/commits/week-14-1
And its build report is available at:
https://travis-ci.org/pratham-pc/git/builds/
Branch: week-14-1
Build #164
Prathamesh Chavan (4):
submodule--helper: introduce get_submodule_displaypath()
submodule--helper: introduce
<sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 156
git-submodule.sh| 49 +-
2 files changed, 157 insertions(+), 48 deletions(-)
diff --git a/builtin/submodule--
and printing.
Mentored-by: Christian Couder <christian.cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 63 +
git-submodule.sh|
;
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 39 +--
1 file changed, 29 insertions(+), 10 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index e666f84ba..847fba854 100644
--- a
cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 38 +-
1 file changed, 25 insertions(+), 13 deletions(-)
diff --git a/builtin/submodule--helper.c b
-14-1
And the build report is available at:
https://travis-ci.org/pratham-pc/git/builds/
Branch: week-14-1
Build #163
Prathamesh Chavan (4):
submodule--helper: introduce get_submodule_displaypath()
submodule--helper: introduce for_each_submodule()
submodule: port set_name_rev() from shell
SUMMARY OF MY PROJECT:
Git submodule subcommands are currently implemented by using shell script
'git-submodule.sh'. There are several reasons why we'll prefer not to
use the shell script. My project intends to convert the subcommands into
C code, thus making them builtins. This will increase
On Mon, Aug 21, 2017 at 10:17 PM, Heiko Voigt <hvo...@hvoigt.net> wrote:
> On Mon, Aug 21, 2017 at 09:45:14PM +0530, Prathamesh Chavan wrote:
>> Function set_name_rev() is ported from git-submodule to the
>> submodule--helper builtin. The function get_name_rev() g
<sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
The patch below underwent some changes after its previous version.
In the shell script, the submodules, which had merge-conflicts are
identified by checking if the $stage variable has the value 'U'
Till the
cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
As said in the previous update,
a short patch series is floated for the maintainer's review,
and is consisting of the following changes:
* introduce function get_sub
Couder <christian.cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 63 +
git-submodule.sh| 16 ++--
2 files chan
m>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 39 +--
1 file changed, 29 insertions(+), 10 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index dcdbde963..7803457ba 10
SUMMARY OF MY PROJECT:
Git submodule subcommands are currently implemented by using shell script
'git-submodule.sh'. There are several reasons why we'll prefer not to
use the shell script. My project intends to convert the subcommands into
C code, thus making them builtins. This will increase
y: Christian Couder <christian.cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
In this new version, the following changes have been made:
* A comment was added to clarify why the env variables were made
available only
It was observed that the variable '$displaypath' was accessible but
undocumented. Hence, document it.
Discussed-with: Ramsay Jones <ram...@ramsayjones.plus.com>
Signed-off-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
<sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
The major changes the patch underwent through is the splitting of the
function print_submodule_summary() into generate_submodule_summary()
and print_summary()
Apart from this, there are also minor changes whi
' variable available and
document it as a deprecated synonym of 'sm_path'.
Discussed-with: Ramsay Jones <ram...@ramsayjones.plus.com>
Signed-off-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
Documentation/git-submodule.txt | 10 ++--
;
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
Documentation/git-submodule.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt
index a23baef62..8e7930ebc 100644
--- a/Documentation/git-s
some automation that can break silently.
Discussed-with: Ramsay Jones <ram...@ramsayjones.plus.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
Signed-off-by: Stefan Beller <sbel...@google.com>
---
git-submodule.sh | 1 -
t/t7407-submodule-foreach.sh | 36
Change the scope of function count_lines for allowing the function
to be reused in other parts of the code as well.
Mentored-by: Christian Couder <christian.cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com&g
<christian.cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 148
git-submodule.sh| 55 +---
2 files changed, 149
<sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 156
git-submodule.sh| 49 +-
2 files changed, 157 insertions(+), 48 deletions(-)
diff --git a/builtin/sub
().
The function print_default_remote() is introduced for getting
the default remote as stdout.
Mentored-by: Christian Couder <christian.cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodu
cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 33 ++---
1 file changed, 22 insertions(+), 11 deletions(-)
diff --git a/builtin/submodule--helper.c b
tps://public-inbox.org/git/CAGZ79kbyyR54me_+wQDZRrikqKTp_a98yozVfr8P85QHfyyy=q...@mail.gmail.com/
[5]: https://travis-ci.org/pratham-pc/git/builds/
[6]: https://github.com/pratham-pc/git/commits/week-12
Prathamesh Chavan (13):
submodule--helper: introduce get_submodule_displaypath()
submodule--helpe
m>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 39 +--
1 file changed, 29 insertions(+), 10 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index 7af4de09b..e41572f7a 10
Couder <christian.cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 63 +
git-submodule.sh| 16 ++--
2 files chan
On Sat, Aug 5, 2017 at 10:25 PM, Christian Couder
<christian.cou...@gmail.com> wrote:
> On Sat, Aug 5, 2017 at 12:28 PM, Prathamesh Chavan <pc44...@gmail.com> wrote:
>> On Tue, Aug 1, 2017 at 4:57 AM, Christian Couder
>> <christian.cou...@gmail.com> wrote:
>
On Tue, Aug 1, 2017 at 4:57 AM, Christian Couder
<christian.cou...@gmail.com> wrote:
> On Mon, Jul 31, 2017 at 10:56 PM, Prathamesh Chavan <pc44...@gmail.com> wrote:
>
>> * variable head was no longer used in module_summary() and instead the strbuf
>> was util
On Tue, Aug 1, 2017 at 3:12 AM, Stefan Beller <sbel...@google.com> wrote:
> On Mon, Jul 31, 2017 at 1:56 PM, Prathamesh Chavan <pc44...@gmail.com> wrote:
>> The same mechanism is used even for porting this submodule
>> subcommand, as used in the ported subcommand
On Tue, Aug 1, 2017 at 2:42 AM, Stefan Beller <sbel...@google.com> wrote:
> On Mon, Jul 31, 2017 at 1:56 PM, Prathamesh Chavan <pc44...@gmail.com> wrote:
>> This aims to make git-submodule 'status' a built-in. Hence, the function
>> cmd_status() is ported fr
the print_submodule_summary() function.
Finally, the print_submodule_summary() takes care of generating
and printing the summary for each submodule.
Mentored-by: Christian Couder <christian.cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc
;
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
Documentation/git-submodule.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt
index a23baef62..8e7930ebc 100644
--- a/Documentation/git-s
().
The function print_default_remote() is introduced for getting
the default remote as stdout.
Mentored-by: Christian Couder <christian.cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
In this new vers
Change the scope of function count_lines for allowing the function
to be reused in other parts of the code as well.
Mentored-by: Christian Couder <christian.cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com&g
<christian.cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
In this new version, the following changes have been made:
* In the function deinit_submodule, since the test is_git_directory()
adds an additional
' variable available and
document it as a deprecated synonym of 'sm_path'.
Discussed-with: Ramsay Jones <ram...@ramsayjones.plus.com>
Signed-off-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
This patch is same as its previous version.
It was observed that the variable '$displaypath' was accessible but
undocumented. Hence, document it.
Discussed-with: Ramsay Jones <ram...@ramsayjones.plus.com>
Signed-off-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
I
y: Christian Couder <christian.cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
In this new version, the following changes have been made:
* Comment style is improved in the function runcommand_in_submodule()
* Comment
some automation that can break silently.
Discussed-with: Ramsay Jones <ram...@ramsayjones.plus.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
Signed-off-by: Stefan Beller <sbel...@google.com>
---
git-submodule.sh | 1 -
t/t7407-submodule-foreach.sh | 36
<sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
In this new version, the following changes have been made:
* parameters passed to the function print_status() have been changed.
Instead of passing char *sub_sha1, instead the object_id is being passe
Couder <christian.cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
In this new version, the following changes have been made:
* The variable namerev from print_name_rev is now freed at the end of the
f
m>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 39 +--
1 file changed, 29 insertions(+), 10 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index 7af4de09b..e41572f7a 10
cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
builtin/submodule--helper.c | 33 ++---
1 file changed, 22 insertions(+), 11 deletions(-)
diff --git a/builtin/submodule--helper.c b
SUMMARY OF MY PROJECT:
Git submodule subcommands are currently implemented by using shell script
'git-submodule.sh'. There are several reasons why we'll prefer not to
use the shell script. My project intends to convert the subcommands into
C code, thus making them builtins. This will increase
On Sun, Jul 30, 2017 at 10:58 AM, Christian Couder
<christian.cou...@gmail.com> wrote:
> On Sun, Jul 30, 2017 at 12:23 AM, Prathamesh Chavan <pc44...@gmail.com> wrote:
>
>> +static int module_summary(int argc, const char **argv, const char *prefix)
>> +{
>
It was observed that the variable '$displaypath' was accessible but
undocumented. Hence, document it.
Discussed-with: Ramsay Jones <ram...@ramsayjones.plus.com>
Signed-off-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
I
y: Christian Couder <christian.cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
In this new version, the following changes have been made:
* Comment style is improved in the function runcommand_in_submodule()
* Comment
the print_submodule_summary() function.
Finally, the print_submodule_summary() takes care of generating
and printing the summary for each submodule.
Mentored-by: Christian Couder <christian.cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc
' variable available and
document it as a deprecated synonym of 'sm_path'.
Discussed-with: Ramsay Jones <ram...@ramsayjones.plus.com>
Signed-off-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
This patch is same as its previous version.
;
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
Documentation/git-submodule.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/git-submodule.txt b/Documentation/git-submodule.txt
index a23baef62..8e7930ebc 100644
--- a/Documentation/git-s
some automation that can break silently.
Discussed-with: Ramsay Jones <ram...@ramsayjones.plus.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
Signed-off-by: Stefan Beller <sbel...@google.com>
---
git-submodule.sh | 1 -
t/t7407-submodule-foreach.sh | 36
<christian.cou...@gmail.com>
Mentored-by: Stefan Beller <sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
In this new version, the following changes have been made:
* In the function deinit_submodule, since the test is_git_directory()
adds an additional
<sbel...@google.com>
Signed-off-by: Prathamesh Chavan <pc44...@gmail.com>
---
In this new version, the following changes have been made:
* parameters passed to the function print_status() have been changed.
Instead of passing char *sub_sha1, instead the object_id is being pass
1 - 100 of 216 matches
Mail list logo
