Re: [PATCH 2/2] [GSOC] show_bisect_vars(): Use unsigned int instead of signed int for flags

int add_file_to_index(..., int flags) in read-cache.c The question is : If the flags field of the structure is used in function calls should i update flags that deep?(there are other cases where the field is used in nested calls ) On Sun, Apr 2, 2017 at 6:30 AM, Junio C Hamano <gits...@pobox.com> wrote:

Re: [PATCH 1/2] [GSOC] Convert signed flags to unsigned

Regarding the first part , i can resend those 2 patches rewriting the commit message if you want. On Sat, Apr 1, 2017 at 10:12 PM, Junio C Hamano <gits...@pobox.com> wrote: > Robert Stanca <robert.stan...@gmail.com> writes: > >> Subject: Re: [PATCH 1/2] [GSOC] Convert

Re: [PATCH 2/2] [GSOC] show_bisect_vars(): Use unsigned int instead of signed int for flags

I am used to 1change per patch so it's easier to redo specific patches...if there are small changes(10 lines max) can i send them as 1 patch? On Sat, Apr 1, 2017 at 10:13 PM, Junio C Hamano <gits...@pobox.com> wrote: > Robert Stanca <robert.stan...@gmail.com> writes: > >

[PATCH 1/2] [GSOC] Convert signed flags to unsigned

Unsigned int is a closer representation of bitflags rather than signed int that uses 1 special bit for sign.This shouldn't make much difference because rev_list_info.flags uses only 2 bits(BISECT_SHOW_ALL and REV_LIST_QUIET) Signed-off-by: Robert Stanca <robert.stan...@gmail.com> --- bi

[PATCH 2/2] [GSOC] show_bisect_vars(): Use unsigned int instead of signed int for flags

As rev_list_info's flag is unsigned int , var flags should have proper type.Also var cnt could be unsigned as there's no negative number of commits (all-reaches) Signed-off-by: Robert Stanca <robert.stan...@gmail.com> --- builtin/rev-list.c | 2 +- 1 file changed, 1 insertion(+), 1 de

Re: [PATCH] [GSOC] prune_worktrees(): reimplement with dir_iterator

On Sat, Apr 1, 2017 at 5:29 AM, Junio C Hamano <gits...@pobox.com> wrote: > > Robert Stanca <robert.stan...@gmail.com> writes: > > > Replaces recursive traversing of opendir with dir_iterator > > The original code for this one, and also the other one, is not

[PATCH] [GSOC] prune_worktrees(): reimplement with dir_iterator

Replaces recursive traversing of opendir with dir_iterator Signed-off-by: Robert Stanca <robert.stan...@gmail.com> --- builtin/worktree.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/builtin/worktree.c b/builtin/worktree.c index 9993ded..7cfd78c

[PATCH] [GSOC] remove_temporary_files(): reimplement using iterators

Replaces recursive traversing of opendir with dir_iterator Signed-off-by: Robert Stanca <robert.stan...@gmail.com> --- builtin/repack.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/builtin/repack.c b/builtin/repack.c index 677bc7c81..dba465814

[PATCH] [GSOC] get_non_kept_pack_filenames(): reimplement using iterators

Replaces recursive traversing of opendir with dir_iterator. Signed-off-by: Robert Stanca <robert.stan...@gmail.com> --- builtin/repack.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/builtin/repack.c b/builtin/repack.c index 677bc7c..27a5597