Re: [BUG REPORT] git 2.9.0 clone --recursive fails on cloning a submodule

2017-04-19 Thread Stefan Beller
On Wed, Apr 19, 2017 at 4:30 AM, Ævar Arnfjörð Bjarmason wrote: > On Sun, Jun 19, 2016 at 10:51 PM, Junio C Hamano wrote: >> Jeff King writes: >> >>> Stefan, I think it might be worth revisiting the default set by d22eb04 >>> to propagate

Re: [BUG REPORT] git 2.9.0 clone --recursive fails on cloning a submodule

2017-04-19 Thread Ævar Arnfjörð Bjarmason
On Sun, Jun 19, 2016 at 10:51 PM, Junio C Hamano wrote: > Jeff King writes: > >> Stefan, I think it might be worth revisiting the default set by d22eb04 >> to propagate shallowness from the super-project clone. In an ideal >> world, we would be asking each

Re: [BUG REPORT] git 2.9.0 clone --recursive fails on cloning a submodule

2016-06-21 Thread Duy Nguyen
On Sun, Jun 19, 2016 at 12:00 PM, Jeff King wrote: > Stefan, I think it might be worth revisiting the default set by d22eb04 > to propagate shallowness from the super-project clone. In an ideal > world, we would be asking each submodule for the actual commit we are > interested in,

Re: [BUG REPORT] git 2.9.0 clone --recursive fails on cloning a submodule

2016-06-20 Thread Jeff King
On Sun, Jun 19, 2016 at 06:09:28PM -0700, Stefan Beller wrote: > > I hadn't paid much attention to this topic originally, but was surprised > > that "--depth 10" in the clone implies "--depth 1" in the submodule. > > This is not really related to your patch (in fact, your patch makes the > >

Re: [BUG REPORT] git 2.9.0 clone --recursive fails on cloning a submodule

2016-06-19 Thread Dennis Kaarsemaker
On zo, 2016-06-19 at 18:09 -0700, Stefan Beller wrote: > How often do we see a depth != 1 in practice? Travis clones with --depth=50 D. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [BUG REPORT] git 2.9.0 clone --recursive fails on cloning a submodule

2016-06-19 Thread Vadim Eisenberg
t;p...@peff.net> > Cc: Junio C Hamano <gits...@pobox.com>, Vadim Eisenberg/Haifa/ > IBM@IBMIL, "git@vger.kernel.org" <git@vger.kernel.org> > Date: 06/20/2016 04:09 AM > Subject: Re: [BUG REPORT] git 2.9.0 clone --recursive fails on > cloning a submodule >

Re: [BUG REPORT] git 2.9.0 clone --recursive fails on cloning a submodule

2016-06-19 Thread Stefan Beller
On Sun, Jun 19, 2016 at 5:13 PM, Jeff King wrote: > On Sun, Jun 19, 2016 at 01:51:56PM -0700, Junio C Hamano wrote: > >> Yup, something like this on top of d22eb04 to be merged before >> v2.9.1 for the maintenance track would be necessary. >> >> -- >8 -- >> Subject: clone: do not

Re: [BUG REPORT] git 2.9.0 clone --recursive fails on cloning a submodule

2016-06-19 Thread Jeff King
On Sun, Jun 19, 2016 at 01:51:56PM -0700, Junio C Hamano wrote: > Yup, something like this on top of d22eb04 to be merged before > v2.9.1 for the maintenance track would be necessary. > > -- >8 -- > Subject: clone: do not let --depth imply --shallow-submodules > > In v2.9.0, we prematurely

Re: [BUG REPORT] git 2.9.0 clone --recursive fails on cloning a submodule

2016-06-19 Thread Junio C Hamano
Jeff King writes: > Stefan, I think it might be worth revisiting the default set by d22eb04 > to propagate shallowness from the super-project clone. In an ideal > world, we would be asking each submodule for the actual commit we are > interested in, and shallowness would not

Re: [BUG REPORT] git 2.9.0 clone --recursive fails on cloning a submodule

2016-06-19 Thread Jeff King
On Sun, Jun 19, 2016 at 04:07:41PM +0300, Vadim Eisenberg wrote: > The problem is with other tools that use git, like Swift Package Manager - > https://swift.org/package-manager/. > Versions of git before 2.9.0 have no option --no-shallow-submodules. So > the tools that use git would have to

Re: [BUG REPORT] git 2.9.0 clone --recursive fails on cloning a submodule

2016-06-19 Thread Vadim Eisenberg
bject: Re: [BUG REPORT] git 2.9.0 clone --recursive fails on > cloning a submodule > > On Sun, Jun 19, 2016 at 10:17:36AM +0300, Vadim Eisenberg wrote: > > > /usr/local/bin/git clone --recursive --depth 10 > > https://github.com/IBM-Swift/Kitura-net.git > > Cloni

Re: [BUG REPORT] git 2.9.0 clone --recursive fails on cloning a submodule

2016-06-19 Thread Jeff King
On Sun, Jun 19, 2016 at 10:17:36AM +0300, Vadim Eisenberg wrote: > /usr/local/bin/git clone --recursive --depth 10 > https://github.com/IBM-Swift/Kitura-net.git > Cloning into 'Kitura-net'... > remote: Counting objects: 253, done. > remote: Compressing objects: 100% (142/142), done. > remote:

[BUG REPORT] git 2.9.0 clone --recursive fails on cloning a submodule

2016-06-19 Thread Vadim Eisenberg
/usr/local/bin/git clone --recursive --depth 10 https://github.com/IBM-Swift/Kitura-net.git Cloning into 'Kitura-net'... remote: Counting objects: 253, done. remote: Compressing objects: 100% (142/142), done. remote: Total 253 (delta 134), reused 188 (delta 86), pack-reused 0 Receiving objects: