Re: [GSoC][PATCH v7 09/26] stash: implement the "list" command in the builtin

2018-08-18 Thread Paul Sebastian Ungureanu
On Wed, Aug 15, 2018 at 10:41 PM, Thomas Gummerer wrote: >> Subject: stash: implement the "list" command in the builtin > > Nit: The previous commit messages all have the format "stash: convert > to builtin", maybe follow the same pattern here? At first, the subject of the commit matched the

Re: [GSoC][PATCH v7 09/26] stash: implement the "list" command in the builtin

2018-08-15 Thread Thomas Gummerer
> Subject: stash: implement the "list" command in the builtin Nit: The previous commit messages all have the format "stash: convert to builtin", maybe follow the same pattern here? The rest of the patch looks good to me. On 08/08, Paul-Sebastian Ungureanu wrote: > Add stash list to the helper

[GSoC][PATCH v7 09/26] stash: implement the "list" command in the builtin

2018-08-08 Thread Paul-Sebastian Ungureanu
Add stash list to the helper and delete the list_stash function from the shell script. Signed-off-by: Paul-Sebastian Ungureanu --- builtin/stash--helper.c | 31 +++ git-stash.sh| 7 +-- 2 files changed, 32 insertions(+), 6 deletions(-) diff --git