Re: [PATCH] C style: use standard style for "TRANSLATORS" comments

2017-05-30 Thread Junio C Hamano
Jiang Xin writes: > 2017-05-12 5:20 GMT+08:00 Ævar Arnfjörð Bjarmason : >> Change all the "TRANSLATORS: [...]" comments in the C code to use the >> regular Git coding style, and amend the style guide so that the >> example there uses that style. >> >>

Re: [PATCH] C style: use standard style for "TRANSLATORS" comments

2017-05-30 Thread Jiang Xin
2017-05-12 5:20 GMT+08:00 Ævar Arnfjörð Bjarmason : > Change all the "TRANSLATORS: [...]" comments in the C code to use the > regular Git coding style, and amend the style guide so that the > example there uses that style. > > This custom style was necessary back in 2010 when the

Re: [PATCH] C style: use standard style for "TRANSLATORS" comments

2017-05-11 Thread Johannes Sixt
Am 11.05.2017 um 23:20 schrieb Ævar Arnfjörð Bjarmason: diff --git a/builtin/notes.c b/builtin/notes.c index 7b891471c4..fb856e53b6 100644 --- a/builtin/notes.c +++ b/builtin/notes.c @@ -340,8 +340,10 @@ static struct notes_tree *init_notes_check(const char *subcommand, ref = (flags &

Re: [PATCH] C style: use standard style for "TRANSLATORS" comments

2017-05-11 Thread Brandon Williams
On 05/11, Jonathan Nieder wrote: > Hi, > > Ævar Arnfjörð Bjarmason wrote: > > > Change all the "TRANSLATORS: [...]" comments in the C code to use the > > regular Git coding style, and amend the style guide so that the > > example there uses that style. > > Hooray! > > [...] > > ---

Re: [PATCH] C style: use standard style for "TRANSLATORS" comments

2017-05-11 Thread Jonathan Nieder
Hi, Ævar Arnfjörð Bjarmason wrote: > Change all the "TRANSLATORS: [...]" comments in the C code to use the > regular Git coding style, and amend the style guide so that the > example there uses that style. Hooray! [...] > --- a/Documentation/CodingGuidelines > +++

[PATCH] C style: use standard style for "TRANSLATORS" comments

2017-05-11 Thread Ævar Arnfjörð Bjarmason
Change all the "TRANSLATORS: [...]" comments in the C code to use the regular Git coding style, and amend the style guide so that the example there uses that style. This custom style was necessary back in 2010 when the gettext support was initially added, and was subsequently documented in commit