Re: [PATCH] Makefile: add a DEVOPTS flag to get pedantic compilation

2018-07-23 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: >> +CFLAGS += -pedantic >> +# don't warn for each N_ use >> +CFLAGS += -DUSE_PARENS_AROUND_GETTEXT_N=0 >> +endif > > ...and set this to "no" not "0" since we document that that's the way to > toggle it off in the Makefile, i.e. let's be consistent. The Make

Re: [PATCH] Makefile: add a DEVOPTS flag to get pedantic compilation

2018-07-21 Thread Ævar Arnfjörð Bjarmason
On Sat, Jul 21 2018, Beat Bolli wrote: > In the interest of code hygiene, make it easier to compile Git with the > flag -pedantic. > > Pure pedantic compilation results in one warning per use of the > translation macro `N_`, therefore also disable the parenthesising of > i18n strings with

[PATCH] Makefile: add a DEVOPTS flag to get pedantic compilation

2018-07-21 Thread Beat Bolli
In the interest of code hygiene, make it easier to compile Git with the flag -pedantic. Pure pedantic compilation results in one warning per use of the translation macro `N_`, therefore also disable the parenthesising of i18n strings with -DUSE_PARENS_AROUND_GETTEXT_N=0 to show only real