Re: [PATCH] cherry-pick: detect bogus arguments to --mainline

2017-03-15 Thread Junio C Hamano
Jeff King writes: > The "0" comes from the initialization of the replay_opts struct (it also > happens if you explicitly disclaim any previous option with > --no-mainline). > > I think using 0 as a sentinel is OK here, but the option-parser should > complain when we go out of

[PATCH] cherry-pick: detect bogus arguments to --mainline

2017-03-15 Thread Jeff King
"0" comes from the initialization of the replay_opts struct (it also happens if you explicitly disclaim any previous option with --no-mainline). I think using 0 as a sentinel is OK here, but the option-parser should complain when we go out of range. Like this: -- >8 -- Subject: [PATCH]