Re: [PATCH] clone: pass --progress decision to recursive submodules

2016-09-22 Thread Jeff King
On Thu, Sep 22, 2016 at 08:36:01AM -0700, Stefan Beller wrote: > > Signed-off-by: Jeff King > > Acked and thanked by Stefan ;) Thanks. > > + /* > > +* We want to show progress for recursive submodule clones iff > > +* we did so for the main clone. But only

Re: [PATCH] clone: pass --progress decision to recursive submodules

2016-09-22 Thread Stefan Beller
On Wed, Sep 21, 2016 at 10:24 PM, Jeff King wrote: > When cloning with "--recursive", we'd generally expect > submodules to show progress reports if the main clone did, > too. > > In older versions of git, this mostly worked out of the > box. Since we show progress by default when

[PATCH] clone: pass --progress decision to recursive submodules

2016-09-21 Thread Jeff King
When cloning with "--recursive", we'd generally expect submodules to show progress reports if the main clone did, too. In older versions of git, this mostly worked out of the box. Since we show progress by default when stderr is a tty, and since the child clones inherit the parent stderr, then