Re: [PATCH] completion: use builtin completion for format-patch

2018-10-29 Thread Denton Liu
On Tue, Oct 30, 2018 at 11:20:45AM +0900, Junio C Hamano wrote: > We saw a similar change proposed and then found out it was not such > a good idea in: > > https://public-inbox.org/git/cacsjy8durvju0hn7kuceo4iv5aimwbytr+e-7kenpvdx90d...@mail.gmail.com/ > > It seems that this one loses options

Re: [PATCH] completion: use builtin completion for format-patch

2018-10-29 Thread Junio C Hamano
Denton Liu writes: > Signed-off-by: Denton Liu > --- > contrib/completion/git-completion.bash | 11 +-- > 1 file changed, 1 insertion(+), 10 deletions(-) We saw a similar change proposed and then found out it was not such a good idea in:

[PATCH] completion: use builtin completion for format-patch

2018-10-29 Thread Denton Liu
Signed-off-by: Denton Liu --- contrib/completion/git-completion.bash | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index d63d2dffd..da77da481 100644 ---