Re: [PATCH] contrib: add credential helper for libsecret

2016-10-11 Thread Dennis Kaarsemaker
On Tue, 2016-10-11 at 13:13 -0700, Junio C Hamano wrote: > Dennis Kaarsemaker writes: > > > On Tue, 2016-10-11 at 22:48 +0300, Mantas Mikulėnas wrote: > > > On 2016-10-11 22:36, Junio C Hamano wrote: > > > > Thanks for a review. I'll wait until one of (1) a squashable

Re: [PATCH] contrib: add credential helper for libsecret

2016-10-11 Thread Junio C Hamano
Junio C Hamano writes: > Dennis Kaarsemaker writes: > >> On Tue, 2016-10-11 at 22:48 +0300, Mantas Mikulėnas wrote: >>> On 2016-10-11 22:36, Junio C Hamano wrote: >>> > Thanks for a review. I'll wait until one of (1) a squashable patch >>> > to

Re: [PATCH] contrib: add credential helper for libsecret

2016-10-11 Thread Junio C Hamano
Dennis Kaarsemaker writes: > On Tue, 2016-10-11 at 22:48 +0300, Mantas Mikulėnas wrote: >> On 2016-10-11 22:36, Junio C Hamano wrote: >> > Thanks for a review. I'll wait until one of (1) a squashable patch >> > to address the "we do not want unconditional overwrite"

Re: [PATCH] contrib: add credential helper for libsecret

2016-10-11 Thread Dennis Kaarsemaker
On Tue, 2016-10-11 at 22:48 +0300, Mantas Mikulėnas wrote: > On 2016-10-11 22:36, Junio C Hamano wrote: > > Thanks for a review. I'll wait until one of (1) a squashable patch > > to address the "we do not want unconditional overwrite" issue, (2) a > > reroll from Mantas to do the same, or (3) a

Re: [PATCH] contrib: add credential helper for libsecret

2016-10-11 Thread Mantas Mikulėnas
On 2016-10-11 22:48, Mantas Mikulėnas wrote: > On 2016-10-11 22:36, Junio C Hamano wrote: >> Thanks for a review. I'll wait until one of (1) a squashable patch >> to address the "we do not want unconditional overwrite" issue, (2) a >> reroll from Mantas to do the same, or (3) a counter-argument

Re: [PATCH] contrib: add credential helper for libsecret

2016-10-11 Thread Mantas Mikulėnas
On 2016-10-11 22:36, Junio C Hamano wrote: > Thanks for a review. I'll wait until one of (1) a squashable patch > to address the "we do not want unconditional overwrite" issue, (2) a > reroll from Mantas to do the same, or (3) a counter-argument from > somebody to explain why unconditional

Re: [PATCH] contrib: add credential helper for libsecret

2016-10-11 Thread Junio C Hamano
Dennis Kaarsemaker writes: > On Sun, 2016-10-09 at 15:34 +0300, Mantas Mikulėnas wrote: > >> +s = g_hash_table_lookup(attributes, "user"); >> +if (s) { >> +g_free(c->username); >> +c->username = g_strdup(s);

Re: [PATCH] contrib: add credential helper for libsecret

2016-10-11 Thread Dennis Kaarsemaker
On Mon, 2016-10-10 at 16:46 -0400, Jeff King wrote: > On Mon, Oct 10, 2016 at 10:20:50PM +0200, Dennis Kaarsemaker wrote: > > > On Sun, 2016-10-09 at 15:34 +0300, Mantas Mikulėnas wrote: > > > This is based on the existing gnome-keyring helper, but instead of > > > libgnome-keyring (which was

Re: [PATCH] contrib: add credential helper for libsecret

2016-10-11 Thread Dennis Kaarsemaker
On Sun, 2016-10-09 at 15:34 +0300, Mantas Mikulėnas wrote: > + s = g_hash_table_lookup(attributes, "user"); > + if (s) { > + g_free(c->username); > + c->username = g_strdup(s); > + } This always overwrites c->username,

Re: [PATCH] contrib: add credential helper for libsecret

2016-10-10 Thread Jeff King
On Mon, Oct 10, 2016 at 10:20:50PM +0200, Dennis Kaarsemaker wrote: > On Sun, 2016-10-09 at 15:34 +0300, Mantas Mikulėnas wrote: > > This is based on the existing gnome-keyring helper, but instead of > > libgnome-keyring (which was specific to GNOME and is deprecated), it > > uses libsecret which

Re: [PATCH] contrib: add credential helper for libsecret

2016-10-10 Thread Dennis Kaarsemaker
On Sun, 2016-10-09 at 15:34 +0300, Mantas Mikulėnas wrote: > This is based on the existing gnome-keyring helper, but instead of > libgnome-keyring (which was specific to GNOME and is deprecated), it > uses libsecret which can support other implementations of XDG Secret > Service API. > > Passes

Re: [PATCH] contrib: add credential helper for libsecret

2016-10-10 Thread Jeff King
On Sun, Oct 09, 2016 at 03:34:17PM +0300, Mantas Mikulėnas wrote: > This is based on the existing gnome-keyring helper, but instead of > libgnome-keyring (which was specific to GNOME and is deprecated), it > uses libsecret which can support other implementations of XDG Secret > Service API.

[PATCH] contrib: add credential helper for libsecret

2016-10-09 Thread Mantas Mikulėnas
This is based on the existing gnome-keyring helper, but instead of libgnome-keyring (which was specific to GNOME and is deprecated), it uses libsecret which can support other implementations of XDG Secret Service API. Passes t0303-credential-external.sh. Signed-off-by: Mantas Mikulėnas