Re: [PATCH] diff: handle --no-abbrev outside of repository

2016-11-28 Thread Jeff King
On Mon, Nov 28, 2016 at 11:25:08AM -0700, Jack Bates wrote: > diff --git a/diff.c b/diff.c > index ec87283..0447eff 100644 > --- a/diff.c > +++ b/diff.c > @@ -3106,7 +3106,8 @@ static const char *diff_abbrev_oid(const struct > object_id *oid, int abbrev) > abbrev =

Re: [PATCH] diff: handle --no-abbrev outside of repository

2016-11-28 Thread Junio C Hamano
Jack Bates writes: > The "git diff --no-index" codepath doesn't handle the --no-abbrev > option. > > Signed-off-by: Jack Bates > --- This patch also needs a new test to protect the fix from future breakages. It is unfortunate that parsing of

[PATCH] diff: handle --no-abbrev outside of repository

2016-11-28 Thread Jack Bates
The "git diff --no-index" codepath doesn't handle the --no-abbrev option. Signed-off-by: Jack Bates --- diff.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/diff.c b/diff.c index ec87283..0447eff 100644 --- a/diff.c +++ b/diff.c @@ -3106,7