Re: [PATCH] document behavior of empty color name

2017-02-03 Thread Jeff King
On Fri, Feb 03, 2017 at 10:12:13AM -0800, Junio C Hamano wrote: > > Right, I think that's the correct behavior. The empty color name is a > > real color ("none"), and you can put it in your list just like any other > > color. > > Makes me wonder if we have a non-empty string that spells the same

Re: [PATCH] document behavior of empty color name

2017-02-03 Thread Junio C Hamano
Jeff King writes: > On Fri, Feb 03, 2017 at 04:24:30PM +0700, Duy Nguyen wrote: > >> > I don't think so. The default value is a git-config thing, but you would >> > want to be able to do the same thing in a config file. For example, to >> > disable coloring entirely for part of

Re: [PATCH] document behavior of empty color name

2017-02-03 Thread Jeff King
On Fri, Feb 03, 2017 at 04:24:30PM +0700, Duy Nguyen wrote: > > I don't think so. The default value is a git-config thing, but you would > > want to be able to do the same thing in a config file. For example, to > > disable coloring entirely for part of the diff, you could do: > > > > [color

Re: [PATCH] document behavior of empty color name

2017-02-03 Thread Duy Nguyen
On Thu, Feb 02, 2017 at 01:42:44PM +0100, Jeff King wrote: > On Thu, Feb 02, 2017 at 04:16:15PM +0700, Duy Nguyen wrote: > > > > I hadn't heard anything back, > > > > Sorry I was accidentally busy during Luna new year holiday. > > No problem. That sounds much more fun than working on Git. :) >

[PATCH] document behavior of empty color name

2017-02-02 Thread Jeff King
ile. For example, to disable coloring entirely for part of the diff, you could do: [color "diff"] meta = "" > This is also a good opportunity to document this behavior in > git-config.txt, I think. Yeah. Maybe: -- >8 -- Subject: [PATCH] document behavior of em