Re: [PATCH] fsck: remove redundant parse_tree() invocation

2017-07-19 Thread Jonathan Nieder
Hi, Jonathan Tan wrote: > If obj->type == OBJ_TREE, an invocation of fsck_walk() will invoke > parse_tree() and return quickly if that returns nonzero, so it is of no > use for traverse_one_object() to invoke parse_tree() in this situation > before invoking fsck_walk(). Remove that code. I like

[PATCH] fsck: remove redundant parse_tree() invocation

2017-07-18 Thread Jonathan Tan
If obj->type == OBJ_TREE, an invocation of fsck_walk() will invoke parse_tree() and return quickly if that returns nonzero, so it is of no use for traverse_one_object() to invoke parse_tree() in this situation before invoking fsck_walk(). Remove that code. The behavior of traverse_one_object() is