Re: [PATCH] http: enable keepalive on TCP sockets

2013-10-14 Thread Jeff King
On Mon, Oct 14, 2013 at 05:27:39AM +, Eric Wong wrote: Daniel Stenberg dan...@haxx.se wrote: On Sat, 12 Oct 2013, Eric Wong wrote: This is a follow up to commit e47a8583a20256851e7fc882233e3bd5bf33dc6e (enable SO_KEEPALIVE for connected TCP sockets). Just keep in mind that

Re: [PATCH] http: enable keepalive on TCP sockets

2013-10-14 Thread Eric Wong
Jeff King p...@peff.net wrote: On Mon, Oct 14, 2013 at 05:27:39AM +, Eric Wong wrote: Daniel Stenberg dan...@haxx.se wrote: On Sat, 12 Oct 2013, Eric Wong wrote: This is a follow up to commit e47a8583a20256851e7fc882233e3bd5bf33dc6e (enable SO_KEEPALIVE for connected TCP

Re: [PATCH] http: enable keepalive on TCP sockets

2013-10-13 Thread Daniel Stenberg
On Sat, 12 Oct 2013, Eric Wong wrote: This is a follow up to commit e47a8583a20256851e7fc882233e3bd5bf33dc6e (enable SO_KEEPALIVE for connected TCP sockets). Just keep in mind that TCP keep-alive is enabled in awkwardly many different ways on different systems and this patch only supports

Re: [PATCH] http: enable keepalive on TCP sockets

2013-10-13 Thread Eric Wong
Daniel Stenberg dan...@haxx.se wrote: On Sat, 12 Oct 2013, Eric Wong wrote: This is a follow up to commit e47a8583a20256851e7fc882233e3bd5bf33dc6e (enable SO_KEEPALIVE for connected TCP sockets). Just keep in mind that TCP keep-alive is enabled in awkwardly many different ways on

[PATCH] http: enable keepalive on TCP sockets

2013-10-12 Thread Eric Wong
This is a follow up to commit e47a8583a20256851e7fc882233e3bd5bf33dc6e (enable SO_KEEPALIVE for connected TCP sockets). Sockets may never receive notification of some link errors, causing git fetch or similar processes to hang forever. Enabling keepalive messages allows hung processes to error