Re: [PATCH] name-hash: fix buffer overrun

2017-04-01 Thread Junio C Hamano
Johannes Schindelin writes: > On Fri, 31 Mar 2017, Junio C Hamano wrote: > >> Junio C Hamano writes: >> >> > Ah, of course. Avoid GNUism to spell HT as "\t" in a sed script. > > Sorry about that, I suggested this snippet to Kevin, it is my fault for > not remembering BSD sed's idiosynchracies.

Re: [PATCH] name-hash: fix buffer overrun

2017-04-01 Thread Johannes Schindelin
Hi Junio, On Fri, 31 Mar 2017, Junio C Hamano wrote: > Junio C Hamano writes: > > > Ah, of course. Avoid GNUism to spell HT as "\t" in a sed script. Sorry about that, I suggested this snippet to Kevin, it is my fault for not remembering BSD sed's idiosynchracies. Ciao, Johannes P.S.: enjoy y

Re: [PATCH] name-hash: fix buffer overrun

2017-03-31 Thread Junio C Hamano
Junio C Hamano writes: > Ah, of course. Avoid GNUism to spell HT as "\t" in a sed script. Here is what I replaced the original patch with. Let's see how well it fares with Travis tonight. -- >8 -- From: Kevin Willford Date: Fri, 31 Mar 2017 17:32:14 +0000 Subject: [

Re: [PATCH] name-hash: fix buffer overrun

2017-03-31 Thread Junio C Hamano
On Fri, Mar 31, 2017 at 2:18 PM, Junio C Hamano wrote: > Junio C Hamano writes: > >> Will queue with ... >> >>> name-hash.c | 4 +++- >>> t/t3008-ls-files-lazy-init-name-hash.sh | 19 +++ >>> 2 files changed, 22 insertions(+), 1 deletion(-) >>> creat

Re: [PATCH] name-hash: fix buffer overrun

2017-03-31 Thread Junio C Hamano
Junio C Hamano writes: > Will queue with ... > >> name-hash.c | 4 +++- >> t/t3008-ls-files-lazy-init-name-hash.sh | 19 +++ >> 2 files changed, 22 insertions(+), 1 deletion(-) >> create mode 100644 t/t3008-ls-files-lazy-init-name-hash.sh > > ... thi

Re: [PATCH] name-hash: fix buffer overrun

2017-03-31 Thread Junio C Hamano
g...@jeffhostetler.com writes: > From: Kevin Willford > > Add check for the end of the entries for the thread partition. > Add test for lazy init name hash with specific directory structure > > The lazy init hash name was causing a buffer overflow when the last > entry in the index was multiple f

[PATCH] name-hash: fix buffer overrun

2017-03-31 Thread git
From: Kevin Willford Add check for the end of the entries for the thread partition. Add test for lazy init name hash with specific directory structure The lazy init hash name was causing a buffer overflow when the last entry in the index was multiple folder deep with parent folders that did not

[PATCH] name-hash: fix buffer overrun

2017-03-31 Thread git
From: Jeff Hostetler Fix buffer overrun in handle_range_dir() when the final entry in the index was the only file in the last directory, such as "a/b/foo.txt". The look ahead (k_start + 1) was invalid since (k_start + 1) == k_end. This bug was introduced by Jeff in "jh/memihash-opt" which was re