Re: [PATCH] pack-objects: document about thread synchronization

2018-08-04 Thread Jonathan Nieder
Jeff King wrote: > On Sun, Jul 29, 2018 at 05:36:05PM +0200, Nguyễn Thái Ngọc Duy wrote: >> These extra comments should be make it easier to understand how to use >> locks in pack-objects delta search code. For reference, see >> >> 8ecce684a3 (basic threaded delta search - 2007-09-06) >>

Re: [PATCH] pack-objects: document about thread synchronization

2018-08-03 Thread Duy Nguyen
On Thu, Aug 2, 2018 at 9:39 PM Jeff King wrote: > > On Sun, Jul 29, 2018 at 05:46:17PM +0200, Duy Nguyen wrote: > > > tOn Sun, Jul 29, 2018 at 5:36 PM Nguyễn Thái Ngọc Duy > > wrote: > > > > > > These extra comments should be make it easier to understand how to use > > > locks in pack-objects

Re: [PATCH] pack-objects: document about thread synchronization

2018-08-02 Thread Jeff King
On Sun, Jul 29, 2018 at 05:46:17PM +0200, Duy Nguyen wrote: > tOn Sun, Jul 29, 2018 at 5:36 PM Nguyễn Thái Ngọc Duy > wrote: > > > > These extra comments should be make it easier to understand how to use > > locks in pack-objects delta search code. For reference, see > > Side note. I wonder if

Re: [PATCH] pack-objects: document about thread synchronization

2018-08-02 Thread Jeff King
On Sun, Jul 29, 2018 at 05:36:05PM +0200, Nguyễn Thái Ngọc Duy wrote: > These extra comments should be make it easier to understand how to use > locks in pack-objects delta search code. For reference, see > > 8ecce684a3 (basic threaded delta search - 2007-09-06) > 384b32c09b (pack-objects: fix

Re: [PATCH] pack-objects: document about thread synchronization

2018-07-29 Thread Duy Nguyen
tOn Sun, Jul 29, 2018 at 5:36 PM Nguyễn Thái Ngọc Duy wrote: > > These extra comments should be make it easier to understand how to use > locks in pack-objects delta search code. For reference, see Side note. I wonder if we could take progress_lock() less often in find_deltas() to reduce

[PATCH] pack-objects: document about thread synchronization

2018-07-29 Thread Nguyễn Thái Ngọc Duy
These extra comments should be make it easier to understand how to use locks in pack-objects delta search code. For reference, see 8ecce684a3 (basic threaded delta search - 2007-09-06) 384b32c09b (pack-objects: fix threaded load balancing - 2007-12-08) 50f22ada52 (threaded pack-objects: Use