Re: [PATCH] rev-list: use hdr_termination instead of a always using a newline

2016-10-20 Thread Jacob Keller
On Thu, Oct 20, 2016 at 11:54 AM, Junio C Hamano wrote: > > The main part of the patch looks good. For "passing NUL to sed", > I'd probably work it around like so: > Yep. I wasn't sure on the test as it was, because of the portability concern. > t/t6000-rev-list-misc.sh |

Re: [PATCH] rev-list: use hdr_termination instead of a always using a newline

2016-10-20 Thread Junio C Hamano
Jacob Keller writes: > diff --git a/t/t6000-rev-list-misc.sh b/t/t6000-rev-list-misc.sh > index 3e752ce03280..e8c6979baf59 100755 > --- a/t/t6000-rev-list-misc.sh > +++ b/t/t6000-rev-list-misc.sh > @@ -4,6 +4,12 @@ test_description='miscellaneous rev-list tests' > >

Re: [PATCH] rev-list: use hdr_termination instead of a always using a newline

2016-10-20 Thread Dennis Kaarsemaker
On Thu, 2016-10-20 at 11:19 -0700, Jacob Keller wrote: > Here's my solution, with an updated test using a helper function based > on using sed (which I think is more portable than tail -n1 ?). The > change actually is very simple. I ran the test suite and it appears to > be not breaking anyone

[PATCH] rev-list: use hdr_termination instead of a always using a newline

2016-10-20 Thread Jacob Keller
From: Jacob Keller When adding support for prefixing output of log and other commands using --line-prefix, commit 660e113ce118 ("graph: add support for --line-prefix on all graph-aware output", 2016-08-31) accidentally broke rev-list --header output. In order to make the