Re: [PATCH] t/perf/run: Don't forget to copy config.mak.autogen & friends to build area

2016-09-13 Thread Kirill Smelkov
exists _and_ is regular file. Some people might have config.mak as a symlink for example. We don't want to miss them too. Please find updated patch below: 8< From: Kirill Smelkov <k...@nexedi.com> Subject: [PATCH] t/perf/run: Don't forget to copy config.mak.autogen & f

Re: [PATCH] t/perf/run: Don't forget to copy config.mak.autogen & friends to build area

2016-09-12 Thread Junio C Hamano
Junio C Hamano writes: > In other words, something along this line, perhaps. > ... Not quite. There is no guanratee that the user is using autoconf at all. It should be more like this, I think. t/perf/run | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff

Re: [PATCH] t/perf/run: Don't forget to copy config.mak.autogen & friends to build area

2016-09-12 Thread Junio C Hamano
Junio C Hamano writes: >> build_git_rev () { >> rev=$1 >> -cp ../../config.mak build/$rev/config.mak >> +cp -t build/$rev ../../{config.mak,config.mak.autogen,config.status} > > That unfortunately is a GNUism -t with a bash-ism {a,b,c}; just keep > it simple and

Re: [PATCH] t/perf/run: Don't forget to copy config.mak.autogen & friends to build area

2016-09-12 Thread Junio C Hamano
Kirill Smelkov writes: > Otherwise for people who use autotools-based configure in main worktree, > the performance testing results will be inconsistent as work and build > trees could be using e.g. different optimization levels. > > See e.g. > > >

[PATCH] t/perf/run: Don't forget to copy config.mak.autogen & friends to build area

2016-09-10 Thread Kirill Smelkov
Otherwise for people who use autotools-based configure in main worktree, the performance testing results will be inconsistent as work and build trees could be using e.g. different optimization levels. See e.g.