Re: [PATCH] tests: fix tests broken under GETTEXT_POISON=YesPlease

2017-04-26 Thread Ævar Arnfjörð Bjarmason
On Wed, Apr 26, 2017 at 3:58 AM, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >> Indeed, I've tried to be careful not to introduce bugs like that, but >> in this skipped case the tests look completely stand-alone to me. > > Yes, the ones I

Re: [PATCH] tests: fix tests broken under GETTEXT_POISON=YesPlease

2017-04-25 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > Indeed, I've tried to be careful not to introduce bugs like that, but > in this skipped case the tests look completely stand-alone to me. Yes, the ones I commented on in the upthread looked like their side effect were not felt in the later

Re: [PATCH] tests: fix tests broken under GETTEXT_POISON=YesPlease

2017-04-25 Thread Ævar Arnfjörð Bjarmason
On Tue, Apr 25, 2017 at 6:11 AM, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >> My general approach when writing & maintaining this poison has been >> that it's fine if we skip some tests, even though we could be bending >> over backwards to run

Re: [PATCH] tests: fix tests broken under GETTEXT_POISON=YesPlease

2017-04-24 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > My general approach when writing & maintaining this poison has been > that it's fine if we skip some tests, even though we could be bending > over backwards to run them, or even if we don't know the root cause > beyond "the rebase machinery is

Re: [PATCH] tests: fix tests broken under GETTEXT_POISON=YesPlease

2017-04-24 Thread Ævar Arnfjörð Bjarmason
On Mon, Apr 24, 2017 at 3:15 AM, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > >> The GETTEXT_POISON=YesPlease compile-time testing option added in my >> bb946bba76 ("i18n: add GETTEXT_POISON to simulate unfriendly >> translator", 2011-02-22) has

Re: [PATCH] tests: fix tests broken under GETTEXT_POISON=YesPlease

2017-04-23 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > The GETTEXT_POISON=YesPlease compile-time testing option added in my > bb946bba76 ("i18n: add GETTEXT_POISON to simulate unfriendly > translator", 2011-02-22) has been slowly bitrotting as strings have > been marked for translation, and new

[PATCH] tests: fix tests broken under GETTEXT_POISON=YesPlease

2017-04-21 Thread Ævar Arnfjörð Bjarmason
The GETTEXT_POISON=YesPlease compile-time testing option added in my bb946bba76 ("i18n: add GETTEXT_POISON to simulate unfriendly translator", 2011-02-22) has been slowly bitrotting as strings have been marked for translation, and new tests have been added without running it. I brought this up on