Re: [PATCH 0/6] Compile cleanly in pedantic mode

2018-07-12 Thread Junio C Hamano
Johannes Schindelin writes: >> That may be something worth discussing before doing; I'd prefer to >> wait until these 6 patches, plus the unsized static array one you >> did spearately, graduates to the 'master' branch. > > If this change to DEVOPTS was done as 7/7, then this would be very easy

Re: [PATCH 0/6] Compile cleanly in pedantic mode

2018-07-12 Thread Johannes Schindelin
Hi, On Wed, 11 Jul 2018, Junio C Hamano wrote: > Beat Bolli writes: > > > Should we add a "pedantic" flag to DEVOPTS that would simplify > > building pedantically? It would also have to set > > USE_PARENS_AROUND_GETTEXT_N so as to not overwhelm the developer with > > too much output. > > That

Re: [PATCH 0/6] Compile cleanly in pedantic mode

2018-07-11 Thread Junio C Hamano
Beat Bolli writes: > Should we add a "pedantic" flag to DEVOPTS that would simplify > building pedantically? It would also have to set > USE_PARENS_AROUND_GETTEXT_N so as to not overwhelm the developer with > too much output. That may be something worth discussing before doing; I'd prefer to

Re: [PATCH 0/6] Compile cleanly in pedantic mode

2018-07-10 Thread Beat Bolli
Hi Junio Am 09.07.2018 23:45, schrieb Junio C Hamano: Beat Bolli writes: While developing 6aaded550 ("builtin/config: work around an unsized array forward declaration", 2018-07-05), I have compiled Git with CFLAGS="-std=c99 -pedantic". Nicely done. With these 6 patches and the

Re: [PATCH 0/6] Compile cleanly in pedantic mode

2018-07-09 Thread Beat Bolli
On 09.07.18 23:45, Junio C Hamano wrote: > Beat Bolli writes: > >> While developing 6aaded550 ("builtin/config: work around an unsized >> array forward declaration", 2018-07-05), I have compiled Git with >> CFLAGS="-std=c99 -pedantic". > > Nicely done. > > With these 6 patches and the

Re: [PATCH 0/6] Compile cleanly in pedantic mode

2018-07-09 Thread Junio C Hamano
Beat Bolli writes: > While developing 6aaded550 ("builtin/config: work around an unsized > array forward declaration", 2018-07-05), I have compiled Git with > CFLAGS="-std=c99 -pedantic". Nicely done. With these 6 patches and the USE_PARENCE_AROUND_GETTEXT_N hack, the forward decl of the

Re: [PATCH 0/6] Compile cleanly in pedantic mode

2018-07-09 Thread Beat Bolli
On 09.07.18 21:25, Beat Bolli wrote: > While developing 6aaded550 ("builtin/config: work around an unsized > array forward declaration", 2018-07-05), I have compiled Git with > CFLAGS="-std=c99 -pedantic". > > This series fixes a few compiler warnings when compiling with these > options. As a

[PATCH 0/6] Compile cleanly in pedantic mode

2018-07-09 Thread Beat Bolli
While developing 6aaded550 ("builtin/config: work around an unsized array forward declaration", 2018-07-05), I have compiled Git with CFLAGS="-std=c99 -pedantic". This series fixes a few compiler warnings when compiling with these options. Note that all warnings were produced by -pedantic; the

Re: [RFC PATCH 0/6] Compile cleanly in pedantic mode

2018-07-09 Thread Junio C Hamano
Beat Bolli writes: > While developing 6aaded550 ("builtin/config: work around an unsized > array forward declaration", 2018-07-05), I have compiled Git with > CFLAGS="-std=c99 -pedantic". Nice. I also pretty recently realized that I stopped building with the pedantic option by accident,

Re: [RFC PATCH 0/6] Compile cleanly in pedantic mode

2018-07-09 Thread Johannes Schindelin
Hi Beat, On Sun, 8 Jul 2018, Beat Bolli wrote: > While developing 6aaded550 ("builtin/config: work around an unsized > array forward declaration", 2018-07-05), I have compiled Git with > CFLAGS="-std=c99 -pedantic". > > This is an RFC patch series that fixes a few compiler warnings when >

[RFC PATCH 0/6] Compile cleanly in pedantic mode

2018-07-08 Thread Beat Bolli
While developing 6aaded550 ("builtin/config: work around an unsized array forward declaration", 2018-07-05), I have compiled Git with CFLAGS="-std=c99 -pedantic". This is an RFC patch series that fixes a few compiler warnings when compiling with these options, always assuming that this is a